fix(agent): normalize harness attempt results

src/agents/pi-embedded-runner/run.empty-error-retry.test.ts

@@ -131,6 +131,7 @@ describe("runEmbeddedPiAgent silent-error retry", () => {
       provider: "ollama",
       model: "glm-5.1:cloud",
       runId: "run-empty-error-retry-skip-clean-stop",
+      allowEmptyAssistantReplyAsSilent: true,
     });
 
     expect(mockedRunEmbeddedAttempt).toHaveBeenCalledTimes(1);

src/agents/pi-embedded-runner/run.overflow-compaction.fixture.ts

@@ -51,15 +51,6 @@ export function makeAttemptResult(
     toolMetas,
     lastAssistant: undefined,
     messagesSnapshot: [],
-    replayMetadata:
-      overrides.replayMetadata ??
-      buildAttemptReplayMetadata({
-        toolMetas,
-        didSendViaMessagingTool,
-        messagingToolSentTexts,
-        messagingToolSentMediaUrls,
-        successfulCronAdds,
-      }),
     itemLifecycle: {
       startedCount: 0,
       completedCount: 0,
@@ -71,6 +62,15 @@ export function makeAttemptResult(
     messagingToolSentTargets: [],
     cloudCodeAssistFormatError: false,
     ...overrides,
+    replayMetadata:
+      overrides.replayMetadata ??
+      buildAttemptReplayMetadata({
+        toolMetas,
+        didSendViaMessagingTool,
+        messagingToolSentTexts,
+        messagingToolSentMediaUrls,
+        successfulCronAdds,
+      }),
   };
 }
 

src/agents/pi-embedded-runner/run.ts

@@ -855,7 +855,7 @@ export async function runEmbeddedPiAgent(
             },
           });
 
-          const attempt = await runEmbeddedAttemptWithBackend({
+          const rawAttempt = await runEmbeddedAttemptWithBackend({
             sessionId: activeSessionId,
             sessionKey: resolvedSessionKey,
             sandboxSessionKey: params.sandboxSessionKey,
@@ -960,6 +960,25 @@ export async function runEmbeddedPiAgent(
             bootstrapPromptWarningSignature:
               bootstrapPromptWarningSignaturesSeen[bootstrapPromptWarningSignaturesSeen.length - 1],
           });
+          const attempt = {
+            ...rawAttempt,
+            assistantTexts: rawAttempt.assistantTexts ?? [],
+            toolMetas: rawAttempt.toolMetas ?? [],
+            messagesSnapshot: rawAttempt.messagesSnapshot ?? [],
+            messagingToolSentTexts: rawAttempt.messagingToolSentTexts ?? [],
+            messagingToolSentMediaUrls: rawAttempt.messagingToolSentMediaUrls ?? [],
+            messagingToolSentTargets: rawAttempt.messagingToolSentTargets ?? [],
+            itemLifecycle: rawAttempt.itemLifecycle ?? {
+              startedCount: 0,
+              completedCount: 0,
+              activeCount: 0,
+            },
+            // Malformed or legacy harness results must not be considered safe to replay.
+            replayMetadata: rawAttempt.replayMetadata ?? {
+              hadPotentialSideEffects: true,
+              replaySafe: false,
+            },
+          };
 
           const {
             aborted,