liuyu/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-06-06 05:51:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(tooling): reject malformed cross-os release timeouts

Browse Source
This commit is contained in:
Vincent Koc
2026-06-03 01:59:48 +02:00
parent 85633eb615
commit dd46fd36a3
2 changed files with 25 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
scripts/openclaw-cross-os-release-checks.ts
View File

@@ -204,11 +204,14 @@ export function parseArgs(argv) {
return parsed;
}
function parsePositiveIntegerEnv(name, fallback) {
const raw = process.env[name]?.trim();
export function parsePositiveIntegerEnv(name, fallback, env = process.env) {
const raw = env[name]?.trim();
if (!raw) {
return fallback;
}
if (!/^\d+$/u.test(raw)) {
throw new Error(`${name} must be a positive integer. Got: ${JSON.stringify(raw)}`);
}
const value = Number(raw);
if (!Number.isSafeInteger(value) || value <= 0) {
throw new Error(`${name} must be a positive integer. Got: ${JSON.stringify(raw)}`);

20
test/scripts/openclaw-cross-os-release-checks.test.ts
View File

@@ -51,6 +51,7 @@ import {
normalizeWindowsCommandShimPath,
normalizeWindowsInstalledCliPath,
maybeBuildOptionalAgentTurnSkipResult,
parsePositiveIntegerEnv,
parseCrossOsSuiteFilter,
parseArgs,
packageHasScript,
@@ -202,6 +203,25 @@ describe("scripts/openclaw-cross-os-release-checks", () => {
expect(CROSS_OS_COMMAND_HEARTBEAT_SECONDS).toBeLessThanOrEqual(60);
});
it("rejects malformed cross-OS positive integer environment values", () => {
expect(parsePositiveIntegerEnv("OPENCLAW_CROSS_OS_COMMAND_HEARTBEAT_SECONDS", 60, {})).toBe(
60,
);
expect(
parsePositiveIntegerEnv("OPENCLAW_CROSS_OS_COMMAND_HEARTBEAT_SECONDS", 60, {
OPENCLAW_CROSS_OS_COMMAND_HEARTBEAT_SECONDS: "25",
}),
).toBe(25);
for (const raw of ["1e3", "25ms", "1.5", "0", "-1", String(Number.MAX_SAFE_INTEGER + 1)]) {
expect(() =>
parsePositiveIntegerEnv("OPENCLAW_CROSS_OS_COMMAND_HEARTBEAT_SECONDS", 60, {
OPENCLAW_CROSS_OS_COMMAND_HEARTBEAT_SECONDS: raw,
}),
).toThrow("OPENCLAW_CROSS_OS_COMMAND_HEARTBEAT_SECONDS must be a positive integer");
}
});
it("records packaged-fresh phase timings for release-check summaries", () => {
const source = readFileSync("scripts/openclaw-cross-os-release-checks.ts", "utf8");
const freshLaneSource = source.slice(