Files
nofx/HOW_TO_SUBMIT_PR.md
nobody 87f67f2da1 feat: Add Aster DEX exchange support + fix precision issues
## Features
- Add full Aster DEX integration with Binance-compatible API
- Support Web3 authentication with API wallet system
- Add comprehensive Aster integration guide (ASTER_INTEGRATION.md)
- Add example Aster configuration (config.aster.example.json)
## Bug Fixes
- Fix precision error (code -1111) for all order types
- Implement proper float-to-string conversion with exchange precision
- Add automatic precision fetching from /exchangeInfo endpoint
- Remove trailing zeros from formatted values
## Documentation
- Update README.md with Aster quick start guide
- Add detailed setup instructions for creating API wallet
- Include troubleshooting FAQ and security best practices
- Update core features to mention three supported exchanges
## Technical Details
- Added formatFloatWithPrecision() helper function
- Updated all order functions to use proper precision formatting
- Added precision logging for debugging
- Fully backward compatible with existing configurations
Closes #[issue number if applicable]
2025-10-30 00:27:33 +08:00

173 lines
5.0 KiB
Markdown
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

# 如何提交这个PR (How to Submit This PR)
## 📋 修改摘要 (Summary of Changes)
### 新增文件 (New Files)
1. **trader/aster_trader.go** - Aster交易所完整实现 (889行)
2. **ASTER_INTEGRATION.md** - Aster集成完整指南 (英文)
3. **config.aster.example.json** - Aster配置示例
4. **COMMIT_MESSAGE.txt** - 提交信息模板 (提交后可删除)
5. **HOW_TO_SUBMIT_PR.md** - 本文件 (提交后可删除)
### 修改文件 (Modified Files)
1. **README.md** - 添加Aster介绍和配置说明
2. **trader/aster_trader.go** - 修复精度问题
3. **config/config.go** - 添加Aster配置字段 (如有修改)
4. **manager/trader_manager.go** - 添加Aster初始化 (如有修改)
5. **trader/auto_trader.go** - 相关更新 (如有修改)
## 🚀 提交步骤 (Submission Steps)
### 1. 检查修改 (Check Changes)
```bash
# 查看所有修改
git status
# 查看具体更改
git diff README.md
git diff trader/aster_trader.go
```
### 2. 暂存文件 (Stage Files)
```bash
# 添加新文件
git add trader/aster_trader.go
git add ASTER_INTEGRATION.md
git add config.aster.example.json
# 添加修改的文件
git add README.md
git add config/config.go
git add manager/trader_manager.go
git add trader/auto_trader.go
# 查看暂存状态
git status
```
### 3. 提交更改 (Commit Changes)
```bash
# 使用提供的提交信息
git commit -F COMMIT_MESSAGE.txt
# 或者手动编写提交信息
git commit -m "feat: Add Aster DEX exchange support + fix precision issues"
```
### 4. 推送到您的分支 (Push to Your Branch)
```bash
# 如果还没有创建分支,先创建
git checkout -b feat/aster-dex-support
# 推送到远程仓库
git push origin feat/aster-dex-support
```
### 5. 创建Pull Request (Create Pull Request)
1. 访问您的GitHub仓库
2. 点击 "Compare & pull request" 按钮
3. 填写PR信息
**标题 (Title):**
```
feat: Add Aster DEX exchange support + fix precision issues
```
**描述 (Description):**
```markdown
## 🎯 Summary
This PR adds full support for Aster DEX - a Binance-compatible decentralized perpetual futures exchange - and fixes critical precision handling issues.
## ✨ Features Added
- ✅ Full Aster DEX trading support (long/short, leverage, stop-loss/take-profit)
- ✅ Web3 authentication with API wallet security model
- ✅ Binance-compatible API (easy migration)
- ✅ Comprehensive integration guide with step-by-step instructions
## 🐛 Bug Fixes
- ✅ Fixed precision error (code -1111) for all order types
- ✅ Automatic precision handling from exchange specifications
- ✅ Proper float-to-string conversion with trailing zero removal
## 📚 Documentation
- ✅ Complete ASTER_INTEGRATION.md guide (setup, API, troubleshooting)
- ✅ Updated README.md with Aster quick start
- ✅ Added config.aster.example.json
## 🔧 Technical Details
- Added `formatFloatWithPrecision()` helper function
- Updated all order functions (OpenLong, OpenShort, CloseLong, CloseShort, SetStopLoss, SetTakeProfit)
- Added precision logging for debugging
- Fully backward compatible
## 🎓 How to Use
See [ASTER_INTEGRATION.md](ASTER_INTEGRATION.md) for detailed setup instructions.
Quick start:
1. Visit https://www.asterdex.com/en/api-wallet
2. Create API wallet and save credentials
3. Configure config.json with Aster settings
4. Run `./nofx`
## 🧪 Testing
- ✅ Compiled successfully
- ✅ Orders placed successfully on Aster
- ✅ Precision handling verified with multiple trading pairs
- ✅ No breaking changes to existing Binance/Hyperliquid configs
## 🙏 Acknowledgments
Thanks to Aster DEX for the excellent API documentation and Binance-compatible design!
```
### 6. 清理临时文件 (Clean Up)
```bash
# PR创建后可以删除这些临时文件
rm COMMIT_MESSAGE.txt
rm HOW_TO_SUBMIT_PR.md
```
## ✅ 提交前检查清单 (Pre-Submit Checklist)
- [ ] 所有新文件都已添加
- [ ] 所有修改都已暂存
- [ ] 代码可以正常编译 (`go build`)
- [ ] 没有语法错误
- [ ] 文档格式正确Markdown
- [ ] 敏感信息已移除API密钥、私钥等
- [ ] ASTER_INTEGRATION.md 文档完整
- [ ] README.md 更新完整
- [ ] config.aster.example.json 使用示例数据
## 📝 PR描述要点 (Key Points for PR Description)
### 核心价值 (Core Value)
1. **Aster DEX集成** - 第三个支持的交易所
2. **Binance兼容API** - 降低迁移成本
3. **修复精度BUG** - 解决实际交易问题
4. **完整文档** - 详细的设置指南
### 技术亮点 (Technical Highlights)
1. Web3认证 - API钱包安全系统
2. 自动精度处理 - 从交易所获取精度要求
3. 向后兼容 - 不影响现有配置
### 用户价值 (User Benefits)
1. 更多交易所选择
2. 去中心化选项
3. 更低手续费
4. 无需KYC
## 🔗 相关链接 (Related Links)
- Aster DEX官网: https://www.asterdex.com/
- Aster API文档: https://github.com/asterdex/api-docs
- API钱包管理: https://www.asterdex.com/en/api-wallet
---
**需要帮助?** 加入Telegram开发者社区: https://t.me/nofx_dev_community
**祝您PR顺利! Good luck with your PR! 🚀**