mirror of
https://github.com/NoFxAiOS/nofx.git
synced 2026-07-02 10:31:04 +08:00
154 lines
3.8 KiB
Markdown
154 lines
3.8 KiB
Markdown
# Pull Request
|
|
|
|
## 📝 Description
|
|
|
|
<!-- Provide a brief summary of your changes -->
|
|
|
|
## 🎯 Type of Change
|
|
|
|
<!-- Mark the relevant option with an "x" -->
|
|
|
|
- [ ] 🐛 Bug fix (non-breaking change which fixes an issue)
|
|
- [ ] ✨ New feature (non-breaking change which adds functionality)
|
|
- [ ] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
|
|
- [ ] 📝 Documentation update
|
|
- [ ] 🎨 Code style update (formatting, renaming)
|
|
- [ ] ♻️ Refactoring (no functional changes)
|
|
- [ ] ⚡ Performance improvement
|
|
- [ ] ✅ Test update
|
|
- [ ] 🔧 Build/config change
|
|
|
|
## 🔗 Related Issues
|
|
|
|
<!-- Link related issues below. Use "Closes #123" to auto-close issues when PR is merged -->
|
|
|
|
- Closes #
|
|
- Related to #
|
|
|
|
## 📋 Changes Made
|
|
|
|
<!-- List the specific changes you made -->
|
|
|
|
- Change 1
|
|
- Change 2
|
|
- Change 3
|
|
|
|
## 🧪 Testing
|
|
|
|
### Manual Testing
|
|
|
|
<!-- Describe how you tested your changes -->
|
|
|
|
- [ ] Tested locally (manual verification)
|
|
- [ ] Tested on testnet (for exchange integrations)
|
|
- [ ] Tested with different configurations
|
|
- [ ] Verified no existing functionality broke
|
|
|
|
### Test Environment
|
|
|
|
- **OS:** [e.g. macOS, Ubuntu]
|
|
- **Go Version:** [e.g. 1.21.5]
|
|
- **Exchange:** [if applicable]
|
|
|
|
### Test Results
|
|
|
|
<!-- Paste relevant test output or describe results -->
|
|
|
|
```
|
|
Test output here
|
|
```
|
|
|
|
## 📸 Screenshots / Demo
|
|
|
|
<!-- If applicable, add screenshots or video demo -->
|
|
|
|
<!-- For UI changes, include before/after screenshots -->
|
|
|
|
**Before:**
|
|
|
|
|
|
**After:**
|
|
|
|
|
|
## ✅ Checklist
|
|
|
|
<!-- Mark completed items with an "x" -->
|
|
|
|
### Code Quality
|
|
|
|
- [ ] My code follows the project's code style ([Contributing Guide](../CONTRIBUTING.md))
|
|
- [ ] I have performed a self-review of my code
|
|
- [ ] I have commented my code, particularly in hard-to-understand areas
|
|
- [ ] My changes generate no new warnings or errors
|
|
- [ ] Code compiles successfully (`go build` / `npm run build`)
|
|
- [ ] I have run `go fmt` (for Go code)
|
|
|
|
### Testing
|
|
|
|
- [ ] I have added tests that prove my fix is effective or that my feature works
|
|
- [ ] New and existing unit tests pass locally
|
|
- [ ] I have tested on testnet (for trading/exchange changes)
|
|
|
|
### Documentation
|
|
|
|
- [ ] I have updated the documentation accordingly
|
|
- [ ] I have updated the README if needed
|
|
- [ ] I have added inline code comments where necessary
|
|
- [ ] I have updated type definitions (for TypeScript changes)
|
|
|
|
### Git
|
|
|
|
- [ ] My commits follow the conventional commits format (`feat:`, `fix:`, etc.)
|
|
- [ ] I have rebased my branch on the latest `dev` branch
|
|
- [ ] There are no merge conflicts
|
|
|
|
## 🔒 Security Considerations
|
|
|
|
<!-- Answer these questions for security-sensitive changes -->
|
|
|
|
- [ ] No API keys or secrets are hardcoded
|
|
- [ ] User inputs are properly validated
|
|
- [ ] No SQL injection vulnerabilities introduced
|
|
- [ ] Authentication/authorization properly handled
|
|
- [ ] N/A (not security-related)
|
|
|
|
## ⚡ Performance Impact
|
|
|
|
<!-- Describe any performance implications -->
|
|
|
|
- [ ] No significant performance impact
|
|
- [ ] Performance improved
|
|
- [ ] Performance may be impacted (explain below)
|
|
|
|
<!-- If performance impacted, explain: -->
|
|
|
|
## 📚 Additional Notes
|
|
|
|
<!-- Any additional information for reviewers -->
|
|
|
|
---
|
|
|
|
## For Bounty Claims
|
|
|
|
<!-- Fill this section only if claiming a bounty -->
|
|
|
|
- [ ] This PR is for bounty issue #
|
|
- [ ] All acceptance criteria from the bounty issue are met
|
|
- [ ] I have included a demo video/screenshots
|
|
- [ ] I am ready for payment upon merge
|
|
|
|
**Payment Details:** <!-- Discuss privately with maintainers -->
|
|
|
|
---
|
|
|
|
## 🙏 Reviewer Notes
|
|
|
|
<!-- Optional: anything specific you want reviewers to focus on? -->
|
|
|
|
---
|
|
|
|
**By submitting this PR, I confirm that:**
|
|
- [ ] I have read the [Contributing Guidelines](../CONTRIBUTING.md)
|
|
- [ ] I agree to the [Code of Conduct](../CODE_OF_CONDUCT.md)
|
|
- [ ] My contribution is licensed under the MIT License
|