- Change validation to check allModels first, then supportedModels
- This allows saving new model configurations without "model does not exist" error
- Fixes issue where users couldn't save AI model config after selecting from dropdown
Fixes#245🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Fixes#200
Previously, positions closed via stop-loss or take-profit were not
recorded in decision logs, causing inaccurate performance metrics
(win rate, profit factor, etc.) displayed in the frontend.
This commit implements a position snapshot mechanism to detect
auto-closed positions by comparing positions between trading cycles.
Changes:
- Add PositionSnapshot struct to track position state
- Add detectAutoClosedPositions() to detect disappeared positions
- Update position snapshots at cycle end (after AI execution)
- Support auto_close_long/auto_close_short action types in logger
- Ensure accurate performance analysis including auto-closed trades
Key fix:
- Snapshots are updated AFTER AI execution to avoid false positives
- AI manual closes won't be mistakenly detected as auto-closes
Enhanced the Exchange API errors section with more detailed solutions
for timestamp-related failures, based on Issue #60.
Problem:
- code=-1021: Timestamp outside of recvWindow
- System time not synced with Binance servers
- Docker container time drift
Enhanced Solutions:
1. System Time Sync (Multiple methods)
- ntpdate pool.ntp.org (recommended)
- ntpdate with different NTP servers
- timedatectl for automatic sync
- Aliyun NTP for China users
2. Docker-specific fixes
- Check container time vs host time
- Restart Docker service
- Add TZ environment variable
3. API Key verification steps
- Regeneration procedure
- Permission checklist
4. Rate limit considerations
- Reduce trader count
- Increase decision interval
Both English and Chinese versions updated.
Fixes: #60🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Added comprehensive troubleshooting guide for Docker image pull failures
in mainland China, based on Issue #168.
Problem:
- Users in China cannot pull Docker images from Docker Hub
- ERROR: load metadata for docker.io/library/...
- Timeouts and connection failures
Solutions Added:
1. Configure Docker registry mirrors (Recommended)
- List of working China mirrors
- Step-by-step configuration for Linux/macOS/Windows
- Verification commands
2. Use VPN
- Taiwan nodes recommended
- Global mode required
3. Offline image download
- Image proxy websites
- Manual import instructions
Both English and Chinese versions updated.
Fixes: #168🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Fixed incorrect information about supported AI models:
Before (Incorrect):
- Listed OpenAI GPT-4 and Claude as directly supported
- These are NOT natively supported
After (Correct):
- DeepSeek (native support, recommended)
- Qwen (native support, Alibaba Cloud)
- Custom OpenAI-compatible APIs (can use OpenAI, Claude via proxy, etc.)
Also updated cost estimates to reflect actual supported models.
Reference: mcp/client.go shows only DeepSeek, Qwen, and Custom providers.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Addressed review feedback on PR #226:
- FAQ and TROUBLESHOOTING serve different purposes and should both be kept
- FAQ: Quick Q&A format for common questions (now expanded)
- TROUBLESHOOTING: Detailed step-by-step diagnostic guide
Changes:
- Expanded FAQ from 26 lines to 200+ lines with 7 sections:
* General Questions (What is NOFX, supported exchanges, profitability)
* Setup & Configuration (requirements, API keys, subaccounts)
* Trading Questions (decision frequency, position limits, customization)
* Technical Issues (quick fixes for common errors)
* AI & Model Questions (supported models, costs, learning)
* Data & Privacy (storage, security, export)
* Contributing (how to help, feature requests)
- Added cross-references between FAQ and TROUBLESHOOTING
- FAQ provides quick answers with links to detailed troubleshooting
- TROUBLESHOOTING remains comprehensive diagnostic guide
Both English and Chinese versions updated.
Fixes review comment from @reviewer on PR #226🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
This commit sets up a minimal, KISS-principle testing infrastructure
for both backend and frontend, and includes the fix for Issue #227.
Backend Changes:
- Add Makefile with test commands (test, test-backend, test-frontend, test-coverage)
- Add example test: config/database_test.go
- Fix Go 1.25 printf format string warnings in trader/auto_trader.go
(Changed log.Printf to log.Print for non-format strings)
- All backend tests pass ✓
Frontend Changes:
- Add Vitest configuration: web/vitest.config.ts (minimal setup)
- Add test utilities: web/src/test/test-utils.tsx
- Add example test: web/src/App.test.tsx
- Add dependencies: vitest, jsdom, @testing-library/react
- All frontend tests pass ✓
Issue #227 Fix:
- Fix AITradersPage to allow editing traders with disabled models/exchanges
- Change validation to use allModels/allExchanges instead of enabledModels/enabledExchanges
- Add comprehensive tests in web/src/components/AITradersPage.test.tsx
- Fixes: https://github.com/tinkle-community/nofx/issues/227
CI/CD:
- Add GitHub Actions workflow: .github/workflows/test.yml
- Non-blocking tests (continue-on-error: true)
- Runs on push/PR to main and dev branches
Test Results:
- Backend: 1 test passing
- Frontend: 5 tests passing (including 4 for Issue #227)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Enhanced bug report template with detailed log capture instructions
- Added bug categorization system (6 main categories)
- Frontend error capture guide (DevTools Console/Network tabs)
- Backend log capture for Docker and PM2 deployments
- Trading/decision logs location and usage
- Comprehensive environment information checklist
- Quick diagnostic tips for faster issue resolution
- Created bilingual troubleshooting guides (EN/ZH)
- Common trading issues (e.g., Issue #202: only short positions)
- Detailed explanation of Binance position mode requirements
- AI decision problems and diagnostics
- Connection and API error solutions
- Frontend and database issues
- Complete log capture instructions with commands
- Emergency reset procedures
- Updated documentation cross-references
- Added troubleshooting guide links to bug report template
- Added links in README Common Issues section
- Bilingual support for better accessibility
This reduces maintainer workload by helping users self-diagnose issues
and submit higher-quality bug reports with all necessary information.
Addresses Issue #202 root cause documentation.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
