liuyu/nofx
1
0
Fork 0
mirror of https://github.com/NoFxAiOS/nofx.git synced 2026-07-06 20:41:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

robustness: add HTTP status code checks to market data & provider APIs

Browse Source 
- market/api_client.go: check StatusCode for exchangeInfo, klines, price
  endpoints + add truncateBody helper for safe error messages
- market/data.go: check StatusCode for openInterest and premiumIndex
- provider/coinank: check StatusCode for GET and POST requests
- provider/twelvedata: check StatusCode for time series and quote APIs
- Prevents confusing JSON unmarshal errors when APIs return 429/500/etc
This commit is contained in:
shinchan-zhai
2026-03-23 11:00:24 +08:00
parent a5ac1b300b
commit b94b64a305
5 changed files with 40 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
market/api_client.go
View File

@@ -15,6 +15,14 @@ const (
baseURL = "https://fapi.binance.com"
)
// truncateBody returns the first 512 bytes of body for error messages.
func truncateBody(body []byte) string {
if len(body) > 512 {
return string(body[:512]) + "..."
}
return string(body)
}
type APIClient struct {
client *http.Client
}
@@ -47,6 +55,9 @@ func (c *APIClient) GetExchangeInfo() (*ExchangeInfo, error) {
if err != nil {
return nil, err
}
if resp.StatusCode != http.StatusOK {
return nil, fmt.Errorf("Binance API error (status %d): %s", resp.StatusCode, truncateBody(body))
}
var exchangeInfo ExchangeInfo
err = json.Unmarshal(body, &exchangeInfo)
if err != nil {
@@ -79,6 +90,9 @@ func (c *APIClient) GetKlines(symbol, interval string, limit int) ([]Kline, erro
if err != nil {
return nil, err
}
if resp.StatusCode != http.StatusOK {
return nil, fmt.Errorf("Binance klines API error (status %d): %s", resp.StatusCode, truncateBody(body))
}
var klineResponses []KlineResponse
err = json.Unmarshal(body, &klineResponses)
@@ -144,6 +158,9 @@ func (c *APIClient) GetCurrentPrice(symbol string) (float64, error) {
if err != nil {
return 0, err
}
if resp.StatusCode != http.StatusOK {
return 0, fmt.Errorf("Binance price API error (status %d): %s", resp.StatusCode, truncateBody(body))
}
var ticker PriceTicker
err = json.Unmarshal(body, &ticker)

9
market/data.go
View File

@@ -1,11 +1,12 @@
package market
import (
"nofx/safe"
"encoding/json"
"fmt"
"math"
"net/http"
"nofx/logger"
"nofx/safe"
"strconv"
"strings"
"sync"
@@ -270,6 +271,9 @@ func getOpenInterestData(symbol string) (*OIData, error) {
if err != nil {
return nil, err
}
if resp.StatusCode != http.StatusOK {
return nil, fmt.Errorf("Binance openInterest API error (status %d): %s", resp.StatusCode, truncateBody(body))
}
var result struct {
OpenInterest string `json:"openInterest"`
@@ -315,6 +319,9 @@ func getFundingRate(symbol string) (float64, error) {
if err != nil {
return 0, err
}
if resp.StatusCode != http.StatusOK {
return 0, fmt.Errorf("Binance premiumIndex API error (status %d): %s", resp.StatusCode, truncateBody(body))
}
var result struct {
Symbol string `json:"symbol"`

3
provider/coinank/coinank_api/kline.go
View File

@@ -71,6 +71,9 @@ func get(ctx context.Context, path string, paramsMap map[string]string) (string,
if err != nil {
return "", err
}
if resp.StatusCode != http.StatusOK {
return "", fmt.Errorf("CoinAnk API error (status %d): %.512s", resp.StatusCode, string(body))
}
return string(body), nil
}

6
provider/coinank/coinank_http.go
View File

@@ -63,6 +63,9 @@ func (c *CoinankClient) Get(ctx context.Context, path string, paramsMap map[stri
if err != nil {
return "", err
}
if resp.StatusCode != http.StatusOK {
return "", fmt.Errorf("CoinAnk GET error (status %d): %.512s", resp.StatusCode, string(body))
}
return string(body), nil
}
@@ -88,6 +91,9 @@ func (c *CoinankClient) Post(ctx context.Context, path string, data any) (string
if err != nil {
return "", err
}
if resp.StatusCode != http.StatusOK {
return "", fmt.Errorf("CoinAnk POST error (status %d): %.512s", resp.StatusCode, string(body))
}
return string(body), nil
}

6
provider/twelvedata/kline.go
View File

@@ -129,6 +129,9 @@ func (c *Client) GetTimeSeries(ctx context.Context, symbol string, interval stri
if err != nil {
return nil, fmt.Errorf("failed to read response: %w", err)
}
if resp.StatusCode != http.StatusOK {
return nil, fmt.Errorf("TwelveData API error (status %d): %.512s", resp.StatusCode, string(body))
}
// Parse response
var result TimeSeriesResponse
@@ -176,6 +179,9 @@ func (c *Client) GetQuote(ctx context.Context, symbol string) (*QuoteResponse, e
if err != nil {
return nil, fmt.Errorf("failed to read response: %w", err)
}
if resp.StatusCode != http.StatusOK {
return nil, fmt.Errorf("TwelveData API error (status %d): %.512s", resp.StatusCode, string(body))
}
// Parse response
var result QuoteResponse