fix: Lighter CancelStopOrders now filters by TriggerPrice, proxyBinance checks upstream status

- CancelStopOrders: only cancel orders with non-empty TriggerPrice (was canceling ALL orders including regular limit orders — safety bug)
- proxyBinance: return 502 when upstream returns non-200 instead of silently proxying error pages
- Remove redundant CORS headers in agent/web.go (already handled by gin middleware)
This commit is contained in:
shinchan-zhai
2026-03-23 11:40:34 +08:00
parent 79b583bd9a
commit 44d1ef42ad
2 changed files with 18 additions and 6 deletions

View File

@@ -122,15 +122,22 @@ func proxyBinance(rw http.ResponseWriter, url string) {
return
}
defer resp.Body.Close()
// Forward upstream error status codes instead of silently proxying bad data
if resp.StatusCode != http.StatusOK {
writeJSON(rw, 502, map[string]string{"error": fmt.Sprintf("upstream returned status %d", resp.StatusCode)})
return
}
rw.Header().Set("Content-Type", "application/json")
rw.Header().Set("Access-Control-Allow-Origin", "*")
// CORS is handled by the gin middleware — no need to set it here
// Limit response body to 2MB to prevent memory exhaustion
io.Copy(rw, io.LimitReader(resp.Body, 2*1024*1024))
}
func writeJSON(w http.ResponseWriter, status int, v interface{}) {
w.Header().Set("Content-Type", "application/json")
w.Header().Set("Access-Control-Allow-Origin", "*")
// CORS is handled by the gin middleware — no need to set it here
w.WriteHeader(status)
json.NewEncoder(w).Encode(v)
}

View File

@@ -186,17 +186,22 @@ func (t *LighterTraderV2) CancelStopOrders(symbol string) error {
}
canceledCount := 0
skippedCount := 0
for _, order := range orders {
// TODO: Check order type, only cancel stop orders
// For now, cancel all orders
// Only cancel orders with a trigger price (stop-loss / take-profit)
// Regular limit orders have empty or "0" trigger price
if order.TriggerPrice == "" || order.TriggerPrice == "0" || order.TriggerPrice == "0.0" {
skippedCount++
continue
}
if err := t.CancelOrder(symbol, order.OrderID); err != nil {
logger.Infof("⚠️ Failed to cancel order (ID: %s): %v", order.OrderID, err)
logger.Infof("⚠️ Failed to cancel stop order (ID: %s): %v", order.OrderID, err)
} else {
canceledCount++
}
}
logger.Infof("✓ LIGHTER - Canceled %d stop orders", canceledCount)
logger.Infof("✓ LIGHTER - Canceled %d stop orders (skipped %d regular orders)", canceledCount, skippedCount)
return nil
}