From e3eb965f5c5c0d78a34a8dd3c3cf44c9d0521121 Mon Sep 17 00:00:00 2001
From: Jactus <dw1920@nyu.edu>
Date: Mon, 28 Sep 2020 14:10:34 +0800
Subject: [PATCH] Update issue template

---
 .github/ISSUE_TEMPLATE/bug-report.md |  4 ++--
 .github/PULL_REQUEST_TEMPLATE.md     | 11 +++++++----
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/.github/ISSUE_TEMPLATE/bug-report.md b/.github/ISSUE_TEMPLATE/bug-report.md
index 7cf52786c..721f7113c 100644
--- a/.github/ISSUE_TEMPLATE/bug-report.md
+++ b/.github/ISSUE_TEMPLATE/bug-report.md
@@ -28,10 +28,10 @@ Steps to reproduce the behavior:
 
 ## Environment
 
- - Qlib version:
+ - Qlib version (use the command: `print(qlib.__version__)`):
  - Python version:
  - OS (`Windows`, `Linux`, `MacOS`):
- - Commit number:
+ - Commit number (optional, please provide it if you are using the dev version):
 
 ## Additional Notes
 
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 2add176d3..26701a9e2 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -8,11 +8,14 @@
 <!--- Why is this change required? What problem does it solve? -->
 
 ## How Has This Been Tested?
-<!--- Please describe in detail how you tested your changes. -->
-<!--- Include details of your testing environment, tests ran to see how -->
-<!--- your change affects other areas of the code, etc. -->
+- [ ] Pass the test by running: `pytest qlib/tests/test_all_pipeline.py` under upper directory of `qlib`.
+- [ ] If you are adding a new feature, test on your own test scripts.
 
-## Screenshots (if appropriate):
+<!--- **ATTENTION**: If you are adding a new feature, please make sure your codes are **correctly tested**. If our test scripts do not cover your cases, please provide your own test scripts under the `tests` folder and test them. More information about test scripts can be found [here](https://docs.python.org/3/library/unittest.html#basic-example), or you could refer to those we provide under the `tests` folder. -->
+
+## Screenshots of Test Results (if appropriate):
+1. Pipeline test:
+2. Your own tests:
 
 ## Types of changes
 <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->