From d66733c358419be44cbe094cd0340f32d1920176 Mon Sep 17 00:00:00 2001 From: Guodong Xu Date: Sat, 26 Jun 2021 18:25:47 +0800 Subject: [PATCH] examples/workflow_by_code.ipynd: fix an error in R.get_recorder() parameters get_recorder() needs specify 'recorder_id='. However workflow_by_code.ipynd didn't. This patch fixes it. Without this fix, here is the error message jupyter-notebook reports: "--------------------------------------------------------------------------- TypeError Traceback (most recent call last) in 26 # backtest and analysis 27 with R.start(experiment_name="backtest_analysis"): ---> 28 recorder = R.get_recorder(rid, experiment_name="train_model") 29 model = recorder.load_object("trained_model") 30 TypeError: get_recorder() takes 1 positional argument but 2 positional arguments (and 1 keyword-only argument) were given" Signed-off-by: Guodong Xu --- examples/workflow_by_code.ipynb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/workflow_by_code.ipynb b/examples/workflow_by_code.ipynb index 1dda1c621..af374b350 100644 --- a/examples/workflow_by_code.ipynb +++ b/examples/workflow_by_code.ipynb @@ -220,7 +220,7 @@ "\n", "# backtest and analysis\n", "with R.start(experiment_name=\"backtest_analysis\"):\n", - " recorder = R.get_recorder(rid, experiment_name=\"train_model\")\n", + " recorder = R.get_recorder(recorder_id=rid, experiment_name=\"train_model\")\n", " model = recorder.load_object(\"trained_model\")\n", "\n", " # prediction\n", @@ -249,7 +249,7 @@ "source": [ "from qlib.contrib.report import analysis_model, analysis_position\n", "from qlib.data import D\n", - "recorder = R.get_recorder(ba_rid, experiment_name=\"backtest_analysis\")\n", + "recorder = R.get_recorder(recorder_id=ba_rid, experiment_name=\"backtest_analysis\")\n", "pred_df = recorder.load_object(\"pred.pkl\")\n", "pred_df_dates = pred_df.index.get_level_values(level='datetime')\n", "report_normal_df = recorder.load_object(\"portfolio_analysis/report_normal.pkl\")\n",