liuyu/qlib
1
0
Fork 0
mirror of https://github.com/microsoft/qlib.git synced 2026-07-12 15:26:54 +08:00
Code Activity

Fix recorder temp dir bug

Browse Source
This commit is contained in:
Jactus
2020-12-23 11:03:07 +08:00
committed by you-n-g
parent e8d7a22651
commit 95de4088df
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
qlib/workflow/recorder.py
View File

@@ -202,9 +202,6 @@ class MLflowRecorder(Recorder):
super(MLflowRecorder, self).__init__(experiment_id, name) super(MLflowRecorder, self).__init__(experiment_id, name)
self._uri = uri self._uri = uri
self.artifact_uri = None self.artifact_uri = None
# set up file manager for saving objects
self.temp_dir = tempfile.mkdtemp()
self.fm = FileManager(Path(self.temp_dir).absolute())
self.client = mlflow.tracking.MlflowClient(tracking_uri=self._uri) self.client = mlflow.tracking.MlflowClient(tracking_uri=self._uri)
# construct from mlflow run # construct from mlflow run
if mlflow_run is not None: if mlflow_run is not None:
@@ -223,6 +220,15 @@ class MLflowRecorder(Recorder):
else None else None
) )
@property
def fm(self):
# only create temp dir when using file managers
if not hasattr(self, "_fm"):
# set up file manager for saving objects
self._temp_dir = tempfile.mkdtemp()
self._fm = FileManager(Path(self._temp_dir).absolute())
return self._fm
def start_run(self): def start_run(self):
# set the tracking uri # set the tracking uri
mlflow.set_tracking_uri(self._uri) mlflow.set_tracking_uri(self._uri)
@@ -248,7 +254,7 @@ class MLflowRecorder(Recorder):
self.end_time = datetime.now().strftime("%Y-%m-%d %H:%M:%S") self.end_time = datetime.now().strftime("%Y-%m-%d %H:%M:%S")
if self.status != Recorder.STATUS_S: if self.status != Recorder.STATUS_S:
self.status = status self.status = status
shutil.rmtree(self.temp_dir) shutil.rmtree(self._temp_dir)
def save_objects(self, local_path=None, artifact_path=None, **kwargs): def save_objects(self, local_path=None, artifact_path=None, **kwargs):
assert self._uri is not None, "Please start the experiment and recorder first before using recorder directly." assert self._uri is not None, "Please start the experiment and recorder first before using recorder directly."