1
0
mirror of https://github.com/microsoft/qlib.git synced 2026-07-13 15:56:57 +08:00

Fix few exp bugs

This commit is contained in:
Jactus
2020-11-05 15:28:31 +08:00
parent 8a0135d79a
commit 918a2b8a38
3 changed files with 6 additions and 5 deletions

View File

@@ -17,7 +17,7 @@ class QlibRecorder:
@contextmanager @contextmanager
def start(self, experiment_name): def start(self, experiment_name):
run = self.start_exp(experiment_name, self.uri) run = self.start_exp(experiment_name)
try: try:
yield run yield run
except: except:

View File

@@ -74,7 +74,7 @@ class MLflowExperiment(Experiment):
def create_recorder(self): def create_recorder(self):
recorder = MLflowRecorder(self.id) recorder = MLflowRecorder(self.id)
self.recorders.append(recorder) self.recorders.append(recorder)
return recorders return recorder
def search_records(self, **kwargs): def search_records(self, **kwargs):
filter_string = "" if kwargs.get("filter_string") is None else kwargs.get("filter_string") filter_string = "" if kwargs.get("filter_string") is None else kwargs.get("filter_string")

View File

@@ -9,7 +9,7 @@ from .exp import MLflowExperiment
from .recorder import MLflowRecorder from .recorder import MLflowRecorder
from ..log import get_module_logger from ..log import get_module_logger
logger = get_module_logger("workflow", "WARN") logger = get_module_logger("workflow", "WARNING")
class ExpManager: class ExpManager:
@@ -168,8 +168,9 @@ class MLflowExpManager(ExpManager):
return self.active_recorder.start_run(experiment_id=experiment.id) return self.active_recorder.start_run(experiment_id=experiment.id)
def end_exp(self): def end_exp(self):
self.active_recorder.end_run() if self.active_recorder is not None:
self.active_recorder = None self.active_recorder.end_run()
self.active_recorder = None
def __create_exp(self, experiment_name=None, uri=None): def __create_exp(self, experiment_name=None, uri=None):
# init experiment # init experiment