From 730f6258d6ec6b88ed3a8e42d2f8d70b3ddc12b7 Mon Sep 17 00:00:00 2001 From: Young Date: Fri, 11 Jun 2021 10:40:56 +0000 Subject: [PATCH] add warning and * --- qlib/workflow/__init__.py | 10 ++++++---- qlib/workflow/expm.py | 4 ++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/qlib/workflow/__init__.py b/qlib/workflow/__init__.py index 2b2535edc..63f63fb56 100644 --- a/qlib/workflow/__init__.py +++ b/qlib/workflow/__init__.py @@ -215,9 +215,9 @@ class QlibRecorder: ------- A dictionary (id -> recorder) of recorder information that being stored. """ - return self.get_exp(experiment_id, experiment_name).list_recorders() + return self.get_exp(experiment_id=experiment_id, experiment_name=experiment_name).list_recorders() - def get_exp(self, experiment_id=None, experiment_name=None, create: bool = True) -> Experiment: + def get_exp(self, *, experiment_id=None, experiment_name=None, create: bool = True) -> Experiment: """ Method for retrieving an experiment with given id or name. Once the `create` argument is set to True, if no valid experiment is found, this method will create one for you. Otherwise, it will @@ -262,7 +262,7 @@ class QlibRecorder: # Case 2 with R.start('test'): - exp = R.get_exp('test1') + exp = R.get_exp(experiment_name='test1') # Case 3 exp = R.get_exp() -> a default experiment. @@ -287,7 +287,9 @@ class QlibRecorder: ------- An experiment instance with given id or name. """ - return self.exp_manager.get_exp(experiment_id, experiment_name, create, start=False) + return self.exp_manager.get_exp( + experiment_id=experiment_id, experiment_name=experiment_name, create=create, start=False + ) def delete_exp(self, experiment_id=None, experiment_name=None): """ diff --git a/qlib/workflow/expm.py b/qlib/workflow/expm.py index 751459d81..7e39d3a32 100644 --- a/qlib/workflow/expm.py +++ b/qlib/workflow/expm.py @@ -109,7 +109,7 @@ class ExpManager: """ raise NotImplementedError(f"Please implement the `search_records` method.") - def get_exp(self, experiment_id=None, experiment_name=None, create: bool = True, start: bool = False): + def get_exp(self, *, experiment_id=None, experiment_name=None, create: bool = True, start: bool = False): """ Retrieve an experiment. This method includes getting an active experiment, and get_or_create a specific experiment. @@ -190,7 +190,7 @@ class ExpManager: except ValueError: if experiment_name is None: experiment_name = self._default_exp_name - logger.info(f"No valid experiment found. Create a new experiment with name {experiment_name}.") + logger.warning(f"No valid experiment found. Create a new experiment with name {experiment_name}.") return self.create_exp(experiment_name), True def _get_exp(self, experiment_id=None, experiment_name=None) -> Experiment: