liuyu/qlib
1
0
Fork 0
mirror of https://github.com/microsoft/qlib.git synced 2026-07-07 13:00:58 +08:00
Code Activity

Remove fm in recorder

Browse Source
This commit is contained in:
Jactus
2020-12-23 18:59:43 +08:00
committed by you-n-g
parent 95de4088df
commit 660edeb94f
1 changed files with 6 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
qlib/workflow/recorder.py
View File

@@ -2,7 +2,7 @@
# Licensed under the MIT License. # Licensed under the MIT License.
import mlflow import mlflow
import shutil, os, pickle, tempfile, codecs import shutil, os, pickle, tempfile, codecs, pickle
from pathlib import Path from pathlib import Path
from datetime import datetime from datetime import datetime
from ..utils.objm import FileManager from ..utils.objm import FileManager
@@ -220,15 +220,6 @@ class MLflowRecorder(Recorder):
else None else None
) )
@property
def fm(self):
# only create temp dir when using file managers
if not hasattr(self, "_fm"):
# set up file manager for saving objects
self._temp_dir = tempfile.mkdtemp()
self._fm = FileManager(Path(self._temp_dir).absolute())
return self._fm
def start_run(self): def start_run(self):
# set the tracking uri # set the tracking uri
mlflow.set_tracking_uri(self._uri) mlflow.set_tracking_uri(self._uri)
@@ -254,16 +245,18 @@ class MLflowRecorder(Recorder):
self.end_time = datetime.now().strftime("%Y-%m-%d %H:%M:%S") self.end_time = datetime.now().strftime("%Y-%m-%d %H:%M:%S")
if self.status != Recorder.STATUS_S: if self.status != Recorder.STATUS_S:
self.status = status self.status = status
shutil.rmtree(self._temp_dir)
def save_objects(self, local_path=None, artifact_path=None, **kwargs): def save_objects(self, local_path=None, artifact_path=None, **kwargs):
assert self._uri is not None, "Please start the experiment and recorder first before using recorder directly." assert self._uri is not None, "Please start the experiment and recorder first before using recorder directly."
if local_path is not None: if local_path is not None:
self.client.log_artifacts(self.id, local_path, artifact_path) self.client.log_artifacts(self.id, local_path, artifact_path)
else: else:
temp_dir = Path(tempfile.mkdtemp()).resolve()
for name, data in kwargs.items(): for name, data in kwargs.items():
self.fm.save_obj(data, name) with (temp_dir / name).open("wb") as f:
self.client.log_artifact(self.id, self.fm.path / name, artifact_path) pickle.dump(data, f)
self.client.log_artifact(self.id, temp_dir / name, artifact_path)
shutil.rmtree(temp_dir)
def load_object(self, name): def load_object(self, name):
assert self._uri is not None, "Please start the experiment and recorder first before using recorder directly." assert self._uri is not None, "Please start the experiment and recorder first before using recorder directly."