Improved naming [skip ci]

This commit is contained in:
Andrew Kane
2026-06-30 01:03:08 -07:00
parent 497db7976c
commit ecd413d0fe
2 changed files with 13 additions and 13 deletions

View File

@@ -427,7 +427,7 @@ typedef struct HnswVacuumState
HnswSupport support; HnswSupport support;
/* Variables */ /* Variables */
struct tidhash_hash *deleted; struct tidhash_hash *deleting;
BufferAccessStrategy bas; BufferAccessStrategy bas;
HnswNeighborTuple ntup; HnswNeighborTuple ntup;
HnswElementData highestPoint; HnswElementData highestPoint;

View File

@@ -19,12 +19,12 @@
#endif #endif
/* /*
* Check if deleted list contains an index TID * Check if deletion list contains an element
*/ */
static bool static bool
DeletedContains(tidhash_hash * deleted, ItemPointer indextid) DeletingElement(tidhash_hash * deleting, ItemPointer indextid)
{ {
return tidhash_lookup(deleted, *indextid) != NULL; return tidhash_lookup(deleting, *indextid) != NULL;
} }
/* /*
@@ -124,10 +124,10 @@ RemoveHeapTids(HnswVacuumState * vacuumstate)
ItemPointerData ip; ItemPointerData ip;
bool found; bool found;
/* Add to deleted list */ /* Add to deletion list */
ItemPointerSet(&ip, blkno, offno); ItemPointerSet(&ip, blkno, offno);
tidhash_insert(vacuumstate->deleted, ip, &found); tidhash_insert(vacuumstate->deleting, ip, &found);
Assert(!found); Assert(!found);
} }
else if (etup->level > highestLevel) else if (etup->level > highestLevel)
@@ -200,8 +200,8 @@ NeedsUpdated(HnswVacuumState * vacuumstate, HnswElement element)
if (!ItemPointerIsValid(indextid)) if (!ItemPointerIsValid(indextid))
continue; continue;
/* Check if in deleted list */ /* Check if in deletion list */
if (DeletedContains(vacuumstate->deleted, indextid)) if (DeletingElement(vacuumstate->deleting, indextid))
{ {
needsUpdated = true; needsUpdated = true;
break; break;
@@ -335,7 +335,7 @@ RepairGraphEntryPoint(HnswVacuumState * vacuumstate)
ItemPointerSet(&epData, entryPoint->blkno, entryPoint->offno); ItemPointerSet(&epData, entryPoint->blkno, entryPoint->offno);
if (DeletedContains(vacuumstate->deleted, &epData)) if (DeletingElement(vacuumstate->deleting, &epData))
{ {
/* /*
* Replace the entry point with the highest point. If highest * Replace the entry point with the highest point. If highest
@@ -565,8 +565,8 @@ ConfirmRepaired(HnswVacuumState * vacuumstate)
if (!ItemPointerIsValid(indextid)) if (!ItemPointerIsValid(indextid))
continue; continue;
/* Check if in deleted list */ /* Check if in deletion list */
if (DeletedContains(vacuumstate->deleted, indextid)) if (DeletingElement(vacuumstate->deleting, indextid))
elog(ERROR, "hnsw graph not repaired"); elog(ERROR, "hnsw graph not repaired");
} }
@@ -748,7 +748,7 @@ InitVacuumState(HnswVacuumState * vacuumstate, IndexVacuumInfo *info, IndexBulkD
HnswGetMetaPageInfo(index, &vacuumstate->m, NULL); HnswGetMetaPageInfo(index, &vacuumstate->m, NULL);
/* Create hash table */ /* Create hash table */
vacuumstate->deleted = tidhash_create(CurrentMemoryContext, 256, NULL); vacuumstate->deleting = tidhash_create(CurrentMemoryContext, 256, NULL);
} }
/* /*
@@ -757,7 +757,7 @@ InitVacuumState(HnswVacuumState * vacuumstate, IndexVacuumInfo *info, IndexBulkD
static void static void
FreeVacuumState(HnswVacuumState * vacuumstate) FreeVacuumState(HnswVacuumState * vacuumstate)
{ {
tidhash_destroy(vacuumstate->deleted); tidhash_destroy(vacuumstate->deleting);
FreeAccessStrategy(vacuumstate->bas); FreeAccessStrategy(vacuumstate->bas);
pfree(vacuumstate->ntup); pfree(vacuumstate->ntup);
MemoryContextDelete(vacuumstate->tmpCtx); MemoryContextDelete(vacuumstate->tmpCtx);