From d4681dd898f6abf7f2e4e99c639c8acdc8b1f932 Mon Sep 17 00:00:00 2001
From: Andrew Kane <andrew@ankane.org>
Date: Fri, 30 Dec 2022 19:25:40 -0800
Subject: [PATCH] Simplified test

---
 test/t/008_avg.pl | 26 ++++++++++----------------
 1 file changed, 10 insertions(+), 16 deletions(-)

diff --git a/test/t/008_avg.pl b/test/t/008_avg.pl
index e84228a..4df8ec7 100644
--- a/test/t/008_avg.pl
+++ b/test/t/008_avg.pl
@@ -2,7 +2,7 @@ use strict;
 use warnings;
 use PostgresNode;
 use TestLib;
-use Test::More tests => 5;
+use Test::More tests => 2;
 
 # Initialize node
 my $node = get_new_node('node');
@@ -11,26 +11,20 @@ $node->start;
 
 # Create table
 $node->safe_psql("postgres", "CREATE EXTENSION vector;");
-$node->safe_psql("postgres", "CREATE TABLE tst (v vector(3));");
+$node->safe_psql("postgres", "CREATE TABLE tst (r1 real, r2 real, r3 real, v vector(3));");
 $node->safe_psql("postgres",
-	"INSERT INTO tst SELECT ARRAY[1.01 + random(), 2.01 + random(), 3.01 + random()] FROM generate_series(1, 1000000) i;"
+	"INSERT INTO tst SELECT r1, r2, r3, ARRAY[r1, r2, r3] FROM (
+		SELECT random() + 1 AS r1, random() + 2 AS r2, random() + 3 AS r3 FROM generate_series(1, 1000000) t
+	) i;"
 );
 
-# Test avg
+# Test matches real
+my $r1 = $node->safe_psql("postgres", "SELECT AVG(r1)::float4 FROM tst;");
+my $r2 = $node->safe_psql("postgres", "SELECT AVG(r2)::float4 FROM tst;");
+my $r3 = $node->safe_psql("postgres", "SELECT AVG(r3)::float4 FROM tst;");
 my $avg = $node->safe_psql("postgres", "SELECT AVG(v) FROM tst;");
-like($avg, qr/\[1\.5/);
-like($avg, qr/,2\.5/);
-like($avg, qr/,3\.5/);
+is($avg, "[$r1,$r2,$r3]");
 
 # Test explain
 my $explain = $node->safe_psql("postgres", "EXPLAIN SELECT AVG(v) FROM tst;");
 like($explain, qr/Partial Aggregate/);
-
-# Test matches real
-$node->safe_psql("postgres", "CREATE TABLE tst2 (r real, v vector(1));");
-$node->safe_psql("postgres",
-	"INSERT INTO tst2 SELECT t.r, ARRAY[t.r] FROM (SELECT random() AS r FROM generate_series(1, 1000000) t0) t;"
-);
-my $expected = $node->safe_psql("postgres", "SELECT AVG(r)::float4 FROM tst2;");
-$avg = $node->safe_psql("postgres", "SELECT AVG(v) FROM tst2;");
-is($avg, "[$expected]");