liuyu/pgvector
1
0
Fork 0
mirror of https://github.com/pgvector/pgvector.git synced 2026-07-14 00:26:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

Updated comments [skip ci]

Browse Source
This commit is contained in:
Andrew Kane
2024-01-22 10:59:46 -08:00
parent 2f9b1e2893
commit cc641002d3
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/hnswbuild.c
View File

@@ -1,5 +1,5 @@
/* /*
* HNSW build happens in two phases: * The HNSW build happens in two phases:
* *
* 1. In-memory phase * 1. In-memory phase
* *
@@ -29,7 +29,7 @@
* In the on-disk phase, the index is built by inserting each vector to the * In the on-disk phase, the index is built by inserting each vector to the
* index one by one, just like on INSERT. The only difference is that we don't * index one by one, just like on INSERT. The only difference is that we don't
* WAL-log the individual inserts. If the graph fit completely in memory and * WAL-log the individual inserts. If the graph fit completely in memory and
* was fully build in the in-memory phase, the on-disk phase is skipped. * was fully built in the in-memory phase, the on-disk phase is skipped.
* *
* After we have finished building the graph, we perform one more scan through * After we have finished building the graph, we perform one more scan through
* the index and write all the pages to the WAL. * the index and write all the pages to the WAL.
@@ -508,8 +508,10 @@ InsertTuple(Relation index, Datum *values, bool *isnull, ItemPointer heaptid, Hn
/* Get datum size */ /* Get datum size */
valueSize = VARSIZE_ANY(DatumGetPointer(value)); valueSize = VARSIZE_ANY(DatumGetPointer(value));
/* Are we in the on-disk phase? */ /* Ensure graph not flushed when inserting */
LWLockAcquire(flushLock, LW_SHARED); LWLockAcquire(flushLock, LW_SHARED);
/* Are we in the on-disk phase? */
if (graph->flushed) if (graph->flushed)
{ {
LWLockRelease(flushLock); LWLockRelease(flushLock);
@@ -518,16 +520,14 @@ InsertTuple(Relation index, Datum *values, bool *isnull, ItemPointer heaptid, Hn
} }
/* /*
* Construct an HnswElement to represent the new value.
*
* In a parallel build, the HnswElement is allocated from the shared * In a parallel build, the HnswElement is allocated from the shared
* memory area, so we need to coordinate with other processes. * memory area, so we need to coordinate with other processes.
*/ */
LWLockAcquire(&graph->allocatorLock, LW_EXCLUSIVE); LWLockAcquire(&graph->allocatorLock, LW_EXCLUSIVE);
/* /*
* Check that we still have enough memory available for the new element, * Check that we have enough memory available for the new element now that
* now that we have the allocator lock. * we have the allocator lock, and flush pages if needed.
*/ */
if (graph->memoryUsed >= graph->memoryTotal) if (graph->memoryUsed >= graph->memoryTotal)
{ {
@@ -562,8 +562,11 @@ InsertTuple(Relation index, Datum *values, bool *isnull, ItemPointer heaptid, Hn
*/ */
LWLockRelease(&graph->allocatorLock); LWLockRelease(&graph->allocatorLock);
/* Copy the datum */
memcpy(valuePtr, DatumGetPointer(value), valueSize); memcpy(valuePtr, DatumGetPointer(value), valueSize);
HnswPtrStore(base, element->value, valuePtr); HnswPtrStore(base, element->value, valuePtr);
/* Create a lock for the element */
LWLockInitialize(&element->lock, hnsw_lock_tranche_id); LWLockInitialize(&element->lock, hnsw_lock_tranche_id);
/* Insert tuple */ /* Insert tuple */