From cbec1b3f48cd983a5dd4c771fafa8dff916038d4 Mon Sep 17 00:00:00 2001
From: Andrew Kane <andrew@ankane.org>
Date: Fri, 9 Jun 2023 18:46:26 -0700
Subject: [PATCH] Improved warnings check

---
 .github/workflows/build.yml | 6 +++---
 src/ivfkmeans.c             | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 8e9bf8f..02aade4 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -26,7 +26,7 @@ jobs:
           dev-files: true
       - run: make
         env:
-          PG_CFLAGS: -Wall -Werror
+          PG_CFLAGS: -Wall -Wextra -Werror -Wno-unused-parameter
       - run: |
           export PG_CONFIG=`which pg_config`
           sudo --preserve-env=PG_CONFIG make install
@@ -47,7 +47,7 @@ jobs:
           postgres-version: 14
       - run: make
         env:
-          PG_CFLAGS: -Wall -Werror
+          PG_CFLAGS: -Wall -Wextra -Werror -Wno-unused-parameter
       - run: make install
       - run: make installcheck
       - if: ${{ failure() }}
@@ -92,4 +92,4 @@ jobs:
           sudo -u postgres make installcheck
           sudo -u postgres make prove_installcheck
         env:
-          PG_CFLAGS: -Wall -Werror
+          PG_CFLAGS: -Wall -Wextra -Werror -Wno-unused-parameter
diff --git a/src/ivfkmeans.c b/src/ivfkmeans.c
index 0079dea..eb94de0 100644
--- a/src/ivfkmeans.c
+++ b/src/ivfkmeans.c
@@ -212,7 +212,7 @@ ElkanKmeans(Relation index, VectorArray samples, VectorArray centers)
 
 	/* Check memory requirements */
 	/* Add one to error message to ceil */
-	if (totalSize / 1024 > maintenance_work_mem)
+	if (totalSize > (Size) maintenance_work_mem * 1024L)
 		ereport(ERROR,
 				(errcode(ERRCODE_PROGRAM_LIMIT_EXCEEDED),
 				 errmsg("memory required is %zu MB, maintenance_work_mem is %d MB",