liuyu/pgvector
1
0
Fork 0
mirror of https://github.com/pgvector/pgvector.git synced 2026-07-14 08:36:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

Prevent overflow at cost to speed

Browse Source
This commit is contained in:
Andrew Kane
2023-08-09 12:36:29 -07:00
parent 47e361a93d
commit 9ed7e63fb7
3 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/vector.c
View File

@@ -754,7 +754,8 @@ normalize_l2(PG_FUNCTION_ARGS)
{ {
Vector *a = PG_GETARG_VECTOR_P(0); Vector *a = PG_GETARG_VECTOR_P(0);
float *ax = a->x; float *ax = a->x;
float norm = 0.0; double norm = 0.0;
float normf;
Vector *result; Vector *result;
float *rx; float *rx;
@@ -763,15 +764,16 @@ normalize_l2(PG_FUNCTION_ARGS)
/* Auto-vectorized */ /* Auto-vectorized */
for (int i = 0; i < a->dim; i++) for (int i = 0; i < a->dim; i++)
norm += ax[i] * ax[i]; norm += (double) ax[i] * (double) ax[i];
norm = sqrtf(norm); norm = sqrt(norm);
normf = (float) norm;
if (norm > 0) if (normf > 0)
{ {
/* Auto-vectorized */ /* Auto-vectorized */
for (int i = 0, imax = a->dim; i < imax; i++) for (int i = 0, imax = a->dim; i < imax; i++)
rx[i] = ax[i] / norm; rx[i] = ax[i] / normf;
/* Check for overflow */ /* Check for overflow */
for (int i = 0, imax = a->dim; i < imax; i++) for (int i = 0, imax = a->dim; i < imax; i++)

6
test/expected/functions.out
View File

@@ -72,6 +72,12 @@ SELECT normalize_l2('[0,0]');
[0,0] [0,0]
(1 row) (1 row)
SELECT normalize_l2('[3e38]');
normalize_l2
--------------
[1]
(1 row)
SELECT l2_distance('[0,0]', '[3,4]'); SELECT l2_distance('[0,0]', '[3,4]');
l2_distance l2_distance
------------- -------------

1
test/sql/functions.sql
View File

@@ -16,6 +16,7 @@ SELECT normalize_l2('[3,4]');
SELECT normalize_l2('[3,0]'); SELECT normalize_l2('[3,0]');
SELECT normalize_l2('[0,0.1]'); SELECT normalize_l2('[0,0.1]');
SELECT normalize_l2('[0,0]'); SELECT normalize_l2('[0,0]');
SELECT normalize_l2('[3e38]');
SELECT l2_distance('[0,0]', '[3,4]'); SELECT l2_distance('[0,0]', '[3,4]');
SELECT l2_distance('[0,0]', '[0,1]'); SELECT l2_distance('[0,0]', '[0,1]');