liuyu/pgvector
1
0
Fork 0
mirror of https://github.com/pgvector/pgvector.git synced 2026-07-11 07:06:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

Free memory on errors

Browse Source
This commit is contained in:
Andrew Kane
2023-06-08 22:35:31 -07:00
parent 0134debfb8
commit 8be2b6c244
1 changed files with 31 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
src/vector.c
View File

@@ -72,18 +72,28 @@ CheckDim(int dim)
* Ensure finite elements * Ensure finite elements
*/ */
static inline void static inline void
CheckElement(float value) CheckElementOrFree(float value, Vector * vec)
{ {
if (isnan(value)) if (isnan(value))
{
if (vec != NULL)
pfree(vec);
ereport(ERROR, ereport(ERROR,
(errcode(ERRCODE_DATA_EXCEPTION), (errcode(ERRCODE_DATA_EXCEPTION),
errmsg("NaN not allowed in vector"))); errmsg("NaN not allowed in vector")));
}
if (isinf(value)) if (isinf(value))
{
if (vec != NULL)
pfree(vec);
ereport(ERROR, ereport(ERROR,
(errcode(ERRCODE_DATA_EXCEPTION), (errcode(ERRCODE_DATA_EXCEPTION),
errmsg("infinite value not allowed in vector"))); errmsg("infinite value not allowed in vector")));
}
} }
/* /*
@@ -188,7 +198,7 @@ vector_in(PG_FUNCTION_ARGS)
/* Use strtof like float4in to avoid a double-rounding problem */ /* Use strtof like float4in to avoid a double-rounding problem */
x[dim] = strtof(pt, &stringEnd); x[dim] = strtof(pt, &stringEnd);
CheckElement(x[dim]); CheckElementOrFree(x[dim], NULL);
dim++; dim++;
if (stringEnd == pt) if (stringEnd == pt)
@@ -360,7 +370,7 @@ vector_recv(PG_FUNCTION_ARGS)
for (i = 0; i < dim; i++) for (i = 0; i < dim; i++)
{ {
result->x[i] = pq_getmsgfloat4(buf); result->x[i] = pq_getmsgfloat4(buf);
CheckElement(result->x[i]); CheckElementOrFree(result->x[i], result);
} }
PG_RETURN_POINTER(result); PG_RETURN_POINTER(result);
@@ -451,7 +461,7 @@ array_to_vector(PG_FUNCTION_ARGS)
(errcode(ERRCODE_DATA_EXCEPTION), (errcode(ERRCODE_DATA_EXCEPTION),
errmsg("unsupported array type"))); errmsg("unsupported array type")));
CheckElement(result->x[i]); CheckElementOrFree(result->x[i], result);
} }
PG_RETURN_POINTER(result); PG_RETURN_POINTER(result);
@@ -690,8 +700,13 @@ vector_add(PG_FUNCTION_ARGS)
rx[i] = ax[i] + bx[i]; rx[i] = ax[i] + bx[i];
for (int i = 0, imax = a->dim; i < imax; i++) for (int i = 0, imax = a->dim; i < imax; i++)
{
if (isinf(rx[i])) if (isinf(rx[i]))
{
pfree(result);
float_overflow_error(); float_overflow_error();
}
}
PG_RETURN_POINTER(result); PG_RETURN_POINTER(result);
} }
@@ -720,8 +735,13 @@ vector_sub(PG_FUNCTION_ARGS)
rx[i] = ax[i] - bx[i]; rx[i] = ax[i] - bx[i];
for (int i = 0, imax = a->dim; i < imax; i++) for (int i = 0, imax = a->dim; i < imax; i++)
{
if (isinf(rx[i])) if (isinf(rx[i]))
{
pfree(result);
float_overflow_error(); float_overflow_error();
}
}
PG_RETURN_POINTER(result); PG_RETURN_POINTER(result);
} }
@@ -882,7 +902,10 @@ vector_accum(PG_FUNCTION_ARGS)
double v = statevalues[i + 1] + x[i]; double v = statevalues[i + 1] + x[i];
if (isinf(v)) if (isinf(v))
{
pfree(statedatums);
float_overflow_error(); float_overflow_error();
}
statedatums[i + 1] = Float8GetDatum(v); statedatums[i + 1] = Float8GetDatum(v);
} }
@@ -950,7 +973,10 @@ vector_combine(PG_FUNCTION_ARGS)
double v = statevalues1[i] + statevalues2[i]; double v = statevalues1[i] + statevalues2[i];
if (isinf(v)) if (isinf(v))
{
pfree(statedatums);
float_overflow_error(); float_overflow_error();
}
statedatums[i] = Float8GetDatum(v); statedatums[i] = Float8GetDatum(v);
} }
@@ -996,7 +1022,7 @@ vector_avg(PG_FUNCTION_ARGS)
for (int i = 0; i < dim; i++) for (int i = 0; i < dim; i++)
{ {
v = statevalues[i + 1] / n; v = statevalues[i + 1] / n;
CheckElement(v); CheckElementOrFree(v, result);
result->x[i] = v; result->x[i] = v;
} }