liuyu/pgvector
1
0
Fork 0
mirror of https://github.com/pgvector/pgvector.git synced 2026-07-14 08:36:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

Improved error message for invalid input syntax

Browse Source
This commit is contained in:
Andrew Kane
2023-06-11 12:00:04 -07:00
parent 5fdf5573a0
commit 7ee9e86b10
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/vector.c
View File

@@ -194,7 +194,7 @@ vector_in(PG_FUNCTION_ARGS)
if (stringEnd == pt) if (stringEnd == pt)
ereport(ERROR, ereport(ERROR,
(errcode(ERRCODE_INVALID_TEXT_REPRESENTATION), (errcode(ERRCODE_INVALID_TEXT_REPRESENTATION),
errmsg("invalid input syntax for type vector: \"%s\"", pt))); errmsg("invalid input syntax for type vector: \"%s\"", lit)));
while (vector_isspace(*stringEnd)) while (vector_isspace(*stringEnd))
stringEnd++; stringEnd++;
@@ -202,7 +202,7 @@ vector_in(PG_FUNCTION_ARGS)
if (*stringEnd != '\0' && *stringEnd != ']') if (*stringEnd != '\0' && *stringEnd != ']')
ereport(ERROR, ereport(ERROR,
(errcode(ERRCODE_INVALID_TEXT_REPRESENTATION), (errcode(ERRCODE_INVALID_TEXT_REPRESENTATION),
errmsg("invalid input syntax for type vector: \"%s\"", pt))); errmsg("invalid input syntax for type vector: \"%s\"", lit)));
pt = strtok(NULL, ","); pt = strtok(NULL, ",");
} }

4
test/expected/input.out
View File

@@ -23,7 +23,7 @@ SELECT '[1.23456]'::vector;
(1 row) (1 row)
SELECT '[hello,1]'::vector; SELECT '[hello,1]'::vector;
ERROR: invalid input syntax for type vector: "hello" ERROR: invalid input syntax for type vector: "[hello,1]"
LINE 1: SELECT '[hello,1]'::vector; LINE 1: SELECT '[hello,1]'::vector;
^ ^
SELECT '[NaN,1]'::vector; SELECT '[NaN,1]'::vector;
@@ -62,7 +62,7 @@ ERROR: vector must have at least 1 dimension
LINE 1: SELECT '[]'::vector; LINE 1: SELECT '[]'::vector;
^ ^
SELECT '[1,]'::vector; SELECT '[1,]'::vector;
ERROR: invalid input syntax for type vector: "]" ERROR: invalid input syntax for type vector: "[1,]"
LINE 1: SELECT '[1,]'::vector; LINE 1: SELECT '[1,]'::vector;
^ ^
SELECT '[1,2,3]'::vector(2); SELECT '[1,2,3]'::vector(2);