From 3c99b55cf9d63afda2c7b145e2624bcd0c5be2d8 Mon Sep 17 00:00:00 2001 From: Andrew Kane Date: Fri, 2 Aug 2024 14:34:56 -0700 Subject: [PATCH] Fixed locking for UpdateNeighborsInMemory --- src/hnswbuild.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/hnswbuild.c b/src/hnswbuild.c index dcfb2bd..4310243 100644 --- a/src/hnswbuild.c +++ b/src/hnswbuild.c @@ -381,6 +381,18 @@ UpdateNeighborsInMemory(char *base, FmgrInfo *procinfo, Oid collation, HnswEleme int lm = HnswGetLayerM(m, lc); HnswNeighborArray *neighbors = HnswGetNeighbors(base, e, lc); + /* Copy neighbors to local memory if needed */ + if (base != NULL) + { + Size neighborsSize = HNSW_NEIGHBOR_ARRAY_SIZE(HnswGetLayerM(m, lc)); + HnswNeighborArray *neighborsData = palloc(neighborsSize); + + LWLockAcquire(&e->lock, LW_SHARED); + memcpy(neighborsData, neighbors, neighborsSize); + LWLockRelease(&e->lock); + neighbors = neighborsData; + } + for (int i = 0; i < neighbors->length; i++) { HnswCandidate *hc = &neighbors->items[i];