liuyu/pgvector
1
0
Fork 0
mirror of https://github.com/pgvector/pgvector.git synced 2026-07-11 23:26:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

Improved input functions [skip ci]

Browse Source
This commit is contained in:
Andrew Kane
2024-04-13 11:09:59 -07:00
parent 9957ba6817
commit 23944302fe
6 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/halfvec.c
View File

@@ -173,6 +173,10 @@ halfvec_in(PG_FUNCTION_ARGS)
errdetail("Vector contents must start with \"[\"."))); errdetail("Vector contents must start with \"[\".")));
str++; str++;
while (halfvec_isspace(*str))
str++;
pt = strtok(str, ","); pt = strtok(str, ",");
stringEnd = pt; stringEnd = pt;

4
src/vector.c
View File

@@ -197,6 +197,10 @@ vector_in(PG_FUNCTION_ARGS)
errdetail("Vector contents must start with \"[\"."))); errdetail("Vector contents must start with \"[\".")));
str++; str++;
while (vector_isspace(*str))
str++;
pt = strtok(str, ","); pt = strtok(str, ",");
stringEnd = pt; stringEnd = pt;

6
test/expected/halfvec_input.out
View File

@@ -96,9 +96,10 @@ LINE 1: SELECT '['::halfvec;
^ ^
DETAIL: Unexpected end of input. DETAIL: Unexpected end of input.
SELECT '[ '::halfvec; SELECT '[ '::halfvec;
ERROR: invalid input syntax for type halfvec: "[ " ERROR: malformed halfvec literal: "[ "
LINE 1: SELECT '[ '::halfvec; LINE 1: SELECT '[ '::halfvec;
^ ^
DETAIL: Unexpected end of input.
SELECT '[,'::halfvec; SELECT '[,'::halfvec;
ERROR: malformed halfvec literal: "[," ERROR: malformed halfvec literal: "[,"
LINE 1: SELECT '[,'::halfvec; LINE 1: SELECT '[,'::halfvec;
@@ -108,9 +109,8 @@ SELECT '[]'::halfvec;
ERROR: halfvec must have at least 1 dimension ERROR: halfvec must have at least 1 dimension
LINE 1: SELECT '[]'::halfvec; LINE 1: SELECT '[]'::halfvec;
^ ^
-- TODO fix error message
SELECT '[ ]'::halfvec; SELECT '[ ]'::halfvec;
ERROR: invalid input syntax for type halfvec: "[ ]" ERROR: halfvec must have at least 1 dimension
LINE 1: SELECT '[ ]'::halfvec; LINE 1: SELECT '[ ]'::halfvec;
^ ^
-- TODO fix error message -- TODO fix error message

6
test/expected/vector_input.out
View File

@@ -108,9 +108,10 @@ LINE 1: SELECT '['::vector;
^ ^
DETAIL: Unexpected end of input. DETAIL: Unexpected end of input.
SELECT '[ '::vector; SELECT '[ '::vector;
ERROR: invalid input syntax for type vector: "[ " ERROR: malformed vector literal: "[ "
LINE 1: SELECT '[ '::vector; LINE 1: SELECT '[ '::vector;
^ ^
DETAIL: Unexpected end of input.
SELECT '[,'::vector; SELECT '[,'::vector;
ERROR: malformed vector literal: "[," ERROR: malformed vector literal: "[,"
LINE 1: SELECT '[,'::vector; LINE 1: SELECT '[,'::vector;
@@ -120,9 +121,8 @@ SELECT '[]'::vector;
ERROR: vector must have at least 1 dimension ERROR: vector must have at least 1 dimension
LINE 1: SELECT '[]'::vector; LINE 1: SELECT '[]'::vector;
^ ^
-- TODO fix error message
SELECT '[ ]'::vector; SELECT '[ ]'::vector;
ERROR: invalid input syntax for type vector: "[ ]" ERROR: vector must have at least 1 dimension
LINE 1: SELECT '[ ]'::vector; LINE 1: SELECT '[ ]'::vector;
^ ^
-- TODO fix error message -- TODO fix error message

1
test/sql/halfvec_input.sql
View File

@@ -20,7 +20,6 @@ SELECT '['::halfvec;
SELECT '[ '::halfvec; SELECT '[ '::halfvec;
SELECT '[,'::halfvec; SELECT '[,'::halfvec;
SELECT '[]'::halfvec; SELECT '[]'::halfvec;
-- TODO fix error message
SELECT '[ ]'::halfvec; SELECT '[ ]'::halfvec;
-- TODO fix error message -- TODO fix error message
SELECT '[,]'::vector; SELECT '[,]'::vector;

1
test/sql/vector_input.sql
View File

@@ -22,7 +22,6 @@ SELECT '['::vector;
SELECT '[ '::vector; SELECT '[ '::vector;
SELECT '[,'::vector; SELECT '[,'::vector;
SELECT '[]'::vector; SELECT '[]'::vector;
-- TODO fix error message
SELECT '[ ]'::vector; SELECT '[ ]'::vector;
-- TODO fix error message -- TODO fix error message
SELECT '[,]'::vector; SELECT '[,]'::vector;