From 1a0d7bccc7f5ae5c312c3d09cde09f2935e2a390 Mon Sep 17 00:00:00 2001 From: Andrew Kane Date: Thu, 10 Aug 2023 20:47:15 -0700 Subject: [PATCH] Updated min ef_search to 1 [skip ci] --- src/hnsw.c | 2 +- src/hnsw.h | 2 +- test/expected/hnsw_options.out | 6 +++--- test/sql/hnsw_options.sql | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/hnsw.c b/src/hnsw.c index 6248aa8..1c3c8ac 100644 --- a/src/hnsw.c +++ b/src/hnsw.c @@ -37,7 +37,7 @@ HnswInit(void) ); DefineCustomIntVariable("hnsw.ef_search", "Sets the size of the dynamic candidate list for search", - "Valid range is 10..1000.", &hnsw_ef_search, + "Valid range is 1..1000.", &hnsw_ef_search, HNSW_DEFAULT_EF_SEARCH, HNSW_MIN_EF_SEARCH, HNSW_MAX_EF_SEARCH, PGC_USERSET, 0, NULL, NULL, NULL); } diff --git a/src/hnsw.h b/src/hnsw.h index 46c7889..0bc9c79 100644 --- a/src/hnsw.h +++ b/src/hnsw.h @@ -35,7 +35,7 @@ #define HNSW_MIN_EF_CONSTRUCTION 10 #define HNSW_MAX_EF_CONSTRUCTION 1000 #define HNSW_DEFAULT_EF_SEARCH 40 -#define HNSW_MIN_EF_SEARCH 10 +#define HNSW_MIN_EF_SEARCH 1 #define HNSW_MAX_EF_SEARCH 1000 #define HNSW_ELEMENT_TUPLE_TYPE 1 diff --git a/test/expected/hnsw_options.out b/test/expected/hnsw_options.out index be10beb..afdc67a 100644 --- a/test/expected/hnsw_options.out +++ b/test/expected/hnsw_options.out @@ -18,8 +18,8 @@ SHOW hnsw.ef_search; 40 (1 row) -SET hnsw.ef_search = 9; -ERROR: 9 is outside the valid range for parameter "hnsw.ef_search" (10 .. 1000) +SET hnsw.ef_search = 0; +ERROR: 0 is outside the valid range for parameter "hnsw.ef_search" (1 .. 1000) SET hnsw.ef_search = 1001; -ERROR: 1001 is outside the valid range for parameter "hnsw.ef_search" (10 .. 1000) +ERROR: 1001 is outside the valid range for parameter "hnsw.ef_search" (1 .. 1000) DROP TABLE t; diff --git a/test/sql/hnsw_options.sql b/test/sql/hnsw_options.sql index c289922..f70bb95 100644 --- a/test/sql/hnsw_options.sql +++ b/test/sql/hnsw_options.sql @@ -8,7 +8,7 @@ CREATE INDEX ON t USING hnsw (val vector_l2_ops) WITH (ef_construction = 1001); SHOW hnsw.ef_search; -SET hnsw.ef_search = 9; +SET hnsw.ef_search = 0; SET hnsw.ef_search = 1001; DROP TABLE t;