Files
openclaw/test/scripts/e2e-temp-state-dir.test.ts
Val Alexander 529282dcff fix(ui): harden Workboard dialog accessibility
Harden Workboard modal and drawer accessibility.

Summary:
- Add Workboard dialog focus lifecycle handling for initial focus, Tab/Shift+Tab containment, Escape close, and opener restore.
- Mark Workboard background content inert/aria-hidden while modal or drawer dialogs are active.
- Add focused unit and Chromium browser smoke coverage for the audited modal/drawer accessibility requirements.
- Keep UI browser test aliases able to resolve shared workspace packages used by the Workboard view.

Verification:
- node scripts/run-vitest.mjs ui/src/ui/views/workboard.test.ts
- node scripts/run-vitest.mjs ui/src/ui/views/workboard.browser.test.ts
- (cd ui && pnpm exec vitest run --config vitest.config.ts --project browser src/ui/views/workboard.browser.test.ts)
- GitHub checks green at 6557012430
2026-06-03 06:14:40 -05:00

133 lines
4.0 KiB
TypeScript

import { spawn } from "node:child_process";
import {
chmodSync,
existsSync,
mkdirSync,
mkdtempSync,
readFileSync,
rmSync,
writeFileSync,
} from "node:fs";
import { tmpdir } from "node:os";
import path from "node:path";
import { setTimeout as delay } from "node:timers/promises";
import { pathToFileURL } from "node:url";
import { describe, expect, it } from "vitest";
import { createE2eStateDir } from "../../scripts/e2e/lib/temp-state-dir.ts";
async function waitForFile(filePath: string) {
for (let attempt = 0; attempt < 100; attempt += 1) {
if (existsSync(filePath)) {
return;
}
await delay(20);
}
throw new Error(`Timed out waiting for ${filePath}`);
}
function waitForExit(child: ReturnType<typeof spawn>) {
return new Promise<{ code: number | null; signal: NodeJS.Signals | null }>((resolve, reject) => {
child.once("error", reject);
child.once("exit", (code, signal) => resolve({ code, signal }));
});
}
describe("E2E temp state dirs", () => {
it("cleans generated state dirs", async () => {
const state = await createE2eStateDir("openclaw-e2e-temp-state-test-", {
OPENCLAW_STATE_DIR: "",
});
expect(state.created).toBe(true);
expect(existsSync(state.stateDir)).toBe(true);
state.cleanup();
expect(existsSync(state.stateDir)).toBe(false);
});
it("leaves caller-provided state dirs alone", async () => {
const root = mkdtempSync(path.join(tmpdir(), "openclaw-e2e-temp-state-existing-"));
try {
const state = await createE2eStateDir("openclaw-e2e-temp-state-test-", {
OPENCLAW_STATE_DIR: root,
});
expect(state).toMatchObject({ created: false, stateDir: root });
state.cleanup();
expect(existsSync(root)).toBe(true);
} finally {
rmSync(root, { force: true, recursive: true });
}
});
it.runIf(process.platform !== "win32")(
"retries generated state cleanup after a failed removal",
async () => {
const root = mkdtempSync(path.join(tmpdir(), "openclaw-e2e-temp-state-retry-"));
const lockedParent = path.join(root, "locked");
mkdirSync(lockedParent);
const state = await createE2eStateDir(
`${path.relative(tmpdir(), lockedParent)}${path.sep}state-`,
{
OPENCLAW_STATE_DIR: "",
},
);
try {
chmodSync(lockedParent, 0o500);
expect(() => state.cleanup()).toThrow();
expect(existsSync(state.stateDir)).toBe(true);
} finally {
chmodSync(lockedParent, 0o700);
}
state.cleanup();
expect(existsSync(state.stateDir)).toBe(false);
rmSync(root, { force: true, recursive: true });
},
);
it("cleans generated state dirs on termination signals", async () => {
const root = mkdtempSync(path.join(tmpdir(), "openclaw-e2e-temp-state-signal-"));
try {
const statePathFile = path.join(root, "state-path");
const scriptPath = path.join(root, "probe.mjs");
const helperUrl = pathToFileURL(path.resolve("scripts/e2e/lib/temp-state-dir.ts")).href;
writeFileSync(
scriptPath,
`import { writeFileSync } from "node:fs";
import { createE2eStateDir } from ${JSON.stringify(helperUrl)};
const state = await createE2eStateDir("openclaw-e2e-temp-state-signal-", {
OPENCLAW_STATE_DIR: "",
});
state.registerExitCleanup();
writeFileSync(${JSON.stringify(statePathFile)}, state.stateDir);
setInterval(() => {}, 1000);
`,
);
const child = spawn(process.execPath, [scriptPath], {
stdio: "ignore",
});
try {
await waitForFile(statePathFile);
const stateDir = readFileSync(statePathFile, "utf8").trim();
expect(existsSync(stateDir)).toBe(true);
child.kill("SIGTERM");
const exit = await waitForExit(child);
expect(exit).toEqual({ code: null, signal: "SIGTERM" });
expect(existsSync(stateDir)).toBe(false);
} finally {
if (child.exitCode === null && child.signalCode === null) {
child.kill("SIGKILL");
}
}
} finally {
rmSync(root, { force: true, recursive: true });
}
});
});