Compare commits

..

465 Commits

Author SHA1 Message Date
Vincent Koc
ba42b6353a fix(whatsapp): route ssrf test helper through local seam 2026-04-11 00:30:11 +01:00
Tak Hoffman
61814c36c9 fix: preserve sender identity in compaction tools 2026-04-11 00:30:10 +01:00
Peter Steinberger
39ef4e8efe test: simplify plugin metadata assertions 2026-04-11 00:30:10 +01:00
Vincent Koc
9a6bfbf51d docs(ci): refresh release notes lane references 2026-04-11 00:11:44 +01:00
Vincent Koc
0cdcb86149 ci(test): align node lane names with boundary split 2026-04-11 00:11:44 +01:00
Peter Steinberger
71efba043c refactor: simplify provider oauth prompts 2026-04-11 00:11:08 +01:00
Peter Steinberger
73d054b764 refactor: simplify web channel runtime export names 2026-04-11 00:09:38 +01:00
Peter Steinberger
29ff425727 refactor: simplify bluebubbles setup strings 2026-04-11 00:08:15 +01:00
Peter Steinberger
a18c717add test: isolate browser network guards 2026-04-11 00:07:41 +01:00
Peter Steinberger
4ff237d776 refactor: simplify browser snapshot strings 2026-04-11 00:07:03 +01:00
Peter Steinberger
7b99a6eaa7 refactor: simplify device-pair error formatting 2026-04-11 00:05:45 +01:00
Rahul kumar Pal
3b57af0388 fix: don't bleed top-level interval/prompt into heartbeat task parsing (#64488)
Merged via squash.

Prepared head SHA: c0cd0fc823
Co-authored-by: Rahulkumar070 <151990777+Rahulkumar070@users.noreply.github.com>
Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
Reviewed-by: @jalehman
2026-04-10 16:05:09 -07:00
Peter Steinberger
5f089b6c2c refactor: simplify discord preflight conversions 2026-04-11 00:04:02 +01:00
Peter Steinberger
ecf76bd97e test: isolate channel media network guards 2026-04-11 00:01:43 +01:00
Peter Steinberger
97df07ed9a refactor: simplify discord allow-list normalization 2026-04-11 00:01:08 +01:00
Tak Hoffman
1c0e444f56 fix: preserve sender-keyed plugin command bindings 2026-04-10 18:00:48 -05:00
Peter Steinberger
c28900f509 refactor: simplify discord thread ids 2026-04-10 23:59:29 +01:00
hcl
8a28a3b056 fix(plugins): preserve contextEngine slot through config normalization (#64192)
Merged via squash.

Prepared head SHA: ae8bd9f09d
Co-authored-by: hclsys <7755017+hclsys@users.noreply.github.com>
Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
Reviewed-by: @jalehman
2026-04-10 15:58:27 -07:00
Peter Steinberger
c0dc3b3cb7 refactor: simplify foundry onboard prompts 2026-04-10 23:57:31 +01:00
Tak Hoffman
5d1f1d9362 fix: preserve reset hook sender policy context 2026-04-10 17:56:33 -05:00
Peter Steinberger
f3abc0c076 test: isolate media network fetches 2026-04-10 23:56:22 +01:00
Peter Steinberger
6bc7822ec7 refactor: simplify msteams allowlist prompt 2026-04-10 23:55:59 +01:00
Peter Steinberger
8025184168 refactor: simplify msteams credential prompts 2026-04-10 23:54:43 +01:00
Peter Steinberger
6d1d5145d9 refactor: simplify telegram ingress logging 2026-04-10 23:53:11 +01:00
Peter Steinberger
7aa3ecad3f refactor: simplify zalouser directory ids 2026-04-10 23:51:47 +01:00
Peter Steinberger
8c0a5ac53b test: isolate provider media fetches 2026-04-10 23:50:11 +01:00
Peter Steinberger
d96c5767c5 refactor: simplify webhook secret headers 2026-04-10 23:49:59 +01:00
Tak Hoffman
8e45398e1d fix: preserve outbound sender policy context 2026-04-10 17:48:58 -05:00
Peter Steinberger
f01469358f test: simplify browser download path checks 2026-04-10 23:48:27 +01:00
Peter Steinberger
81fbe129c9 perf: optimize test import surfaces 2026-04-10 23:48:03 +01:00
Peter Steinberger
d56886e10d test: simplify discord model picker component checks 2026-04-10 23:46:45 +01:00
Peter Steinberger
22c2af0065 test: isolate qa network fetches 2026-04-10 23:46:20 +01:00
mariosousa-finn
ac13b09b74 fix(agents,gateway): keep subagent announces in the original thread (#63143)
Merged via squash.

Prepared head SHA: 9aa5303b48
Co-authored-by: mariosousa-finn <244526439+mariosousa-finn@users.noreply.github.com>
Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
Reviewed-by: @jalehman
2026-04-10 15:46:01 -07:00
Peter Steinberger
9832559f45 refactor: simplify discord send result ids 2026-04-10 23:44:53 +01:00
Peter Steinberger
22955fcdcb refactor: simplify foundry cli output handling 2026-04-10 23:43:27 +01:00
Tak Hoffman
928c1c3861 test: skip helper directories in runtime guardrail scans 2026-04-10 17:42:12 -05:00
Peter Steinberger
1aab686a1a refactor: simplify tlon thread id handling 2026-04-10 23:42:02 +01:00
Peter Steinberger
29453c9578 refactor: simplify device identity pem exports 2026-04-10 23:40:06 +01:00
Peter Steinberger
b8cb0b4473 refactor: simplify image metadata dimensions 2026-04-10 23:38:44 +01:00
Peter Steinberger
a5aa9f93e9 refactor: simplify claude usage debug parsing 2026-04-10 23:37:23 +01:00
Peter Steinberger
9082fc37f3 refactor: simplify legacy auth provider normalization 2026-04-10 23:36:08 +01:00
Peter Steinberger
3d4e524014 refactor: simplify model catalog normalization 2026-04-10 23:34:49 +01:00
Peter Steinberger
8473099c70 fix: honor inactive runtime web providers 2026-04-10 23:32:37 +01:00
Peter Steinberger
3ead2d1090 refactor: simplify openai response part extraction 2026-04-10 23:32:22 +01:00
Peter Steinberger
96817fe6e9 test: simplify reset hook surface values 2026-04-10 23:30:50 +01:00
Peter Steinberger
debe372c9a test: add medium game qa scenarios 2026-04-10 23:29:58 +01:00
Peter Steinberger
610407730d fix: stop qa lab children cleanly 2026-04-10 23:29:58 +01:00
Peter Steinberger
c643e3c72d fix: dispose codex app-server harnesses 2026-04-10 23:29:58 +01:00
Peter Steinberger
f1d3815077 refactor: simplify reply dispatch string normalization 2026-04-10 23:29:29 +01:00
Peter Steinberger
1a93b9cf03 refactor: simplify daemon status flags 2026-04-10 23:27:48 +01:00
Peter Steinberger
0d1360ed7c fix: preserve plugin group policy resolution 2026-04-10 23:27:18 +01:00
Peter Steinberger
594a84cfa4 refactor: simplify nodes invoke option values 2026-04-10 23:26:29 +01:00
Tak Hoffman
6a8da3dc49 fix: resolve group tool policy from canonical session ids 2026-04-10 17:26:02 -05:00
Peter Steinberger
44c2474172 refactor: simplify agent add prompt values 2026-04-10 23:25:05 +01:00
Peter Steinberger
b3b8b9a0a9 refactor: simplify doctor prompt defaults 2026-04-10 23:23:13 +01:00
Peter Steinberger
e26794e9ef perf: optimize directive test imports 2026-04-10 23:22:22 +01:00
Peter Steinberger
e2b03049b6 refactor: remove redundant model list conversions 2026-04-10 23:21:53 +01:00
Peter Steinberger
dcca78bc00 test: simplify gateway auth token helpers 2026-04-10 23:20:39 +01:00
Peter Steinberger
53f97f86c7 test: simplify plugin fixture path strings 2026-04-10 23:16:38 +01:00
Peter Steinberger
75cee3d4d1 refactor: normalize gateway wizard text input 2026-04-10 23:15:19 +01:00
Peter Steinberger
058a3a7ee0 refactor: remove redundant whatsapp setup conversions 2026-04-10 23:13:53 +01:00
Peter Steinberger
849e0d0a7f test: narrow telegram sticker cache imports 2026-04-10 23:12:59 +01:00
Peter Steinberger
02b5be4370 test: remove redundant zalouser note conversions 2026-04-10 23:12:28 +01:00
Peter Steinberger
aa55ba6316 test: remove duplicate openai image response keys 2026-04-10 23:11:01 +01:00
Peter Steinberger
62adec38b8 refactor: remove redundant memory config conversions 2026-04-10 23:11:00 +01:00
Peter Steinberger
f7a10d6759 refactor: isolate strict-agentic execution policy 2026-04-10 23:09:55 +01:00
Peter Steinberger
a73dc477d7 style: apply oxfmt cleanup 2026-04-10 23:09:37 +01:00
Peter Steinberger
6281dd7379 perf: reduce test import overhead 2026-04-10 23:09:37 +01:00
Peter Steinberger
88bb6b0bce refactor: normalize google prompt cache keys 2026-04-10 23:09:01 +01:00
Peter Steinberger
c59fc764db docs(codex): document harness command smoke 2026-04-10 23:07:25 +01:00
Peter Steinberger
3f6af907f7 test(codex): cover app-server command seams 2026-04-10 23:07:25 +01:00
Peter Steinberger
3b65e2302a refactor(codex): split app-server lifecycle seams 2026-04-10 23:07:25 +01:00
Peter Steinberger
979ae0bb53 refactor: remove redundant openai stream conversions 2026-04-10 23:07:15 +01:00
Peter Steinberger
6c4921890b test: reuse trigger usage reply text 2026-04-10 23:05:48 +01:00
Tak Hoffman
f16a66fa43 fix: release local heavy-check locks on success 2026-04-10 17:05:26 -05:00
Peter Steinberger
8b7ba0e481 test: keep unit-fast single shard 2026-04-10 23:04:29 +01:00
Peter Steinberger
de8f3fdf92 test: split unit-fast shard 2026-04-10 23:02:22 +01:00
Peter Steinberger
9f5bdde62f test: reuse reply usage text 2026-04-10 23:02:03 +01:00
Peter Steinberger
0bd2857dce refactor: remove redundant model directive conversions 2026-04-10 23:00:38 +01:00
Peter Steinberger
1e72b11825 refactor: remove redundant canvas option conversions 2026-04-10 22:59:08 +01:00
Peter Steinberger
7c37de2d41 refactor: remove redundant location option conversions 2026-04-10 22:58:10 +01:00
Peter Steinberger
3a2dd52cf9 refactor: remove redundant screen option conversions 2026-04-10 22:56:41 +01:00
Peter Steinberger
e22f60faea docs: note strict-agentic execution contract 2026-04-10 22:56:37 +01:00
Peter Steinberger
09b1117271 agents: add strict-agentic execution contract 2026-04-10 22:56:37 +01:00
Peter Steinberger
3de0267908 refactor: remove redundant model status conversions 2026-04-10 22:55:14 +01:00
Peter Steinberger
2db067d886 refactor: remove redundant exec file conversions 2026-04-10 22:53:35 +01:00
Peter Steinberger
7d0f3c20bb test: remove redundant gateway pem conversions 2026-04-10 22:52:16 +01:00
Peter Steinberger
18db265ef3 refactor: remove redundant device pair conversions 2026-04-10 22:50:29 +01:00
Peter Steinberger
b74a1f997b chore: remove redundant discord smoke conversions 2026-04-10 22:48:35 +01:00
Peter Steinberger
69fc1fcb79 test: reuse subagents command fixture values 2026-04-10 22:47:24 +01:00
Peter Steinberger
70e128e559 test: remove duplicate openai final url stubs 2026-04-10 22:46:51 +01:00
Peter Steinberger
b896f126a2 test: reuse channel status account ids 2026-04-10 22:45:42 +01:00
Peter Steinberger
49ec2f15c3 test: include openai guarded fetch final url 2026-04-10 22:45:42 +01:00
Tak Hoffman
43b91c0ab3 test: satisfy openai postJsonRequest mock shape 2026-04-10 16:44:45 -05:00
Peter Steinberger
67f1a20136 docs: add Codex harness recipes 2026-04-10 22:43:44 +01:00
Peter Steinberger
796ea57378 test: validate Codex app-server config 2026-04-10 22:43:44 +01:00
Peter Steinberger
8d72aafdbb refactor: split Codex app-server modules 2026-04-10 22:43:44 +01:00
Peter Steinberger
e9684c22c1 test: remove redundant doctor status conversions 2026-04-10 22:43:15 +01:00
Tak Hoffman
98be3ab6de test: harden openai image generation stub 2026-04-10 16:41:50 -05:00
Peter Steinberger
1c821c614f refactor: remove redundant matrix onboarding conversions 2026-04-10 22:41:21 +01:00
Peter Steinberger
84ebbc461d refactor: remove redundant whatsapp inbound conversions 2026-04-10 22:39:28 +01:00
Peter Steinberger
d0581ca66f refactor: remove redundant agent runner conversions 2026-04-10 22:37:37 +01:00
Peter Steinberger
9fb131e5fe refactor: remove redundant gateway configure conversions 2026-04-10 22:35:59 +01:00
Peter Steinberger
ccbbe1cd95 refactor: remove redundant remote onboard conversions 2026-04-10 22:34:27 +01:00
Shion Eria
552667271e fix(cli): route gateway media sends through sendMedia (openclaw#64492)
Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm test -- src/cli/send-runtime/channel-outbound-send.test.ts src/gateway/server-methods/send.test.ts

Representative verification note:
- pnpm check reached tsgo in this worktree and then failed locally without actionable diagnostics; treated as an unhealthy local tooling signal rather than a PR-specific regression.

Co-authored-by: ShionEria <267903315+ShionEria@users.noreply.github.com>
2026-04-10 16:33:46 -05:00
Peter Steinberger
e1a350d08e refactor: remove redundant setup helper conversions 2026-04-10 22:32:30 +01:00
Tak Hoffman
2995c98990 config: sync embedded harness schema labels 2026-04-10 16:31:42 -05:00
Peter Steinberger
f274655f66 refactor: remove redundant pairing store conversions 2026-04-10 22:30:06 +01:00
Peter Steinberger
b54bd26661 refactor: remove redundant agent method conversions 2026-04-10 22:28:28 +01:00
Peter Steinberger
a3301a1b18 refactor: remove redundant node method conversions 2026-04-10 22:26:30 +01:00
Peter Steinberger
dcc3392a1a refactor: remove redundant model fallback conversions 2026-04-10 22:24:45 +01:00
Peter Steinberger
3d1b74bfc1 refactor: remove redundant zalo user conversions 2026-04-10 22:22:50 +01:00
Peter Steinberger
d187e1f3ad refactor: remove redundant feishu setup conversions 2026-04-10 22:21:26 +01:00
Tak Hoffman
efd6da136d fix: restore CI compile checks 2026-04-10 16:19:53 -05:00
Peter Steinberger
64016589b9 refactor: remove redundant irc setup conversions 2026-04-10 22:19:45 +01:00
Peter Steinberger
691a758e65 docs(changelog): add launchd stop lifecycle note (#64447) (thanks @ngutman) 2026-04-10 22:19:37 +01:00
Peter Steinberger
f3c143f0cd fix(daemon): honor launchd running state without pid 2026-04-10 22:19:37 +01:00
Peter Steinberger
1f80ebf643 docs(daemon): clarify launchd lifecycle behavior 2026-04-10 22:19:37 +01:00
Peter Steinberger
8c6d231dba fix(daemon): sanitize launchd handoff label errors 2026-04-10 22:19:37 +01:00
Nimrod Gutman
4d2fdb9f71 test(daemon): cover launchd compatibility scenarios 2026-04-10 22:19:37 +01:00
Nimrod Gutman
eebad7a372 refactor(daemon): simplify launchd stop lifecycle 2026-04-10 22:19:37 +01:00
Nimrod Gutman
affffddf04 fix(daemon): keep launchd enable scoped to owned stops 2026-04-10 22:19:37 +01:00
Nimrod Gutman
c0ddcf6630 fix(daemon): confirm launchd stop state before success 2026-04-10 22:19:37 +01:00
Nimrod Gutman
23d9a100c4 fix(daemon): keep launchd stop persistent without reinstall 2026-04-10 22:19:37 +01:00
Peter Steinberger
31a0b7bd42 feat: add Codex app-server controls 2026-04-10 22:19:00 +01:00
Peter Steinberger
0f0891656b fix: resolve latest ci type failures 2026-04-10 22:16:40 +01:00
Tak Hoffman
fab5277191 config: sync embedded harness schema labels 2026-04-10 16:10:34 -05:00
Eva H
3b13986214 fix: prevent fallback persistence from clobbering user /models picks (#64471)
Merged via squash.

Prepared head SHA: b0a6add41f
Co-authored-by: hoyyeva <63033505+hoyyeva@users.noreply.github.com>
Co-authored-by: BruceMacD <5853428+BruceMacD@users.noreply.github.com>
Reviewed-by: @BruceMacD
2026-04-10 14:05:07 -07:00
Peter Steinberger
a736b6eede test: remove redundant subagent allowlist conversions 2026-04-10 22:04:06 +01:00
Peter Steinberger
1a83731ea1 fix: label embedded harness config 2026-04-10 22:03:47 +01:00
EronFan
5e2136c6ae fix: include memory plugins in gateway startup (openclaw#64423)
Verified:
- pnpm build
- pnpm check
- pnpm test -- src/plugins/channel-plugin-ids.test.ts

Co-authored-by: EronFan <50734013+EronFan@users.noreply.github.com>
2026-04-10 16:02:44 -05:00
Peter Steinberger
241c63c7e0 refactor: remove redundant tool handler conversions 2026-04-10 22:01:48 +01:00
Peter Steinberger
a8bb0ab255 refactor: remove redundant model selection conversions 2026-04-10 22:00:02 +01:00
Tak Hoffman
afff0716f7 ci: shard checks-node-test by vitest suite 2026-04-10 15:59:41 -05:00
Davanum Srinivas
fbf11ebdb7 fix(sandbox): enforce CDP source-range restriction by default (#61404)
* fix(sandbox): enforce CDP source-range restriction by default

Auto-derive CDP_SOURCE_RANGE from Docker network gateway IP when not
explicitly configured. The entrypoint script refuses to start the socat
CDP relay without a source range (fail-closed).

- readDockerNetworkGateway: use Go template println, filter <no value>
  sentinel, prefer IPv4 gateway on dual-stack networks
- Reject IPv6-only gateways for auto-derivation (relay binds IPv4)
- Remove stale browser_cdp_bridge_unrestricted audit check (runtime
  auto-derives range for all bridge-like networks)
- Bump SANDBOX_BROWSER_SECURITY_HASH_EPOCH to force container recreation

* chore(changelog): add sandbox CDP source-range entry

* fix(sandbox): gate CDP source-range derivation to bridge-style networks

Only auto-derive OPENCLAW_BROWSER_CDP_SOURCE_RANGE from the Docker
gateway IP for bridge networks (or when driver is unknown). Non-bridge
drivers (macvlan, ipvlan, overlay) may route traffic from different
source IPs, so they require explicit cdpSourceRange config.

Adds readDockerNetworkDriver helper and a regression test for macvlan.

---------

Co-authored-by: Devin Robison <drobison@nvidia.com>
2026-04-10 14:59:25 -06:00
Peter Steinberger
67ae576b9e test: remove redundant launchd conversions 2026-04-10 21:58:40 +01:00
Peter Steinberger
fc50e23262 refactor: remove redundant model picker conversions 2026-04-10 21:57:01 +01:00
Peter Steinberger
fdaebf587c test: remove redundant phone control conversions 2026-04-10 21:55:28 +01:00
Peter Steinberger
9470b616c9 refactor: remove redundant camera CLI conversions 2026-04-10 21:53:47 +01:00
Peter Steinberger
7ccf4b7d02 refactor: remove redundant twitch setup conversions 2026-04-10 21:51:36 +01:00
Peter Steinberger
506f564fb9 refactor: remove redundant telegram conversions 2026-04-10 21:49:54 +01:00
Peter Steinberger
405a920862 refactor: remove redundant browser helper conversions 2026-04-10 21:48:38 +01:00
Peter Steinberger
20849e7196 refactor: remove redundant browser session conversions 2026-04-10 21:46:52 +01:00
Peter Steinberger
3475404c7e refactor: remove redundant browser state conversions 2026-04-10 21:46:00 +01:00
Peter Steinberger
c66afe472a docs: add codex harness setup guide 2026-04-10 21:45:32 +01:00
Peter Steinberger
b76f218c53 refactor: remove redundant browser screenshot conversions 2026-04-10 21:44:53 +01:00
Peter Steinberger
e892def77c chore: bump basic-ftp override 2026-04-10 21:44:16 +01:00
Peter Steinberger
1560da7be2 refactor: remove redundant browser cdp conversions 2026-04-10 21:43:34 +01:00
Peter Steinberger
b8554128b4 refactor: remove redundant model auth conversions 2026-04-10 21:42:10 +01:00
Peter Steinberger
972ed139a7 fix: make docs anchor audit use Mintlify CLI 2026-04-10 21:39:52 +01:00
Peter Steinberger
b0a39f4112 test: remove redundant matrix conversions 2026-04-10 21:34:41 +01:00
Tak Hoffman
71c4900051 test: harden telegram reply media transport stub 2026-04-10 15:31:55 -05:00
Peter Steinberger
75823947ae test: remove redundant loader message conversions 2026-04-10 21:30:48 +01:00
Peter Steinberger
cb3fbe7e50 refactor: remove redundant session patch conversions 2026-04-10 21:29:27 +01:00
Peter Steinberger
277028f1f5 test: remove redundant doctor string conversions 2026-04-10 21:27:33 +01:00
Peter Steinberger
c16b1b7433 docs: document harness fallback policy 2026-04-10 21:27:26 +01:00
Peter Steinberger
d236cb4680 chore: enable redundant type constituent checks 2026-04-10 21:23:40 +01:00
Peter Steinberger
6783bef7ed ci: refresh browser raw fetch guard 2026-04-10 21:22:16 +01:00
Peter Steinberger
bce0e5228a fix(codex): satisfy approval bridge lint 2026-04-10 21:22:16 +01:00
Peter Steinberger
8bc157c304 fix: prefer manifest evidence in install scanner 2026-04-10 21:22:16 +01:00
Peter Steinberger
ba55a81a32 fix: close landing test gaps 2026-04-10 21:22:16 +01:00
Peter Steinberger
b174d8aed4 build: refresh pi-ai lockfile snapshot 2026-04-10 21:22:16 +01:00
Peter Steinberger
d3cabde7b8 fix(browser): keep legacy ssrf alias raw-config only 2026-04-10 21:22:16 +01:00
Peter Steinberger
2bd56b8c38 build: refresh Codex harness lockfile 2026-04-10 21:22:16 +01:00
Peter Steinberger
c9067b6520 fix: preserve scoped plugin symlink installs 2026-04-10 21:22:16 +01:00
Peter Steinberger
3198c10fba fix: stabilize Codex harness landing checks 2026-04-10 21:22:16 +01:00
Peter Steinberger
d5698038d7 fix(codex): keep app-server inside extension src 2026-04-10 21:22:16 +01:00
Peter Steinberger
dbca237c77 docs: note Codex harness PR in changelog 2026-04-10 21:22:16 +01:00
Peter Steinberger
2d80bbc43d feat(agents): allow disabling PI harness fallback 2026-04-10 21:22:16 +01:00
Peter Steinberger
6e4d78ce80 fix(codex): require supported app-server version 2026-04-10 21:22:16 +01:00
Peter Steinberger
cb19451132 refactor: drop legacy Codex approval support 2026-04-10 21:22:16 +01:00
Peter Steinberger
84098a2267 fix: keep Codex harness opt-in by default 2026-04-10 21:22:16 +01:00
Peter Steinberger
106256d896 fix: address Codex harness review regressions 2026-04-10 21:22:16 +01:00
Peter Steinberger
b79f9f965e fix: address Codex harness review issues 2026-04-10 21:22:16 +01:00
Peter Steinberger
bfc0889776 docs: document Codex harness plugin workflow 2026-04-10 21:22:16 +01:00
Peter Steinberger
dd26e8c44d feat: add Codex app-server harness extension 2026-04-10 21:22:16 +01:00
Peter Steinberger
44ec4d05de feat: add pluggable agent harness registry 2026-04-10 21:22:16 +01:00
Peter Steinberger
fa97004ee1 test: remove duplicate gateway server coverage 2026-04-10 21:15:57 +01:00
Agustin Rivera
851294126b Redact Gmail watcher startup args from log tail (#62661)
* fix(logging): redact gmail watcher startup args

* fix(logging): normalize redaction formatting

* fix(logging): harden gmail watcher log redaction

* fix(logging): honor configured log tail redaction

* fix(logging): skip redact pattern resolution when off

* fix(logging): reuse compiled redact regexes

* chore: untrack USER.md (covered by .gitignore)

* chore: untrack USER.md (covered by .gitignore)

* fix(logging): avoid double-resolution in log-tail redaction

* fix(logging): redact across line boundaries for multiline patterns

* fix(logging): guard redactSensitiveLines against empty input

* chore(changelog): add Gmail watcher log redaction entry

---------

Co-authored-by: Devin Robison <drobison@nvidia.com>
2026-04-10 14:07:28 -06:00
Peter Steinberger
733137615f test: trim agents shard waits 2026-04-10 21:07:12 +01:00
Agustin Rivera
eab6fcedaa Ensure ACPX plugin-tools bridge honors before_tool_call (#63886)
* fix(acpx): honor tool hook on plugin bridge

Co-authored-by: smaeljaish771 <smaeljaish771@gmail.com>

* chore(changelog): add ACPX plugin-tools before_tool_call entry

---------

Co-authored-by: smaeljaish771 <smaeljaish771@gmail.com>
Co-authored-by: Devin Robison <drobison@nvidia.com>
2026-04-10 14:05:34 -06:00
Extra Small
abb4736267 fix(skills): add missing opening --- to taskflow and taskflow-inbox-triage SKILL.md frontmatter (openclaw#64469)
Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test src/agents/skills.bundled-frontmatter.test.ts

Co-authored-by: extrasmall0 <"258180677"+extrasmall0@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
2026-04-10 14:59:55 -05:00
Peter Steinberger
0ebeee8b0d chore: enable consistent-return 2026-04-10 20:56:43 +01:00
Peter Steinberger
bc27278d6d test: fix msteams thread parent fixture 2026-04-10 20:50:44 +01:00
joshavant
b6927d93ba IRP refinement
Signed-off-by: joshavant <830519+joshavant@users.noreply.github.com>
2026-04-10 14:49:49 -05:00
Peter Steinberger
d015986265 fix: preserve browser cdp ssrf policy 2026-04-10 20:45:45 +01:00
sudie-codes
784318799b fix(msteams): handle fileConsent/invoke callback for bot-to-user file upload (#55386) (#64087)
* fix(msteams): update FileConsentCard after user accepts upload

- Adds consentCardActivityId to PendingUpload so the consent card
  activity can be replaced in-place after upload succeeds
- Uses context.updateActivity() to replace the FileConsentCard with
  the file info card; falls back to sendActivity if update fails
- Adds updateActivity to MSTeamsTurnContext type
- Fixes timer leak in pending-uploads: clears TTL setTimeout on
  explicit removal and on clearPendingUploads()
- Adds pending-uploads.test.ts covering all new timer/cleanup paths

* msteams: wire consentCardActivityId from send response + add happy-path updateActivity test

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(msteams): retry consent uploads end-to-end

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Brad Groux <3053586+BradGroux@users.noreply.github.com>
2026-04-10 14:42:54 -05:00
sudie-codes
99f76ec4c6 fix(msteams): keep streaming alive during long tool chains via typing indicator (#59731) (#64088)
* fix(msteams): keep streaming alive during long tool chains via periodic typing (#59731)

* test(msteams): align thread-session store mock with interface

* fix(msteams): treat failed streams as inactive

---------

Co-authored-by: Brad Groux <bradgroux@users.noreply.github.com>
Co-authored-by: Brad Groux <3053586+BradGroux@users.noreply.github.com>
2026-04-10 14:42:41 -05:00
sudie-codes
01ea7e4921 feat(msteams): auto-inject parent message context for thread replies (#54932) (#63945)
* feat(msteams): auto-inject parent message context for thread replies (#54932)

* msteams: use Promise.allSettled for thread context, remove no-op buildInjectedKey

* fix(msteams): gate thread parent context by visibility

---------

Co-authored-by: Brad Groux <3053586+BradGroux@users.noreply.github.com>
2026-04-10 14:42:02 -05:00
joshavant
4edf0bb750 Docs: add incident response plan 2026-04-10 14:41:00 -05:00
Peter Steinberger
8e9e584b1e fix: validate browser profile driver before cdp policy 2026-04-10 20:31:27 +01:00
Peter Steinberger
d2c0440fac ci: fix current main additional checks 2026-04-10 20:28:48 +01:00
Peter Steinberger
cc6c5f3edb style: simplify lint-safe test helpers 2026-04-10 20:20:33 +01:00
Agustin Rivera
121c452d66 fix(browser): tighten strict browser hostname navigation (#64367)
* fix(browser): tighten strict browser hostname navigation

* fix(browser): address review follow-ups

* chore(changelog): add strict browser hostname navigation entry

* fix(browser): remove stale state prop from SelectionDeps call site

The PR's SelectionDeps uses getSsrFPolicy instead of the full state
object; the state property was leftover from an earlier iteration.

---------

Co-authored-by: Devin Robison <drobison@nvidia.com>
2026-04-10 13:18:53 -06:00
Peter Steinberger
4164d6fc4c test: narrow auto-reply command imports 2026-04-10 20:16:54 +01:00
Peter Steinberger
5580d7e2b1 style: simplify mattermost reaction test url checks 2026-04-10 20:14:49 +01:00
Peter Steinberger
04c8026d03 chore: enable no-unnecessary-type-arguments 2026-04-10 20:14:49 +01:00
Peter Steinberger
2786ed0f67 chore: enable no-base-to-string 2026-04-10 20:14:49 +01:00
Peter Steinberger
dfe4c2d16d chore: enable no-floating-promises 2026-04-10 20:14:49 +01:00
Peter Steinberger
2940379361 chore: enable no-unnecessary-template-expression 2026-04-10 20:14:49 +01:00
Peter Steinberger
01113566fd chore: enable await-thenable 2026-04-10 20:14:49 +01:00
Peter Steinberger
cdb944ef0a chore: enable no-misused-spread 2026-04-10 20:14:49 +01:00
Peter Steinberger
fe05983d91 chore: enable no-unnecessary-type-assertion 2026-04-10 20:14:48 +01:00
Peter Steinberger
1088904a47 test: skip provider runtime hints in config test 2026-04-10 20:12:16 +01:00
Agustin Rivera
c949af9fab fix(media): honor sender policy for host media reads (#64459)
* fix(media): honor sender policy for host media reads

* fix(media): clarify host read group policy gating

* fix(media): forward sender identity for outbound reads

* fix(media): propagate non-id sender fields through outbound session for e164/username/name policy matching

* fix(media): preserve requester provider for host read policy

* fix(media): forward full sender identity through followup and core send paths

* fix(media): forward requester session/account context through core send fallback

* fix(media): preserve account policy fallback for requester-scoped host reads

* chore(changelog): add outbound media sender-policy entry

* fix(media): align test call shape with production — omit messageProvider when sessionKey is set

Addresses P2 review: production call sites pass messageProvider: undefined
when sessionKey is present; tests should mirror that so regressions in
the precedence order are caught.

---------

Co-authored-by: Devin Robison <drobison@nvidia.com>
2026-04-10 13:07:56 -06:00
Peter Steinberger
5df7771d0c test: keep browser subpath test import-only 2026-04-10 20:06:00 +01:00
Peter Steinberger
a96b97979d test: align browser subpath ssrf default 2026-04-10 20:03:28 +01:00
Peter Steinberger
8640b89158 test: trim provider contract slow paths 2026-04-10 20:00:48 +01:00
Agustin Rivera
e3a845bde5 Normalize agent hook system event trust handling (#64372)
* fix(hooks): sanitize agent hook system events

Co-authored-by: zsx <git@zsxsoft.com>

* chore(changelog): add agent hook trust normalization entry

---------

Co-authored-by: zsx <git@zsxsoft.com>
Co-authored-by: Devin Robison <drobison@nvidia.com>
2026-04-10 12:56:00 -06:00
Agustin Rivera
109267b82a Handle subframe document navigations in browser guards (#64371)
* fix(browser): guard subframe document navigations

Co-authored-by: zsx <git@zsxsoft.com>

* fix(browser): preserve quarantine on subframe blocks

* chore(changelog): add subframe SSRF guard entry

* fix(browser): fail closed when subframe frame resolution throws

isSubframeDocumentNavigationRequest now returns true (apply SSRF
check) instead of false (skip check) when request.frame() throws,
so transient renderer churn cannot bypass the subframe navigation
policy guard.

---------

Co-authored-by: zsx <git@zsxsoft.com>
Co-authored-by: Devin Robison <drobison@nvidia.com>
2026-04-10 12:51:23 -06:00
Peter Steinberger
b2df0ed4b7 fix: align browser ssrf policy typing 2026-04-10 19:49:46 +01:00
Peter Steinberger
abc499ec49 fix: preserve cdp guarded fetch dispatchers 2026-04-10 19:49:09 +01:00
Peter Steinberger
81ead0bc5b fix(browser): keep legacy ssrf alias internal 2026-04-10 19:46:37 +01:00
Peter Steinberger
a6edccad3d test: align plugin install denylist expectations 2026-04-10 19:42:38 +01:00
Agustin Rivera
905f19230a Align external marker span mapping (#63885)
* fix(markers): align external marker spans

* fix(browser): ssrfPolicy defaults fail-closed for unconfigured installs (GHSA-53vx-pmqw-863c)

* fix(browser): enforce strict default SSRF policy

* chore(changelog): add browser SSRF default + marker alignment entry

---------

Co-authored-by: Devin Robison <drobison@nvidia.com>
2026-04-10 12:35:20 -06:00
Agustin Rivera
daeb74920d fix(browser): guard existing-session navigation (#64370)
* fix(browser): guard existing-session navigation

Co-authored-by: zsx <git@zsxsoft.com>

* fix(browser): tighten interaction navigation guard

* fix(browser): tighten existing-session nav guard

* fix(browser): fail closed on unstable existing-session probes

* fix(browser): add follow-up probe for late URL transitions in existing-session nav guard

* fix(browser): keep probing through full navigation window

* fix(browser): reset stability flag on probe error in existing-session nav guard

* chore(changelog): add Chrome MCP interaction SSRF guard entry

---------

Co-authored-by: zsx <git@zsxsoft.com>
Co-authored-by: Devin Robison <drobison@nvidia.com>
2026-04-10 12:31:41 -06:00
Peter Steinberger
a52d38275e test: remove duplicate agent reset e2e 2026-04-10 19:30:24 +01:00
Peter Steinberger
cbce38d78c style: format post-rebase files 2026-04-10 19:28:42 +01:00
Peter Steinberger
59925c1a74 chore: update dependencies and oxc tooling 2026-04-10 19:28:42 +01:00
Peter Steinberger
2fc3223ed4 ci: repair plugin boundary artifact freshness 2026-04-10 19:25:32 +01:00
Peter Steinberger
925a499d84 ci: fix additional guard failures 2026-04-10 19:23:10 +01:00
Peter Steinberger
e7db987ce6 test: trim heavy imports and harden ci checks 2026-04-10 19:23:10 +01:00
Peter Steinberger
d9b33205dc test: move disabled compat routes to http harness 2026-04-10 19:21:55 +01:00
Peter Steinberger
15c6748c01 test: stabilize vitest full-suite runner 2026-04-10 19:17:39 +01:00
Peter Steinberger
f6ed276f51 style: apply updated formatter output 2026-04-10 19:17:39 +01:00
Peter Steinberger
8127c6cc15 build(deps): update workspace dependencies 2026-04-10 19:17:39 +01:00
Peter Steinberger
ea8d0833c3 test: trim gateway auth slow paths 2026-04-10 19:16:55 +01:00
Peter Steinberger
56468cdb06 fix: align plugin install denylist scan tests 2026-04-10 18:57:52 +01:00
Peter Steinberger
420e092d90 test: remove duplicate matrix approval fallback case 2026-04-10 18:50:40 +01:00
Gustavo Madeira Santana
457a33646c docs(matrix): track spec support gaps 2026-04-10 13:48:15 -04:00
Peter Steinberger
d522dc637e test: trim embedded agents slow paths 2026-04-10 18:33:03 +01:00
Michael Appel
e0b8ddc1a5 fix(browser): apply three-phase interaction navigation guard to pressKey and type(submit) [AI-assisted] (#63889)
* fix: address issue

* chore(changelog): add pressKey/type SSRF guard entry

---------

Co-authored-by: Devin Robison <drobison@nvidia.com>
2026-04-10 11:27:53 -06:00
Michael Appel
9f97ad857a fix(security): pin axios to 1.15.0 and add dependency denylist for plugin installs [AI-assisted] (#63891)
* fix: address issue

* fix: address review feedback

* fix: address PR review feedback

* fix: address PR review feedback

* fix: address PR review feedback

* fix: address PR review feedback

* fix: address PR review feedback

* Plugins: fix install security CI regressions

* Plugins: make manifest traversal linear

* Plugins: bound manifest security traversal

* Plugins: block denied node_modules package dirs

* Plugins: match node_modules case-insensitively

* Plugins: block denied package symlink paths

* Tests: normalize blocked symlink assertion

* Plugins: fail closed on unreadable denied paths

* Plugins: block denied node_modules file aliases

* Plugins: inspect node_modules symlink targets

* Plugins: preserve symlink target package paths

* fix: address PR review feedback

* chore(changelog): add axios pin and dependency denylist entry

---------

Co-authored-by: Devin Robison <drobison@nvidia.com>
2026-04-10 11:20:05 -06:00
Gustavo Madeira Santana
9b44929f28 fix(gateway): preserve restart sentinel account routing 2026-04-10 13:16:19 -04:00
Peter Steinberger
527601d7a5 fix: align channel owner context test types 2026-04-10 18:14:14 +01:00
sudie-codes
2b5b58194b fix(msteams): include tenantId and aadObjectId on proactive sends (#58774) (#63949)
* fix(msteams): capture and forward tenantId/aadObjectId on proactive sends (#58774)

* msteams: preserve tenantId/aadObjectId on sparse merges, thread recipientId on proactive sends
2026-04-10 12:09:14 -05:00
Michael Appel
19a2e9ddb5 fix(infra): extend exec completion detection to cover local background exec formats [AI-assisted] (#64376)
* fix: address issue

* fix: address PR review feedback

* fix: address PR review feedback

* fix: address PR review feedback

* chore(changelog): add exec completion owner-downgrade entry

---------

Co-authored-by: Devin Robison <drobison@nvidia.com>
2026-04-10 11:07:14 -06:00
Peter Steinberger
e1a2a26ec9 test: isolate agent runtime mocks 2026-04-10 18:06:49 +01:00
Peter Steinberger
cbc4447d6b test: narrow doctor config matrix helper import 2026-04-10 18:05:02 +01:00
Agustin Rivera
8dfbf3268b fix(browser): gate sandbox noVNC helper auth
Require bridge auth before /sandbox/novnc token redemption and keep the noVNC observer URL out of model-visible prompt context.

Local verification:
- pnpm test extensions/browser/src/browser/bridge-server.auth.test.ts src/agents/sanitize-for-prompt.test.ts src/agents/pi-embedded-runner.buildembeddedsandboxinfo.test.ts

Note: pnpm check currently fails on latest main in unrelated files (src/agents/tools/message-tool.ts and src/gateway/mcp-http.test.ts), outside this PR diff.

Thanks @eleqtrizit.

Co-authored-by: eleqtrizit <31522568+eleqtrizit@users.noreply.github.com>
2026-04-10 18:01:26 +01:00
Michael Appel
979c6f09d6 fix: include image param in sandbox media normalization [AI-assisted] (#64377)
* fix: address issue

* chore(changelog): add Discord event image sandbox entry

---------

Co-authored-by: Devin Robison <drobison@nvidia.com>
2026-04-10 11:01:04 -06:00
Peter Steinberger
56d3f97e23 test: use lightweight channel status stubs 2026-04-10 18:00:45 +01:00
Peter Steinberger
710a19dd86 fix: repair latest main type drift 2026-04-10 18:00:45 +01:00
Michael Appel
afadb7dae6 fix(voice-call): reject oversized realtime WebSocket frames
Reject realtime voice WebSocket frames above 256 KB before JSON parsing or bridge setup, and absorb ws error events so oversized frames close the connection instead of crashing the gateway.

Local verification:
- pnpm test extensions/voice-call/src/webhook/realtime-handler.test.ts
- pnpm check

Thanks @mmaps.

Co-authored-by: mmaps <3399869+mmaps@users.noreply.github.com>
2026-04-10 17:58:44 +01:00
Peter Steinberger
b9981c8ee8 test: inject setup command side effects 2026-04-10 17:57:15 +01:00
Agustin Rivera
fe0f686c92 Gate Matrix profile updates for non-owner message tool runs (#62662)
Merged via squash.

Prepared head SHA: 602b16a676
Co-authored-by: eleqtrizit <31522568+eleqtrizit@users.noreply.github.com>
Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com>
Reviewed-by: @gumadeiras
2026-04-10 12:56:17 -04:00
Peter Steinberger
1c1fe8a405 test: remove duplicate workspace auth choice e2e 2026-04-10 17:52:44 +01:00
Peter Steinberger
9031a9b2cc test: narrow legacy doctor migration hot paths 2026-04-10 17:51:15 +01:00
Menglin Li
36c3a54b51 fix(gateway): plug long-running memory leaks
Prune stale gateway control-plane rate-limit buckets, bound transcript-session lookup caching, clear agent event sequence state with run contexts, and clear node wake/nudge state on disconnect.\n\nVerified locally after rebasing onto main:\n\n- pnpm test src/gateway/control-plane-rate-limit.test.ts src/gateway/session-transcript-key.test.ts src/infra/agent-events.test.ts src/gateway/server-methods/nodes.invoke-wake.test.ts\n- pnpm check\n\nCo-authored-by: lml2468 <39320777+lml2468@users.noreply.github.com>
2026-04-10 17:45:12 +01:00
Devin Robison
54ae138db7 fix: the cron isolated agent in openclaw unconditiona (#383) (#63878) 2026-04-10 10:44:22 -06:00
Gustavo Madeira Santana
9c44f10026 fix: preserve canonical restart sentinel routes (#64391)
Merged via squash.

Prepared head SHA: 0183c1782f
Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com>
Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com>
Reviewed-by: @gumadeiras
2026-04-10 12:44:07 -04:00
Devin Robison
dffad08529 fix: a sandboxed agent can request host node in an ex (#384) (#63880) 2026-04-10 10:40:27 -06:00
Peter Steinberger
777c6f7580 refactor: split manifest command alias helpers 2026-04-10 17:37:31 +01:00
Peter Steinberger
5f3356a746 refactor: split session store key helper 2026-04-10 17:37:25 +01:00
EVA
47c0a5135a fix: dedupe delivered subagent completion announces (#61525) (thanks @100yenadmin)
* fix(subagents): dedupe delivered completion announces

* refactor(subagents): distill cleanup delivery status writes

* fix: dedupe delivered subagent completion announces (#61525) (thanks @100yenadmin)

---------

Co-authored-by: Eva <eva@100yen.org>
Co-authored-by: Ayaan Zaidi <hi@obviy.us>
2026-04-10 22:06:46 +05:30
Ayaan Zaidi
8755d2d3da fix: bound telegram qa api requests 2026-04-10 22:06:38 +05:30
Ayaan Zaidi
1512f9188d fix: reject unknown telegram qa scenarios 2026-04-10 22:06:38 +05:30
Peter Steinberger
81ae34c434 test: keep browser selection cdp guard profile-aware 2026-04-10 17:35:54 +01:00
Peter Steinberger
c077af987f perf: add narrow inbound roots sdk surface 2026-04-10 17:34:41 +01:00
Peter Steinberger
bac98d4218 test: reduce media contract import cost 2026-04-10 17:31:08 +01:00
Gustavo Madeira Santana
5d2225212d fix(matrix): preserve ACP thread binding targets (#64343)
Merged via squash.

Prepared head SHA: def7dcda96
Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com>
Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com>
Reviewed-by: @gumadeiras
2026-04-10 12:30:08 -04:00
Ayaan Zaidi
2f84e73c18 fix(agents): always emit terminal lifecycle events 2026-04-10 21:58:20 +05:30
Peter Steinberger
58ee5e48d1 test: fix browser and matrix verification 2026-04-10 17:25:04 +01:00
Peter Steinberger
d5df4cd4e5 test: add Anthropic Opus QA smokes 2026-04-10 17:24:54 +01:00
Ayaan Zaidi
5df09052e0 fix: add Telegram QA E2E lane (#64303) 2026-04-10 21:53:31 +05:30
Ayaan Zaidi
9d3583bc2f fix(qa-lab): tighten telegram canary matching 2026-04-10 21:53:31 +05:30
Ayaan Zaidi
ecb3e0a62d fix(qa-lab): harden telegram qa artifacts 2026-04-10 21:53:31 +05:30
Ayaan Zaidi
d69cc5da5c fix(qa-lab): address remaining review comments 2026-04-10 21:53:31 +05:30
Ayaan Zaidi
2aaf5a3baa fix(qa-lab): address telegram qa review comments 2026-04-10 21:53:31 +05:30
Ayaan Zaidi
7348c3193d test(telegram): cover threaded qa replies 2026-04-10 21:53:31 +05:30
Ayaan Zaidi
88a7970f84 fix(telegram): thread native command replies 2026-04-10 21:53:31 +05:30
Ayaan Zaidi
0ff03a74a8 fix(qa-lab): trust telegram canary send result 2026-04-10 21:53:31 +05:30
Ayaan Zaidi
653a110ef6 fix(qa-lab): refine telegram canary output 2026-04-10 21:53:31 +05:30
Ayaan Zaidi
5c7a232ebc fix(qa-lab): improve telegram canary diagnostics 2026-04-10 21:53:31 +05:30
Ayaan Zaidi
e093cb6c93 feat(qa-lab): add telegram live qa lane 2026-04-10 21:53:31 +05:30
Peter Steinberger
fa2ee2af85 test: enforce browser cdp policy before playwright 2026-04-10 17:21:19 +01:00
Gustavo Madeira Santana
0dd8ce72a2 Matrix: consolidate migration status routing (#64373)
Merged via squash.

Prepared head SHA: dfe29e36bb
Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com>
Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com>
Reviewed-by: @gumadeiras
2026-04-10 12:20:13 -04:00
Lellansin Huang
2ccd1839f2 fix: return real usage for OpenAI-compatible chat completions (#62986) (thanks @Lellansin)
* Gateway: fix chat completions usage compatibility

* Gateway: clarify usage-gated stream wait

* Gateway: preserve aggregate usage totals

* Agents: clamp usage components before total

* fix(gateway): bound usage stream finalization

* fix: add OpenAI compat usage changelog (#62986) (thanks @Lellansin)

* fix(agents): emit lifecycle terminal events after flush

---------

Co-authored-by: Ayaan Zaidi <hi@obviy.us>
2026-04-10 21:46:24 +05:30
Peter Steinberger
f64c84ab6b test: narrow command doctor helper coverage 2026-04-10 17:11:57 +01:00
Peter Steinberger
253982d05f test: keep command setup hook tests narrow 2026-04-10 17:08:38 +01:00
Peter Steinberger
be9bef32df perf: cache local tsgo checks 2026-04-10 17:06:28 +01:00
Peter Steinberger
aaf38acc07 test: keep legacy migration tests core-only 2026-04-10 17:03:38 +01:00
Devin Robison
48c0347921 fix: in the browser extension s tabs action route the (#310) (#63332)
* fix: in the browser extension s tabs action route the (#310)

* fix(browser): fail closed for tab close and CDP redirects

* fix(browser): sanitize tab SSRF policy errors

* chore(changelog): add browser tabs action policy enforcement entry

* fix(browser): differentiate CDP endpoint blocks from navigation blocks in error mapping

Split SsrFBlockedError handling so navigation-target policy failures
(from assertBrowserNavigationAllowed) surface as 'browser navigation
blocked by policy' while CDP endpoint policy failures (from
assertCdpEndpointAllowed) surface as 'browser endpoint blocked by
policy'. Both stay sanitized so raw policy details still do not leak
to callers.

- Add BrowserCdpEndpointBlockedError (extends BrowserError, 400).
- assertCdpEndpointAllowed now catches SsrFBlockedError and rethrows
  as BrowserCdpEndpointBlockedError so the route error mapping can
  route endpoint vs navigation failures to the right user-facing
  message without inspecting stack strings.
- toBrowserErrorResponse: raw SsrFBlockedError now maps to the
  navigation-blocked message; endpoint-blocked errors are handled by
  the existing BrowserError branch and keep the endpoint-blocked
  message.
- Update tests that exercised the endpoint path to assert the new
  error class instead of the raw SSRF message.

* fix(browser): move SSRF check after cache hit and thread ssrfPolicy through tryTerminateExecutionViaCdp

- connectBrowser: move assertCdpEndpointAllowed after cache lookup so
  transient DNS failures don't break active cached sessions.
- tryTerminateExecutionViaCdp: accept ssrfPolicy and run
  assertCdpEndpointAllowed before HTTP/WS I/O so the terminate path
  doesn't bypass SSRF policy enforcement.
- forceDisconnectPlaywrightForTarget: thread ssrfPolicy through to
  tryTerminateExecutionViaCdp.

* fix(browser): drop redundant pre-Playwright SSRF checks so cached sessions survive DNS blips

Remove assertProfileCdpEndpointAllowed() calls that precede
Playwright-backed tab operations (listPagesViaPlaywright,
focusPageByTargetIdViaPlaywright, closePageByTargetIdViaPlaywright)
since connectBrowser already runs the check on cache miss.

Keep the checks before raw CDP HTTP calls (fetchJson/fetchOk for
/json/list, /json/activate, /json/close) where there is no
connection cache.

Add comment on fetchCdpChecked explaining why redirect blocking
covers all CDP HTTP paths, not just probes.
2026-04-10 10:03:16 -06:00
Peter Steinberger
74f25c0e88 test: narrow doctor command warning coverage 2026-04-10 16:49:55 +01:00
Peter Steinberger
eddbc04f4b test: narrow command runtime config coverage 2026-04-10 16:46:09 +01:00
Peter Steinberger
8a5b7cf573 test: inject provider auth command fixtures 2026-04-10 16:41:10 +01:00
Peter Steinberger
d6ece7fb89 test: inject cli backend fixtures 2026-04-10 16:33:37 +01:00
Chunyue Wang
574bab80e5 fix(exec): disable onUpdate after run settlement to prevent gateway crash (#62821)
Squash-merged via maintainer prepare workflow.

Prepared head SHA: 431381ae1e

Co-authored-by: openperf <16864032@qq.com>
2026-04-10 23:33:25 +08:00
Peter Steinberger
eec19d5929 test: relax sandbox registry lock wait 2026-04-10 16:24:32 +01:00
neo1027144
2cf9ed782d fix(daemon): prevent systemd restart storm on config validation failure
Exit gateway configuration failures with EX_CONFIG and teach generated systemd units not to restart on that exit status.\n\nCo-authored-by: neo1027144-creator <neo1027144-creator@users.noreply.github.com>
2026-04-10 16:23:46 +01:00
Peter Steinberger
fc5a231e95 test: spread deterministic port blocks by process 2026-04-10 16:18:28 +01:00
Peter Steinberger
1628217114 test: avoid real signal exit in lock tests 2026-04-10 16:09:46 +01:00
Peter Steinberger
1000a85fb6 test: mock provider runtime in pi runner tests 2026-04-10 16:07:09 +01:00
Peter Steinberger
5c67fa7cc0 test: avoid plugin fallback in agents tests 2026-04-10 16:00:08 +01:00
evandance
4fb393980c feat(feishu): standardize request UA and register bot as AI agent (#63835)
- Set User-Agent to openclaw-feishu-builtin/{version}/{platform} for all
  Feishu API requests to comply with OAPI best practices
- Switch health-check probe to POST /bot/v1/openclaw_bot/ping to register
  the app as an AI agent (智能体) on the Feishu platform
- Update probe response parsing for new pingBotInfo response shape
2026-04-10 22:57:38 +08:00
Peter Steinberger
407da8edfc perf: trim tsgo input graph 2026-04-10 15:56:56 +01:00
Peter Steinberger
3522224b25 test: trim provider runtime from agents hotspots 2026-04-10 15:56:28 +01:00
Peter Steinberger
e9fb4c7f93 perf: skip tsgo declaration transforms 2026-04-10 15:52:07 +01:00
Peter Steinberger
56fc20fb7c test: align Vitest config path assertions 2026-04-10 15:49:37 +01:00
Nimrod Gutman
4b4ec4dbc2 fix(feishu): route /btw through out-of-band lanes (#64324)
* fix(feishu): route /btw through out-of-band lanes

* fix(feishu): bound btw out-of-band lanes

* fix: route feishu btw out-of-band (#64324) (thanks @ngutman)
2026-04-10 17:48:15 +03:00
Peter Steinberger
a1262e15a3 perf: reduce heartbeat prompt tokens 2026-04-10 15:38:39 +01:00
Peter Steinberger
3c0e5f0ea5 test: restore moved Vitest config paths 2026-04-10 15:38:14 +01:00
Peter Steinberger
a48eb84181 test: narrow nodes workspace guard imports 2026-04-10 15:37:48 +01:00
Peter Steinberger
1714e7bbe5 docs: credit Qwen tool-call text fix (#64214) (thanks @MoerAI) 2026-04-10 15:36:25 +01:00
MoerAI
a2fb063370 fix(text): strip Qwen-style XML tool call payloads from visible text (#63999) 2026-04-10 15:36:25 +01:00
Peter Steinberger
9fd08f9d0f refactor: remove type-only import cycles 2026-04-10 15:14:27 +01:00
Peter Steinberger
fe1fd055d5 fix: sanitize Gemini tool schema required fields (#64284) (thanks @xxxxxmax) 2026-04-10 15:01:37 +01:00
max
0dbcf81b34 fix: sanitize required fields in tool schemas for Gemini compatibility 2026-04-10 15:01:37 +01:00
Peter Steinberger
f621fb4aba refactor: centralize speech voice-note channel routing 2026-04-10 15:01:19 +01:00
Peter Steinberger
77bdf2f44d test: remove import-heavy files from unit-fast 2026-04-10 14:57:24 +01:00
Peter Steinberger
07e7222e28 test: split Claude CLI QA auth modes 2026-04-10 14:56:36 +01:00
Peter Steinberger
ddfd6c3401 fix: guard QA lab gateway health fetch (#64242) 2026-04-10 14:56:12 +01:00
Peter Steinberger
09a8e0f289 fix: keep bundled CLI backend fallback stable (#64242) 2026-04-10 14:56:12 +01:00
Peter Steinberger
beaff3c553 fix: clarify plugin command alias diagnostics (#64242) (thanks @feiskyer) 2026-04-10 14:56:12 +01:00
Pengfei Ni
8cb45c051e fix(config): give actionable guidance when command names are used in plugins.allow (#64191)
When users put a runtime command name like "dreaming" into `plugins.allow`,
validation now explains that it is a command provided by a specific plugin
(e.g. "memory-core") and suggests using the plugin id instead, rather than
the generic "plugin not found" warning that previously created a circular
trap with the CLI error message.

Similarly, running `openclaw dreaming` from the CLI now explains that
`/dreaming` is a runtime slash command (not a CLI command) and points users
to `openclaw memory` for CLI operations or `/dreaming` in a chat session.

Fixes two related UX problems:
1. `plugins.allow: ["dreaming"]` → validation warned "plugin not found"
2. `openclaw dreaming status` → CLI said "add dreaming to plugins.allow"
   (which then triggered problem 1)

Root cause: "dreaming" is a slash command registered by the memory-core
plugin via `api.registerCommand()`, not a standalone plugin or CLI command.
2026-04-10 14:56:12 +01:00
Alvin
65ef70b070 feat(matrix): add MSC4357 live streaming markers to draft-stream edits (#63513)
Merged via squash.

Prepared head SHA: 87a866a238
Co-authored-by: TigerInYourDream <48358093+TigerInYourDream@users.noreply.github.com>
Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com>
Reviewed-by: @gumadeiras
2026-04-10 09:47:43 -04:00
Peter Steinberger
3631ec1f54 fix: route Discord auto TTS as voice notes (#64096) (thanks @LiuHuaize) 2026-04-10 14:37:25 +01:00
liuhuaize
271d3b3bdb speech-core: fix TTS regression test typing 2026-04-10 14:37:25 +01:00
liuhuaize
b3d7fd166a speech-core: route Discord auto TTS as voice notes 2026-04-10 14:37:25 +01:00
Peter Steinberger
6286810388 test: add Claude CLI provider QA scenario 2026-04-10 14:23:19 +01:00
Peter Steinberger
1b1853f0cc test: restore moved Vitest config discovery 2026-04-10 14:20:39 +01:00
Peter Steinberger
d2b9d918af docs(changelog): thank @hanamizuki for #64172 2026-04-10 14:07:22 +01:00
Hana Chang
8c876e311f test(discord): prefer claude-sonnet-4-6 in thread-title fixture
Follow repo testing guideline to prefer sonnet-4.6 for Anthropic model
constants in tests (per CLAUDE.md, flagged by Greptile review on #64172).
2026-04-10 14:07:22 +01:00
Hana Chang
537479f5b0 fix(discord): raise thread title max tokens for reasoning models
When the simple-completion model selected for thread-title generation is a
reasoning model (e.g. MiniMax M2, Claude thinking models, OpenAI o-series),
the 24-token output budget is entirely consumed by the internal thinking
block before any user-visible text is emitted. extractAssistantText then
returns an empty string, generateThreadTitle returns null, and the
auto-thread rename is silently skipped while the feature appears to do
nothing.

Raise DISCORD_THREAD_TITLE_MAX_TOKENS to 512 so there is enough headroom
for a short thinking pass plus the 3-6 word title output. The generous
ceiling only matters when the provider actually reasons; non-reasoning
models still emit a short title and stop early at end-of-sequence.

Verified live against a MiniMax M2 reasoning model served through an
Anthropic-compatible API endpoint: before the fix, the rename never fired;
after the fix, the thread is renamed with a concise generated title.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-10 14:07:22 +01:00
ly85206559
13821fd54b fix(plugins): make service registration idempotent
Treat duplicate registerService calls from the same plugin id as idempotent so plugin snapshot and activation loads stop emitting spurious service already registered diagnostics.\n\nThanks @ly85206559.
2026-04-10 14:06:18 +01:00
Mariano
03e19c5436 fix(gateway): restore dreaming startup reconciliation (#64258)
* gateway: restore dreaming startup reconciliation

* gateway: harden dreaming startup reconciliation

---------

Co-authored-by: mbelinky <mbelinky@users.noreply.github.com>
2026-04-10 15:02:19 +02:00
Mariano
383ea34efe fix(reply): keep resolved secret config stable (#64249)
Merged via squash.

Prepared head SHA: 973f863d8c
Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com>
Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com>
Reviewed-by: @mbelinky
2026-04-10 14:56:30 +02:00
Nimrod Gutman
af9272606f docs(changelog): note control ui btw fixes (#64290) (thanks @ngutman) 2026-04-10 15:55:03 +03:00
Nimrod Gutman
96f388e35c fix(ui): clear btw card on slash reset 2026-04-10 15:55:03 +03:00
Nimrod Gutman
b3a9c95dde fix(ui): ignore detached btw terminal teardown 2026-04-10 15:55:03 +03:00
Nimrod Gutman
9e2adb3ea8 fix(ui): send btw immediately during active runs 2026-04-10 15:55:03 +03:00
Nimrod Gutman
f989927174 feat(ui): render btw side results in control ui 2026-04-10 15:55:03 +03:00
Ravish Gupta
790343c4b1 fix(heartbeat): widen empty-detection to skip API calls for comment-only HEARTBEAT.md (#61690) (#63434)
Merged via squash.

Prepared head SHA: 1ad16a1238
Co-authored-by: ravyg <1249023+ravyg@users.noreply.github.com>
Co-authored-by: hxy91819 <8814856+hxy91819@users.noreply.github.com>
Reviewed-by: @hxy91819
2026-04-10 20:53:23 +08:00
Nimrod Gutman
795cc7d9dc fix(auth): thread workspaceDir into /btw runtime auth 2026-04-10 15:50:50 +03:00
Nimrod Gutman
7a59e5548a fix(auth): apply copilot runtime auth to /btw 2026-04-10 15:50:50 +03:00
Peter Steinberger
3027efaf21 test: raise QA suite default concurrency 2026-04-10 13:45:57 +01:00
Peter Steinberger
4c14f55c62 test: parallelize QA suite scenarios 2026-04-10 13:45:57 +01:00
Peter Steinberger
886e01c27b ci: keep full-suite tests conservative 2026-04-10 13:45:18 +01:00
Peter Steinberger
89d7a24a35 fix(cli-runner): wire OpenClaw skills into Claude CLI
Co-authored-by: Omar López <zomars@me.com>
2026-04-10 13:45:02 +01:00
Peter Steinberger
d5afeae206 test: align shard path expectations 2026-04-10 13:44:51 +01:00
Peter Steinberger
2ccb5cff22 test: move Vitest configs under test 2026-04-10 13:44:51 +01:00
Peter Steinberger
64f2b20963 test: isolate sharding default env 2026-04-10 13:43:25 +01:00
Peter Steinberger
b64a03793c test: keep conservative full-suite shards aggregated 2026-04-10 13:36:48 +01:00
Peter Steinberger
2eb66a1ba9 fix: detect llama.cpp context overflow (#64196) (thanks @alexander-applyinnovations) 2026-04-10 13:30:33 +01:00
Alexander Bunn
57e6aeca84 fix(agents): detect llama.cpp slot overflow as context overflow
Auto-compaction never triggered for self-hosted llama.cpp HTTP servers
(used directly or behind an OpenAI-compatible shim configured with
`api: "openai-completions"`) because llama.cpp's native overflow wording
isn't covered by any existing pattern in `isContextOverflowError()` or
`matchesProviderContextOverflow()`.

When the prompt overshoots a slot's `--ctx-size`, llama.cpp returns:

  400 request (66202 tokens) exceeds the available context size (65536 tokens), try increasing it

That message uses "context size" rather than "context length", says
"request (N tokens)" instead of "input/prompt is too long", and the
status code is 400 (not 413), so it slips past every existing string
check and every regex in `PROVIDER_CONTEXT_OVERFLOW_PATTERNS`. The
generic candidate pre-check passes, but the concrete provider regexes
all miss, so the agent runner reports `surface_error reason=...` and
the user gets the raw upstream error instead of compaction + retry.

This commit adds a llama.cpp-shaped pattern next to the existing Bedrock
/ Vertex / Ollama / Cohere ones in
`PROVIDER_CONTEXT_OVERFLOW_PATTERNS`, plus four test cases (three
parameterised messages exercising the new regex directly, and one
end-to-end assertion that `isContextOverflowError()` now returns true
for the verbatim message produced by llama.cpp's slot manager).

The pattern is anchored on llama.cpp's stable slot-manager wording
(`(?:request|prompt) (N tokens) exceeds (the )?available context size`)
so it won't accidentally swallow unrelated provider errors.

Closes #64180

AI-assisted: drafted with Claude Code (Opus 4.6, 1M context).
Testing: targeted tests pass via `pnpm vitest run
src/agents/pi-embedded-helpers/provider-error-patterns.test.ts`
(26/26). Broader vitest run shows 2 unrelated failures in
`group-policy.fallback.contract.test.ts` that are not touched by this
change.
2026-04-10 13:30:33 +01:00
Peter Steinberger
12ae2fa408 ci: parallelize full-suite project shards 2026-04-10 13:23:03 +01:00
Peter Steinberger
66ac5194f7 test: honor low-worker full-suite gate 2026-04-10 13:10:04 +01:00
Nimrod Gutman
8fe74145c4 fix(btw): land side-question context hardening (#64225) (thanks @ngutman) 2026-04-10 15:03:51 +03:00
Nimrod Gutman
7bb98ea12f fix(btw): drop hidden reasoning from side-question context 2026-04-10 15:03:51 +03:00
Nimrod Gutman
9553b402ee fix(btw): strip embedded tool blocks from side-question context 2026-04-10 15:03:51 +03:00
Nimrod Gutman
cc5cb496ad fix(btw): strip replayed tool calls from side-question context 2026-04-10 15:03:51 +03:00
Peter Steinberger
2138273d63 test: run full suite shards in parallel locally 2026-04-10 12:58:29 +01:00
Peter Steinberger
9f864c9ade fix: guard browser control fetches 2026-04-10 12:46:26 +01:00
Peter Steinberger
bf40baaa4d fix(gateway): improve websocket auth logging 2026-04-10 12:39:08 +01:00
Peter Steinberger
d350280fc2 test: fix latest type and lazy cli gates 2026-04-10 12:37:01 +01:00
Peter Steinberger
2ad451e91f test: fix parallel full-suite exposed gates 2026-04-10 12:34:53 +01:00
Peter Steinberger
9248a44fc1 fix: restore rebased type gates 2026-04-10 12:24:50 +01:00
Peter Steinberger
7c7a63eab4 test(nostr): type mock profile response 2026-04-10 12:20:04 +01:00
Peter Steinberger
644105bea6 fix: restore latest main typecheck 2026-04-10 12:20:04 +01:00
Peter Steinberger
8e242622e1 fix: stabilize rebased test gates 2026-04-10 12:14:36 +01:00
Peter Steinberger
444cdd055d fix: stabilize main test gates 2026-04-10 12:14:36 +01:00
Peter Steinberger
ef1694575d fix: restore main type gates 2026-04-10 12:14:36 +01:00
Pavan Kumar Gondhi
6517c700de fix(nostr): require operator.admin scope for profile mutation routes [AI] (#63553)
* fix: address issue

* fix: address review feedback

* fix: address review feedback

* fix: finalize issue changes

* fix: address PR review feedback

* fix: address review-pr skill feedback

* fix: address PR review feedback

* fix: address review-pr skill feedback

* fix: address PR review feedback

* fix: address PR review feedback

* fix: address PR review feedback

* fix: address PR review feedback

* docs: add changelog entry for PR merge
2026-04-10 16:38:41 +05:30
Vincent Koc
0e54440ecc fix(cycles): remove browser cli and tlon runtime seams 2026-04-10 11:45:28 +01:00
Vincent Koc
dbe2a97e80 fix(cycles): remove qa-lab and ui runtime seams 2026-04-10 11:45:27 +01:00
Peter Steinberger
10b26ed2ec test: restore full gate stability 2026-04-10 11:36:41 +01:00
Nimrod Gutman
125db8038d docs(changelog): credit original btw fix author 2026-04-10 13:16:29 +03:00
Nimrod Gutman
35002cb6bb fix(btw): allow aws-sdk auth for bedrock side questions 2026-04-10 13:16:29 +03:00
Nimrod Gutman
90e784cab8 fix(btw): omit empty tool arrays for side questions (#64219) (thanks @ngutman) (#64219) 2026-04-10 13:12:38 +03:00
Mariano
46f8c4dfd5 fix(memory-core): harden request-scoped dreaming fallback (#64156)
* memory-core: harden request-scoped dreaming fallback

* memory-core: tighten request-scoped fallback classification
2026-04-10 12:11:57 +02:00
Vincent Koc
948909b3fb fix(protocol): regenerate chat event error kind 2026-04-10 11:01:55 +01:00
Peter Steinberger
0b0c062e97 fix: avoid Claude CLI subscription prompt classifier 2026-04-10 10:52:35 +01:00
Peter Steinberger
f8dbd7dd69 test: align qqbot account speech config expectation 2026-04-10 10:45:11 +01:00
Peter Steinberger
9714495797 test: keep plugin runtime symlink assertion on symlink path 2026-04-10 10:28:53 +01:00
Peter Steinberger
6c82a91d3d refactor: tighten device pairing approval types 2026-04-10 10:22:00 +01:00
Peter Steinberger
ae4817e0e0 test: align matrix acp delivery expectation 2026-04-10 10:15:51 +01:00
Peter Steinberger
bbede259b7 test(delivery): keep telegram parent channel target expectation 2026-04-10 10:12:07 +01:00
Peter Steinberger
edf4ec81c4 fix(imessage): remove duplicate runtime type import 2026-04-10 10:12:07 +01:00
Peter Steinberger
feb3c7f823 fix(test): repair rebased gate failures 2026-04-10 10:12:07 +01:00
Peter Steinberger
c2e2b87f28 fix(acp): classify gateway chat error kinds 2026-04-10 10:12:07 +01:00
Peter Steinberger
8763614d1e test: cover bundled plugin skill runtime 2026-04-10 10:11:35 +01:00
Peter Steinberger
68b4b36a90 test: harden qa eval scenarios 2026-04-10 10:11:35 +01:00
Mingkuan
005b629b6d fix(qqbot): allow extension fields in channel config schema (#64075)
* fix(qqbot): allow extension fields in channel config schema

Use passthrough() on QQBotConfigSchema, QQBotAccountSchema, and
QQBotStreamingSchema so third-party builds that share the qqbot
channel id can add custom fields without triggering
"must NOT have additional properties" validation errors.

tts and stt sub-schemas remain strict to preserve typo detection
for those sensitive fields.

* Update extensions/qqbot/openclaw.plugin.json

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

* chore(qqbot): update changelog for config schema passthrough

---------

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
2026-04-10 17:01:00 +08:00
Vincent Koc
3b6500ca20 fix(telegram): bypass bot handlers barrel 2026-04-10 10:00:24 +01:00
Vincent Koc
ae4fdaea82 fix(telegram): split monitor runtime types 2026-04-10 10:00:24 +01:00
Vincent Koc
ad8207c9d5 fix(protocol): regenerate agent models 2026-04-10 09:57:50 +01:00
Peter Steinberger
e462e531ad test: keep runtime staging fallback assertion on symlink path 2026-04-10 09:57:27 +01:00
Peter Steinberger
ec5ef68b0c test: fix latest fast-lane boundaries 2026-04-10 09:53:17 +01:00
Peter Steinberger
0728ac73c2 chore: remove stray empty files 2026-04-10 09:51:07 +01:00
Vincent Koc
489d0f7cd9 fix(whatsapp): split outbound media runtime seam 2026-04-10 09:49:02 +01:00
Peter Steinberger
b660493e54 fix: harden device pairing scope approval 2026-04-10 09:48:17 +01:00
Peter Steinberger
a5de4a1a50 test: align telegram delivery context expectation 2026-04-10 09:47:57 +01:00
Peter Steinberger
67ede66b3e test: refresh latest main expectations 2026-04-10 09:47:57 +01:00
Peter Steinberger
4522c1527e test: avoid jiti facade load in group policy fallback 2026-04-10 09:47:57 +01:00
Peter Steinberger
56cf1bd40c test: move image generation live sweep out of src 2026-04-10 09:47:57 +01:00
Vignesh Natarajan
4fde879142 chore: prep dreaming UI land (#64035) (thanks @davemorin) 2026-04-10 01:44:57 -07:00
Vignesh Natarajan
f479ab1498 dreaming: preserve unknown phase state on partial status 2026-04-10 01:44:57 -07:00
Dave Morin
c519f5abe1 dreaming: stabilize waiting-entry recency sort 2026-04-10 01:44:57 -07:00
Dave Morin
7d342374ce dreaming: pin the diary nav above long entries 2026-04-10 01:44:57 -07:00
Vignesh Natarajan
68cf8e01d6 Dreaming UI: handle unknown phases and refresh i18n 2026-04-10 01:44:57 -07:00
Vignesh Natarajan
060d2cc156 Dreaming UI: sort waiting queue and sync i18n 2026-04-10 01:44:57 -07:00
Dave Morin
05714d9777 dreaming: keep diary entry content below the date nav 2026-04-10 01:44:57 -07:00
Dave Morin
e710d6938f dreaming: polish review copy and diary wrapping 2026-04-10 01:44:57 -07:00
Dave Morin
14c96261e0 dreaming: simplify the advanced review flow 2026-04-10 01:44:57 -07:00
Dave Morin
7947d730fd dreaming: trim advanced tab copy 2026-04-10 01:44:57 -07:00
Dave Morin
564b46b39e dreaming: add an advanced review tab 2026-04-10 01:44:57 -07:00
Dave Morin
0202af9b38 dreaming: remove stale diary UI code 2026-04-10 01:44:57 -07:00
Dave Morin
cc387edf87 dreaming: use i18n for phase labels and off state
Add dreaming.phase.{light,deep,rem,off} translation keys.
Replace hardcoded English literals in phase cards template.
2026-04-10 01:44:57 -07:00
Dave Morin
d1be4cec07 dreaming: simplify Scene and Diary UI
Scene: remove trace grid, replace with clean phase cards (Light/Deep/REM).
Diary: remove arrow nav and heatmap, replace with horizontal scrollable date chips.
Left-align content to match rest of app. Net -250 lines.
2026-04-10 01:44:57 -07:00
Vincent Koc
25db93457e fix(qa-lab): split lab server runtime types 2026-04-10 09:38:55 +01:00
Peter Steinberger
1d310e2ab0 fix: restore main verification gates 2026-04-10 09:34:50 +01:00
Neerav Makwana
782b5622b6 fix: strip wrapped imsg rpc text fields (#64000) (thanks @neeravmakwana)
* fix(imessage): strip length-prefixed UTF-8 from imsg rpc text

* fix: strip wrapped imsg rpc text fields (#64000) (thanks @neeravmakwana)

---------

Co-authored-by: Ayaan Zaidi <hi@obviy.us>
2026-04-10 14:00:09 +05:30
Vincent Koc
5f489c25cb fix(zalo): align setup allowlist prompts with shared dm policy 2026-04-10 09:28:19 +01:00
Ayaan Zaidi
004781955c fix: restore model-scoped deprecation fallback matching 2026-04-10 13:57:00 +05:30
Vincent Koc
01058162be fix(ui): split view type seams 2026-04-10 09:24:48 +01:00
Vincent Koc
3323ec8ff1 fix(channels): keep test facades vitest-safe 2026-04-10 09:23:52 +01:00
Neerav Makwana
75deed54f3 Agents: allow cooldown probe for timeout failover reason 2026-04-10 13:52:37 +05:30
Peter Steinberger
a12c2ecd8a docs: link active memory changelog entry 2026-04-10 09:16:31 +01:00
Ted Li
d78d91f8c2 fix: continue fallback after OpenRouter no-endpoints 404 (#61472) (thanks @MonkeyLeeT)
* Fix OpenRouter no-endpoints fallback classification

* Restore bare model-not-found matcher coverage

* Preserve model does-not-exist fallback classification

* Narrow does-not-exist model-not-found matching

* Keep runtime model-not-found matcher strict

* style(agents): drop model matcher comment

* fix: continue fallback after OpenRouter no-endpoints 404 (#61472) (thanks @MonkeyLeeT)

---------

Co-authored-by: Ayaan Zaidi <hi@obviy.us>
2026-04-10 13:46:14 +05:30
Peter Steinberger
b53d6ebc21 docs: add active memory to docs nav 2026-04-10 09:15:03 +01:00
Alex Alaniz
6bd64ca4a7 fix: stop marking Claude CLI runs as host-managed
Stop injecting CLAUDE_CODE_PROVIDER_MANAGED_BY_HOST into Claude CLI runs and strip inherited/backend overrides before spawn.\n\nAlso repairs the Zalo setup allowlist prompt wiring needed by the current main check gate.\n\nThanks @Alex-Alaniz.
2026-04-10 09:14:15 +01:00
Ayaan Zaidi
e3e2a19ab7 fix(imessage): drop ambiguous reflected self-chat echoes 2026-04-10 13:42:02 +05:30
Vincent Koc
c3d3cf23bc fix(approval): split discord and slack runtime seams 2026-04-10 09:08:28 +01:00
Neerav Makwana
8ed7c95a6a fix: require destination_caller_id for self-chat classification (#63989) (thanks @neeravmakwana)
* fix(imessage): require destination_caller_id for self-chat classification (#63980)

Made-with: Cursor

* fix(imessage): scope self-chat cache to self-chat

---------

Co-authored-by: Ayaan Zaidi <hi@obviy.us>
2026-04-10 13:36:01 +05:30
Vincent Koc
8c88fb68b7 fix(msteams): align handler tests with conversation store 2026-04-10 09:03:10 +01:00
Neerav Makwana
0002982e52 fix: reset TUI footer activity on session switch (#63988) (thanks @neeravmakwana)
* TUI: reset activity to idle on session switch

* chore: remove redundant tui session comment

---------

Co-authored-by: Ayaan Zaidi <hi@obviy.us>
2026-04-10 13:32:01 +05:30
Vincent Koc
dfdc281f55 fix(cycles): split small runtime seams 2026-04-10 09:00:19 +01:00
Vincent Koc
c27ee0af42 fix(qa-lab): use strong vm suffix entropy 2026-04-10 08:52:10 +01:00
Vincent Koc
77b108ee7f fix(telegram): split runtime and audit types 2026-04-10 08:51:17 +01:00
Vincent Koc
76c2221717 fix(zalo): split runtime api type imports 2026-04-10 08:51:17 +01:00
Vincent Koc
5308003e2a fix(twitch): remove runtime api barrel back-edges 2026-04-10 08:51:17 +01:00
Sliverp
1bbe66450e fix: copy SKILL.md as hard copy in dist-runtime to prevent realpath security check failure (#64166)
SKILL.md files were created as symlinks pointing to dist/, causing
realpathSync() in resolveContainedSkillPath to resolve outside the
dist-runtime/ directory. The security check then rejected the path,
resulting in all 23 plugin skills being skipped at load time.

Add SKILL.md to the shouldCopyRuntimeFile whitelist so it gets a hard
copy instead of a symlink, matching the existing behavior for
package.json and plugin.json files.

Fixes #64138
2026-04-10 15:41:28 +08:00
Vincent Koc
d9ad995b77 docs(agents): add tsgo triage guidance 2026-04-10 08:40:54 +01:00
sudie-codes
828ebd43d4 feat(msteams): handle signin/tokenExchange and signin/verifyState for SSO (#60956) (#64089)
* feat(msteams): handle signin/tokenExchange and signin/verifyState for SSO (#60956)

* test(msteams): mock conversationStore.get in thread session fixture

---------

Co-authored-by: Brad Groux <bradgroux@users.noreply.github.com>
2026-04-10 02:38:01 -05:00
Frank Yang
360955a7c8 fix: preserve commands.list metadata (#64147)
Merged via squash.

Reviewed-by: @frankekn
2026-04-10 15:35:05 +08:00
Peter Steinberger
c919cc2cef fix(discord): restore modal type exports 2026-04-10 08:27:54 +01:00
Vincent Koc
b82fc1fdad docs(boundary): codify shared test helper plugin seams 2026-04-10 08:27:35 +01:00
Peter Steinberger
9b81c200c8 docs: refresh 2026.4.10 changelog 2026-04-10 08:23:23 +01:00
Peter Steinberger
3218f8f4e5 chore: align release metadata for 2026.4.10 2026-04-10 08:19:47 +01:00
Vincent Koc
f654b5a424 test(boundary): remove last direct bundled plugin imports 2026-04-10 08:19:20 +01:00
Vincent Koc
d674afcab3 fix(zalouser): remove runtime api type back-edges 2026-04-10 08:16:28 +01:00
Vincent Koc
2b96f53f97 fix(feishu): split message and mention types 2026-04-10 08:16:28 +01:00
Vincent Koc
5cf15f8598 fix(nostr): remove api type back-edges 2026-04-10 08:16:28 +01:00
Vincent Koc
337fa8c956 fix(telegram): split bot option types 2026-04-10 08:16:28 +01:00
Vincent Koc
e2a628b5a1 fix(whatsapp): split account config types 2026-04-10 08:16:28 +01:00
Vincent Koc
f5352b5611 fix(line): remove setup api barrel back-edge 2026-04-10 08:16:28 +01:00
Vincent Koc
503b43f43f fix(extensions): remove remaining line and imessage type back-edges 2026-04-10 08:16:28 +01:00
Vincent Koc
6784cc692c fix(extensions): split account config type seams 2026-04-10 08:16:28 +01:00
Vincent Koc
1c78822a1f fix(discord): split interactive component types 2026-04-10 08:16:27 +01:00
Vincent Koc
4a275cf6b1 fix(extensions): split shared runtime type seams 2026-04-10 08:16:27 +01:00
Vincent Koc
d752ff7191 fix(extensions): split runtime store type imports 2026-04-10 08:16:27 +01:00
Vincent Koc
4aa61cf8ca fix(extensions): remove barrel type back-edges 2026-04-10 08:16:27 +01:00
Vincent Koc
78d2e9e2a8 fix(ci): repair main type drift 2026-04-10 08:13:02 +01:00
Peter Steinberger
7e7a8d6b0f fix(claude-cli): harden gateway auth env 2026-04-10 08:10:46 +01:00
Peter Steinberger
7e2a1db53b fix: recover silent LLM idle timeouts 2026-04-10 08:09:17 +01:00
Vincent Koc
975e69b00b test(memory-core): keep memory tool mock local to plugin 2026-04-10 08:05:56 +01:00
Vincent Koc
3cea11d3b6 test(boundary): route helper imports through bundled plugin surfaces 2026-04-10 08:05:56 +01:00
Peter Steinberger
50f5091979 test: strengthen character eval judging 2026-04-10 08:04:49 +01:00
Shadow
d5b25f81cf update carbon 2026-04-10 01:53:36 -05:00
Frank Yang
fbb024ad2e docs(changelog): credit samzong for #61577 2026-04-10 14:44:21 +08:00
samzong
0f0a192ecb [Fix] agents.create RPC: support model param, write identity to config (#61577)
* fix(gateway): support model on agents.create, write identity to config

Signed-off-by: samzong <samzong.lu@gmail.com>

* fix(gateway): sync agent identity file writes

* fix(gateway): preserve richer identity markdown

* fix(gateway): preserve destination identity on workspace moves

* fix(gateway): preserve source identity on workspace moves

---------

Signed-off-by: samzong <samzong.lu@gmail.com>
Co-authored-by: Frank Yang <frank.ekn@gmail.com>
2026-04-10 14:36:22 +08:00
samzong
723dec0432 [Feat] Gateway: add commands.list RPC method (#62656)
Merged via squash.

Co-authored-by: samzong <samzong.lu@gmail.com>
Co-authored-by: Frank Yang <frank.ekn@gmail.com>
Reviewed-by: @frankekn
2026-04-10 14:28:47 +08:00
Tak Hoffman
4bf94aa0d6 feat: add local exec-policy CLI (#64050)
* feat: add local exec-policy CLI

* fix: harden exec-policy CLI output

* fix: harden exec approvals writes

* fix: tighten local exec-policy sync

* docs: document exec-policy CLI

* fix: harden exec-policy rollback and approvals path checks

* fix: reject exec-policy sync when host remains node

* fix: validate approvals path before mkdir

* fix: guard exec-policy rollback against newer approvals writes

* fix: restore exec approvals via hardened rollback path

* fix: guard exec-policy config writes with base hash

* docs: add exec-policy changelog entry

* fix: clarify exec-policy show for node host

* fix: strip stale exec-policy decisions
2026-04-10 01:16:03 -05:00
Pavan Kumar Gondhi
2d126fc623 fix(infra): expand host env security policy denylist [AI] (#63277)
* fix: address issue

* fix: address PR review feedback

* fix: address PR review feedback

* fix: address PR review feedback

* fix: address PR review feedback

* fix: address PR review feedback

* fix: address PR review feedback

* fix: address PR review feedback

* fix: address PR review feedback

* fix: close host env inherited sanitization gap

* fix: enforce host env reported baseline coverage

* fix: address PR review feedback

* fix: address PR review feedback

* fix: address PR review feedback

* docs: add changelog entry for PR merge
2026-04-10 11:36:39 +05:30
Qasim Soomro
71617ef2f0 fix: allow private network provider request opt-in (#63671)
* feat(models): allow private network via models.providers.*.request
Add optional request.allowPrivateNetwork for operator-controlled self-hosted
OpenAI-compatible bases (LAN/overlay/split DNS). Plumbs the flag into
resolveProviderRequestPolicyConfig for streaming provider HTTP and OpenAI
responses WebSocket so SSRF policy can allow private-resolved model URLs
when explicitly enabled.
Updates zod schema, config help/labels, and unit tests for sanitize/merge.

* agents thread provider request into websocket stream

* fix(config): scope allowPrivateNetwork to model requests

* fix(agents): refresh websocket manager on request changes

* fix(agents): scope runtime private-network overrides to models

* fix: allow private network provider request opt-in (#63671) (thanks @qas)

---------

Co-authored-by: Ayaan Zaidi <hi@obviy.us>
2026-04-10 11:11:03 +05:30
1484 changed files with 53944 additions and 19724 deletions

4
.github/labeler.yml vendored
View File

@@ -297,6 +297,10 @@
- changed-files:
- any-glob-to-any-file:
- "extensions/openai/**"
"extensions: codex":
- changed-files:
- any-glob-to-any-file:
- "extensions/codex/**"
"extensions: kimi-coding":
- changed-files:
- any-glob-to-any-file:

View File

@@ -37,9 +37,10 @@ jobs:
run_build_artifacts: ${{ steps.manifest.outputs.run_build_artifacts }}
run_checks_fast: ${{ steps.manifest.outputs.run_checks_fast }}
checks_fast_core_matrix: ${{ steps.manifest.outputs.checks_fast_core_matrix }}
checks_fast_extensions_matrix: ${{ steps.manifest.outputs.checks_fast_extensions_matrix }}
checks_node_extensions_matrix: ${{ steps.manifest.outputs.checks_node_extensions_matrix }}
run_checks: ${{ steps.manifest.outputs.run_checks }}
checks_matrix: ${{ steps.manifest.outputs.checks_matrix }}
checks_node_core_test_matrix: ${{ steps.manifest.outputs.checks_node_core_test_matrix }}
run_extension_fast: ${{ steps.manifest.outputs.run_extension_fast }}
extension_fast_matrix: ${{ steps.manifest.outputs.extension_fast_matrix }}
run_check: ${{ steps.manifest.outputs.run_check }}
@@ -135,6 +136,9 @@ jobs:
run: |
node --input-type=module <<'EOF'
import { appendFileSync } from "node:fs";
import {
createNodeTestShards,
} from "./scripts/lib/ci-node-test-plan.mjs";
import {
createExtensionTestShards,
DEFAULT_EXTENSION_TEST_SHARD_COUNT,
@@ -211,12 +215,11 @@ jobs:
]
: [],
),
checks_fast_extensions_matrix: extensionShardMatrix,
checks_node_extensions_matrix: extensionShardMatrix,
run_checks: runNode,
checks_matrix: createMatrix(
runNode
? [
{ check_name: "checks-node-test", runtime: "node", task: "test" },
{ check_name: "checks-node-channels", runtime: "node", task: "channels" },
...(isPush
? [
@@ -232,6 +235,17 @@ jobs:
]
: [],
),
checks_node_core_test_matrix: createMatrix(
runNode
? createNodeTestShards().map((shard) => ({
check_name: shard.checkName,
runtime: "node",
task: "test-shard",
shard_name: shard.shardName,
configs: shard.configs,
}))
: [],
),
run_extension_fast: hasChangedExtensions,
extension_fast_matrix: createMatrix(
hasChangedExtensions
@@ -470,7 +484,7 @@ jobs:
;;
esac
checks-fast-extensions-shard:
checks-node-extensions-shard:
name: ${{ matrix.check_name }}
needs: [preflight]
if: needs.preflight.outputs.run_checks_fast == 'true'
@@ -478,7 +492,7 @@ jobs:
timeout-minutes: 60
strategy:
fail-fast: false
matrix: ${{ fromJson(needs.preflight.outputs.checks_fast_extensions_matrix) }}
matrix: ${{ fromJson(needs.preflight.outputs.checks_node_extensions_matrix) }}
steps:
- name: Checkout
uses: actions/checkout@v6
@@ -497,16 +511,16 @@ jobs:
OPENCLAW_EXTENSION_BATCH: ${{ matrix.extensions_csv }}
run: pnpm test:extensions:batch -- "$OPENCLAW_EXTENSION_BATCH"
checks-fast-extensions:
name: checks-fast-extensions
needs: [preflight, checks-fast-extensions-shard]
checks-node-extensions:
name: checks-node-extensions
needs: [preflight, checks-node-extensions-shard]
if: always() && needs.preflight.outputs.run_checks_fast == 'true'
runs-on: blacksmith-16vcpu-ubuntu-2404
timeout-minutes: 5
steps:
- name: Verify extension shards
env:
SHARD_RESULT: ${{ needs.checks-fast-extensions-shard.result }}
SHARD_RESULT: ${{ needs.checks-node-extensions-shard.result }}
run: |
if [ "$SHARD_RESULT" != "success" ]; then
echo "Extension shard checks failed: $SHARD_RESULT" >&2
@@ -599,6 +613,102 @@ jobs:
;;
esac
checks-node-core-test-shard:
name: ${{ matrix.check_name }}
needs: [preflight, build-artifacts]
if: always() && needs.preflight.outputs.run_checks == 'true' && needs.build-artifacts.result == 'success'
runs-on: blacksmith-16vcpu-ubuntu-2404
timeout-minutes: 60
strategy:
fail-fast: false
matrix: ${{ fromJson(needs.preflight.outputs.checks_node_core_test_matrix) }}
steps:
- name: Checkout
uses: actions/checkout@v6
with:
persist-credentials: false
submodules: false
- name: Setup Node environment
uses: ./.github/actions/setup-node-env
with:
node-version: "${{ matrix.node_version || '24.x' }}"
cache-key-suffix: "${{ matrix.cache_key_suffix || 'node24' }}"
install-bun: "false"
use-sticky-disk: "false"
- name: Configure Node test resources
run: echo "OPENCLAW_VITEST_MAX_WORKERS=2" >> "$GITHUB_ENV"
- name: Download dist artifact
uses: actions/download-artifact@v8
with:
name: dist-build
path: dist/
- name: Download A2UI bundle artifact
uses: actions/download-artifact@v8
with:
name: canvas-a2ui-bundle
path: src/canvas-host/a2ui/
- name: Run Node test shard
env:
NODE_OPTIONS: --max-old-space-size=6144
OPENCLAW_NODE_TEST_CONFIGS_JSON: ${{ toJson(matrix.configs) }}
shell: bash
run: |
set -euo pipefail
node --input-type=module <<'EOF'
import { spawnSync } from "node:child_process";
import { resolveVitestCliEntry, resolveVitestNodeArgs } from "./scripts/run-vitest.mjs";
const configs = JSON.parse(process.env.OPENCLAW_NODE_TEST_CONFIGS_JSON ?? "[]");
if (!Array.isArray(configs) || configs.length === 0) {
console.error("Missing node test shard configs");
process.exit(1);
}
for (const config of configs) {
console.error(`[test] starting ${config}`);
const result = spawnSync(
"pnpm",
[
"exec",
"node",
...resolveVitestNodeArgs(process.env),
resolveVitestCliEntry(),
"run",
"--config",
config,
],
{
env: process.env,
stdio: "inherit",
},
);
if ((result.status ?? 1) !== 0) {
process.exit(result.status ?? 1);
}
}
EOF
checks-node-core-test:
name: checks-node-core-test
needs: [preflight, checks-node-core-test-shard]
if: always() && needs.preflight.outputs.run_checks == 'true'
runs-on: blacksmith-16vcpu-ubuntu-2404
timeout-minutes: 5
steps:
- name: Verify node test shards
env:
SHARD_RESULT: ${{ needs.checks-node-core-test-shard.result }}
run: |
if [ "$SHARD_RESULT" != "success" ]; then
echo "Node test shards failed: $SHARD_RESULT" >&2
exit 1
fi
extension-fast:
name: "extension-fast"
needs: [preflight]

View File

@@ -1,9 +1,9 @@
{
"$schema": "./node_modules/oxfmt/configuration_schema.json",
"experimentalSortImports": {
"sortImports": {
"newlinesBetween": false,
},
"experimentalSortPackageJson": {
"sortPackageJson": {
"sortScripts": true,
},
"tabWidth": 2,

View File

@@ -13,13 +13,17 @@
"eslint/no-new": "off",
"eslint/no-shadow": "off",
"eslint/no-unmodified-loop-condition": "off",
"eslint-plugin-unicorn/prefer-set-size": "off",
"oxc/no-accumulating-spread": "off",
"oxc/no-async-endpoint-handlers": "off",
"oxc/no-map-spread": "off",
"typescript/consistent-return": "error",
"typescript/no-explicit-any": "error",
"typescript/no-extraneous-class": "off",
"typescript/no-unnecessary-type-conversion": "off",
"typescript/no-unsafe-type-assertion": "off",
"unicorn/consistent-function-scoping": "off",
"unicorn/prefer-set-size": "off",
"unicorn/require-post-message-target-origin": "off"
},
"ignorePatterns": [
@@ -54,13 +58,7 @@
"**/*test-support.ts"
],
"rules": {
"typescript/await-thenable": "off",
"typescript/no-base-to-string": "off",
"typescript/no-explicit-any": "off",
"typescript/no-floating-promises": "off",
"typescript/no-misused-spread": "off",
"typescript/no-redundant-type-constituents": "off",
"typescript/no-unnecessary-template-expression": "off",
"typescript/unbound-method": "off",
"eslint/no-unsafe-optional-chaining": "off"
}

View File

@@ -73,6 +73,8 @@
- Extension test boundary:
- Keep extension-owned onboarding/config/provider coverage under the owning bundled plugin package when feasible.
- If core tests need bundled plugin behavior, consume it through public `src/plugin-sdk/<id>.ts` facades or the plugin's `api.ts`, not private extension modules.
- Shared helpers under `test/helpers/**` are part of that same boundary. Do not hardcode repo-relative `extensions/**` imports there, and do not keep plugin-local deep mocks in shared helpers just because multiple tests use them.
- When core tests or shared helpers need bundled plugin public surfaces, use `src/test-utils/bundled-plugin-public-surface.ts` for `api.ts`, `runtime-api.ts`, `contract-api.ts`, `test-api.ts`, plugin entrypoint `index.js`, and resolved module ids for dynamic import or mocking.
- If a core test is asserting extension-specific behavior instead of a generic contract, move it to the owning extension package.
## Docs Linking (Mintlify)
@@ -149,6 +151,7 @@
- Config schema drift uses `pnpm config:docs:gen` / `pnpm config:docs:check`.
- Plugin SDK API drift uses `pnpm plugin-sdk:api:gen` / `pnpm plugin-sdk:api:check`.
- If you change config schema/help or the public Plugin SDK surface, run the matching gen command and commit the updated `.sha256` hash file. Keep the two drift-check flows adjacent in scripts/workflows/docs guidance rather than inventing a third pattern.
- When `pnpm tsgo` fails, triage by coherent surface instead of by raw error count: rerun the gate, group failures by package/module/type contract, open the source-of-truth type or export file first, fix the root mismatch, then rerun `pnpm tsgo` before widening into downstream consumers. Check `origin/main` before doing broad cleanup because some apparent type debt is already fixed upstream.
- For narrowly scoped changes, prefer narrowly scoped tests that directly validate the touched behavior. If no meaningful scoped test exists, say so explicitly and use the next most direct validation available.
- Verification modes for work on `main`:
- Default mode: `main` is relatively stable. Count pre-commit hook coverage when it already verified the current tree, avoid rerunning the exact same checks just for ceremony, and prefer keeping CI/main green before landing.
@@ -296,7 +299,7 @@
- When working on a GitHub Issue or PR, print the full URL at the end of the task.
- When answering questions, respond with high-confidence answers only: verify in code; do not guess.
- Carbon: prefer latest published beta over stable when possible; do not switch to stable casually.
- Carbon version edits are owner-only: do not change `@buape/carbon` version pins unless you are Shadow (@thewilloftheshadow) as verified by gh.
- Any dependency with `pnpm.patchedDependencies` must use an exact version (no `^`/`~`).
- Patching dependencies (pnpm patches, overrides, or vendored changes) requires explicit approval; do not do this by default.
- **Multi-agent safety:** do **not** create/apply/drop `git stash` entries unless explicitly requested (this includes `git pull --rebase --autostash`). Assume other agents may be working; keep unrelated WIP untouched and avoid cross-cutting state changes.

View File

@@ -6,67 +6,149 @@ Docs: https://docs.openclaw.ai
### Changes
- Memory/Active Memory: add a new optional Active Memory plugin that gives OpenClaw a dedicated memory sub-agent right before the main reply, so ongoing chats can automatically pull in relevant preferences, context, and past details without making users remember to manually say "remember this" or "search memory" first. Includes configurable message/recent/full context modes, live `/verbose` inspection, advanced prompt/thinking overrides for tuning, and opt-in transcript persistence for debugging.
- Memory/Active Memory: add a new optional Active Memory plugin that gives OpenClaw a dedicated memory sub-agent right before the main reply, so ongoing chats can automatically pull in relevant preferences, context, and past details without making users remember to manually say "remember this" or "search memory" first. Includes configurable message/recent/full context modes, live `/verbose` inspection, advanced prompt/thinking overrides for tuning, and opt-in transcript persistence for debugging. Docs: https://docs.openclaw.ai/concepts/active-memory. (#63286) Thanks @Takhoffman.
- macOS/Talk: add an experimental local MLX speech provider for Talk Mode, with explicit provider selection, local utterance playback, interruption handling, and system-voice fallback. (#63539) Thanks @ImLukeF.
- Docs i18n: chunk raw doc translation, reject truncated tagged outputs, avoid ambiguous body-only wrapper unwrapping, and recover from terminated Pi translation sessions without changing the default `openai/gpt-5.4` path. (#62969, #63808) Thanks @hxy91819.
- CLI/exec policy: add a local `openclaw exec-policy` command with `show`, `preset`, and `set` subcommands for synchronizing requested `tools.exec.*` config with the local exec approvals file, plus follow-up hardening for node-host rejection, rollback safety, and sync conflict detection. (#64050)
- Gateway: add a `commands.list` RPC so remote gateway clients can discover runtime-native, text, skill, and plugin commands with surface-aware naming and serialized argument metadata. (#62656) Thanks @samzong.
- Models/providers: add per-provider `models.providers.*.request.allowPrivateNetwork` for trusted self-hosted OpenAI-compatible endpoints, keep the opt-in scoped to model request surfaces, and refresh cached WebSocket managers when request transport overrides change. (#63671) Thanks @qas.
- QA/testing: add a `--runner multipass` lane for `openclaw qa suite` so repo-backed QA scenarios can run inside a disposable Linux VM and write back the usual report, summary, and VM logs. (#63426) Thanks @shakkernerd.
- Docs i18n: chunk raw doc translation, reject truncated tagged outputs, avoid ambiguous body-only wrapper unwrapping, and recover from terminated Pi translation sessions without changing the default `openai/gpt-5.4` path. (#62969, #63808) Thanks @hxy91819.
- Control UI/dreaming: simplify the Scene and Diary surfaces, preserve unknown phase state for partial status payloads, and stabilize waiting-entry recency ordering so Dreaming status and review lists stay clear and deterministic. (#64035) Thanks @davemorin.
- Gateway: split startup and runtime seams so gateway lifecycle sequencing, reload state, and shutdown behavior stay easier to maintain without changing observed behavior. (#63975) Thanks @gumadeiras.
- Control UI/webchat: normalize assistant `MEDIA:`/reply/voice directives into structured bubble rendering, rename the unreleased rich web shortcode to `[embed ...]`, and surface session runtime roots so hosted web content is written to the correct document path instead of guessed local files.
- Matrix/partial streaming: add MSC4357 live markers to draft preview sends and edits so supporting Matrix clients can render a live/typewriter animation and stop it when the final edit lands. (#63513) Thanks @TigerInYourDream.
- QA/Telegram: add a live `openclaw qa telegram` lane for private-group bot-to-bot checks, harden its artifact handling, and preserve native Telegram command reply threading for QA verification. (#64303) Thanks @obviyus.
- Models/Codex: add the bundled Codex provider and plugin-owned app-server harness so `codex/gpt-*` models use Codex-managed auth, native threads, model discovery, and compaction while `openai/gpt-*` stays on the normal OpenAI provider path. (#64298) Thanks @steipete.
- Agents: add an opt-in strict-agentic embedded Pi execution contract for GPT-5-family runs so plan-only or filler turns keep acting until they hit a real blocker. (#64241) Thanks @100yenadmin.
### Fixes
- fix(agents): guard nodes tool outPath against workspace boundary [AI-assisted]. (#63551) Thanks @pgondhi987.
- fix(qqbot): enforce media storage boundary for all outbound local file paths [AI]. (#63271) Thanks @pgondhi987.
- iMessage/self-chat: distinguish normal DM outbound rows from true self-chat using `destination_caller_id` plus chat participants, while preserving multi-handle self-chat aliases so outbound DM replies stop looping back as inbound messages. (#61619) Thanks @neeravmakwana.
- fix(browser): auto-generate browser control auth token for none/trusted-proxy modes [AI]. (#63280) Thanks @pgondhi987.
- fix(exec): replace TOCTOU check-then-read with atomic pinned-fd open in script preflight [AI]. (#62333) Thanks @pgondhi987.
- WhatsApp/auto-reply: keep inbound reply, media, and composing sends on the current socket across reconnects, wait through reconnect gaps, and retry timeout-only send failures without dropping the active socket ref. (#62892) Thanks @mcaxtr.
- Config/plugins: let config writes keep disabled plugin entries without forcing required plugin config schemas or crashing raw plugin validation, so slot switches and similar plugin-state updates persist cleanly. (#63296) Thanks @fuller-stack-dev.
- WhatsApp/outbound queue: drain queued WhatsApp deliveries when the listener reconnects without dropping reconnect-delayed sends after a special TTL or rewriting retry history, so disconnect-window outbound messages can recover once the channel is ready again. (#46299) Thanks @manuel-claw.
- Tools/web_fetch: add an opt-in `tools.web.fetch.ssrfPolicy.allowRfc2544BenchmarkRange` config so fake-IP proxy environments that resolve public sites into `198.18.0.0/15` can use `web_fetch` without weakening the default SSRF block. (#61830) Thanks @xing-xing-coder.
- Daemon/gateway install: preserve safe custom service env vars on forced reinstall, merge prior custom PATH segments behind the managed service PATH, and stop removed managed env keys from persisting as custom carryover. (#63136) Thanks @WarrenJones.
- Config validation: surface the actual offending field for strict-schema union failures in bindings, including top-level unexpected keys on the matching ACP branch. (#40841) Thanks @Hollychou924.
- QQBot/security: replace raw `fetch()` in the image-size probe with SSRF-guarded `fetchRemoteMedia`, fix `resolveRepoRoot()` to walk up to `.git` instead of hardcoding two parent levels, and refresh the raw-fetch allowlist to match the corrected scan. (#63495) Thanks @dims.
- Cron/scheduling: treat `nextRunAtMs <= 0` as invalid across cron update, maintenance, timer, and stale-delivery paths so corrupted zero timestamps self-heal instead of causing immediate runs or skipped deliveries. (#63507) Thanks @WarrenJones.
- Status: show configured fallback models in `/status` and shared session status cards so per-agent fallback configuration is visible before a live failover happens. (#33111) Thanks @AnCoSONG.
- Fireworks/FirePass: disable Kimi K2.5 Turbo reasoning output by forcing thinking off on the FirePass path and hardening the provider wrapper so hidden reasoning no longer leaks into visible replies. (#63607) Thanks @frankekn.
- Sessions/model selection: preserve catalog-backed session model labels and keep already-qualified session model refs stable when catalog metadata is unavailable, so Control UI model selection survives reloads without bogus provider-prefixed values. (#61382) Thanks @Mule-ME.
- CLI/WhatsApp media sends: route gateway-mode outbound sends with `--media` through the channel `sendMedia` path and preserve media access context, so WhatsApp document and attachment sends stop silently dropping the file while still delivering the caption. (#64478) Thanks @ShionEria.
- fix(nostr): require operator.admin scope for profile mutation routes [AI]. (#63553) Thanks @pgondhi987.
- Gateway/startup: keep WebSocket RPC available while channels and plugin sidecars start, hold `chat.history` unavailable until startup sidecars finish so synchronous history reads cannot stall startup (reported in #63450), refresh advertised gateway methods after deferred plugin reloads, and enforce the pre-auth WebSocket upgrade budget before the no-handler 503 path so upgrade floods cannot bypass connection limits during that window. (#63480) Thanks @neeravmakwana.
- Dreaming/cron: reconcile managed dreaming cron from the resolved gateway startup config so boot-time schedule recovery respects the configured cadence and timezone. (#63873) Thanks @mbelinky.
- Dreaming/cron: keep managed dreaming cron reconciled after startup by rechecking lifecycle state during runtime config/plugin changes, recovering missing managed jobs, and applying cadence/timezone updates idempotently. (#63929) Thanks @mbelinky.
- Gateway/tailscale: start Tailscale exposure and the gateway update check before awaiting channel and plugin sidecar startup so remote operators are not locked out when startup sidecars stall.
- WhatsApp: keep inbound replies, media, composing indicators, and queued outbound deliveries attached to the current socket across reconnect gaps, including fresh retry-eligible sends after the listener comes back. (#30806, #46299, #62892, #63916) Thanks @mcaxtr.
- Microsoft Teams: restore media downloads for personal DMs, Bot Framework `a:` conversations, OneDrive/SharePoint shared files, and Graph-backed chat IDs; accept Bot Framework audience tokens; and deliver cron announcements to Teams conversation IDs. (#55383, #58001, #58249, #62219, #62674, #63063, #63942, #63951, #63953) Thanks @obviyus.
- Gateway/thread routing: preserve Slack, Telegram, Mattermost, and ACP parent-thread delivery targets so subagent, cron, and stream-relay completion messages land back in the originating thread or topic. (#54840, #57056, #63228, #63506) Thanks @yzzymt.
- Agents/timeouts: extend the default LLM idle window to 120s and keep silent no-token idle timeouts on recovery paths, so slow models can retry or fall back before users see an error.
- Gateway/agents: preserve configured model selection and richer `IDENTITY.md` content across agent create/update flows and workspace moves, and fail safely instead of silently overwriting unreadable identity files. (#61577) Thanks @samzong.
- Skills/TaskFlow: restore valid frontmatter fences for the bundled `taskflow` and `taskflow-inbox-triage` skills so they stay discoverable and loadable after updates. (#64469) Thanks @extrasmall0.
- Windows/exec: settle supervisor waits from child exit state after stdout and stderr drain even when `close` never arrives, so CLI commands stop hanging or dying with forced `SIGKILL` on Windows. (#64072) Thanks @obviyus.
- Browser/sandbox: prevent sandbox browser CDP startup hangs by recreating containers when the browser security hash changes and by waiting on the correct sandbox browser lifecycle. (#62873) Thanks @Syysean.
- iMessage/self-chat: distinguish normal DM outbound rows from true self-chat using `destination_caller_id` plus chat participants, while preserving multi-handle self-chat aliases so outbound DM replies stop looping back as inbound messages. (#61619) Thanks @neeravmakwana.
- QQBot/streaming: make block streaming configurable per QQ bot account via `streaming.mode` (`"partial"` | `"off"`, default `"partial"`) instead of hardcoding it off, so responses can be delivered incrementally. (#63746)
- QQBot/config: allow extra fields in `channels.qqbot` and `channels.qqbot.accounts.*` so extended qqbot builds can add new config options without gateway startup failing on schema validation. (#64075) Thanks @WideLee.
- Dreaming/gateway: require `operator.admin` for persistent `/dreaming on|off` changes and treat missing gateway client scopes as unprivileged instead of silently allowing config writes. (#63872) Thanks @mbelinky.
- Matrix/multi-account: keep room-level `account` scoping, inherited room overrides, and implicit account selection consistent across top-level default auth, named accounts, and cached-credential env setups. (#58449) thanks @Daanvdplas and @gumadeiras.
- Gateway/pairing: prefer explicit QR bootstrap auth over earlier Tailscale auth classification so iOS `/pair qr` silent bootstrap pairing does not fall through to `pairing required`. (#59232) Thanks @ngutman.
- WhatsApp/outbound queue: drain same-account pending WhatsApp deliveries when the listener reconnects, including fresh queued sends that are already retry-eligible, so reconnects recover deliverable outbound messages without waiting for another gateway restart. (#63916) Thanks @mcaxtr.
- Config/Discord: coerce safe integer numeric Discord IDs to strings during config validation, keep unsafe or precision-losing numeric snowflakes rejected, and align `openclaw doctor` repair guidance with the same fail-closed behavior. (#45125) Thanks @moliendocode.
- Gateway/sessions: scope bare `sessions.create` aliases like `main` to the requested agent while preserving the canonical `global` and `unknown` sentinel keys. (#58207) thanks @jalehman.
- `/context detail` now compares the tracked prompt estimate with cached context usage and surfaces untracked provider/runtime overhead when present. (#28391) thanks @ImLukeF.
- Gateway/session reset: emit the typed `before_reset` hook for gateway `/new` and `/reset`, preserving reset-hook behavior even when the previous transcript has already been archived. (#53872) thanks @VACInc
- Browser/control: auto-generate browser-control auth tokens for `none` and `trusted-proxy` modes, and route browser auth/profile/doctor helpers through the public browser plugin facades. (#63280, #63957) Thanks @pgondhi987.
- Browser/act: centralize `/act` request normalization and execution dispatch while adding stable machine-readable route-level error codes for invalid requests, selector misuse, evaluate-disabled gating, target mismatch, and existing-session unsupported actions. (#63977) Thanks @joshavant.
- Security/exec: replace script-preflight check-then-read logic with an atomic pinned-file-descriptor open, and expand the host environment denylist for dangerous runtime-control variables. (#62333, #63277) Thanks @pgondhi987.
- Security/nodes: keep `nodes` tool output paths inside the workspace boundary so model-driven node writes cannot escape the intended workspace. (#63551) Thanks @pgondhi987.
- Security/QQBot: enforce media storage boundaries for all outbound local file paths and route image-size probes through SSRF-guarded media fetching instead of raw `fetch()`. (#63271, #63495) Thanks @pgondhi987.
- Channel setup: ignore workspace plugin shadows when resolving trusted channel setup catalog entries so onboarding and setup flows keep using the bundled, trusted setup contract.
- Gateway/memory startup: load the explicitly selected memory-slot plugin during gateway startup, while keeping restrictive allowlists and implicit default memory slots from auto-starting unrelated memory plugins. (#64423) Thanks @EronFan.
- Config/plugins: let config writes keep disabled plugin entries without forcing required plugin config schemas or crashing raw plugin validation, and avoid re-activating plugin registry state during schema checks. (#54971, #63296) Thanks @fuller-stack-dev.
- Config validation: surface the actual offending field for strict-schema union failures in bindings, including top-level unexpected keys on the matching ACP branch. (#40841) Thanks @Hollychou924.
- Wizard/plugin config: coerce integer-typed plugin config fields from interactive text input so integer schema values persist as numbers instead of failing validation. (#63346) Thanks @jalehman.
- Daemon/gateway install: preserve safe custom service env vars on forced reinstall, merge prior custom PATH segments behind the managed service PATH, and stop removed managed env keys from persisting as custom carryover. (#63136) Thanks @WarrenJones.
- Cron/scheduling: treat `nextRunAtMs <= 0` as invalid across cron update, maintenance, timer, and stale-delivery paths so corrupted zero timestamps self-heal instead of causing immediate runs or skipped deliveries. (#63507) Thanks @WarrenJones.
- Cron/auth: resolve auth profiles consistently for isolated cron jobs so scheduled runs use the same configured provider credentials as interactive sessions. (#62797) Thanks @neeravmakwana.
- Tasks: let `openclaw tasks cancel` cancel stuck background tasks that never reached a normal terminal state. (#62506) Thanks @neeravmakwana.
- Sessions/model selection: preserve catalog-backed session model labels, provider-qualified context limits, and already-qualified session model refs when catalog metadata is unavailable, so model selection and memory/context budgets survive reloads without bogus provider prefixes. (#61382, #62493) Thanks @Mule-ME.
- Status: show configured fallback models in `/status` and shared session status cards so per-agent fallback configuration is visible before a live failover happens. (#33111) Thanks @AnCoSONG.
- `/context detail` now compares the tracked prompt estimate with cached context usage and surfaces untracked provider/runtime overhead when present. (#28391) Thanks @ImLukeF.
- Gateway/sessions: scope bare `sessions.create` aliases like `main` to the requested agent while preserving the canonical `global` and `unknown` sentinel keys. (#58207) Thanks @jalehman.
- Gateway/session reset: emit the typed `before_reset` hook for gateway `/new` and `/reset`, preserving reset-hook behavior even when the previous transcript has already been archived. (#53872) Thanks @VACInc.
- Plugins/commands: pass the active host `sessionKey` into plugin command contexts, and include `sessionId` when it is already available from the active session entry, so bundled and third-party commands can resolve the current conversation reliably. (#59044) Thanks @jalehman.
- Agents/auth: honor `models.providers.*.authHeader` for pi embedded runner model requests by injecting `Authorization: Bearer <apiKey>` when requested. (#54390) Thanks @lndyzwdxhs.
- Dreaming/cron: stop runtime cron reconciliation on ordinary user turns and only recover managed dreaming cron state during heartbeat-triggered dreaming checks, so unrelated chat traffic does not silently recreate removed jobs. (#63938) Thanks @mbelinky.
- UI/compaction: keep the compaction indicator in a retry-pending state until the run actually finishes, so the UI does not show `Context compacted` before compaction actually finishes. (#55132) Thanks @mpz4life.
- Cron/tool schemas: keep cron tool schemas strict-model-friendly while still preserving `failureAlert=false`, nullable `agentId`/`sessionKey`, and flattened add/update recovery for the newly exposed cron job fields. (#55043) Thanks @brunolorente.
- BlueBubbles/config: accept `enrichGroupParticipantsFromContacts` in the core strict config schema so gateways no longer fail validation or startup when the BlueBubbles plugin writes that field. (#56889) Thanks @zqchris.
- Agents/failover: classify AbortError and stream-abort messages as timeout so Ollama NDJSON stream aborts stop showing `reason=unknown` in model fallback logs. (#58324) Thanks @yelog
- Exec approvals: route Slack, Discord, and Telegram approvals through the shared channel approval-capability path so native approval auth, delivery, and `/approve` handling stay aligned across channels while preserving Telegram session-key agent filtering. (#58634) thanks @gumadeiras
- Claude CLI: clear inherited Anthropic auth/header environment aliases before spawning Claude Code and add sanitized CLI backend auth-env diagnostics for debugging gateway-run provider selection.
- Agents/failover: classify AbortError and stream-abort messages as timeout so Ollama NDJSON stream aborts stop showing `reason=unknown` in model fallback logs. (#58324) Thanks @yelog.
- Fireworks/FirePass: disable Kimi K2.5 Turbo reasoning output by forcing thinking off on the FirePass path and hardening the provider wrapper so hidden reasoning no longer leaks into visible replies. (#63607) Thanks @frankekn.
- Matrix/multi-account: keep room-level `account` scoping, inherited room overrides, and implicit account selection consistent across top-level default auth, named accounts, and cached-credential env setups. (#58449) Thanks @gumadeiras.
- Matrix/runtime: resolve the verification/bootstrap runtime from a distinct packaged Matrix entry so global npm installs stop failing on crypto bootstrap with missing-module or recursive runtime alias errors. (#59249) Thanks @gumadeiras.
- Matrix/streaming: preserve ordered block flushes before tool, message, and agent boundaries, add explicit `channels.matrix.blockStreaming` opt-in so Matrix `streaming: "off"` stays final-only by default, and move MiniMax plain-text final handling into the MiniMax provider runtime instead of the shared core heuristic. (#59266) thanks @gumadeiras
- Gateway/agents: fix stale run-context TTL cleanup so the new maintenance sweep compiles and resets orphaned run sequence state correctly. (#52731) thanks @artwalker
- Matrix/streaming: preserve ordered block flushes before tool, message, and agent boundaries, add explicit `channels.matrix.blockStreaming` opt-in so Matrix `streaming: "off"` stays final-only by default, and move MiniMax plain-text final handling into the MiniMax provider runtime instead of the shared core heuristic. (#59266) Thanks @gumadeiras.
- QQBot/streaming: make block streaming configurable per QQ bot account via `streaming.mode` (`"partial"` | `"off"`, default `"partial"`) instead of hardcoding it off, so responses can be delivered incrementally. (#63746)
- Discord: update Carbon to v0.15.0. Thanks @thewilloftheshadow.
- Config/Discord: coerce safe integer numeric Discord IDs to strings during config validation, keep unsafe or precision-losing numeric snowflakes rejected, and align `openclaw doctor` repair guidance with the same fail-closed behavior. (#45125) Thanks @moliendocode.
- BlueBubbles/config: accept `enrichGroupParticipantsFromContacts` in the core strict config schema so gateways no longer fail validation or startup when the BlueBubbles plugin writes that field. (#56889) Thanks @zqchris.
- Feishu/webhooks: read webhook bodies through the pre-auth guard so unauthenticated webhook traffic stays under the same body budget as other protected channel ingress paths.
- Tools/web_fetch: add an opt-in `tools.web.fetch.ssrfPolicy.allowRfc2544BenchmarkRange` config so fake-IP proxy environments that resolve public sites into `198.18.0.0/15` can use `web_fetch` without weakening the default SSRF block. (#61830) Thanks @xing-xing-coder.
- Dreaming/gateway: require `operator.admin` for persistent `/dreaming on|off` changes and treat missing gateway client scopes as unprivileged instead of silently allowing config writes. (#63872) Thanks @mbelinky.
- Dreaming/cron: reconcile managed dreaming cron from startup config and runtime lifecycle changes, but only recover managed dreaming cron state during heartbeat-triggered dreaming checks so ordinary chat traffic does not recreate removed jobs. (#63873, #63929, #63938) Thanks @mbelinky.
- Memory/lancedb: accept `dreaming` config when `memory-lancedb` owns the memory slot so Dreaming surfaces can read slot-owner settings without schema rejection. (#63874) Thanks @mbelinky.
- Control UI/dreaming: keep the Dreaming trace area contained and scrollable so overlays no longer cover tabs or blow out the page layout. (#63875) Thanks @mbelinky.
- Dreaming/diary: add idempotent narrative subagent runs, preserve restrictive `DREAMS.md` permissions during atomic writes, and surface temp cleanup failures so repeated sweeps do not double-run the same narrative request or silently weaken diary safety. (#63876) Thanks @mbelinky.
- Heartbeats/sessions: remove stale accumulated isolated heartbeat session keys when the next tick converges them back to the canonical sibling, so repaired sessions stop showing orphaned `:heartbeat:heartbeat` variants in session listings. (#59606) Thanks @rogerdigital.
- Gateway/run cleanup: fix stale run-context TTL cleanup so the new maintenance sweep resets orphaned run sequence state and prevents unbounded run-context growth. (#52731) Thanks @artwalker.
- UI/compaction: keep the compaction indicator in a retry-pending state until the run actually finishes, so the UI does not show `Context compacted` before compaction actually finishes. (#55132) Thanks @mpz4life.
- Cron/tool schemas: keep cron tool schemas strict-model-friendly while still preserving `failureAlert=false`, nullable `agentId`/`sessionKey`, and flattened add/update recovery for the newly exposed cron job fields. (#55043) Thanks @brunolorente.
- Git metadata: read commit ids from packed refs as well as loose refs so version and status metadata stay accurate after repository maintenance. (#63943)
- Gateway: keep `commands.list` skill entries categorized under tools and include provider-aware plugin `nativeName` metadata even when `scope=text`, so remote clients can group skills correctly and map text-surface plugin commands back to native aliases.
- TUI: reset footer activity to idle when switching sessions so a stale streaming indicator cannot persist after the selection changes. (#63988) Thanks @neeravmakwana.
- iMessage: treat `sender === chat_identifier` as self-chat only when `destination_caller_id` is present and matches the sender, fixing DM outbound rows that omit destination from being run through self-chat echo handling. (#63980) Thanks @neeravmakwana.
- Cron/Telegram: collapse isolated announce delivery to the final assistant-visible text only for Telegram targets, while preserving existing multi-message direct delivery semantics for other channels. (#63228) Thanks @welfo-beo.
- Gateway/thread routing: preserve Slack, Telegram, and Mattermost thread-child delivery targets so bound subagent completion messages land in the originating thread instead of top-level channels. (#54840) Thanks @yzzymt.
- ACP/stream relay: pass parent delivery context to ACP stream relay system events so `streamTo="parent"` updates route to the correct thread or topic instead of falling back to the main DM. (#57056) Thanks @pingren.
- Agents/sessions: preserve announce `threadId` when `sessions.list` fallback rehydrates agent-to-agent announce targets so final announce messages stay in the originating thread/topic. (#63506) Thanks @SnowSky1.
- iMessage/self-chat: remember ambiguous `sender === chat_identifier` outbound rows with missing `destination_caller_id` in self-chat dedupe state so the later reflected inbound copy still drops instead of re-entering inbound handling when the echo cache misses. Thanks @neeravmakwana.
- Claude CLI: stop marking spawned Claude Code runs as host-managed so they keep using normal CLI subscription behavior. (#64023) Thanks @Alex-Alaniz.
- Agents/failover: classify OpenRouter `404 No endpoints found for <model>` responses as `model_not_found` so fallback chains continue past retired OpenRouter candidates. (#61472) Thanks @MonkeyLeeT.
- Browser/plugin SDK: route browser auth, profile, host-inspection, and doctor readiness helpers through browser plugin public facades so core compatibility helpers stop carrying duplicate runtime implementations. (#63957) Thanks @joshavant.
- Browser/act: centralize `/act` request normalization and execution dispatch while adding stable machine-readable route-level error codes for invalid requests, selector misuse, evaluate-disabled gating, target mismatch, and existing-session unsupported actions. (#63977) Thanks @joshavant.
- Windows/exec: settle supervisor waits from child exit state after stdout and stderr drain even when `close` never arrives, so CLI commands stop hanging or dying with forced `SIGKILL` on Windows. (#64072) Thanks @obviyus.
- Agents/failover: allow cooldown probes for `timeout` (including network outage classifications) so the primary model can recover after failover without a gateway restart. (#63996) Thanks @neeravmakwana.
- iMessage (imsg): strip an accidental protobuf length-delimited UTF-8 field wrapper from inbound `text` and `reply_to_text` when it fully consumes the field, fixing leading garbage before the real message. (#63868) Thanks @neeravmakwana.
- Gateway/pairing: fail closed for paired device records that have no device tokens, and reject pairing approvals whose requested scopes do not match the requested device roles.
- ACP/gateway chat: classify lifecycle errors before forwarding them to ACP clients so refusals use ACP's refusal stop reason while transient backend errors continue to finish as normal turns.
- Agents/BTW: strip replayed tool blocks, hidden reasoning, and malformed image payloads from `/btw` side-question context so Bedrock no-tools side questions keep working after tool-use turns. (#64225) Thanks @ngutman.
- Commands/btw: keep tool-less side questions from sending injected empty `tools` arrays on strict OpenAI-compatible providers, so `/btw` continues working after prior tool-call history. (#64219) Thanks @ngutman.
- Agents/Bedrock: let `/btw` side questions use `auth: "aws-sdk"` without a static API key so Bedrock IAM and instance-role sessions stop failing before the side question runs. (#64218) Thanks @SnowSky1.
- Feishu: route `/btw` side questions and `/stop` onto bounded out-of-band lanes so BTW no longer waits behind a busy normal chat turn while ordinary same-chat traffic stays FIFO. (#64324) Thanks @ngutman.
- Agents/failover: detect llama.cpp slot context overflows as context-overflow errors so compaction can retry self-hosted OpenAI-compatible runs instead of surfacing the raw upstream 400. (#64196) Thanks @alexander-applyinnovations.
- Claude CLI/skills: pass eligible OpenClaw skills into CLI runs, including native Claude Code skill resolution via a temporary plugin plus per-run skill env/API key injection. (#62686, #62723) Thanks @zomars.
- Discord: keep generated auto-thread names working with reasoning models by giving title generation enough output budget for thinking plus visible title text. (#64172) Thanks @hanamizuki.
- Heartbeat: ignore doc-only Markdown fence markers in the default `HEARTBEAT.md` template so comment-only heartbeat scaffolds skip API calls again. (#63434) Thanks @ravyg.
- Control UI/BTW: render `/btw` side results as dismissible ephemeral cards in the browser, send `/btw` immediately during active runs, and clear stale BTW cards on reset flows so webchat matches the intended detached side-question behavior. (#64290) Thanks @ngutman.
- Reply/skills: keep resolved skill and memory secret config stable through embedded reply runs so raw SecretRefs in secondary skill settings no longer crash replies when the gateway already has the live env. (#64249) Thanks @mbelinky.
- Dreaming/startup: keep plugin-registered startup hooks alive across workspace hook reloads and include dreaming startup owners in the gateway startup plugin scope, so managed Dreaming cron registration comes back reliably after gateway boot. (#62327) Thanks @mbelinky.
- Plugins: treat duplicate `registerService` calls from the same plugin id as idempotent so snapshot and activation loads no longer emit spurious `service already registered` diagnostics. (#62033, #64128) Thanks @ly85206559.
- Discord/TTS: route auto voice replies through the native voice-note path so Discord receives Opus voice messages instead of regular audio attachments. (#64096) Thanks @LiuHuaize.
- Config/plugins: use plugin-owned command alias metadata when `plugins.allow` contains runtime command names like `dreaming`, and point users at the owning plugin instead of stale plugin-not-found guidance. (#64242) Thanks @feiskyer.
- Agents/Gemini: strip orphaned `required` entries from Gemini tool schemas so provider validation no longer rejects tools after schema cleanup or union flattening. (#64284) Thanks @xxxxxmax.
- Assistant text: strip Qwen-style XML tool call payloads from visible replies so web and channel messages no longer show raw `<tool_call><function=...>` output. (#64214) Thanks @MoerAI.
- Daemon/gateway: prevent systemd restart storms on configuration errors by exiting with `EX_CONFIG` and adding generated unit restart-prevention guards. (#63913) Thanks @neo1027144-creator.
- Agents/exec: prevent gateway crash ("Agent listener invoked outside active run") when a subagent exec tool produces stdout/stderr after the agent run has ended or been aborted. (#62821) Thanks @openperf.
- Browser/tabs: route `/tabs/action` close/select through the same browser endpoint reachability and policy checks as list/new (including Playwright-backed remote tab operations), reject CDP HTTP redirects on probe requests, and sanitize blocked-endpoint error responses so tab list/focus/close flows fail closed without echoing raw policy details back to callers. (#63332)
- Gateway/OpenAI compat: return real `usage` for non-stream `/v1/chat/completions` responses, emit the final usage chunk when `stream_options.include_usage=true`, and bound usage-gated stream finalization after lifecycle end. (#62986) Thanks @Lellansin.
- Matrix/migration: keep packaged warning-only crypto migrations from being misclassified as actionable when only helper chunks are present, so startup and doctor stay on the warning-only path instead of creating unnecessary migration snapshots. (#64373) Thanks @gumadeiras.
- Matrix/ACP thread bindings: preserve canonical room casing and parent conversation routing during ACP session spawn so mixed-case room ids bind correctly from top-level rooms and existing Matrix threads. (#64343) Thanks @gumadeiras.
- Agents/subagents: deduplicate delivered completion announces so retry or re-entry cleanup does not inject duplicate internal-context completion turns into the parent session. (#61525) Thanks @100yenadmin.
- Agents/exec: keep sandboxed `tools.exec.host=auto` sessions from honoring per-call `host=node` or `host=gateway` overrides while a sandbox runtime is active, and stop advertising node routing in that state so exec stays on the sandbox host. (#63880)
- Gateway/restart sentinel: route restart notices only from stored canonical delivery metadata and skip outbound guessing from lossy session keys, avoiding misdelivery on case-sensitive channels like Matrix. (#64391) Thanks @gumadeiras.
- Cron/isolated agent: run scheduled agent turns as non-owner senders so owner-only tools stay unavailable during cron execution. (#63878)
- Voice Call/realtime: reject oversized realtime WebSocket frames before bridge setup so large pre-start payloads cannot crash the gateway. (#63890) Thanks @mmaps.
- Browser/sandbox: gate `/sandbox/novnc` behind bridge auth and stop surfacing sandbox observer URLs in model-visible prompt context. (#63882) Thanks @eleqtrizit.
- Discord/sandbox: include `image` in sandbox media param normalization so Discord event cover images cannot bypass sandbox path rewriting. (#64377) Thanks @mmaps.
- Agents/exec: extend exec completion detection to cover local background exec formats so the owner-downgrade fires correctly for all exec paths. (#64376) Thanks @mmaps.
- Security/dependencies: pin axios to 1.15.0 and add a plugin install dependency denylist that blocks known malicious packages before install. (#63891) Thanks @mmaps.
- Browser/security: apply three-phase interaction navigation guard to pressKey and type(submit) so delayed JS redirects from keypress cannot bypass SSRF policy. (#63889) Thanks @mmaps.
- Browser/security: guard existing-session Chrome MCP interaction routes with SSRF post-checks so delayed navigation from click, type, press, and evaluate cannot bypass the configured policy. (#64370) Thanks @eleqtrizit.
- Browser/security: default browser SSRF policy to strict mode so unconfigured installs block private-network navigation, and align external-content marker span mapping so ZWS-injected boundary spoofs are fully sanitized. (#63885) Thanks @eleqtrizit.
- Browser/security: apply SSRF navigation policy to subframe document navigations so iframe-targeted private-network hops are blocked without quarantining the parent page. (#64371) Thanks @eleqtrizit.
- Hooks/security: mark agent hook system events as untrusted and sanitize hook display names before cron metadata reuse. (#64372) Thanks @eleqtrizit.
- Media/security: honor sender-scoped `toolsBySender` policy for outbound host-media reads so denied senders cannot trigger host file disclosure via attachment hydration. (#64459) Thanks @eleqtrizit.
- Browser/security: reject strict-policy hostname navigation unless the hostname is an explicit allowlist exception or IP literal, and route CDP HTTP discovery through the pinned SSRF fetch path. (#64367) Thanks @eleqtrizit.
- Plugins/ACPX: wrap plugin tools on the MCP bridge with the shared `before_tool_call` handler so block and approval hooks fire consistently across all execution paths. (#63886) Thanks @eleqtrizit.
- Logging/security: redact Gmail watcher `--hook-token` values from startup logging and `logs.tail` output. (#62661) Thanks @eleqtrizit.
- Models/fallback: preserve `/models` selection across transient primary-model failures and config reloads so the fallback chain no longer permanently clobbers a user-chosen model. (#64471) Thanks @hoyyeva.
- Sandbox/security: auto-derive CDP source-range from Docker network gateway and refuse to start the socat relay without one, so peer containers cannot reach CDP unauthenticated. (#61404) Thanks @dims.
- Daemon/launchd: keep `openclaw gateway stop` persistent without uninstalling the macOS LaunchAgent, re-enable it on explicit restart or repair, and harden launchd label handling. (#64447) Thanks @ngutman.
- Agents/Slack: preserve threaded announce delivery when `sessions.list` rows lack stored thread metadata by falling back to the thread id encoded in the session key. (#63143) Thanks @mariosousa-finn.
- Plugins/context engines: preserve `plugins.slots.contextEngine` through normalization and keep explicitly selected workspace context-engine plugins enabled, so loader diagnostics and plugin activation stop dropping that slot selection. (#64192) Thanks @hclsys.
- Heartbeat: stop top-level `interval:` and `prompt:` fields outside the `tasks:` block from bleeding into the last parsed heartbeat task. (#64488) Thanks @Rahulkumar070.
## 2026.4.9
### Changes
@@ -114,6 +196,7 @@ Docs: https://docs.openclaw.ai
- Control UI/models: preserve provider-qualified refs for OpenRouter catalog models whose ids already contain slashes so picker selections submit allowlist-compatible model refs instead of dropping the `openrouter/` prefix. (#63416) Thanks @sallyom.
- Plugin SDK/command auth: split command status builders onto the lightweight `openclaw/plugin-sdk/command-status` subpath while preserving deprecated `command-auth` compatibility exports, so auth-only plugin imports no longer pull status/context warmup into CLI onboarding paths. (#63174) Thanks @hxy91819.
- Wizard/plugin config: coerce integer-typed plugin config fields from interactive text input so integer schema values persist as numbers instead of failing validation. (#63346) Thanks @jalehman.
- Dreaming/narrative: harden request-scoped diary fallback so scheduled dreaming only falls back on the dedicated subagent-runtime error, stop trusting spoofable raw error-code objects, and avoid leaking workspace paths when local fallback writes fail. (#64156) Thanks @mbelinky.
## 2026.4.8
@@ -234,6 +317,9 @@ Docs: https://docs.openclaw.ai
- CLI/tasks: `openclaw tasks cancel` now records operator cancellation for CLI runtime tasks instead of returning "Task runtime does not support cancellation yet", so stuck `running` CLI tasks can be cleared. (#62419) Thanks @neeravmakwana.
- Sessions/context: resolve context window limits using the active provider plus model (not bare model id alone) when persisting session usage, applying inline directives, and sizing memory-flush / preflight compaction thresholds, so duplicate model ids across providers no longer leak the wrong `contextTokens` into the session store or `/status`. (#62472) Thanks @neeravmakwana.
- Channels/setup: exclude workspace shadow entries from channel setup catalog lookups and align trust checks with auto-enable so workspace-scoped overrides no longer bypass the trusted catalog. (`GHSA-82qx-6vj7-p8m2`) Thanks @zsxsoft.
- Reply execution: prefer the active runtime snapshot over stale queued reply config during embedded reply and follow-up execution so SecretRef-backed reply turns stop crashing after secrets have already resolved. (#62693) Thanks @mbelinky.
- Android/manual connect: allow blank port input only for TLS manual gateway endpoints so standard HTTPS Tailscale hosts default to `443` without silently changing cleartext manual connects. (#63134) Thanks @Tyler-RNG.
- Matrix/agents: hide owner-only `set-profile` from embedded agent channel-action discovery so non-owner runs stop advertising profile updates they cannot execute. (#62662) Thanks @eleqtrizit.
## 2026.4.5
@@ -484,7 +570,6 @@ Docs: https://docs.openclaw.ai
- Matrix: avoid failing startup when token auth already knows the user ID but still needs optional device metadata, retry transient auth bootstrap requests, and backfill missing device IDs after startup while keeping unknown-device storage reuse conservative until metadata is repaired. (#61383) Thanks @gumadeiras.
- Agents/exec: stop streaming `tool_execution_update` events after an exec session backgrounds, preventing delayed background output from hitting a stale listener and crashing the gateway while keeping the output available through `process poll/log`. (#61627) Thanks @openperf.
- Matrix: pass configured `deviceId` through health probes and keep probe-only client setup out of durable Matrix storage, so health checks preserve the correct device identity without rewriting `storage-meta.json` or related probe state on disk. (#61581) Thanks @MoerAI.
||||||| parent of b4694a4ac7 (Telegram: add outbound chunker regression coverage)
- Image generation/build: write stable runtime alias files into `dist/` and route provider-auth runtime lookups through those aliases so image-generation providers keep resolving auth/runtime modules after rebuilds instead of crashing on missing hashed chunk files.
- Config/runtime: pin the first successful config load in memory for the running process and refresh that snapshot on successful writes/reloads, so hot paths stop reparsing `openclaw.json` between watcher-driven swaps.
- Config/legacy cleanup: stop probing obsolete alternate legacy config names and service labels during local config/service detection, while keeping the active `~/.openclaw/openclaw.json` path canonical.

View File

@@ -102,6 +102,11 @@ For coordinated change sets that genuinely need more than 10 PRs, join the **#cl
- For targeted shared-surface work, use `pnpm test:contracts:channels` or `pnpm test:contracts:plugins`
- These commands also cover the shared seam/smoke files that the default unit lane skips
- If you changed broader runtime behavior, still run the relevant wider lanes (`pnpm test:extensions`, `pnpm test:channels`, or `pnpm test`) before asking for review
- If you touched bundled-plugin boundaries in shared code, run the matching inventories:
- `node scripts/check-src-extension-import-boundary.mjs --json` for `src/**`
- `node scripts/check-sdk-package-extension-import-boundary.mjs --json` for `src/plugin-sdk/**` and `packages/**`
- `node scripts/check-test-helper-extension-import-boundary.mjs --json` for `test/helpers/**`
- Shared test helpers must use `src/test-utils/bundled-plugin-public-surface.ts` instead of repo-relative `extensions/**` imports. Keep plugin-local deep mocks inside the owning bundled plugin package.
- If you have access to Codex, run `codex review --base origin/main` locally before opening or updating your PR. Treat this as the current highest standard of AI review, even if GitHub Codex review also runs.
- Do not submit refactor-only PRs unless a maintainer explicitly requested that refactor for an active fix or deliverable.
- Do not submit test or CI-config fixes for failures already red on `main` CI. If a failure is already visible in the [main branch CI runs](https://github.com/openclaw/openclaw/actions), it's a known issue the Maintainer team is tracking, and a PR that only addresses those failures will be closed automatically. If you spot a _new_ regression not yet shown in main CI, report it as an issue first.

52
INCIDENT_RESPONSE.md Normal file
View File

@@ -0,0 +1,52 @@
# OpenClaw Incident Response Plan
## 1. Detection and triage
We monitor security signals from:
- GitHub Security Advisories (GHSA) and private vulnerability reports.
- Public GitHub issues/discussions when reports are not sensitive.
- Automated signals (for example Dependabot, CodeQL, npm advisories, and secret scanning).
Initial triage:
1. Confirm affected component, version, and trust boundary impact.
2. Classify as security issue vs hardening/no-action using the repository `SECURITY.md` scope and out-of-scope rules.
3. An incident owner responds accordingly.
## 2. Assessment
Severity guide:
- **Critical:** Package/release/repository compromise, active exploitation, or unauthenticated trust-boundary bypass with high-impact control or data exposure.
- **High:** Verified trust-boundary bypass requiring limited preconditions (for example authenticated but unauthorized high-impact action), or exposure of OpenClaw-owned sensitive credentials.
- **Medium:** Significant security weakness with practical impact but constrained exploitability or substantial prerequisites.
- **Low:** Defense-in-depth findings, narrowly scoped denial-of-service, or hardening/parity gaps without a demonstrated trust-boundary bypass.
## 3. Response
1. Acknowledge receipt to the reporter (private when sensitive).
2. Reproduce on supported releases and latest `main`, then implement and validate a patch with regression coverage.
3. For critical/high incidents, prepare patched release(s) as fast as practical.
4. For medium/low incidents, patch in normal release flow and document mitigation guidance.
## 4. Communication
We communicate through:
- GitHub Security Advisories in the affected repository.
- Release notes/changelog entries for fixed versions.
- Direct reporter follow-up on status and resolution.
Disclosure policy:
- Critical/high incidents should receive coordinated disclosure, with CVE issuance when appropriate.
- Low-risk hardening findings may be documented in release notes or advisories without CVE, depending on impact and user exposure.
## 5. Recovery and follow-up
After shipping the fix:
1. Verify remediations in CI and release artifacts.
2. Run a short post-incident review (timeline, root cause, detection gap, prevention plan).
3. Add follow-up hardening/tests/docs tasks and track them to completion.

View File

@@ -8,6 +8,10 @@
### Fixed
## 2026.4.10 - 2026-04-10
Maintenance update for the current OpenClaw release.
## 2026.4.6 - 2026-04-06
First App Store release of OpenClaw for iPhone. Pair with your OpenClaw Gateway to use chat, voice, sharing, and device actions from iOS.

View File

@@ -2,8 +2,8 @@
// Source of truth: apps/ios/version.json
// Generated by scripts/ios-sync-versioning.ts.
OPENCLAW_IOS_VERSION = 2026.4.6
OPENCLAW_MARKETING_VERSION = 2026.4.6
OPENCLAW_IOS_VERSION = 2026.4.10
OPENCLAW_MARKETING_VERSION = 2026.4.10
OPENCLAW_BUILD_VERSION = 1
#include? "../build/Version.xcconfig"

View File

@@ -1 +1 @@
First App Store release of OpenClaw for iPhone. Pair with your OpenClaw Gateway to use chat, voice, sharing, and device actions from iOS.
Maintenance update for the current OpenClaw release.

View File

@@ -1,3 +1,3 @@
{
"version": "2026.4.6"
"version": "2026.4.10"
}

View File

@@ -8,6 +8,8 @@ struct HostEnvOverrideDiagnostics: Equatable {
enum HostEnvSanitizer {
/// Generated from src/infra/host-env-security-policy.json via scripts/generate-host-env-security-policy-swift.mjs.
/// Parity is validated by src/infra/host-env-security.policy-parity.test.ts.
private static let blockedInheritedKeys = HostEnvSecurityPolicy.blockedInheritedKeys
private static let blockedInheritedPrefixes = HostEnvSecurityPolicy.blockedInheritedPrefixes
private static let blockedKeys = HostEnvSecurityPolicy.blockedKeys
private static let blockedPrefixes = HostEnvSecurityPolicy.blockedPrefixes
private static let blockedOverrideKeys = HostEnvSecurityPolicy.blockedOverrideKeys
@@ -28,6 +30,11 @@ enum HostEnvSanitizer {
return self.blockedPrefixes.contains(where: { upperKey.hasPrefix($0) })
}
private static func isBlockedInherited(_ upperKey: String) -> Bool {
if self.blockedInheritedKeys.contains(upperKey) { return true }
return self.blockedInheritedPrefixes.contains(where: { upperKey.hasPrefix($0) })
}
private static func isBlockedOverride(_ upperKey: String) -> Bool {
if self.blockedOverrideKeys.contains(upperKey) { return true }
return self.blockedOverridePrefixes.contains(where: { upperKey.hasPrefix($0) })
@@ -113,7 +120,7 @@ enum HostEnvSanitizer {
let key = rawKey.trimmingCharacters(in: .whitespacesAndNewlines)
guard !key.isEmpty else { continue }
let upper = key.uppercased()
if self.isBlocked(upper) { continue }
if self.isBlockedInherited(upper) { continue }
merged[key] = value
}

View File

@@ -5,20 +5,232 @@
import Foundation
enum HostEnvSecurityPolicy {
static let blockedInheritedKeys: Set<String> = [
"_JAVA_OPTIONS",
"AMQP_URL",
"ANSIBLE_CALLBACK_PLUGINS",
"ANSIBLE_COLLECTIONS_PATH",
"ANSIBLE_CONFIG",
"ANSIBLE_CONNECTION_PLUGINS",
"ANSIBLE_FILTER_PLUGINS",
"ANSIBLE_INVENTORY_PLUGINS",
"ANSIBLE_LIBRARY",
"ANSIBLE_LOOKUP_PLUGINS",
"ANSIBLE_MODULE_UTILS",
"ANSIBLE_REMOTE_TEMP",
"ANSIBLE_ROLES_PATH",
"ANSIBLE_STRATEGY_PLUGINS",
"ANT_OPTS",
"AWS_ACCESS_KEY_ID",
"AWS_CONTAINER_CREDENTIALS_FULL_URI",
"AWS_CONTAINER_CREDENTIALS_RELATIVE_URI",
"AWS_SECRET_ACCESS_KEY",
"AWS_SECURITY_TOKEN",
"AWS_SESSION_TOKEN",
"AZURE_CLIENT_ID",
"AZURE_CLIENT_SECRET",
"BASH_ENV",
"BROWSER",
"BUN_CONFIG_REGISTRY",
"BUNDLE_GEMFILE",
"BZR_EDITOR",
"BZR_PLUGIN_PATH",
"BZR_SSH",
"C_INCLUDE_PATH",
"CARGO_BUILD_RUSTC",
"CARGO_BUILD_RUSTC_WRAPPER",
"CARGO_HOME",
"CATALINA_OPTS",
"CC",
"CFLAGS",
"CGO_CFLAGS",
"CGO_LDFLAGS",
"CLASSPATH",
"CMAKE_C_COMPILER",
"CMAKE_CXX_COMPILER",
"CMAKE_TOOLCHAIN_FILE",
"COMPOSER_HOME",
"CONFIG_SHELL",
"CONFIG_SITE",
"CORECLR_PROFILER",
"CORECLR_PROFILER_PATH",
"CPATH",
"CPLUS_INCLUDE_PATH",
"CURL_HOME",
"CXX",
"DATABASE_URL",
"DENO_DIR",
"DOTNET_ADDITIONAL_DEPS",
"DOTNET_STARTUP_HOOKS",
"EDITOR",
"ELIXIR_ERL_OPTIONS",
"EMACSLOADPATH",
"ENV",
"ERL_AFLAGS",
"ERL_FLAGS",
"ERL_ZFLAGS",
"EXINIT",
"FCEDIT",
"GCONV_PATH",
"GEM_HOME",
"GEM_PATH",
"GH_TOKEN",
"GIT_ALTERNATE_OBJECT_DIRECTORIES",
"GIT_ASKPASS",
"GIT_COMMON_DIR",
"GIT_DIR",
"GIT_EDITOR",
"GIT_EXEC_PATH",
"GIT_EXTERNAL_DIFF",
"GIT_HOOK_PATH",
"GIT_INDEX_FILE",
"GIT_NAMESPACE",
"GIT_OBJECT_DIRECTORY",
"GIT_PROXY_COMMAND",
"GIT_SEQUENCE_EDITOR",
"GIT_SSH",
"GIT_SSH_COMMAND",
"GIT_SSL_CAINFO",
"GIT_SSL_CAPATH",
"GIT_SSL_NO_VERIFY",
"GIT_TEMPLATE_DIR",
"GIT_WORK_TREE",
"GITHUB_TOKEN",
"GITLAB_TOKEN",
"GLIBC_TUNABLES",
"GOENV",
"GOFLAGS",
"GONOPROXY",
"GONOSUMCHECK",
"GONOSUMDB",
"GOPATH",
"GOPRIVATE",
"GOPROXY",
"GRADLE_OPTS",
"GVIMINIT",
"HELM_HOME",
"HELM_PLUGINS",
"HGRCPATH",
"HOSTALIASES",
"IFS",
"JAVA_OPTS",
"JAVA_TOOL_OPTIONS",
"JDK_JAVA_OPTIONS",
"JULIA_EDITOR",
"LDFLAGS",
"LESSCLOSE",
"LESSOPEN",
"LIBRARY_PATH",
"LUA_CPATH",
"LUA_INIT",
"LUA_INIT_5_1",
"LUA_INIT_5_2",
"LUA_INIT_5_3",
"LUA_INIT_5_4",
"LUA_PATH",
"MAKEFLAGS",
"MAVEN_OPTS",
"MFLAGS",
"MONGODB_URI",
"MYVIMRC",
"NODE_AUTH_TOKEN",
"NODE_OPTIONS",
"NODE_PATH",
"NPM_TOKEN",
"OBJC_INCLUDE_PATH",
"OPENSSL_CONF",
"OPENSSL_ENGINES",
"PACKER_PLUGIN_PATH",
"PERL5DB",
"PERL5DBCMD",
"PERL5LIB",
"PERL5OPT",
"PHP_INI_SCAN_DIR",
"PHPRC",
"PIP_CONFIG_FILE",
"PIP_EXTRA_INDEX_URL",
"PIP_FIND_LINKS",
"PIP_INDEX_URL",
"PIP_PYPI_URL",
"PIP_TRUSTED_HOST",
"PROMPT_COMMAND",
"PS4",
"PYTHONBREAKPOINT",
"PYTHONHOME",
"PYTHONPATH",
"PYTHONSTARTUP",
"PYTHONUSERBASE",
"R_ENVIRON",
"R_ENVIRON_USER",
"R_LIBS_USER",
"R_PROFILE",
"R_PROFILE_USER",
"REDIS_URL",
"RUBYLIB",
"RUBYOPT",
"RUBYSHELL",
"RUSTC_WRAPPER",
"RUSTFLAGS",
"SBT_OPTS",
"SHELL",
"SHELLOPTS",
"SSH_ASKPASS",
"SSLKEYLOGFILE",
"SUDO_ASKPASS",
"SUDO_EDITOR",
"SVN_EDITOR",
"SVN_SSH",
"TF_CLI_CONFIG_FILE",
"TF_PLUGIN_CACHE_DIR",
"UV_DEFAULT_INDEX",
"UV_EXTRA_INDEX_URL",
"UV_INDEX",
"UV_INDEX_URL",
"UV_PYTHON",
"VAGRANT_VAGRANTFILE",
"VIMINIT",
"VIRTUAL_ENV",
"VISUAL",
"WGETRC",
"XDG_CONFIG_DIRS",
"XDG_CONFIG_HOME",
"YARN_RC_FILENAME"
]
static let blockedInheritedPrefixes: [String] = [
"BASH_FUNC_",
"DYLD_",
"LD_"
]
static let blockedKeys: Set<String> = [
"_JAVA_OPTIONS",
"ANT_OPTS",
"BASH_ENV",
"BROWSER",
"BZR_EDITOR",
"BZR_PLUGIN_PATH",
"BZR_SSH",
"CARGO_BUILD_RUSTC",
"CARGO_BUILD_RUSTC_WRAPPER",
"CATALINA_OPTS",
"CC",
"CMAKE_C_COMPILER",
"CMAKE_CXX_COMPILER",
"CMAKE_TOOLCHAIN_FILE",
"CONFIG_SHELL",
"CONFIG_SITE",
"CORECLR_PROFILER",
"CXX",
"DOTNET_ADDITIONAL_DEPS",
"DOTNET_STARTUP_HOOKS",
"ELIXIR_ERL_OPTIONS",
"EMACSLOADPATH",
"ENV",
"ERL_AFLAGS",
"ERL_FLAGS",
"ERL_ZFLAGS",
"EXINIT",
"GCONV_PATH",
"GIT_ALTERNATE_OBJECT_DIRECTORIES",
"GIT_COMMON_DIR",
@@ -26,6 +238,7 @@ enum HostEnvSecurityPolicy {
"GIT_EDITOR",
"GIT_EXEC_PATH",
"GIT_EXTERNAL_DIFF",
"GIT_HOOK_PATH",
"GIT_INDEX_FILE",
"GIT_NAMESPACE",
"GIT_OBJECT_DIRECTORY",
@@ -37,42 +250,85 @@ enum HostEnvSecurityPolicy {
"GIT_WORK_TREE",
"GLIBC_TUNABLES",
"GRADLE_OPTS",
"GVIMINIT",
"HELM_PLUGINS",
"HGRCPATH",
"HOSTALIASES",
"IFS",
"JAVA_OPTS",
"JAVA_TOOL_OPTIONS",
"JDK_JAVA_OPTIONS",
"JULIA_EDITOR",
"LUA_INIT",
"LUA_INIT_5_1",
"LUA_INIT_5_2",
"LUA_INIT_5_3",
"LUA_INIT_5_4",
"MAKEFLAGS",
"MAVEN_OPTS",
"MFLAGS",
"MYVIMRC",
"NODE_OPTIONS",
"NODE_PATH",
"PACKER_PLUGIN_PATH",
"PERL5LIB",
"PERL5OPT",
"PS4",
"PYTHONBREAKPOINT",
"PYTHONHOME",
"PYTHONPATH",
"R_ENVIRON",
"R_ENVIRON_USER",
"R_PROFILE",
"R_PROFILE_USER",
"RUBYLIB",
"RUBYOPT",
"RUBYSHELL",
"RUSTC_WRAPPER",
"SBT_OPTS",
"SHELL",
"SHELLOPTS",
"SSLKEYLOGFILE"
"SSLKEYLOGFILE",
"SUDO_ASKPASS",
"SVN_EDITOR",
"SVN_SSH",
"VAGRANT_VAGRANTFILE",
"VIMINIT"
]
static let blockedOverrideKeys: Set<String> = [
"ALL_PROXY",
"AMQP_URL",
"ANSIBLE_CALLBACK_PLUGINS",
"ANSIBLE_COLLECTIONS_PATH",
"ANSIBLE_CONFIG",
"ANSIBLE_CONNECTION_PLUGINS",
"ANSIBLE_FILTER_PLUGINS",
"ANSIBLE_INVENTORY_PLUGINS",
"ANSIBLE_LIBRARY",
"ANSIBLE_LOOKUP_PLUGINS",
"ANSIBLE_MODULE_UTILS",
"ANSIBLE_REMOTE_TEMP",
"ANSIBLE_ROLES_PATH",
"ANSIBLE_STRATEGY_PLUGINS",
"AWS_ACCESS_KEY_ID",
"AWS_CONFIG_FILE",
"AWS_CONTAINER_CREDENTIALS_FULL_URI",
"AWS_CONTAINER_CREDENTIALS_RELATIVE_URI",
"AWS_SECRET_ACCESS_KEY",
"AWS_SECURITY_TOKEN",
"AWS_SESSION_TOKEN",
"AWS_SHARED_CREDENTIALS_FILE",
"AWS_WEB_IDENTITY_TOKEN_FILE",
"AZURE_AUTH_LOCATION",
"AZURE_CLIENT_ID",
"AZURE_CLIENT_SECRET",
"BUN_CONFIG_REGISTRY",
"BUNDLE_GEMFILE",
"C_INCLUDE_PATH",
"CARGO_BUILD_RUSTC_WRAPPER",
"CARGO_HOME",
"CFLAGS",
"CGO_CFLAGS",
"CGO_LDFLAGS",
"CLASSPATH",
@@ -82,6 +338,7 @@ enum HostEnvSecurityPolicy {
"CPLUS_INCLUDE_PATH",
"CURL_CA_BUNDLE",
"CURL_HOME",
"DATABASE_URL",
"DENO_DIR",
"DOCKER_CERT_PATH",
"DOCKER_CONTEXT",
@@ -91,6 +348,7 @@ enum HostEnvSecurityPolicy {
"FCEDIT",
"GEM_HOME",
"GEM_PATH",
"GH_TOKEN",
"GIT_ALTERNATE_OBJECT_DIRECTORIES",
"GIT_ASKPASS",
"GIT_COMMON_DIR",
@@ -106,6 +364,8 @@ enum HostEnvSecurityPolicy {
"GIT_SSL_CAPATH",
"GIT_SSL_NO_VERIFY",
"GIT_WORK_TREE",
"GITHUB_TOKEN",
"GITLAB_TOKEN",
"GOENV",
"GOFLAGS",
"GONOPROXY",
@@ -123,6 +383,7 @@ enum HostEnvSecurityPolicy {
"HTTP_PROXY",
"HTTPS_PROXY",
"KUBECONFIG",
"LDFLAGS",
"LESSCLOSE",
"LESSOPEN",
"LIBRARY_PATH",
@@ -131,9 +392,12 @@ enum HostEnvSecurityPolicy {
"MAKEFLAGS",
"MANPAGER",
"MFLAGS",
"MONGODB_URI",
"NO_PROXY",
"NODE_AUTH_TOKEN",
"NODE_EXTRA_CA_CERTS",
"NODE_TLS_REJECT_UNAUTHORIZED",
"NPM_TOKEN",
"OBJC_INCLUDE_PATH",
"OPENSSL_CONF",
"OPENSSL_ENGINES",
@@ -151,13 +415,18 @@ enum HostEnvSecurityPolicy {
"PROMPT_COMMAND",
"PYTHONSTARTUP",
"PYTHONUSERBASE",
"R_LIBS_USER",
"REDIS_URL",
"REQUESTS_CA_BUNDLE",
"RUSTC_WRAPPER",
"RUSTFLAGS",
"SSH_ASKPASS",
"SSH_AUTH_SOCK",
"SSL_CERT_DIR",
"SSL_CERT_FILE",
"SUDO_EDITOR",
"TF_CLI_CONFIG_FILE",
"TF_PLUGIN_CACHE_DIR",
"UV_DEFAULT_INDEX",
"UV_EXTRA_INDEX_URL",
"UV_INDEX",
@@ -166,6 +435,7 @@ enum HostEnvSecurityPolicy {
"VIRTUAL_ENV",
"VISUAL",
"WGETRC",
"XDG_CONFIG_DIRS",
"XDG_CONFIG_HOME",
"YARN_RC_FILENAME",
"ZDOTDIR"
@@ -174,7 +444,8 @@ enum HostEnvSecurityPolicy {
static let blockedOverridePrefixes: [String] = [
"CARGO_REGISTRIES_",
"GIT_CONFIG_",
"NPM_CONFIG_"
"NPM_CONFIG_",
"TF_VAR_"
]
static let blockedPrefixes: [String] = [

View File

@@ -2510,17 +2510,20 @@ public struct AgentSummary: Codable, Sendable {
public struct AgentsCreateParams: Codable, Sendable {
public let name: String
public let workspace: String
public let model: String?
public let emoji: String?
public let avatar: String?
public init(
name: String,
workspace: String,
model: String?,
emoji: String?,
avatar: String?)
{
self.name = name
self.workspace = workspace
self.model = model
self.emoji = emoji
self.avatar = avatar
}
@@ -2528,6 +2531,7 @@ public struct AgentsCreateParams: Codable, Sendable {
private enum CodingKeys: String, CodingKey {
case name
case workspace
case model
case emoji
case avatar
}
@@ -2538,17 +2542,20 @@ public struct AgentsCreateResult: Codable, Sendable {
public let agentid: String
public let name: String
public let workspace: String
public let model: String?
public init(
ok: Bool,
agentid: String,
name: String,
workspace: String)
workspace: String,
model: String?)
{
self.ok = ok
self.agentid = agentid
self.name = name
self.workspace = workspace
self.model = model
}
private enum CodingKeys: String, CodingKey {
@@ -2556,6 +2563,7 @@ public struct AgentsCreateResult: Codable, Sendable {
case agentid = "agentId"
case name
case workspace
case model
}
}
@@ -2564,6 +2572,7 @@ public struct AgentsUpdateParams: Codable, Sendable {
public let name: String?
public let workspace: String?
public let model: String?
public let emoji: String?
public let avatar: String?
public init(
@@ -2571,12 +2580,14 @@ public struct AgentsUpdateParams: Codable, Sendable {
name: String?,
workspace: String?,
model: String?,
emoji: String?,
avatar: String?)
{
self.agentid = agentid
self.name = name
self.workspace = workspace
self.model = model
self.emoji = emoji
self.avatar = avatar
}
@@ -2585,6 +2596,7 @@ public struct AgentsUpdateParams: Codable, Sendable {
case name
case workspace
case model
case emoji
case avatar
}
}
@@ -2883,6 +2895,92 @@ public struct ModelsListResult: Codable, Sendable {
}
}
public struct CommandEntry: Codable, Sendable {
public let name: String
public let nativename: String?
public let textaliases: [String]?
public let description: String
public let category: AnyCodable?
public let source: AnyCodable
public let scope: AnyCodable
public let acceptsargs: Bool
public let args: [[String: AnyCodable]]?
public init(
name: String,
nativename: String?,
textaliases: [String]?,
description: String,
category: AnyCodable?,
source: AnyCodable,
scope: AnyCodable,
acceptsargs: Bool,
args: [[String: AnyCodable]]?)
{
self.name = name
self.nativename = nativename
self.textaliases = textaliases
self.description = description
self.category = category
self.source = source
self.scope = scope
self.acceptsargs = acceptsargs
self.args = args
}
private enum CodingKeys: String, CodingKey {
case name
case nativename = "nativeName"
case textaliases = "textAliases"
case description
case category
case source
case scope
case acceptsargs = "acceptsArgs"
case args
}
}
public struct CommandsListParams: Codable, Sendable {
public let agentid: String?
public let provider: String?
public let scope: AnyCodable?
public let includeargs: Bool?
public init(
agentid: String?,
provider: String?,
scope: AnyCodable?,
includeargs: Bool?)
{
self.agentid = agentid
self.provider = provider
self.scope = scope
self.includeargs = includeargs
}
private enum CodingKeys: String, CodingKey {
case agentid = "agentId"
case provider
case scope
case includeargs = "includeArgs"
}
}
public struct CommandsListResult: Codable, Sendable {
public let commands: [CommandEntry]
public init(
commands: [CommandEntry])
{
self.commands = commands
}
private enum CodingKeys: String, CodingKey {
case commands
}
}
public struct SkillsStatusParams: Codable, Sendable {
public let agentid: String?
@@ -4174,6 +4272,7 @@ public struct ChatEvent: Codable, Sendable {
public let state: AnyCodable
public let message: AnyCodable?
public let errormessage: String?
public let errorkind: AnyCodable?
public let usage: AnyCodable?
public let stopreason: String?
@@ -4184,6 +4283,7 @@ public struct ChatEvent: Codable, Sendable {
state: AnyCodable,
message: AnyCodable?,
errormessage: String?,
errorkind: AnyCodable?,
usage: AnyCodable?,
stopreason: String?)
{
@@ -4193,6 +4293,7 @@ public struct ChatEvent: Codable, Sendable {
self.state = state
self.message = message
self.errormessage = errormessage
self.errorkind = errorkind
self.usage = usage
self.stopreason = stopreason
}
@@ -4204,6 +4305,7 @@ public struct ChatEvent: Codable, Sendable {
case state
case message
case errormessage = "errorMessage"
case errorkind = "errorKind"
case usage
case stopreason = "stopReason"
}

View File

@@ -2510,17 +2510,20 @@ public struct AgentSummary: Codable, Sendable {
public struct AgentsCreateParams: Codable, Sendable {
public let name: String
public let workspace: String
public let model: String?
public let emoji: String?
public let avatar: String?
public init(
name: String,
workspace: String,
model: String?,
emoji: String?,
avatar: String?)
{
self.name = name
self.workspace = workspace
self.model = model
self.emoji = emoji
self.avatar = avatar
}
@@ -2528,6 +2531,7 @@ public struct AgentsCreateParams: Codable, Sendable {
private enum CodingKeys: String, CodingKey {
case name
case workspace
case model
case emoji
case avatar
}
@@ -2538,17 +2542,20 @@ public struct AgentsCreateResult: Codable, Sendable {
public let agentid: String
public let name: String
public let workspace: String
public let model: String?
public init(
ok: Bool,
agentid: String,
name: String,
workspace: String)
workspace: String,
model: String?)
{
self.ok = ok
self.agentid = agentid
self.name = name
self.workspace = workspace
self.model = model
}
private enum CodingKeys: String, CodingKey {
@@ -2556,6 +2563,7 @@ public struct AgentsCreateResult: Codable, Sendable {
case agentid = "agentId"
case name
case workspace
case model
}
}
@@ -2564,6 +2572,7 @@ public struct AgentsUpdateParams: Codable, Sendable {
public let name: String?
public let workspace: String?
public let model: String?
public let emoji: String?
public let avatar: String?
public init(
@@ -2571,12 +2580,14 @@ public struct AgentsUpdateParams: Codable, Sendable {
name: String?,
workspace: String?,
model: String?,
emoji: String?,
avatar: String?)
{
self.agentid = agentid
self.name = name
self.workspace = workspace
self.model = model
self.emoji = emoji
self.avatar = avatar
}
@@ -2585,6 +2596,7 @@ public struct AgentsUpdateParams: Codable, Sendable {
case name
case workspace
case model
case emoji
case avatar
}
}
@@ -2883,6 +2895,92 @@ public struct ModelsListResult: Codable, Sendable {
}
}
public struct CommandEntry: Codable, Sendable {
public let name: String
public let nativename: String?
public let textaliases: [String]?
public let description: String
public let category: AnyCodable?
public let source: AnyCodable
public let scope: AnyCodable
public let acceptsargs: Bool
public let args: [[String: AnyCodable]]?
public init(
name: String,
nativename: String?,
textaliases: [String]?,
description: String,
category: AnyCodable?,
source: AnyCodable,
scope: AnyCodable,
acceptsargs: Bool,
args: [[String: AnyCodable]]?)
{
self.name = name
self.nativename = nativename
self.textaliases = textaliases
self.description = description
self.category = category
self.source = source
self.scope = scope
self.acceptsargs = acceptsargs
self.args = args
}
private enum CodingKeys: String, CodingKey {
case name
case nativename = "nativeName"
case textaliases = "textAliases"
case description
case category
case source
case scope
case acceptsargs = "acceptsArgs"
case args
}
}
public struct CommandsListParams: Codable, Sendable {
public let agentid: String?
public let provider: String?
public let scope: AnyCodable?
public let includeargs: Bool?
public init(
agentid: String?,
provider: String?,
scope: AnyCodable?,
includeargs: Bool?)
{
self.agentid = agentid
self.provider = provider
self.scope = scope
self.includeargs = includeargs
}
private enum CodingKeys: String, CodingKey {
case agentid = "agentId"
case provider
case scope
case includeargs = "includeArgs"
}
}
public struct CommandsListResult: Codable, Sendable {
public let commands: [CommandEntry]
public init(
commands: [CommandEntry])
{
self.commands = commands
}
private enum CodingKeys: String, CodingKey {
case commands
}
}
public struct SkillsStatusParams: Codable, Sendable {
public let agentid: String?
@@ -4174,6 +4272,7 @@ public struct ChatEvent: Codable, Sendable {
public let state: AnyCodable
public let message: AnyCodable?
public let errormessage: String?
public let errorkind: AnyCodable?
public let usage: AnyCodable?
public let stopreason: String?
@@ -4184,6 +4283,7 @@ public struct ChatEvent: Codable, Sendable {
state: AnyCodable,
message: AnyCodable?,
errormessage: String?,
errorkind: AnyCodable?,
usage: AnyCodable?,
stopreason: String?)
{
@@ -4193,6 +4293,7 @@ public struct ChatEvent: Codable, Sendable {
self.state = state
self.message = message
self.errormessage = errormessage
self.errorkind = errorkind
self.usage = usage
self.stopreason = stopreason
}
@@ -4204,6 +4305,7 @@ public struct ChatEvent: Codable, Sendable {
case state
case message
case errormessage = "errorMessage"
case errorkind = "errorKind"
case usage
case stopreason = "stopReason"
}

View File

@@ -1,4 +1,4 @@
0a75b57f5dbb0bb1488eacb47111ee22ff42dd3747bfe07bb69c9445d5e55c3e config-baseline.json
ff15bb8b4231fc80174249ae89bcb61439d7adda5ee6be95e4d304680253a59f config-baseline.core.json
7f42b22b46c487d64aaac46001ba9d9096cf7bf0b1c263a54d39946303ff5018 config-baseline.channel.json
483d4f3c1d516719870ad6f2aba6779b9950f85471ee77b9994a077a7574a892 config-baseline.plugin.json
1977d4698bb80b9aa99315f1114a61b5692bd5630f2ac4a225d81ddc5459d588 config-baseline.json
d1ee5c4d01deac5cf8ea284cafcd8b6c952b2554d40947d2463d08e314acfcda config-baseline.core.json
e1f94346a8507ce3dec763b598e79f3bb89ff2e33189ce977cc87d3b05e71c1d config-baseline.channel.json
0fb10e5cb00e7da2cd07c959e0e3397ecb2fdcf15e13a7eae06a2c5b2346bb10 config-baseline.plugin.json

View File

@@ -1,2 +1,2 @@
087dc7fe9759330c953a00130ea20242b3d7f460eaa530d631cfb2a9f96e0370 plugin-sdk-api-baseline.json
a84765a726e0493dc87d2799020fd454407b1fe2c4d3ad69e8c3cc3a0cde834b plugin-sdk-api-baseline.jsonl
2256ba1237c3608ca981bce3a7c66b6880b12d05025f260d5c086b69038f408b plugin-sdk-api-baseline.json
6360529513280140c122020466f0821a9acc83aba64612cf90656c2af0261ab3 plugin-sdk-api-baseline.jsonl

View File

@@ -43,6 +43,8 @@ together`, and similar hints) and no descendant subagent run is still
responsible for the final answer, OpenClaw re-prompts once for the actual
result before delivery.
<a id="maintenance"></a>
Task reconciliation for cron is runtime-owned: an active cron task stays live while the
cron runtime still tracks that job as running, even if an old child session row still exists.
Once the runtime stops owning the job and the 5-minute grace window expires, maintenance can

View File

@@ -164,10 +164,14 @@ Enable any bundled hook:
openclaw hooks enable <hook-name>
```
<a id="session-memory"></a>
### session-memory details
Extracts the last 15 user/assistant messages, generates a descriptive filename slug via LLM, and saves to `<workspace>/memory/YYYY-MM-DD-slug.md`. Requires `workspace.dir` to be configured.
<a id="bootstrap-extra-files"></a>
### bootstrap-extra-files config
```json
@@ -187,6 +191,18 @@ Extracts the last 15 user/assistant messages, generates a descriptive filename s
Paths resolve relative to workspace. Only recognized bootstrap basenames are loaded (`AGENTS.md`, `SOUL.md`, `TOOLS.md`, `IDENTITY.md`, `USER.md`, `HEARTBEAT.md`, `BOOTSTRAP.md`, `MEMORY.md`).
<a id="command-logger"></a>
### command-logger details
Logs every slash command to `~/.openclaw/logs/commands.log`.
<a id="boot-md"></a>
### boot-md details
Runs `BOOT.md` from the active workspace when the gateway starts.
## Plugin hooks
Plugins can register hooks through the Plugin SDK for deeper integration: intercepting tool calls, modifying prompts, controlling message flow, and more. The Plugin SDK exposes 28 hooks covering model resolution, agent lifecycle, message flow, tool execution, subagent coordination, and gateway lifecycle.

View File

@@ -12,24 +12,25 @@ The CI runs on every push to `main` and every pull request. It uses smart scopin
## Job Overview
| Job | Purpose | When it runs |
| ------------------------ | ---------------------------------------------------------------------------------------- | ----------------------------------- |
| `preflight` | Detect docs-only changes, changed scopes, changed extensions, and build the CI manifest | Always on non-draft pushes and PRs |
| `security-fast` | Private key detection, workflow audit via `zizmor`, production dependency audit | Always on non-draft pushes and PRs |
| `build-artifacts` | Build `dist/` and the Control UI once, upload reusable artifacts for downstream jobs | Node-relevant changes |
| `checks-fast-core` | Fast Linux correctness lanes such as bundled/plugin-contract/protocol checks | Node-relevant changes |
| `checks-fast-extensions` | Aggregate the extension shard lanes after `checks-fast-extensions-shard` completes | Node-relevant changes |
| `extension-fast` | Focused tests for only the changed bundled plugins | When extension changes are detected |
| `check` | Main local gate in CI: `pnpm check` plus `pnpm build:strict-smoke` | Node-relevant changes |
| `check-additional` | Architecture, boundary, import-cycle guards plus the gateway watch regression harness | Node-relevant changes |
| `build-smoke` | Built-CLI smoke tests and startup-memory smoke | Node-relevant changes |
| `checks` | Heavier Linux Node lanes: full tests, channel tests, and push-only Node 22 compatibility | Node-relevant changes |
| `check-docs` | Docs formatting, lint, and broken-link checks | Docs changed |
| `skills-python` | Ruff + pytest for Python-backed skills | Python-skill-relevant changes |
| `checks-windows` | Windows-specific test lanes | Windows-relevant changes |
| `macos-node` | macOS TypeScript test lane using the shared built artifacts | macOS-relevant changes |
| `macos-swift` | Swift lint, build, and tests for the macOS app | macOS-relevant changes |
| `android` | Android build and test matrix | Android-relevant changes |
| Job | Purpose | When it runs |
| ------------------------ | --------------------------------------------------------------------------------------- | ----------------------------------- |
| `preflight` | Detect docs-only changes, changed scopes, changed extensions, and build the CI manifest | Always on non-draft pushes and PRs |
| `security-fast` | Private key detection, workflow audit via `zizmor`, production dependency audit | Always on non-draft pushes and PRs |
| `build-artifacts` | Build `dist/` and the Control UI once, upload reusable artifacts for downstream jobs | Node-relevant changes |
| `checks-fast-core` | Fast Linux correctness lanes such as bundled/plugin-contract/protocol checks | Node-relevant changes |
| `checks-node-extensions` | Full bundled-plugin test shards across the extension suite | Node-relevant changes |
| `checks-node-core-test` | Core Node test shards, excluding channel, bundled, contract, and extension lanes | Node-relevant changes |
| `extension-fast` | Focused tests for only the changed bundled plugins | When extension changes are detected |
| `check` | Main local gate in CI: `pnpm check` plus `pnpm build:strict-smoke` | Node-relevant changes |
| `check-additional` | Architecture, boundary, import-cycle guards plus the gateway watch regression harness | Node-relevant changes |
| `build-smoke` | Built-CLI smoke tests and startup-memory smoke | Node-relevant changes |
| `checks` | Remaining Linux Node lanes: channel tests and push-only Node 22 compatibility | Node-relevant changes |
| `check-docs` | Docs formatting, lint, and broken-link checks | Docs changed |
| `skills-python` | Ruff + pytest for Python-backed skills | Python-skill-relevant changes |
| `checks-windows` | Windows-specific test lanes | Windows-relevant changes |
| `macos-node` | macOS TypeScript test lane using the shared built artifacts | macOS-relevant changes |
| `macos-swift` | Swift lint, build, and tests for the macOS app | macOS-relevant changes |
| `android` | Android build and test matrix | Android-relevant changes |
## Fail-Fast Order
@@ -38,7 +39,7 @@ Jobs are ordered so cheap checks fail before expensive ones run:
1. `preflight` decides which lanes exist at all. The `docs-scope` and `changed-scope` logic are steps inside this job, not standalone jobs.
2. `security-fast`, `check`, `check-additional`, `check-docs`, and `skills-python` fail quickly without waiting on the heavier artifact and platform matrix jobs.
3. `build-artifacts` overlaps with the fast Linux lanes so downstream consumers can start as soon as the shared build is ready.
4. Heavier platform and runtime lanes fan out after that: `checks-fast-core`, `checks-fast-extensions`, `extension-fast`, `checks`, `checks-windows`, `macos-node`, `macos-swift`, and `android`.
4. Heavier platform and runtime lanes fan out after that: `checks-fast-core`, `checks-node-extensions`, `checks-node-core-test`, `extension-fast`, `checks`, `checks-windows`, `macos-node`, `macos-swift`, and `android`.
Scope logic lives in `scripts/ci-changed-scope.mjs` and is covered by unit tests in `src/scripts/ci-changed-scope.test.ts`.
The separate `install-smoke` workflow reuses the same scope script through its own `preflight` job. It computes `run_install_smoke` from the narrower changed-smoke signal, so Docker/install smoke only runs for install, packaging, and container-relevant changes.

View File

@@ -37,7 +37,7 @@ Use routing bindings to pin inbound channel traffic to a specific agent.
If you also want different visible skills per agent, configure
`agents.defaults.skills` and `agents.list[].skills` in `openclaw.json`. See
[Skills config](/tools/skills-config) and
[Configuration Reference](/gateway/configuration-reference#agentsdefaultsskills).
[Configuration Reference](/gateway/configuration-reference#agents-defaults-skills).
List bindings:

View File

@@ -1,5 +1,5 @@
---
summary: "CLI reference for `openclaw approvals` (exec approvals for gateway or node hosts)"
summary: "CLI reference for `openclaw approvals` and `openclaw exec-policy`"
read_when:
- You want to edit exec approvals from the CLI
- You need to manage allowlists on gateway or node hosts
@@ -18,6 +18,45 @@ Related:
- Exec approvals: [Exec approvals](/tools/exec-approvals)
- Nodes: [Nodes](/nodes)
## `openclaw exec-policy`
`openclaw exec-policy` is the local convenience command for keeping the requested
`tools.exec.*` config and the local host approvals file aligned in one step.
Use it when you want to:
- inspect the local requested policy, host approvals file, and effective merge
- apply a local preset such as YOLO or deny-all
- synchronize local `tools.exec.*` and local `~/.openclaw/exec-approvals.json`
Examples:
```bash
openclaw exec-policy show
openclaw exec-policy show --json
openclaw exec-policy preset yolo
openclaw exec-policy preset cautious --json
openclaw exec-policy set --host gateway --security full --ask off --ask-fallback full
```
Output modes:
- no `--json`: prints the human-readable table view
- `--json`: prints machine-readable structured output
Current scope:
- `exec-policy` is **local-only**
- it updates the local config file and the local approvals file together
- it does **not** push policy to the gateway host or a node host
- `--host node` is rejected in this command because node exec approvals are fetched from the node at runtime and must be managed through node-targeted approvals commands instead
- `openclaw exec-policy show` marks `host=node` scopes as node-managed at runtime instead of deriving an effective policy from the local approvals file
If you need to edit remote host approvals directly, keep using `openclaw approvals set --gateway`
or `openclaw approvals set --node <id|name|ip>`.
## Common commands
```bash
@@ -100,6 +139,16 @@ Why `tools.exec.host=gateway` in this example:
This matches the current host-default YOLO behavior. Tighten it if you want approvals.
Local shortcut:
```bash
openclaw exec-policy preset yolo
```
That local shortcut updates both the requested local `tools.exec.*` config and the
local approvals defaults together. It is equivalent in intent to the manual two-step
setup above, but only for the local machine.
## Allowlist helpers
```bash

View File

@@ -151,7 +151,7 @@ See [Plugin hooks](/plugins/architecture#provider-runtime-hooks) for the hook AP
- `agent.wait` default: 30s (just the wait). `timeoutMs` param overrides.
- Agent runtime: `agents.defaults.timeoutSeconds` default 172800s (48 hours); enforced in `runEmbeddedPiAgent` abort timer.
- LLM idle timeout: `agents.defaults.llm.idleTimeoutSeconds` aborts a model request when no response chunks arrive before the idle window. Set it explicitly for slow local models or reasoning/tool-call providers; set it to 0 to disable. If it is not set, OpenClaw uses `agents.defaults.timeoutSeconds` when configured, otherwise 60s. Cron-triggered runs with no explicit LLM or agent timeout disable the idle watchdog and rely on the cron outer timeout.
- LLM idle timeout: `agents.defaults.llm.idleTimeoutSeconds` aborts a model request when no response chunks arrive before the idle window. Set it explicitly for slow local models or reasoning/tool-call providers; set it to 0 to disable. If it is not set, OpenClaw uses `agents.defaults.timeoutSeconds` when configured, otherwise 120s. Cron-triggered runs with no explicit LLM or agent timeout disable the idle watchdog and rely on the cron outer timeout.
## Where things can end early

View File

@@ -50,6 +50,13 @@ For model selection rules, see [/concepts/models](/concepts/models).
family, transcript/tooling quirks, transport/cache hints). It is not the
same as the [public capability model](/plugins/architecture#public-capability-model)
which describes what a plugin registers (text inference, speech, etc.).
- The bundled `codex` provider is paired with the bundled Codex agent harness.
Use `codex/gpt-*` when you want Codex-owned login, model discovery, native
thread resume, and app-server execution. Plain `openai/gpt-*` refs continue
to use the OpenAI provider and the normal OpenClaw provider transport.
Codex-only deployments can disable automatic PI fallback with
`agents.defaults.embeddedHarness.fallback: "none"`; see
[Codex Harness](/plugins/codex-harness).
## Plugin-owned provider behavior

View File

@@ -62,6 +62,10 @@ This boots a fresh Multipass guest, installs dependencies, builds OpenClaw
inside the guest, runs `qa suite`, then copies the normal QA report and
summary back into `.artifacts/qa-e2e/...` on the host.
It reuses the same scenario-selection behavior as `qa suite` on the host.
Host and Multipass suite runs execute multiple selected scenarios in parallel
with isolated gateway workers by default, up to 64 workers or the selected
scenario count. Use `--concurrency <count>` to tune the worker count, or
`--concurrency 1` for serial execution.
Live runs forward the supported QA auth inputs that are practical for the
guest: env-based provider keys, the QA live provider config path, and
`CODEX_HOME` when present. Keep `--output-dir` under the repo root so the guest

View File

@@ -1074,6 +1074,7 @@
"concepts/memory-qmd",
"concepts/memory-honcho",
"concepts/memory-search",
"concepts/active-memory",
"concepts/dreaming"
]
},
@@ -1112,6 +1113,7 @@
"tools/plugin",
"plugins/community",
"plugins/bundles",
"plugins/codex-harness",
"plugins/webhooks",
"plugins/voice-call",
{
@@ -1129,6 +1131,7 @@
"plugins/sdk-overview",
"plugins/sdk-entrypoints",
"plugins/sdk-runtime",
"plugins/sdk-agent-harness",
"plugins/sdk-setup",
"plugins/sdk-testing",
"plugins/manifest",

View File

@@ -159,6 +159,14 @@ model_instructions_file="..."`). Codex does not expose a Claude-style
`--append-system-prompt` flag, so OpenClaw writes the assembled prompt to a
temporary file for each fresh Codex CLI session.
The bundled Anthropic `claude-cli` backend receives the OpenClaw skills snapshot
two ways: the compact OpenClaw skills catalog in the appended system prompt, and
a temporary Claude Code plugin passed with `--plugin-dir`. The plugin contains
only the eligible skills for that agent/session, so Claude Code's native skill
resolver sees the same filtered set that OpenClaw would otherwise advertise in
the prompt. Skill env/API key overrides are still applied by OpenClaw to the
child process environment for the run.
## Sessions
- If the CLI supports sessions, set `sessionArg` (e.g. `--session-id`) or

View File

@@ -1053,6 +1053,10 @@ Time format in system prompt. Default: `auto` (OS preference).
fallbacks: ["openai/gpt-5.4-mini"],
},
params: { cacheRetention: "long" }, // global default provider params
embeddedHarness: {
runtime: "auto", // auto | pi | registered harness id, e.g. codex
fallback: "pi", // pi | none
},
pdfMaxBytesMb: 10,
pdfMaxPages: 20,
thinkingDefault: "low",
@@ -1100,9 +1104,37 @@ Time format in system prompt. Default: `auto` (OS preference).
- `models`: the configured model catalog and allowlist for `/model`. Each entry can include `alias` (shortcut) and `params` (provider-specific, for example `temperature`, `maxTokens`, `cacheRetention`, `context1m`).
- `params`: global default provider parameters applied to all models. Set at `agents.defaults.params` (e.g. `{ cacheRetention: "long" }`).
- `params` merge precedence (config): `agents.defaults.params` (global base) is overridden by `agents.defaults.models["provider/model"].params` (per-model), then `agents.list[].params` (matching agent id) overrides by key. See [Prompt Caching](/reference/prompt-caching) for details.
- `embeddedHarness`: default low-level embedded agent runtime policy. Use `runtime: "auto"` to let registered plugin harnesses claim supported models, `runtime: "pi"` to force the built-in PI harness, or a registered harness id such as `runtime: "codex"`. Set `fallback: "none"` to disable automatic PI fallback.
- Config writers that mutate these fields (for example `/models set`, `/models set-image`, and fallback add/remove commands) save canonical object form and preserve existing fallback lists when possible.
- `maxConcurrent`: max parallel agent runs across sessions (each session still serialized). Default: 4.
### `agents.defaults.embeddedHarness`
`embeddedHarness` controls which low-level executor runs embedded agent turns.
Most deployments should keep the default `{ runtime: "auto", fallback: "pi" }`.
Use it when a trusted plugin provides a native harness, such as the bundled
Codex app-server harness.
```json5
{
agents: {
defaults: {
model: "codex/gpt-5.4",
embeddedHarness: {
runtime: "codex",
fallback: "none",
},
},
},
}
```
- `runtime`: `"auto"`, `"pi"`, or a registered plugin harness id. The bundled Codex plugin registers `codex`.
- `fallback`: `"pi"` or `"none"`. `"pi"` keeps the built-in PI harness as the compatibility fallback. `"none"` makes missing or unsupported plugin harness selection fail instead of silently using PI.
- Environment overrides: `OPENCLAW_AGENT_RUNTIME=<id|auto|pi>` overrides `runtime`; `OPENCLAW_AGENT_HARNESS_FALLBACK=none` disables PI fallback for that process.
- For Codex-only deployments, set `model: "codex/gpt-5.4"`, `embeddedHarness.runtime: "codex"`, and `embeddedHarness.fallback: "none"`.
- This only controls the embedded chat harness. Media generation, vision, PDF, music, video, and TTS still use their provider/model settings.
**Built-in alias shorthands** (only apply when the model is in `agents.defaults.models`):
| Alias | Model |
@@ -1583,6 +1615,7 @@ scripts/sandbox-browser-setup.sh # optional browser image
thinkingDefault: "high", // per-agent thinking level override
reasoningDefault: "on", // per-agent reasoning visibility override
fastModeDefault: false, // per-agent fast mode override
embeddedHarness: { runtime: "auto", fallback: "pi" },
params: { cacheRetention: "none" }, // overrides matching defaults.models params by key
skills: ["docs-search"], // replaces agents.defaults.skills when set
identity: {
@@ -1623,6 +1656,7 @@ scripts/sandbox-browser-setup.sh # optional browser image
- `thinkingDefault`: optional per-agent default thinking level (`off | minimal | low | medium | high | xhigh | adaptive`). Overrides `agents.defaults.thinkingDefault` for this agent when no per-message or session override is set.
- `reasoningDefault`: optional per-agent default reasoning visibility (`on | off | stream`). Applies when no per-message or session reasoning override is set.
- `fastModeDefault`: optional per-agent default for fast mode (`true | false`). Applies when no per-message or session fast-mode override is set.
- `embeddedHarness`: optional per-agent low-level harness policy override. Use `{ runtime: "codex", fallback: "none" }` to make one agent Codex-only while other agents keep the default PI fallback.
- `runtime`: optional per-agent runtime descriptor. Use `type: "acp"` with `runtime.acp` defaults (`agent`, `backend`, `mode`, `cwd`) when the agent should default to ACP harness sessions.
- `identity.avatar`: workspace-relative path, `http(s)` URL, or `data:` URI.
- `identity` derives defaults: `ackReaction` from `emoji`, `mentionPatterns` from `name`/`emoji`.
@@ -2299,7 +2333,7 @@ Notes:
### `tools.experimental`
Experimental built-in tool flags. Default off unless a runtime-specific auto-enable rule applies.
Experimental built-in tool flags. Default off unless a strict-agentic GPT-5 auto-enable rule applies.
```json5
{
@@ -2314,7 +2348,7 @@ Experimental built-in tool flags. Default off unless a runtime-specific auto-ena
Notes:
- `planTool`: enables the structured `update_plan` tool for non-trivial multi-step work tracking.
- Default: `false` for non-OpenAI providers. OpenAI and OpenAI Codex runs auto-enable it when unset; set `false` to disable that auto-enable.
- Default: `false` unless `agents.defaults.embeddedPi.executionContract` (or a per-agent override) is set to `"strict-agentic"` for an OpenAI or OpenAI Codex GPT-5-family run. Set `true` to force the tool on outside that scope, or `false` to keep it off even for strict-agentic GPT-5 runs.
- When enabled, the system prompt also adds usage guidance so the model only uses it for substantial work and keeps at most one step `in_progress`.
### `agents.defaults.subagents`
@@ -2758,7 +2792,7 @@ See [Plugins](/tools/plugin).
evaluateEnabled: true,
defaultProfile: "user",
ssrfPolicy: {
dangerouslyAllowPrivateNetwork: true, // default trusted-network mode
// dangerouslyAllowPrivateNetwork: true, // opt in only for trusted private-network access
// allowPrivateNetwork: true, // legacy alias
// hostnameAllowlist: ["*.example.com", "example.com"],
// allowedHostnames: ["localhost"],
@@ -2786,8 +2820,8 @@ See [Plugins](/tools/plugin).
```
- `evaluateEnabled: false` disables `act:evaluate` and `wait --fn`.
- `ssrfPolicy.dangerouslyAllowPrivateNetwork` defaults to `true` when unset (trusted-network model).
- Set `ssrfPolicy.dangerouslyAllowPrivateNetwork: false` for strict public-only browser navigation.
- `ssrfPolicy.dangerouslyAllowPrivateNetwork` is disabled when unset, so browser navigation stays strict by default.
- Set `ssrfPolicy.dangerouslyAllowPrivateNetwork: true` only when you intentionally trust private-network browser navigation.
- In strict mode, remote CDP profile endpoints (`profiles.*.cdpUrl`) are subject to the same private-network blocking during reachability/discovery checks.
- `ssrfPolicy.allowPrivateNetwork` remains supported as a legacy alias.
- In strict mode, use `ssrfPolicy.hostnameAllowlist` and `ssrfPolicy.allowedHostnames` for explicit exceptions.
@@ -2859,7 +2893,6 @@ See [Plugins](/tools/plugin).
enabled: true,
basePath: "/openclaw",
// root: "dist/control-ui",
// embedSandbox: "powerful", // powerful | isolated
// allowedOrigins: ["https://control.example.com"], // required for non-loopback Control UI
// dangerouslyAllowHostHeaderOriginFallback: false, // dangerous Host-header origin fallback mode
// allowInsecureAuth: false,

View File

@@ -224,7 +224,7 @@ When validation fails:
- Omit `agents.list[].skills` to inherit the defaults.
- Set `agents.list[].skills: []` for no skills.
- See [Skills](/tools/skills), [Skills config](/tools/skills-config), and
the [Configuration Reference](/gateway/configuration-reference#agentsdefaultsskills).
the [Configuration Reference](/gateway/configuration-reference#agents-defaults-skills).
</Accordion>

View File

@@ -400,7 +400,7 @@ implemented in `src/gateway/server-methods/*.ts`.
- `wake` schedules an immediate or next-heartbeat wake text injection
- `cron.list`, `cron.status`, `cron.add`, `cron.update`, `cron.remove`,
`cron.run`, `cron.runs`
- skills/tools: `skills.*`, `tools.catalog`, `tools.effective`
- skills/tools: `commands.list`, `skills.*`, `tools.catalog`, `tools.effective`
### Common event families
@@ -431,6 +431,18 @@ implemented in `src/gateway/server-methods/*.ts`.
### Operator helper methods
- Operators may call `commands.list` (`operator.read`) to fetch the runtime
command inventory for an agent.
- `agentId` is optional; omit it to read the default agent workspace.
- `scope` controls which surface the primary `name` targets:
- `text` returns the primary text command token without the leading `/`
- `native` and the default `both` path return provider-aware native names
when available
- `textAliases` carries exact slash aliases such as `/model` and `/m`.
- `nativeName` carries the provider-aware native command name when one exists.
- `provider` is optional and only affects native naming plus native plugin
command availability.
- `includeArgs=false` omits serialized argument metadata from the response.
- Operators may call `tools.catalog` (`operator.read`) to fetch the runtime tool catalog for an
agent. The response includes grouped tools and provenance metadata:
- `source`: `core` or `plugin`

View File

@@ -13,7 +13,7 @@ OpenClaw is **not** a hostile multi-tenant security boundary for multiple advers
If you need mixed-trust or adversarial-user operation, split trust boundaries (separate gateway + credentials, ideally separate OS users/hosts).
</Warning>
**On this page:** [Trust model](#scope-first-personal-assistant-security-model) | [Quick audit](#quick-check-openclaw-security-audit) | [Hardened baseline](#hardened-baseline-in-60-seconds) | [DM access model](#dm-access-model-pairing--allowlist--open--disabled) | [Configuration hardening](#configuration-hardening-examples) | [Incident response](#incident-response)
**On this page:** [Trust model](#scope-first-personal-assistant-security-model) | [Quick audit](#quick-check-openclaw-security-audit) | [Hardened baseline](#hardened-baseline-in-60-seconds) | [DM access model](#dm-access-model-pairing-allowlist-open-disabled) | [Configuration hardening](#configuration-hardening-examples) | [Incident response](#incident-response)
## Scope first: personal assistant security model
@@ -187,7 +187,7 @@ Allowlists gate triggers and command authorization. The `contextVisibility` sett
- `contextVisibility: "allowlist"` filters supplemental context to senders allowed by the active allowlist checks.
- `contextVisibility: "allowlist_quote"` behaves like `allowlist`, but still keeps one explicit quoted reply.
Set `contextVisibility` per channel or per room/conversation. See [Group Chats](/channels/groups#context-visibility) for setup details.
Set `contextVisibility` per channel or per room/conversation. See [Group Chats](/channels/groups#context-visibility-and-allowlists) for setup details.
Advisory triage guidance:
@@ -579,6 +579,8 @@ Plugins run **in-process** with the Gateway. Treat them as trusted code:
Details: [Plugins](/tools/plugin)
<a id="dm-access-model-pairing-allowlist-open-disabled"></a>
## DM access model (pairing / allowlist / open / disabled)
All current DM-capable channels support a DM policy (`dmPolicy` or `*.dm.policy`) that gates inbound DMs **before** the message is processed:
@@ -1149,13 +1151,13 @@ access those accounts and data. Treat browser profiles as **sensitive state**:
- Disable browser proxy routing when you dont need it (`gateway.nodes.browser.mode="off"`).
- Chrome MCP existing-session mode is **not** “safer”; it can act as you in whatever that host Chrome profile can reach.
### Browser SSRF policy (trusted-network default)
### Browser SSRF policy (strict by default)
OpenClaws browser network policy defaults to the trusted-operator model: private/internal destinations are allowed unless you explicitly disable them.
OpenClaws browser navigation policy is strict by default: private/internal destinations stay blocked unless you explicitly opt in.
- Default: `browser.ssrfPolicy.dangerouslyAllowPrivateNetwork: true` (implicit when unset).
- Default: `browser.ssrfPolicy.dangerouslyAllowPrivateNetwork` is unset, so browser navigation keeps private/internal/special-use destinations blocked.
- Legacy alias: `browser.ssrfPolicy.allowPrivateNetwork` is still accepted for compatibility.
- Strict mode: set `browser.ssrfPolicy.dangerouslyAllowPrivateNetwork: false` to block private/internal/special-use destinations by default.
- Opt-in mode: set `browser.ssrfPolicy.dangerouslyAllowPrivateNetwork: true` to allow private/internal/special-use destinations.
- In strict mode, use `hostnameAllowlist` (patterns like `*.example.com`) and `allowedHostnames` (exact host exceptions, including blocked names like `localhost`) for explicit exceptions.
- Navigation is checked before request and best-effort re-checked on the final `http(s)` URL after navigation to reduce redirect-based pivots.

View File

@@ -111,7 +111,7 @@ Fix options:
Related:
- [/gateway/local-models](/gateway/local-models)
- [/gateway/configuration#models](/gateway/configuration#models)
- [/gateway/configuration](/gateway/configuration)
- [/gateway/configuration-reference#openai-compatible-endpoints](/gateway/configuration-reference#openai-compatible-endpoints)
## No replies

View File

@@ -48,6 +48,10 @@ These commands sit beside the main test suites when you need QA-lab realism:
- `pnpm openclaw qa suite`
- Runs repo-backed QA scenarios directly on the host.
- Runs multiple selected scenarios in parallel by default with isolated
gateway workers, up to 64 workers or the selected scenario count. Use
`--concurrency <count>` to tune the worker count, or `--concurrency 1` for
the older serial lane.
- `pnpm openclaw qa suite --runner multipass`
- Runs the same QA suite inside a disposable Multipass Linux VM.
- Keeps the same scenario-selection behavior as `qa suite` on the host.
@@ -84,7 +88,7 @@ Think of the suites as “increasing realism” (and increasing flakiness/cost):
- `pnpm test --watch` still uses the native root `vitest.config.ts` project graph, because a multi-shard watch loop is not practical.
- `pnpm test`, `pnpm test:watch`, and `pnpm test:perf:imports` route explicit file/directory targets through scoped lanes first, so `pnpm test extensions/discord/src/monitor/message-handler.preflight.test.ts` avoids paying the full root project startup tax.
- `pnpm test:changed` expands changed git paths into the same scoped lanes when the diff only touches routable source/test files; config/setup edits still fall back to the broad root-project rerun.
- Selected `plugin-sdk` and `commands` tests also route through dedicated light lanes that skip `test/setup-openclaw-runtime.ts`; stateful/runtime-heavy files stay on the existing lanes.
- Import-light unit tests from agents, commands, plugins, auto-reply helpers, `plugin-sdk`, and similar pure utility areas route through the `unit-fast` lane, which skips `test/setup-openclaw-runtime.ts`; stateful/runtime-heavy files stay on the existing lanes.
- Selected `plugin-sdk` and `commands` helper source files also map changed-mode runs to explicit sibling tests in those light lanes, so helper edits avoid rerunning the full heavy suite for that directory.
- `auto-reply` now has three dedicated buckets: top-level core helpers, top-level `reply.*` integration tests, and the `src/auto-reply/reply/**` subtree. This keeps the heaviest reply harness work off the cheap status/chunk/token tests.
- Embedded runner note:
@@ -316,6 +320,7 @@ Single-provider Docker recipes:
```bash
pnpm test:docker:live-cli-backend:claude
pnpm test:docker:live-cli-backend:claude-subscription
pnpm test:docker:live-cli-backend:codex
pnpm test:docker:live-cli-backend:gemini
```
@@ -325,6 +330,7 @@ Notes:
- The Docker runner lives at `scripts/test-live-cli-backend-docker.sh`.
- It runs the live CLI-backend smoke inside the repo Docker image as the non-root `node` user.
- It resolves CLI smoke metadata from the owning extension, then installs the matching Linux CLI package (`@anthropic-ai/claude-code`, `@openai/codex`, or `@google/gemini-cli`) into a cached writable prefix at `OPENCLAW_DOCKER_CLI_TOOLS_DIR` (default: `~/.cache/openclaw/docker-cli-tools`).
- `pnpm test:docker:live-cli-backend:claude-subscription` requires portable Claude Code subscription OAuth through either `~/.claude/.credentials.json` with `claudeAiOauth.subscriptionType` or `CLAUDE_CODE_OAUTH_TOKEN` from `claude setup-token`. It first proves direct `claude -p` in Docker, then runs two Gateway CLI-backend turns without preserving Anthropic API-key env vars. This subscription lane disables the Claude MCP/tool and image probes by default because Claude currently routes third-party app usage through extra-usage billing instead of normal subscription plan limits.
- The live CLI-backend smoke now exercises the same end-to-end flow for Claude, Codex, and Gemini: text turn, image classification turn, then MCP `cron` tool call verified through the gateway CLI.
- Claude's default smoke also patches the session from Sonnet to Opus and verifies the resumed session still remembers an earlier note.
@@ -384,6 +390,55 @@ Docker notes:
- It sources `~/.profile`, stages the matching CLI auth material into the container, installs `acpx` into a writable npm prefix, then installs the requested live CLI (`@anthropic-ai/claude-code`, `@openai/codex`, or `@google/gemini-cli`) if missing.
- Inside Docker, the runner sets `OPENCLAW_LIVE_ACP_BIND_ACPX_COMMAND=$HOME/.npm-global/bin/acpx` so acpx keeps provider env vars from the sourced profile available to the child harness CLI.
## Live: Codex app-server harness smoke
- Goal: validate the plugin-owned Codex harness through the normal gateway
`agent` method:
- load the bundled `codex` plugin
- select `OPENCLAW_AGENT_RUNTIME=codex`
- send a first gateway agent turn to `codex/gpt-5.4`
- send a second turn to the same OpenClaw session and verify the app-server
thread can resume
- run `/codex status` and `/codex models` through the same gateway command
path
- Test: `src/gateway/gateway-codex-harness.live.test.ts`
- Enable: `OPENCLAW_LIVE_CODEX_HARNESS=1`
- Default model: `codex/gpt-5.4`
- Optional image probe: `OPENCLAW_LIVE_CODEX_HARNESS_IMAGE_PROBE=1`
- Optional MCP/tool probe: `OPENCLAW_LIVE_CODEX_HARNESS_MCP_PROBE=1`
- The smoke sets `OPENCLAW_AGENT_HARNESS_FALLBACK=none` so a broken Codex
harness cannot pass by silently falling back to PI.
- Auth: `OPENAI_API_KEY` from the shell/profile, plus optional copied
`~/.codex/auth.json` and `~/.codex/config.toml`
Local recipe:
```bash
source ~/.profile
OPENCLAW_LIVE_CODEX_HARNESS=1 \
OPENCLAW_LIVE_CODEX_HARNESS_IMAGE_PROBE=1 \
OPENCLAW_LIVE_CODEX_HARNESS_MCP_PROBE=1 \
OPENCLAW_LIVE_CODEX_HARNESS_MODEL=codex/gpt-5.4 \
pnpm test:live -- src/gateway/gateway-codex-harness.live.test.ts
```
Docker recipe:
```bash
source ~/.profile
pnpm test:docker:live-codex-harness
```
Docker notes:
- The Docker runner lives at `scripts/test-live-codex-harness-docker.sh`.
- It sources the mounted `~/.profile`, passes `OPENAI_API_KEY`, copies Codex CLI
auth files when present, installs `@openai/codex` into a writable mounted npm
prefix, stages the source tree, then runs only the Codex-harness live test.
- Docker enables the image and MCP/tool probes by default. Set
`OPENCLAW_LIVE_CODEX_HARNESS_IMAGE_PROBE=0` or
`OPENCLAW_LIVE_CODEX_HARNESS_MCP_PROBE=0` when you need a narrower debug run.
### Recommended live recipes
Narrow, explicit allowlists are fastest and least flaky:
@@ -612,6 +667,7 @@ The live-model Docker runners also bind-mount only the needed CLI auth homes (or
- Direct models: `pnpm test:docker:live-models` (script: `scripts/test-live-models-docker.sh`)
- ACP bind smoke: `pnpm test:docker:live-acp-bind` (script: `scripts/test-live-acp-bind-docker.sh`)
- CLI backend smoke: `pnpm test:docker:live-cli-backend` (script: `scripts/test-live-cli-backend-docker.sh`)
- Codex app-server harness smoke: `pnpm test:docker:live-codex-harness` (script: `scripts/test-live-codex-harness-docker.sh`)
- Gateway + dev agent: `pnpm test:docker:live-gateway` (script: `scripts/test-live-gateway-models-docker.sh`)
- Open WebUI live smoke: `pnpm test:docker:openwebui` (script: `scripts/e2e/openwebui-docker.sh`)
- Onboarding wizard (TTY, full scaffolding): `pnpm test:docker:onboard` (script: `scripts/e2e/onboard-docker.sh`)
@@ -669,6 +725,7 @@ Useful env vars:
- Override manually with `OPENCLAW_DOCKER_AUTH_DIRS=all`, `OPENCLAW_DOCKER_AUTH_DIRS=none`, or a comma list like `OPENCLAW_DOCKER_AUTH_DIRS=.claude,.codex`
- `OPENCLAW_LIVE_GATEWAY_MODELS=...` / `OPENCLAW_LIVE_MODELS=...` to narrow the run
- `OPENCLAW_LIVE_GATEWAY_PROVIDERS=...` / `OPENCLAW_LIVE_PROVIDERS=...` to filter providers in-container
- `OPENCLAW_SKIP_DOCKER_BUILD=1` to reuse an existing `openclaw:local-live` image for reruns that do not need a rebuild
- `OPENCLAW_LIVE_REQUIRE_PROFILE_KEYS=1` to ensure creds come from the profile store (not env)
- `OPENCLAW_OPENWEBUI_MODEL=...` to choose the model exposed by the gateway for the Open WebUI smoke
- `OPENCLAW_OPENWEBUI_PROMPT=...` to override the nonce-check prompt used by the Open WebUI smoke

View File

@@ -251,18 +251,19 @@ flowchart TD
Common log signatures:
- `cron: scheduler disabled; jobs will not run automatically` → cron is disabled.
- `heartbeat skipped` with `reason=quiet-hours` → outside configured active hours.
- `heartbeat skipped` with `reason=empty-heartbeat-file` → `HEARTBEAT.md` exists but only contains blank/header-only scaffolding.
- `heartbeat skipped` with `reason=no-tasks-due` → `HEARTBEAT.md` task mode is active but none of the task intervals are due yet.
- `heartbeat skipped` with `reason=alerts-disabled` → all heartbeat visibility is disabled (`showOk`, `showAlerts`, and `useIndicator` are all off).
- `requests-in-flight` → main lane busy; heartbeat wake was deferred. - `unknown accountId` → heartbeat delivery target account does not exist.
- `cron: scheduler disabled; jobs will not run automatically` → cron is disabled.
- `heartbeat skipped` with `reason=quiet-hours` → outside configured active hours.
- `heartbeat skipped` with `reason=empty-heartbeat-file` → `HEARTBEAT.md` exists but only contains blank/header-only scaffolding.
- `heartbeat skipped` with `reason=no-tasks-due` → `HEARTBEAT.md` task mode is active but none of the task intervals are due yet.
- `heartbeat skipped` with `reason=alerts-disabled` → all heartbeat visibility is disabled (`showOk`, `showAlerts`, and `useIndicator` are all off).
- `requests-in-flight` → main lane busy; heartbeat wake was deferred.
- `unknown accountId` → heartbeat delivery target account does not exist.
Deep pages:
Deep pages:
- [/gateway/troubleshooting#cron-and-heartbeat-delivery](/gateway/troubleshooting#cron-and-heartbeat-delivery)
- [/automation/cron-jobs#troubleshooting](/automation/cron-jobs#troubleshooting)
- [/gateway/heartbeat](/gateway/heartbeat)
- [/gateway/troubleshooting#cron-and-heartbeat-delivery](/gateway/troubleshooting#cron-and-heartbeat-delivery)
- [/automation/cron-jobs#troubleshooting](/automation/cron-jobs#troubleshooting)
- [/gateway/heartbeat](/gateway/heartbeat)
</Accordion>
@@ -338,7 +339,7 @@ flowchart TD
- [/tools/exec](/tools/exec)
- [/tools/exec-approvals](/tools/exec-approvals)
- [/gateway/security#runtime-expectation-drift](/gateway/security#runtime-expectation-drift)
- [/gateway/security#what-the-audit-checks-high-level](/gateway/security#what-the-audit-checks-high-level)
</Accordion>
@@ -376,6 +377,7 @@ flowchart TD
- [/tools/browser-wsl2-windows-remote-cdp-troubleshooting](/tools/browser-wsl2-windows-remote-cdp-troubleshooting)
</Accordion>
</AccordionGroup>
## Related

View File

@@ -0,0 +1,487 @@
---
title: "Codex Harness"
summary: "Run OpenClaw embedded agent turns through the bundled Codex app-server harness"
read_when:
- You want to use the bundled Codex app-server harness
- You need Codex model refs and config examples
- You want to disable PI fallback for Codex-only deployments
---
# Codex Harness
The bundled `codex` plugin lets OpenClaw run embedded agent turns through the
Codex app-server instead of the built-in PI harness.
Use this when you want Codex to own the low-level agent session: model
discovery, native thread resume, native compaction, and app-server execution.
OpenClaw still owns chat channels, session files, model selection, tools,
approvals, media delivery, and the visible transcript mirror.
The harness is off by default. It is selected only when the `codex` plugin is
enabled and the resolved model is a `codex/*` model, or when you explicitly
force `embeddedHarness.runtime: "codex"` or `OPENCLAW_AGENT_RUNTIME=codex`.
If you never configure `codex/*`, existing PI, OpenAI, Anthropic, Gemini, local,
and custom-provider runs keep their current behavior.
## Pick the right model prefix
OpenClaw has separate routes for OpenAI and Codex-shaped access:
| Model ref | Runtime path | Use when |
| ---------------------- | -------------------------------------------- | ----------------------------------------------------------------------- |
| `openai/gpt-5.4` | OpenAI provider through OpenClaw/PI plumbing | You want direct OpenAI Platform API access with `OPENAI_API_KEY`. |
| `openai-codex/gpt-5.4` | OpenAI Codex OAuth provider through PI | You want ChatGPT/Codex OAuth without the Codex app-server harness. |
| `codex/gpt-5.4` | Bundled Codex provider plus Codex harness | You want native Codex app-server execution for the embedded agent turn. |
The Codex harness only claims `codex/*` model refs. Existing `openai/*`,
`openai-codex/*`, Anthropic, Gemini, xAI, local, and custom provider refs keep
their normal paths.
## Requirements
- OpenClaw with the bundled `codex` plugin available.
- Codex app-server `0.118.0` or newer.
- Codex auth available to the app-server process.
The plugin blocks older or unversioned app-server handshakes. That keeps
OpenClaw on the protocol surface it has been tested against.
For live and Docker smoke tests, auth usually comes from `OPENAI_API_KEY`, plus
optional Codex CLI files such as `~/.codex/auth.json` and
`~/.codex/config.toml`. Use the same auth material your local Codex app-server
uses.
## Minimal config
Use `codex/gpt-5.4`, enable the bundled plugin, and force the `codex` harness:
```json5
{
plugins: {
entries: {
codex: {
enabled: true,
},
},
},
agents: {
defaults: {
model: "codex/gpt-5.4",
embeddedHarness: {
runtime: "codex",
fallback: "none",
},
},
},
}
```
If your config uses `plugins.allow`, include `codex` there too:
```json5
{
plugins: {
allow: ["codex"],
entries: {
codex: {
enabled: true,
},
},
},
}
```
Setting `agents.defaults.model` or an agent model to `codex/<model>` also
auto-enables the bundled `codex` plugin. The explicit plugin entry is still
useful in shared configs because it makes the deployment intent obvious.
## Add Codex without replacing other models
Keep `runtime: "auto"` when you want Codex for `codex/*` models and PI for
everything else:
```json5
{
plugins: {
entries: {
codex: {
enabled: true,
},
},
},
agents: {
defaults: {
model: {
primary: "codex/gpt-5.4",
fallbacks: ["openai/gpt-5.4", "anthropic/claude-opus-4-6"],
},
models: {
"codex/gpt-5.4": { alias: "codex" },
"codex/gpt-5.4-mini": { alias: "codex-mini" },
"openai/gpt-5.4": { alias: "gpt" },
"anthropic/claude-opus-4-6": { alias: "opus" },
},
embeddedHarness: {
runtime: "auto",
fallback: "pi",
},
},
},
}
```
With this shape:
- `/model codex` or `/model codex/gpt-5.4` uses the Codex app-server harness.
- `/model gpt` or `/model openai/gpt-5.4` uses the OpenAI provider path.
- `/model opus` uses the Anthropic provider path.
- If a non-Codex model is selected, PI remains the compatibility harness.
## Codex-only deployments
Disable PI fallback when you need to prove that every embedded agent turn uses
the Codex harness:
```json5
{
agents: {
defaults: {
model: "codex/gpt-5.4",
embeddedHarness: {
runtime: "codex",
fallback: "none",
},
},
},
}
```
Environment override:
```bash
OPENCLAW_AGENT_RUNTIME=codex \
OPENCLAW_AGENT_HARNESS_FALLBACK=none \
openclaw gateway run
```
With fallback disabled, OpenClaw fails early if the Codex plugin is disabled,
the requested model is not a `codex/*` ref, the app-server is too old, or the
app-server cannot start.
## Per-agent Codex
You can make one agent Codex-only while the default agent keeps normal
auto-selection:
```json5
{
agents: {
defaults: {
embeddedHarness: {
runtime: "auto",
fallback: "pi",
},
},
list: [
{
id: "main",
default: true,
model: "anthropic/claude-opus-4-6",
},
{
id: "codex",
name: "Codex",
model: "codex/gpt-5.4",
embeddedHarness: {
runtime: "codex",
fallback: "none",
},
},
],
},
}
```
Use normal session commands to switch agents and models. `/new` creates a fresh
OpenClaw session and the Codex harness creates or resumes its sidecar app-server
thread as needed. `/reset` clears the OpenClaw session binding for that thread.
## Model discovery
By default, the Codex plugin asks the app-server for available models. If
discovery fails or times out, it uses the bundled fallback catalog:
- `codex/gpt-5.4`
- `codex/gpt-5.4-mini`
- `codex/gpt-5.2`
You can tune discovery under `plugins.entries.codex.config.discovery`:
```json5
{
plugins: {
entries: {
codex: {
enabled: true,
config: {
discovery: {
enabled: true,
timeoutMs: 2500,
},
},
},
},
},
}
```
Disable discovery when you want startup to avoid probing Codex and stick to the
fallback catalog:
```json5
{
plugins: {
entries: {
codex: {
enabled: true,
config: {
discovery: {
enabled: false,
},
},
},
},
},
}
```
## App-server connection and policy
By default, the plugin starts Codex locally with:
```bash
codex app-server --listen stdio://
```
You can keep that default and only tune Codex native policy:
```json5
{
plugins: {
entries: {
codex: {
enabled: true,
config: {
appServer: {
approvalPolicy: "on-request",
sandbox: "workspace-write",
serviceTier: "priority",
},
},
},
},
},
}
```
For an already-running app-server, use WebSocket transport:
```json5
{
plugins: {
entries: {
codex: {
enabled: true,
config: {
appServer: {
transport: "websocket",
url: "ws://127.0.0.1:39175",
authToken: "${CODEX_APP_SERVER_TOKEN}",
requestTimeoutMs: 60000,
},
},
},
},
},
}
```
Supported `appServer` fields:
| Field | Default | Meaning |
| ------------------- | ---------------------------------------- | ------------------------------------------------------------------------ |
| `transport` | `"stdio"` | `"stdio"` spawns Codex; `"websocket"` connects to `url`. |
| `command` | `"codex"` | Executable for stdio transport. |
| `args` | `["app-server", "--listen", "stdio://"]` | Arguments for stdio transport. |
| `url` | unset | WebSocket app-server URL. |
| `authToken` | unset | Bearer token for WebSocket transport. |
| `headers` | `{}` | Extra WebSocket headers. |
| `requestTimeoutMs` | `60000` | Timeout for app-server control-plane calls. |
| `approvalPolicy` | `"never"` | Native Codex approval policy sent to thread start/resume/turn. |
| `sandbox` | `"workspace-write"` | Native Codex sandbox mode sent to thread start/resume. |
| `approvalsReviewer` | `"user"` | Use `"guardian_subagent"` to let Codex guardian review native approvals. |
| `serviceTier` | unset | Optional Codex service tier, for example `"priority"`. |
The older environment variables still work as fallbacks for local testing when
the matching config field is unset:
- `OPENCLAW_CODEX_APP_SERVER_BIN`
- `OPENCLAW_CODEX_APP_SERVER_ARGS`
- `OPENCLAW_CODEX_APP_SERVER_APPROVAL_POLICY`
- `OPENCLAW_CODEX_APP_SERVER_SANDBOX`
- `OPENCLAW_CODEX_APP_SERVER_GUARDIAN=1`
Config is preferred for repeatable deployments.
## Common recipes
Local Codex with default stdio transport:
```json5
{
plugins: {
entries: {
codex: {
enabled: true,
},
},
},
}
```
Codex-only harness validation, with PI fallback disabled:
```json5
{
embeddedHarness: {
fallback: "none",
},
plugins: {
entries: {
codex: {
enabled: true,
},
},
},
}
```
Guardian-reviewed Codex approvals:
```json5
{
plugins: {
entries: {
codex: {
enabled: true,
config: {
appServer: {
approvalPolicy: "on-request",
approvalsReviewer: "guardian_subagent",
sandbox: "workspace-write",
},
},
},
},
},
}
```
Remote app-server with explicit headers:
```json5
{
plugins: {
entries: {
codex: {
enabled: true,
config: {
appServer: {
transport: "websocket",
url: "ws://gateway-host:39175",
headers: {
"X-OpenClaw-Agent": "main",
},
},
},
},
},
},
}
```
Model switching stays OpenClaw-controlled. When an OpenClaw session is attached
to an existing Codex thread, the next turn sends the currently selected
`codex/*` model, provider, approval policy, sandbox, and service tier to
app-server again. Switching from `codex/gpt-5.4` to `codex/gpt-5.2` keeps the
thread binding but asks Codex to continue with the newly selected model.
## Codex command
The bundled plugin registers `/codex` as an authorized slash command. It is
generic and works on any channel that supports OpenClaw text commands.
Common forms:
- `/codex status` shows live app-server connectivity, models, account, rate limits, MCP servers, and skills.
- `/codex models` lists live Codex app-server models.
- `/codex threads [filter]` lists recent Codex threads.
- `/codex resume <thread-id>` attaches the current OpenClaw session to an existing Codex thread.
- `/codex compact` asks Codex app-server to compact the attached thread.
- `/codex review` starts Codex native review for the attached thread.
- `/codex account` shows account and rate-limit status.
- `/codex mcp` lists Codex app-server MCP server status.
- `/codex skills` lists Codex app-server skills.
`/codex resume` writes the same sidecar binding file that the harness uses for
normal turns. On the next message, OpenClaw resumes that Codex thread, passes the
currently selected OpenClaw `codex/*` model into app-server, and keeps extended
history enabled.
The command surface requires Codex app-server `0.118.0` or newer. Individual
control methods are reported as `unsupported by this Codex app-server` if a
future or custom app-server does not expose that JSON-RPC method.
## Tools, media, and compaction
The Codex harness changes the low-level embedded agent executor only.
OpenClaw still builds the tool list and receives dynamic tool results from the
harness. Text, images, video, music, TTS, approvals, and messaging-tool output
continue through the normal OpenClaw delivery path.
When the selected model uses the Codex harness, native thread compaction is
delegated to Codex app-server. OpenClaw keeps a transcript mirror for channel
history, search, `/new`, `/reset`, and future model or harness switching.
Media generation does not require PI. Image, video, music, PDF, TTS, and media
understanding continue to use the matching provider/model settings such as
`agents.defaults.imageGenerationModel`, `videoGenerationModel`, `pdfModel`, and
`messages.tts`.
## Troubleshooting
**Codex does not appear in `/model`:** enable `plugins.entries.codex.enabled`,
set a `codex/*` model ref, or check whether `plugins.allow` excludes `codex`.
**OpenClaw falls back to PI:** set `embeddedHarness.fallback: "none"` or
`OPENCLAW_AGENT_HARNESS_FALLBACK=none` while testing.
**The app-server is rejected:** upgrade Codex so the app-server handshake
reports version `0.118.0` or newer.
**Model discovery is slow:** lower `plugins.entries.codex.config.discovery.timeoutMs`
or disable discovery.
**WebSocket transport fails immediately:** check `appServer.url`, `authToken`,
and that the remote app-server speaks the same Codex app-server protocol version.
**A non-Codex model uses PI:** that is expected. The Codex harness only claims
`codex/*` model refs.
## Related
- [Agent Harness Plugins](/plugins/sdk-agent-harness)
- [Model Providers](/concepts/model-providers)
- [Configuration Reference](/gateway/configuration-reference)
- [Testing](/help/testing#live-codex-app-server-harness-smoke)

View File

@@ -147,6 +147,7 @@ Those belong in your plugin code and `package.json`.
| `providers` | No | `string[]` | Provider ids owned by this plugin. |
| `modelSupport` | No | `object` | Manifest-owned shorthand model-family metadata used to auto-load the plugin before runtime. |
| `cliBackends` | No | `string[]` | CLI inference backend ids owned by this plugin. Used for startup auto-activation from explicit config refs. |
| `commandAliases` | No | `object[]` | Command names owned by this plugin that should produce plugin-aware config and CLI diagnostics before runtime loads. |
| `providerAuthEnvVars` | No | `Record<string, string[]>` | Cheap provider-auth env metadata that OpenClaw can inspect without loading plugin code. |
| `providerAuthAliases` | No | `Record<string, string>` | Provider ids that should reuse another provider id for auth lookup, for example a coding provider that shares the base provider API key and auth profiles. |
| `channelEnvVars` | No | `Record<string, string[]>` | Cheap channel env metadata that OpenClaw can inspect without loading plugin code. Use this for env-driven channel setup or auth surfaces that generic startup/config helpers should see. |
@@ -183,6 +184,30 @@ OpenClaw reads this before provider runtime loads.
| `cliDescription` | No | `string` | Description used in CLI help. |
| `onboardingScopes` | No | `Array<"text-inference" \| "image-generation">` | Which onboarding surfaces this choice should appear in. If omitted, it defaults to `["text-inference"]`. |
## commandAliases reference
Use `commandAliases` when a plugin owns a runtime command name that users may
mistakenly put in `plugins.allow` or try to run as a root CLI command. OpenClaw
uses this metadata for diagnostics without importing plugin runtime code.
```json
{
"commandAliases": [
{
"name": "dreaming",
"kind": "runtime-slash",
"cliCommand": "memory"
}
]
}
```
| Field | Required | Type | What it means |
| ------------ | -------- | ----------------- | ----------------------------------------------------------------------- |
| `name` | Yes | `string` | Command name that belongs to this plugin. |
| `kind` | No | `"runtime-slash"` | Marks the alias as a chat slash command rather than a root CLI command. |
| `cliCommand` | No | `string` | Related root CLI command to suggest for CLI operations, if one exists. |
## uiHints reference
`uiHints` is a map from config field names to small rendering hints.

View File

@@ -0,0 +1,264 @@
---
title: "Agent Harness Plugins"
sidebarTitle: "Agent Harness"
summary: "Experimental SDK surface for plugins that replace the low level embedded agent executor"
read_when:
- You are changing the embedded agent runtime or harness registry
- You are registering an agent harness from a bundled or trusted plugin
- You need to understand how the Codex plugin relates to model providers
---
# Agent Harness Plugins
An **agent harness** is the low level executor for one prepared OpenClaw agent
turn. It is not a model provider, not a channel, and not a tool registry.
Use this surface only for bundled or trusted native plugins. The contract is
still experimental because the parameter types intentionally mirror the current
embedded runner.
## When to use a harness
Register an agent harness when a model family has its own native session
runtime and the normal OpenClaw provider transport is the wrong abstraction.
Examples:
- a native coding-agent server that owns threads and compaction
- a local CLI or daemon that must stream native plan/reasoning/tool events
- a model runtime that needs its own resume id in addition to the OpenClaw
session transcript
Do **not** register a harness just to add a new LLM API. For normal HTTP or
WebSocket model APIs, build a [provider plugin](/plugins/sdk-provider-plugins).
## What core still owns
Before a harness is selected, OpenClaw has already resolved:
- provider and model
- runtime auth state
- thinking level and context budget
- the OpenClaw transcript/session file
- workspace, sandbox, and tool policy
- channel reply callbacks and streaming callbacks
- model fallback and live model switching policy
That split is intentional. A harness runs a prepared attempt; it does not pick
providers, replace channel delivery, or silently switch models.
## Register a harness
**Import:** `openclaw/plugin-sdk/agent-harness`
```typescript
import type { AgentHarness } from "openclaw/plugin-sdk/agent-harness";
import { definePluginEntry } from "openclaw/plugin-sdk/plugin-entry";
const myHarness: AgentHarness = {
id: "my-harness",
label: "My native agent harness",
supports(ctx) {
return ctx.provider === "my-provider"
? { supported: true, priority: 100 }
: { supported: false };
},
async runAttempt(params) {
// Start or resume your native thread.
// Use params.prompt, params.tools, params.images, params.onPartialReply,
// params.onAgentEvent, and the other prepared attempt fields.
return await runMyNativeTurn(params);
},
};
export default definePluginEntry({
id: "my-native-agent",
name: "My Native Agent",
description: "Runs selected models through a native agent daemon.",
register(api) {
api.registerAgentHarness(myHarness);
},
});
```
## Selection policy
OpenClaw chooses a harness after provider/model resolution:
1. `OPENCLAW_AGENT_RUNTIME=<id>` forces a registered harness with that id.
2. `OPENCLAW_AGENT_RUNTIME=pi` forces the built-in PI harness.
3. `OPENCLAW_AGENT_RUNTIME=auto` asks registered harnesses if they support the
resolved provider/model.
4. If no registered harness matches, OpenClaw uses PI unless PI fallback is
disabled.
Forced plugin harness failures surface as run failures. In `auto` mode,
OpenClaw may fall back to PI when the selected plugin harness fails before a
turn has produced side effects. Set `OPENCLAW_AGENT_HARNESS_FALLBACK=none` or
`embeddedHarness.fallback: "none"` to make that fallback a hard failure instead.
The bundled Codex plugin registers `codex` as its harness id. For compatibility,
`codex-app-server` and `app-server` also resolve to that same harness when you
set `OPENCLAW_AGENT_RUNTIME` manually.
## Provider plus harness pairing
Most harnesses should also register a provider. The provider makes model refs,
auth status, model metadata, and `/model` selection visible to the rest of
OpenClaw. The harness then claims that provider in `supports(...)`.
The bundled Codex plugin follows this pattern:
- provider id: `codex`
- user model refs: `codex/gpt-5.4`, `codex/gpt-5.2`, or another model returned
by the Codex app server
- harness id: `codex`
- auth: synthetic provider availability, because the Codex harness owns the
native Codex login/session
- app-server request: OpenClaw sends the bare model id to Codex and lets the
harness talk to the native app-server protocol
The Codex plugin is additive. Plain `openai/gpt-*` refs remain OpenAI provider
refs and continue to use the normal OpenClaw provider path. Select `codex/gpt-*`
when you want Codex-managed auth, Codex model discovery, native threads, and
Codex app-server execution. `/model` can switch among the Codex models returned
by the Codex app server without requiring OpenAI provider credentials.
For operator setup, model prefix examples, and Codex-only configs, see
[Codex Harness](/plugins/codex-harness).
OpenClaw requires Codex app-server `0.118.0` or newer. The Codex plugin checks
the app-server initialize handshake and blocks older or unversioned servers so
OpenClaw only runs against the protocol surface it has been tested with.
## Disable PI fallback
By default, OpenClaw runs embedded agents with `agents.defaults.embeddedHarness`
set to `{ runtime: "auto", fallback: "pi" }`. In `auto` mode, registered plugin
harnesses can claim a provider/model pair. If none match, or if an auto-selected
plugin harness fails before producing output, OpenClaw falls back to PI.
Set `fallback: "none"` when you need to prove that a plugin harness is the only
runtime being exercised. This disables automatic PI fallback; it does not block
an explicit `runtime: "pi"` or `OPENCLAW_AGENT_RUNTIME=pi`.
For Codex-only embedded runs:
```json
{
"agents": {
"defaults": {
"model": "codex/gpt-5.4",
"embeddedHarness": {
"runtime": "codex",
"fallback": "none"
}
}
}
}
```
If you want any registered plugin harness to claim matching models but never
want OpenClaw to silently fall back to PI, keep `runtime: "auto"` and disable
the fallback:
```json
{
"agents": {
"defaults": {
"embeddedHarness": {
"runtime": "auto",
"fallback": "none"
}
}
}
}
```
Per-agent overrides use the same shape:
```json
{
"agents": {
"defaults": {
"embeddedHarness": {
"runtime": "auto",
"fallback": "pi"
}
},
"list": [
{
"id": "codex-only",
"model": "codex/gpt-5.4",
"embeddedHarness": {
"runtime": "codex",
"fallback": "none"
}
}
]
}
}
```
`OPENCLAW_AGENT_RUNTIME` still overrides the configured runtime. Use
`OPENCLAW_AGENT_HARNESS_FALLBACK=none` to disable PI fallback from the
environment.
```bash
OPENCLAW_AGENT_RUNTIME=codex \
OPENCLAW_AGENT_HARNESS_FALLBACK=none \
openclaw gateway run
```
With fallback disabled, a session fails early when the requested harness is not
registered, does not support the resolved provider/model, or fails before
producing turn side effects. That is intentional for Codex-only deployments and
for live tests that must prove the Codex app-server path is actually in use.
This setting only controls the embedded agent harness. It does not disable
image, video, music, TTS, PDF, or other provider-specific model routing.
## Native sessions and transcript mirror
A harness may keep a native session id, thread id, or daemon-side resume token.
Keep that binding explicitly associated with the OpenClaw session, and keep
mirroring user-visible assistant/tool output into the OpenClaw transcript.
The OpenClaw transcript remains the compatibility layer for:
- channel-visible session history
- transcript search and indexing
- switching back to the built-in PI harness on a later turn
- generic `/new`, `/reset`, and session deletion behavior
If your harness stores a sidecar binding, implement `reset(...)` so OpenClaw can
clear it when the owning OpenClaw session is reset.
## Tool and media results
Core constructs the OpenClaw tool list and passes it into the prepared attempt.
When a harness executes a dynamic tool call, return the tool result back through
the harness result shape instead of sending channel media yourself.
This keeps text, image, video, music, TTS, approval, and messaging-tool outputs
on the same delivery path as PI-backed runs.
## Current limitations
- The public import path is generic, but some attempt/result type aliases still
carry `Pi` names for compatibility.
- Third-party harness installation is experimental. Prefer provider plugins
until you need a native session runtime.
- Harness switching is supported across turns. Do not switch harnesses in the
middle of a turn after native tools, approvals, assistant text, or message
sends have started.
## Related
- [SDK Overview](/plugins/sdk-overview)
- [Runtime Helpers](/plugins/sdk-runtime)
- [Provider Plugins](/plugins/sdk-provider-plugins)
- [Codex Harness](/plugins/codex-harness)
- [Model Providers](/concepts/model-providers)

View File

@@ -256,7 +256,7 @@ should use `resolveInboundMentionDecision({ facts, policy })`.
<Step title="Package and manifest">
Create the standard plugin files. The `channel` field in `package.json` is
what makes this a channel plugin. For the full package-metadata surface,
see [Plugin Setup and Config](/plugins/sdk-setup#openclawchannel):
see [Plugin Setup and Config](/plugins/sdk-setup#openclaw-channel):
<CodeGroup>
```json package.json

View File

@@ -219,6 +219,7 @@ explicitly promotes one as public.
| `plugin-sdk/models-provider-runtime` | `/models` command/provider reply helpers |
| `plugin-sdk/skill-commands-runtime` | Skill command listing helpers |
| `plugin-sdk/native-command-registry` | Native command registry/build/serialize helpers |
| `plugin-sdk/agent-harness` | Experimental trusted-plugin surface for low-level agent harnesses: harness types, active-run steer/abort helpers, OpenClaw tool bridge helpers, and attempt result utilities |
| `plugin-sdk/provider-zai-endpoint` | Z.AI endpoint detection helpers |
| `plugin-sdk/infra-runtime` | System event/heartbeat helpers |
| `plugin-sdk/collection-runtime` | Small bounded cache helpers |
@@ -302,20 +303,21 @@ methods:
### Capability registration
| Method | What it registers |
| ------------------------------------------------ | -------------------------------- |
| `api.registerProvider(...)` | Text inference (LLM) |
| `api.registerCliBackend(...)` | Local CLI inference backend |
| `api.registerChannel(...)` | Messaging channel |
| `api.registerSpeechProvider(...)` | Text-to-speech / STT synthesis |
| `api.registerRealtimeTranscriptionProvider(...)` | Streaming realtime transcription |
| `api.registerRealtimeVoiceProvider(...)` | Duplex realtime voice sessions |
| `api.registerMediaUnderstandingProvider(...)` | Image/audio/video analysis |
| `api.registerImageGenerationProvider(...)` | Image generation |
| `api.registerMusicGenerationProvider(...)` | Music generation |
| `api.registerVideoGenerationProvider(...)` | Video generation |
| `api.registerWebFetchProvider(...)` | Web fetch / scrape provider |
| `api.registerWebSearchProvider(...)` | Web search |
| Method | What it registers |
| ------------------------------------------------ | ------------------------------------- |
| `api.registerProvider(...)` | Text inference (LLM) |
| `api.registerAgentHarness(...)` | Experimental low-level agent executor |
| `api.registerCliBackend(...)` | Local CLI inference backend |
| `api.registerChannel(...)` | Messaging channel |
| `api.registerSpeechProvider(...)` | Text-to-speech / STT synthesis |
| `api.registerRealtimeTranscriptionProvider(...)` | Streaming realtime transcription |
| `api.registerRealtimeVoiceProvider(...)` | Duplex realtime voice sessions |
| `api.registerMediaUnderstandingProvider(...)` | Image/audio/video analysis |
| `api.registerImageGenerationProvider(...)` | Image generation |
| `api.registerMusicGenerationProvider(...)` | Music generation |
| `api.registerVideoGenerationProvider(...)` | Video generation |
| `api.registerWebFetchProvider(...)` | Web fetch / scrape provider |
| `api.registerWebSearchProvider(...)` | Web search |
### Tools and commands

View File

@@ -20,6 +20,13 @@ API key auth, and dynamic model resolution.
structure and manifest setup.
</Info>
<Tip>
Provider plugins add models to OpenClaw's normal inference loop. If the model
must run through a native agent daemon that owns threads, compaction, or tool
events, pair the provider with an [agent harness](/plugins/sdk-agent-harness)
instead of putting daemon protocol details in core.
</Tip>
## Walkthrough
<Steps>

View File

@@ -50,9 +50,9 @@ const timeoutMs = api.runtime.agent.resolveAgentTimeoutMs(cfg);
// Ensure workspace exists
await api.runtime.agent.ensureAgentWorkspace(cfg);
// Run an embedded Pi agent
// Run an embedded agent turn
const agentDir = api.runtime.agent.resolveAgentDir(cfg);
const result = await api.runtime.agent.runEmbeddedPiAgent({
const result = await api.runtime.agent.runEmbeddedAgent({
sessionId: "my-plugin:task-1",
runId: crypto.randomUUID(),
sessionFile: path.join(agentDir, "sessions", "my-plugin-task-1.jsonl"),
@@ -62,6 +62,12 @@ const result = await api.runtime.agent.runEmbeddedPiAgent({
});
```
`runEmbeddedAgent(...)` is the neutral helper for starting a normal OpenClaw
agent turn from plugin code. It uses the same provider/model resolution and
agent-harness selection as channel-triggered replies.
`runEmbeddedPiAgent(...)` remains as a compatibility alias.
**Session store helpers** are under `api.runtime.agent.session`:
```typescript

View File

@@ -69,9 +69,9 @@ OpenClaw has three public release lanes:
- npm release preflight fails closed unless the tarball includes both
`dist/control-ui/index.html` and a non-empty `dist/control-ui/assets/` payload
so we do not ship an empty browser dashboard again
- If the release work touched CI planning, extension timing manifests, or fast
test matrices, regenerate and review the planner-owned `checks-fast-extensions`
workflow matrix outputs from `.github/workflows/ci.yml`
- If the release work touched CI planning, extension timing manifests, or
extension test matrices, regenerate and review the planner-owned
`checks-node-extensions` workflow matrix outputs from `.github/workflows/ci.yml`
before approval so release notes do not describe a stale CI layout
- Stable macOS release readiness also includes the updater surfaces:
- the GitHub release must end up with the packaged `.zip`, `.dmg`, and `.dSYM.zip`

View File

@@ -1,50 +0,0 @@
# Rich Output Protocol
Assistant output can carry a small set of delivery/render directives:
- `MEDIA:` for attachment delivery
- `[[audio_as_voice]]` for audio presentation hints
- `[[reply_to_current]]` / `[[reply_to:<id>]]` for reply metadata
- `[canvas ...]` for Control UI rich rendering
These directives are separate. `MEDIA:` and reply/voice tags remain delivery metadata; `[canvas ...]` is the web-only rich render path.
## `[canvas ...]`
`[canvas ...]` is the only agent-facing rich render syntax for the Control UI.
Self-closing example:
```text
[canvas ref="cv_123" title="Status" /]
```
Rules:
- `[view ...]` is no longer valid for new output.
- Canvas shortcodes render in the assistant message surface only.
- Only URL-backed canvases are rendered. Use `ref="..."` or `url="..."`.
- Block-form inline HTML canvas shortcodes are not rendered.
- The web UI strips the shortcode from visible text and renders the canvas inline.
- `MEDIA:` is not a canvas alias and should not be used for rich canvas rendering.
## Stored Rendering Shape
The normalized/stored assistant content block is a structured `canvas` item:
```json
{
"type": "canvas",
"preview": {
"kind": "canvas",
"surface": "assistant_message",
"render": "url",
"viewId": "cv_123",
"url": "/__openclaw__/canvas/documents/cv_123/index.html",
"title": "Status",
"preferredHeight": 320
}
}
```
Stored/rendered rich blocks use this `canvas` shape directly. `present_view` is not recognized.

View File

@@ -136,9 +136,6 @@ Skills provide your tools. When you need one, check its `SKILL.md`. Keep local n
When you receive a heartbeat poll (message matches the configured heartbeat prompt), don't just reply `HEARTBEAT_OK` every time. Use heartbeats productively!
Default heartbeat prompt:
`Read HEARTBEAT.md if it exists (workspace context). Follow it strictly. Do not infer or repeat old tasks from prior chats. If nothing needs attention, reply HEARTBEAT_OK.`
You are free to edit `HEARTBEAT.md` with a short checklist or reminders. Keep it small to limit token burn.
### Heartbeat vs Cron: When to Use Each

View File

@@ -146,7 +146,7 @@ Browser settings live in `~/.openclaw/openclaw.json`.
browser: {
enabled: true, // default: true
ssrfPolicy: {
dangerouslyAllowPrivateNetwork: true, // default trusted-network mode
// dangerouslyAllowPrivateNetwork: true, // opt in only for trusted private-network access
// allowPrivateNetwork: true, // legacy alias
// hostnameAllowlist: ["*.example.com", "example.com"],
// allowedHostnames: ["localhost"],
@@ -191,7 +191,7 @@ Notes:
- `remoteCdpHandshakeTimeoutMs` applies to remote CDP WebSocket reachability checks.
- Browser navigation/open-tab is SSRF-guarded before navigation and best-effort re-checked on final `http(s)` URL after navigation.
- In strict SSRF mode, remote CDP endpoint discovery/probes (`cdpUrl`, including `/json/version` lookups) are checked too.
- `browser.ssrfPolicy.dangerouslyAllowPrivateNetwork` defaults to `true` (trusted-network model). Set it to `false` for strict public-only browsing.
- `browser.ssrfPolicy.dangerouslyAllowPrivateNetwork` is disabled by default. Set it to `true` only when you intentionally trust private-network browser access.
- `browser.ssrfPolicy.allowPrivateNetwork` remains supported as a legacy alias for compatibility.
- `attachOnly: true` means “never launch a local browser; only attach if it is already running.”
- `color` + per-profile `color` tint the browser UI so you can see which profile is active.

View File

@@ -20,6 +20,11 @@ session or config defaults request `ask: "on-miss"`.
Use `openclaw approvals get`, `openclaw approvals get --gateway`, or
`openclaw approvals get --node <id|name|ip>` to inspect the requested policy,
host policy sources, and the effective result.
For the local machine, `openclaw exec-policy show` exposes the same merged view and
`openclaw exec-policy set|preset` can synchronize the local requested policy with the
local host approvals file in one step. When a local scope requests `host=node`,
`openclaw exec-policy show` reports that scope as node-managed at runtime instead of
pretending the local approvals file is the effective source of truth.
If the companion app UI is **not available**, any request that requires a prompt is
resolved by the **ask fallback** (default: deny).
@@ -143,6 +148,21 @@ openclaw approvals set --stdin <<'EOF'
EOF
```
Local shortcut for the same gateway-host policy on the current machine:
```bash
openclaw exec-policy preset yolo
```
That local shortcut updates both:
- local `tools.exec.host/security/ask`
- local `~/.openclaw/exec-approvals.json` defaults
It is intentionally local-only. If you need to change gateway-host or node-host approvals
remotely, continue using `openclaw approvals set --gateway` or
`openclaw approvals set --node <id|name|ip>`.
For a node host, apply the same approvals file on that node instead:
```bash
@@ -158,6 +178,12 @@ openclaw approvals set --node <id|name|ip> --stdin <<'EOF'
EOF
```
Important local-only limitation:
- `openclaw exec-policy` does not synchronize node approvals
- `openclaw exec-policy set --host node` is rejected
- node exec approvals are fetched from the node at runtime, so node-targeted updates must use `openclaw approvals --node ...`
Session-only shortcut:
- `/exec security=full ask=off` changes only the current session.

View File

@@ -68,7 +68,7 @@ tool with the `react` action. Reaction behavior varies by channel.
Per-channel `reactionLevel` config controls how broadly the agent uses reactions. Values are typically `off`, `ack`, `minimal`, or `extensive`.
- [Telegram reactionLevel](/channels/telegram#reaction-notifications) — `channels.telegram.reactionLevel`
- [WhatsApp reactionLevel](/channels/whatsapp#reactions) — `channels.whatsapp.reactionLevel`
- [WhatsApp reactionLevel](/channels/whatsapp#reaction-level) — `channels.whatsapp.reactionLevel`
Set `reactionLevel` on individual channels to tune how actively the agent reacts to messages on each platform.

View File

@@ -303,6 +303,13 @@ When an agent run starts, OpenClaw:
This is **scoped to the agent run**, not a global shell environment.
For the bundled `claude-cli` backend, OpenClaw also materializes the same
eligible snapshot as a temporary Claude Code plugin and passes it with
`--plugin-dir`. Claude Code can then use its native skill resolver while
OpenClaw still owns precedence, per-agent allowlists, gating, and
`skills.entries.*` env/API key injection. Other CLI backends use the prompt
catalog only.
## Session snapshot (performance)
OpenClaw snapshots the eligible skills **when a session starts** and reuses that list for subsequent turns in the same session. Changes to skills or config take effect on the next new session.

View File

@@ -152,6 +152,7 @@ Bundled plugins can add more slash commands. Current bundled commands in this re
- `/phone status|arm <camera|screen|writes|all> [duration]|disarm` temporarily arms high-risk phone node commands.
- `/voice status|list [limit]|set <voiceId|name>` manages Talk voice config. On Discord, the native command name is `/talkvoice`.
- `/card ...` sends LINE rich card presets. See [LINE](/channels/line).
- `/codex status|models|threads|resume|compact|review|account|mcp|skills` inspects and controls the bundled Codex app-server harness. See [Codex Harness](/plugins/codex-harness).
- QQBot-only commands:
- `/bot-ping`
- `/bot-version`

View File

@@ -4,7 +4,7 @@
"description": "OpenClaw ACP runtime backend",
"type": "module",
"dependencies": {
"acpx": "0.5.2"
"acpx": "0.5.3"
},
"devDependencies": {
"@openclaw/plugin-sdk": "workspace:*"

View File

@@ -2,7 +2,7 @@ import { describe, expect, it } from "vitest";
type SplitCommandLine = (
value: string,
platform?: NodeJS.Platform | string,
platform?: string,
) => {
command: string;
args: string[];

View File

@@ -1,11 +1,15 @@
import type { AcpSessionStore } from "acpx/runtime";
import { beforeEach, describe, expect, it, vi } from "vitest";
import type { AcpRuntime } from "../runtime-api.js";
import { AcpxRuntime } from "./runtime.js";
function makeRuntime(baseStore: AcpSessionStore): {
type TestSessionStore = {
load(sessionId: string): Promise<Record<string, unknown> | undefined>;
save(record: Record<string, unknown>): Promise<void>;
};
function makeRuntime(baseStore: TestSessionStore): {
runtime: AcpxRuntime;
wrappedStore: AcpSessionStore & { markFresh: (sessionKey: string) => void };
wrappedStore: TestSessionStore & { markFresh: (sessionKey: string) => void };
delegate: { close: AcpRuntime["close"] };
} {
const runtime = new AcpxRuntime({
@@ -22,7 +26,7 @@ function makeRuntime(baseStore: AcpSessionStore): {
runtime,
wrappedStore: (
runtime as unknown as {
sessionStore: AcpSessionStore & { markFresh: (sessionKey: string) => void };
sessionStore: TestSessionStore & { markFresh: (sessionKey: string) => void };
}
).sessionStore,
delegate: (runtime as unknown as { delegate: { close: AcpRuntime["close"] } }).delegate,
@@ -35,7 +39,7 @@ describe("AcpxRuntime fresh reset wrapper", () => {
});
it("keeps stale persistent loads hidden until a fresh record is saved", async () => {
const baseStore: AcpSessionStore = {
const baseStore: TestSessionStore = {
load: vi.fn(async () => ({ acpxRecordId: "stale" }) as never),
save: vi.fn(async () => {}),
};
@@ -68,7 +72,7 @@ describe("AcpxRuntime fresh reset wrapper", () => {
});
it("marks the session fresh after discardPersistentState close", async () => {
const baseStore: AcpSessionStore = {
const baseStore: TestSessionStore = {
load: vi.fn(async () => ({ acpxRecordId: "stale" }) as never),
save: vi.fn(async () => {}),
};

View File

@@ -111,7 +111,7 @@ describe("active-memory plugin", () => {
runEmbeddedPiAgent.mockResolvedValue({
payloads: [{ text: "- lemon pepper wings\n- blue cheese" }],
});
plugin.register(api as unknown as OpenClawPluginApi);
await plugin.register(api as unknown as OpenClawPluginApi);
});
afterEach(async () => {
@@ -406,7 +406,7 @@ describe("active-memory plugin", () => {
agents: ["main"],
allowedChatTypes: ["direct", "group"],
};
plugin.register(api as unknown as OpenClawPluginApi);
await plugin.register(api as unknown as OpenClawPluginApi);
const result = await hooks.before_prompt_build(
{ prompt: "what wings should we order?", messages: [] },
@@ -509,7 +509,7 @@ describe("active-memory plugin", () => {
agents: ["main"],
queryMode: "message",
};
plugin.register(api as unknown as OpenClawPluginApi);
await plugin.register(api as unknown as OpenClawPluginApi);
await hooks.before_prompt_build(
{
@@ -537,7 +537,7 @@ describe("active-memory plugin", () => {
queryMode: "message",
promptStyle: "preference-only",
};
plugin.register(api as unknown as OpenClawPluginApi);
await plugin.register(api as unknown as OpenClawPluginApi);
await hooks.before_prompt_build(
{
@@ -582,7 +582,7 @@ describe("active-memory plugin", () => {
agents: ["main"],
thinking: "medium",
};
plugin.register(api as unknown as OpenClawPluginApi);
await plugin.register(api as unknown as OpenClawPluginApi);
await hooks.before_prompt_build(
{
@@ -608,7 +608,7 @@ describe("active-memory plugin", () => {
agents: ["main"],
promptAppend: "Prefer stable long-term preferences over one-off events.",
};
plugin.register(api as unknown as OpenClawPluginApi);
await plugin.register(api as unknown as OpenClawPluginApi);
await hooks.before_prompt_build(
{
@@ -637,7 +637,7 @@ describe("active-memory plugin", () => {
promptOverride: "Custom memory prompt. Return NONE or one user fact.",
promptAppend: "Extra custom instruction.",
};
plugin.register(api as unknown as OpenClawPluginApi);
await plugin.register(api as unknown as OpenClawPluginApi);
await hooks.before_prompt_build(
{
@@ -710,7 +710,7 @@ describe("active-memory plugin", () => {
api.pluginConfig = {
agents: ["main"],
};
plugin.register(api as unknown as OpenClawPluginApi);
await plugin.register(api as unknown as OpenClawPluginApi);
await hooks.before_prompt_build(
{ prompt: "what wings should i order? temp transcript", messages: [] },
@@ -735,7 +735,7 @@ describe("active-memory plugin", () => {
agents: ["main"],
modelFallbackPolicy: "resolved-only",
};
plugin.register(api as unknown as OpenClawPluginApi);
await plugin.register(api as unknown as OpenClawPluginApi);
const result = await hooks.before_prompt_build(
{ prompt: "what wings should i order? no fallback", messages: [] },
@@ -872,7 +872,7 @@ describe("active-memory plugin", () => {
timeoutMs: 250,
logging: true,
};
plugin.register(api as unknown as OpenClawPluginApi);
await plugin.register(api as unknown as OpenClawPluginApi);
let lastAbortSignal: AbortSignal | undefined;
runEmbeddedPiAgent.mockImplementation(async (params: { abortSignal?: AbortSignal }) => {
lastAbortSignal = params.abortSignal;
@@ -918,7 +918,7 @@ describe("active-memory plugin", () => {
agents: ["main"],
logging: true,
};
plugin.register(api as unknown as OpenClawPluginApi);
await plugin.register(api as unknown as OpenClawPluginApi);
await hooks.before_prompt_build(
{ prompt: "what wings should i order? session id cache", messages: [] },
@@ -1037,7 +1037,7 @@ describe("active-memory plugin", () => {
agents: ["main"],
queryMode: "message",
};
plugin.register(api as unknown as OpenClawPluginApi);
await plugin.register(api as unknown as OpenClawPluginApi);
await hooks.before_prompt_build(
{
@@ -1065,7 +1065,7 @@ describe("active-memory plugin", () => {
agents: ["main"],
queryMode: "full",
};
plugin.register(api as unknown as OpenClawPluginApi);
await plugin.register(api as unknown as OpenClawPluginApi);
await hooks.before_prompt_build(
{
@@ -1096,7 +1096,7 @@ describe("active-memory plugin", () => {
agents: ["main"],
queryMode: "recent",
};
plugin.register(api as unknown as OpenClawPluginApi);
await plugin.register(api as unknown as OpenClawPluginApi);
await hooks.before_prompt_build(
{
@@ -1174,7 +1174,7 @@ describe("active-memory plugin", () => {
agents: ["main"],
maxSummaryChars: 40,
};
plugin.register(api as unknown as OpenClawPluginApi);
await plugin.register(api as unknown as OpenClawPluginApi);
runEmbeddedPiAgent.mockResolvedValueOnce({
payloads: [
{
@@ -1211,7 +1211,7 @@ describe("active-memory plugin", () => {
agents: ["main"],
maxSummaryChars: 90,
};
plugin.register(api as unknown as OpenClawPluginApi);
await plugin.register(api as unknown as OpenClawPluginApi);
await hooks.before_prompt_build(
{ prompt: "what wings should i order? prompt-count-check", messages: [] },
@@ -1261,7 +1261,7 @@ describe("active-memory plugin", () => {
transcriptDir: "active-memory-subagents",
logging: true,
};
plugin.register(api as unknown as OpenClawPluginApi);
await plugin.register(api as unknown as OpenClawPluginApi);
const mkdirSpy = vi.spyOn(fs, "mkdir").mockResolvedValue(undefined);
const mkdtempSpy = vi.spyOn(fs, "mkdtemp");
const rmSpy = vi.spyOn(fs, "rm").mockResolvedValue(undefined);
@@ -1305,7 +1305,7 @@ describe("active-memory plugin", () => {
transcriptDir: "C:/temp/escape",
logging: true,
};
plugin.register(api as unknown as OpenClawPluginApi);
await plugin.register(api as unknown as OpenClawPluginApi);
const mkdirSpy = vi.spyOn(fs, "mkdir").mockResolvedValue(undefined);
await hooks.before_prompt_build(
@@ -1342,7 +1342,7 @@ describe("active-memory plugin", () => {
transcriptDir: "active-memory-subagents",
logging: true,
};
plugin.register(api as unknown as OpenClawPluginApi);
await plugin.register(api as unknown as OpenClawPluginApi);
const mkdirSpy = vi.spyOn(fs, "mkdir").mockResolvedValue(undefined);
await hooks.before_prompt_build(
@@ -1409,7 +1409,7 @@ describe("active-memory plugin", () => {
agents: ["main"],
logging: true,
};
plugin.register(api as unknown as OpenClawPluginApi);
await plugin.register(api as unknown as OpenClawPluginApi);
for (let index = 0; index <= 1000; index += 1) {
await hooks.before_prompt_build(

View File

@@ -1496,7 +1496,7 @@ export default definePluginEntry({
agentId: effectiveAgentId,
sessionKey: resolvedSessionKey,
});
return;
return undefined;
}
if (!isEnabledForAgent(config, effectiveAgentId)) {
await persistPluginStatusLines({
@@ -1504,7 +1504,7 @@ export default definePluginEntry({
agentId: effectiveAgentId,
sessionKey: resolvedSessionKey,
});
return;
return undefined;
}
if (!isEligibleInteractiveSession(ctx)) {
await persistPluginStatusLines({
@@ -1512,7 +1512,7 @@ export default definePluginEntry({
agentId: effectiveAgentId,
sessionKey: resolvedSessionKey,
});
return;
return undefined;
}
if (
!isAllowedChatType(config, {
@@ -1526,7 +1526,7 @@ export default definePluginEntry({
agentId: effectiveAgentId,
sessionKey: resolvedSessionKey,
});
return;
return undefined;
}
const query = buildQuery({
latestUserMessage: event.prompt,
@@ -1544,11 +1544,11 @@ export default definePluginEntry({
currentModelId: ctx.modelId,
});
if (!result.summary) {
return;
return undefined;
}
const metadata = buildMetadata(result.summary);
if (!metadata) {
return;
return undefined;
}
return {
prependSystemContext: ACTIVE_MEMORY_PLUGIN_GUIDANCE,

View File

@@ -5,7 +5,7 @@
"description": "OpenClaw Amazon Bedrock provider plugin",
"type": "module",
"dependencies": {
"@aws-sdk/client-bedrock": "3.1024.0"
"@aws-sdk/client-bedrock": "3.1028.0"
},
"devDependencies": {
"@openclaw/plugin-sdk": "workspace:*"

View File

@@ -7,7 +7,6 @@ import {
CLAUDE_CLI_BACKEND_ID,
CLAUDE_CLI_DEFAULT_MODEL_REF,
CLAUDE_CLI_CLEAR_ENV,
CLAUDE_CLI_HOST_MANAGED_ENV,
CLAUDE_CLI_MODEL_ALIASES,
CLAUDE_CLI_SESSION_ID_FIELDS,
normalizeClaudeBackendConfig,
@@ -63,7 +62,6 @@ export function buildAnthropicCliBackend(): CliBackendPlugin {
systemPromptArg: "--append-system-prompt",
systemPromptMode: "append",
systemPromptWhen: "first",
env: { ...CLAUDE_CLI_HOST_MANAGED_ENV },
clearEnv: [...CLAUDE_CLI_CLEAR_ENV],
reliability: {
watchdog: {

View File

@@ -2,7 +2,6 @@ import { describe, expect, it } from "vitest";
import { buildAnthropicCliBackend } from "./cli-backend.js";
import {
CLAUDE_CLI_CLEAR_ENV,
CLAUDE_CLI_HOST_MANAGED_ENV,
normalizeClaudeBackendConfig,
normalizeClaudePermissionArgs,
normalizeClaudeSettingSourcesArgs,
@@ -132,16 +131,19 @@ describe("normalizeClaudeBackendConfig", () => {
expect(normalized?.resumeArgs).toContain("user");
});
it("marks claude cli as host-managed, restricts setting sources, and clears inherited env overrides", () => {
it("leaves claude cli subscription-managed, restricts setting sources, and clears inherited env overrides", () => {
const backend = buildAnthropicCliBackend();
expect(backend.config.env).toEqual(CLAUDE_CLI_HOST_MANAGED_ENV);
expect(backend.config.env).toBeUndefined();
expect(backend.config.args).toContain("--setting-sources");
expect(backend.config.args).toContain("user");
expect(backend.config.resumeArgs).toContain("--setting-sources");
expect(backend.config.resumeArgs).toContain("user");
expect(backend.config.clearEnv).toEqual([...CLAUDE_CLI_CLEAR_ENV]);
expect(backend.config.clearEnv).toContain("ANTHROPIC_API_TOKEN");
expect(backend.config.clearEnv).toContain("ANTHROPIC_BASE_URL");
expect(backend.config.clearEnv).toContain("ANTHROPIC_CUSTOM_HEADERS");
expect(backend.config.clearEnv).toContain("ANTHROPIC_OAUTH_TOKEN");
expect(backend.config.clearEnv).toContain("CLAUDE_CONFIG_DIR");
expect(backend.config.clearEnv).toContain("CLAUDE_CODE_USE_BEDROCK");
expect(backend.config.clearEnv).toContain("CLAUDE_CODE_OAUTH_TOKEN");

View File

@@ -40,10 +40,6 @@ export const CLAUDE_CLI_SESSION_ID_FIELDS = [
"conversationId",
] as const;
export const CLAUDE_CLI_HOST_MANAGED_ENV = {
CLAUDE_CODE_PROVIDER_MANAGED_BY_HOST: "1",
} as const;
// Claude Code honors provider-routing, auth, and config-root env before
// consulting its local login state, so inherited shell overrides must not
// steer OpenClaw-managed Claude CLI runs toward a different provider,
@@ -51,8 +47,11 @@ export const CLAUDE_CLI_HOST_MANAGED_ENV = {
export const CLAUDE_CLI_CLEAR_ENV = [
"ANTHROPIC_API_KEY",
"ANTHROPIC_API_KEY_OLD",
"ANTHROPIC_API_TOKEN",
"ANTHROPIC_AUTH_TOKEN",
"ANTHROPIC_BASE_URL",
"ANTHROPIC_CUSTOM_HEADERS",
"ANTHROPIC_OAUTH_TOKEN",
"ANTHROPIC_UNIX_SOCKET",
"CLAUDE_CONFIG_DIR",
"CLAUDE_CODE_API_KEY_FILE_DESCRIPTOR",

View File

@@ -18,7 +18,7 @@ function runWrapper(apiKey: string | undefined): Record<string, string> | undefi
return {} as never;
};
const wrapper = createAnthropicBetaHeadersWrapper(base, [CONTEXT_1M_BETA]);
wrapper(
void wrapper(
{ provider: "anthropic", id: "claude-opus-4-6" } as never,
{} as never,
{ apiKey } as never,
@@ -64,7 +64,7 @@ describe("anthropic stream wrappers", () => {
extraParams: { context1m: true, serviceTier: "auto" },
} as never);
wrapped?.(
void wrapped?.(
{ provider: "anthropic", api: "anthropic-messages", id: "claude-sonnet-4-6" } as never,
{} as never,
{ apiKey: "sk-ant-oat01-oauth-token" } as never,
@@ -91,7 +91,7 @@ describe("anthropic stream wrappers", () => {
extraParams: { context1m: true, serviceTier: "auto" },
} as never);
wrapped?.(
void wrapped?.(
{ provider: "anthropic", api: "anthropic-messages", id: "claude-sonnet-4-6" } as never,
{} as never,
{ apiKey: "sk-ant-api-123" } as never,
@@ -121,7 +121,7 @@ describe("createAnthropicFastModeWrapper", () => {
};
const wrapper = createAnthropicFastModeWrapper(base, params.enabled ?? true);
wrapper(
void wrapper(
{
provider: params.provider ?? "anthropic",
api: params.api ?? "anthropic-messages",
@@ -177,7 +177,7 @@ describe("createAnthropicServiceTierWrapper", () => {
};
const wrapper = createAnthropicServiceTierWrapper(base, params.serviceTier ?? "auto");
wrapper(
void wrapper(
{
provider: params.provider ?? "anthropic",
api: params.api ?? "anthropic-messages",

View File

@@ -1370,7 +1370,7 @@ describe("BlueBubbles webhook monitor", () => {
mockDispatchReplyWithBufferedBlockDispatcher.mockImplementationOnce(async (params) => {
await params.dispatcherOptions.onReplyStart?.();
await params.dispatcherOptions.deliver({ text: "replying now" }, { kind: "final" });
await params.dispatcherOptions.onIdle?.();
params.dispatcherOptions.onIdle?.();
return EMPTY_DISPATCH_RESULT;
});

View File

@@ -109,7 +109,7 @@ function applyBlueBubblesSetupPatch(
}
function validateBlueBubblesWebhookPath(value: string): string | undefined {
const trimmed = String(value ?? "").trim();
const trimmed = value.trim();
if (!trimmed) {
return "Required";
}
@@ -222,7 +222,7 @@ export const blueBubblesSetupWizard: ChannelSetupWizard = {
currentValue: ({ cfg, accountId }) =>
normalizeOptionalString(resolveBlueBubblesAccount({ cfg, accountId }).config.serverUrl),
validate: ({ value }) => validateBlueBubblesServerUrlInput(value),
normalizeValue: ({ value }) => String(value).trim(),
normalizeValue: ({ value }) => value.trim(),
applySet: async ({ cfg, accountId, value }) =>
applyBlueBubblesSetupPatch(cfg, accountId, {
serverUrl: value,
@@ -241,7 +241,7 @@ export const blueBubblesSetupWizard: ChannelSetupWizard = {
shouldPrompt: ({ credentialValues }) =>
credentialValues[CONFIGURE_CUSTOM_WEBHOOK_FLAG] === "1",
validate: ({ value }) => validateBlueBubblesWebhookPath(value),
normalizeValue: ({ value }) => String(value).trim(),
normalizeValue: ({ value }) => value.trim(),
applySet: async ({ cfg, accountId, value }) =>
applyBlueBubblesSetupPatch(cfg, accountId, {
webhookPath: value,

View File

@@ -65,7 +65,7 @@ describe("browser plugin", () => {
it("forwards per-session browser options into the tool factory", async () => {
const { api, registerTool } = createApi();
await registerBrowserPlugin(api);
registerBrowserPlugin(api);
const tool = registerTool.mock.calls[0]?.[0];
if (typeof tool !== "function") {

View File

@@ -286,7 +286,7 @@ async function callBrowserProxy(params: {
? Math.max(1, Math.floor(params.timeoutMs))
: DEFAULT_BROWSER_PROXY_TIMEOUT_MS;
const gatewayTimeoutMs = proxyTimeoutMs + BROWSER_PROXY_GATEWAY_TIMEOUT_SLACK_MS;
const payload = await browserToolDeps.callGatewayTool<{ payloadJSON?: string; payload?: string }>(
const payload = await browserToolDeps.callGatewayTool(
"node.invoke",
{ timeoutMs: gatewayTimeoutMs },
{

View File

@@ -83,10 +83,12 @@ describe("startBrowserBridgeServer auth", () => {
});
it("serves noVNC bootstrap html without leaking password in Location header", async () => {
let resolveCalls = 0;
const bridge = await startBrowserBridgeServer({
resolved: buildResolvedConfig(),
authToken: "secret-token",
resolveSandboxNoVncToken: (token) => {
resolveCalls += 1;
if (token !== "valid-token") {
return null;
}
@@ -95,8 +97,15 @@ describe("startBrowserBridgeServer auth", () => {
});
servers.push({ stop: () => stopBrowserBridgeServer(bridge.server) });
const res = await fetch(`${bridge.baseUrl}/sandbox/novnc?token=valid-token`);
const unauth = await fetch(`${bridge.baseUrl}/sandbox/novnc?token=valid-token`);
expect(unauth.status).toBe(401);
expect(resolveCalls).toBe(0);
const res = await fetch(`${bridge.baseUrl}/sandbox/novnc?token=valid-token`, {
headers: { Authorization: "Bearer secret-token" },
});
expect(res.status).toBe(200);
expect(resolveCalls).toBe(1);
expect(res.headers.get("location")).toBeNull();
expect(res.headers.get("cache-control")).toContain("no-store");
expect(res.headers.get("referrer-policy")).toBe("no-referrer");

View File

@@ -13,6 +13,7 @@ import {
type ProfileContext,
} from "./server-context.js";
import {
hasVerifiedBrowserAuth,
installBrowserAuthMiddleware,
installBrowserCommonMiddleware,
} from "./server-middleware.js";
@@ -76,8 +77,19 @@ export async function startBrowserBridgeServer(params: {
const app = express();
installBrowserCommonMiddleware(app);
const authToken = normalizeOptionalString(params.authToken);
const authPassword = normalizeOptionalString(params.authPassword);
if (!authToken && !authPassword) {
throw new Error("bridge server requires auth (authToken/authPassword missing)");
}
installBrowserAuthMiddleware(app, { token: authToken, password: authPassword });
if (params.resolveSandboxNoVncToken) {
app.get("/sandbox/novnc", (req, res) => {
if (!hasVerifiedBrowserAuth(req)) {
res.status(401).send("Unauthorized");
return;
}
res.setHeader("Cache-Control", "no-store, no-cache, must-revalidate, proxy-revalidate");
res.setHeader("Pragma", "no-cache");
res.setHeader("Expires", "0");
@@ -96,13 +108,6 @@ export async function startBrowserBridgeServer(params: {
});
}
const authToken = normalizeOptionalString(params.authToken);
const authPassword = normalizeOptionalString(params.authPassword);
if (!authToken && !authPassword) {
throw new Error("bridge server requires auth (authToken/authPassword missing)");
}
installBrowserAuthMiddleware(app, { token: authToken, password: authPassword });
const state: BrowserServerState = {
server: null as unknown as Server,
port,

View File

@@ -0,0 +1,65 @@
import { afterEach, describe, expect, it, vi } from "vitest";
const fetchWithSsrFGuardMock = vi.hoisted(() => vi.fn());
vi.mock("openclaw/plugin-sdk/ssrf-runtime", async (importOriginal) => {
const actual = await importOriginal<typeof import("openclaw/plugin-sdk/ssrf-runtime")>();
return {
...actual,
fetchWithSsrFGuard: (...args: unknown[]) => fetchWithSsrFGuardMock(...args),
};
});
import { fetchJson, fetchOk } from "./cdp.helpers.js";
describe("cdp helpers", () => {
afterEach(() => {
fetchWithSsrFGuardMock.mockReset();
});
it("releases guarded CDP fetches after the response body is consumed", async () => {
const release = vi.fn(async () => {});
const json = vi.fn(async () => {
expect(release).not.toHaveBeenCalled();
return { ok: true };
});
fetchWithSsrFGuardMock.mockResolvedValueOnce({
response: {
ok: true,
status: 200,
json,
},
release,
});
await expect(
fetchJson("http://127.0.0.1:9222/json/version", 250, undefined, {
dangerouslyAllowPrivateNetwork: false,
allowedHostnames: ["127.0.0.1"],
}),
).resolves.toEqual({ ok: true });
expect(json).toHaveBeenCalledTimes(1);
expect(release).toHaveBeenCalledTimes(1);
});
it("releases guarded CDP fetches for bodyless requests", async () => {
const release = vi.fn(async () => {});
fetchWithSsrFGuardMock.mockResolvedValueOnce({
response: {
ok: true,
status: 200,
},
release,
});
await expect(
fetchOk("http://127.0.0.1:9222/json/close/TARGET_1", 250, undefined, {
dangerouslyAllowPrivateNetwork: false,
allowedHostnames: ["127.0.0.1"],
}),
).resolves.toBeUndefined();
expect(release).toHaveBeenCalledTimes(1);
});
});

View File

@@ -1,11 +1,17 @@
import { fetchWithSsrFGuard } from "openclaw/plugin-sdk/ssrf-runtime";
import { normalizeLowercaseStringOrEmpty } from "openclaw/plugin-sdk/text-runtime";
import WebSocket from "ws";
import { isLoopbackHost } from "../gateway/net.js";
import { type SsrFPolicy, resolvePinnedHostnameWithPolicy } from "../infra/net/ssrf.js";
import {
SsrFBlockedError,
type SsrFPolicy,
resolvePinnedHostnameWithPolicy,
} from "../infra/net/ssrf.js";
import { rawDataToString } from "../infra/ws.js";
import { redactSensitiveText } from "../logging/redact.js";
import { getDirectAgentForCdp, withNoProxyForCdpUrl } from "./cdp-proxy-bypass.js";
import { CDP_HTTP_REQUEST_TIMEOUT_MS, CDP_WS_HANDSHAKE_TIMEOUT_MS } from "./cdp-timeouts.js";
import { BrowserCdpEndpointBlockedError } from "./errors.js";
import { resolveBrowserRateLimitMessage } from "./rate-limit-message.js";
export { isLoopbackHost };
@@ -62,9 +68,13 @@ export async function assertCdpEndpointAllowed(
if (!["http:", "https:", "ws:", "wss:"].includes(parsed.protocol)) {
throw new Error(`Invalid CDP URL protocol: ${parsed.protocol.replace(":", "")}`);
}
await resolvePinnedHostnameWithPolicy(parsed.hostname, {
policy: ssrfPolicy,
});
try {
await resolvePinnedHostnameWithPolicy(parsed.hostname, {
policy: ssrfPolicy,
});
} catch (error) {
throw new BrowserCdpEndpointBlockedError({ cause: error });
}
}
export function redactCdpUrl(cdpUrl: string | null | undefined): string | null | undefined {
@@ -152,6 +162,11 @@ export function normalizeCdpHttpBaseForJsonEndpoints(cdpUrl: string): string {
}
}
type CdpFetchResult = {
response: Response;
release: () => Promise<void>;
};
function createCdpSender(ws: WebSocket) {
let nextId = 1;
const pending = new Map<number, Pending>();
@@ -217,23 +232,47 @@ export async function fetchJson<T>(
url: string,
timeoutMs = CDP_HTTP_REQUEST_TIMEOUT_MS,
init?: RequestInit,
ssrfPolicy?: SsrFPolicy,
): Promise<T> {
const res = await fetchCdpChecked(url, timeoutMs, init);
return (await res.json()) as T;
const { response, release } = await fetchCdpChecked(url, timeoutMs, init, ssrfPolicy);
try {
return (await response.json()) as T;
} finally {
await release();
}
}
export async function fetchCdpChecked(
url: string,
timeoutMs = CDP_HTTP_REQUEST_TIMEOUT_MS,
init?: RequestInit,
): Promise<Response> {
ssrfPolicy?: SsrFPolicy,
): Promise<CdpFetchResult> {
const ctrl = new AbortController();
const t = setTimeout(ctrl.abort.bind(ctrl), timeoutMs);
let guardedRelease: (() => Promise<void>) | undefined;
let released = false;
const release = async () => {
if (released) {
return;
}
released = true;
clearTimeout(t);
await guardedRelease?.();
};
try {
const headers = getHeadersWithAuth(url, (init?.headers as Record<string, string>) || {});
const res = await withNoProxyForCdpUrl(url, () =>
fetch(url, { ...init, headers, signal: ctrl.signal }),
);
const res = await withNoProxyForCdpUrl(url, async () => {
const guarded = await fetchWithSsrFGuard({
url,
init: { ...init, headers },
signal: ctrl.signal,
policy: ssrfPolicy ?? { allowPrivateNetwork: true },
auditContext: "browser-cdp",
});
guardedRelease = guarded.release;
return guarded.response;
});
if (!res.ok) {
if (res.status === 429) {
// Do not reflect upstream response text into the error surface (log/agent injection risk)
@@ -241,9 +280,13 @@ export async function fetchCdpChecked(
}
throw new Error(`HTTP ${res.status}`);
}
return res;
} finally {
clearTimeout(t);
return { response: res, release };
} catch (error) {
await release();
if (error instanceof SsrFBlockedError) {
throw new BrowserCdpEndpointBlockedError({ cause: error });
}
throw error;
}
}
@@ -251,8 +294,10 @@ export async function fetchOk(
url: string,
timeoutMs = CDP_HTTP_REQUEST_TIMEOUT_MS,
init?: RequestInit,
ssrfPolicy?: SsrFPolicy,
): Promise<void> {
await fetchCdpChecked(url, timeoutMs, init);
const { release } = await fetchCdpChecked(url, timeoutMs, init, ssrfPolicy);
await release();
}
export function openCdpWebSocket(

View File

@@ -1,13 +1,29 @@
import { createServer } from "node:http";
import { afterEach, describe, expect, it, vi } from "vitest";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { type WebSocket, WebSocketServer } from "ws";
import { SsrFBlockedError } from "../infra/net/ssrf.js";
import { rawDataToString } from "../infra/ws.js";
import { isWebSocketUrl } from "./cdp.helpers.js";
import { createTargetViaCdp, evaluateJavaScript, normalizeCdpWsUrl, snapshotAria } from "./cdp.js";
import { parseHttpUrl } from "./config.js";
import { BrowserCdpEndpointBlockedError } from "./errors.js";
import { InvalidBrowserNavigationUrlError } from "./navigation-guard.js";
vi.mock("openclaw/plugin-sdk/browser-security-runtime", async () => {
const actual = await vi.importActual<
typeof import("openclaw/plugin-sdk/browser-security-runtime")
>("openclaw/plugin-sdk/browser-security-runtime");
const lookupFn = async (_hostname: string, options?: { all?: boolean }) => {
const result = { address: "93.184.216.34", family: 4 };
return options?.all === true ? [result] : result;
};
return {
...actual,
resolvePinnedHostnameWithPolicy: (hostname: string, params: object = {}) =>
actual.resolvePinnedHostnameWithPolicy(hostname, { ...params, lookupFn: lookupFn as never }),
};
});
describe("cdp", () => {
let httpServer: ReturnType<typeof createServer> | null = null;
let wsServer: WebSocketServer | null = null;
@@ -56,6 +72,7 @@ describe("cdp", () => {
};
afterEach(async () => {
vi.unstubAllEnvs();
await new Promise<void>((resolve) => {
if (!httpServer) {
return resolve();
@@ -185,6 +202,22 @@ describe("cdp", () => {
}
});
it("blocks hostname navigation targets when strict SSRF policy is configured", async () => {
const fetchSpy = vi.spyOn(globalThis, "fetch");
try {
await expect(
createTargetViaCdp({
cdpUrl: "http://127.0.0.1:9222",
url: "https://example.com",
ssrfPolicy: { dangerouslyAllowPrivateNetwork: false },
}),
).rejects.toBeInstanceOf(InvalidBrowserNavigationUrlError);
expect(fetchSpy).not.toHaveBeenCalled();
} finally {
fetchSpy.mockRestore();
}
});
it("blocks unsupported non-network navigation URLs", async () => {
const fetchSpy = vi.spyOn(globalThis, "fetch");
try {
@@ -235,39 +268,39 @@ describe("cdp", () => {
await expect(
createTargetViaCdp({
cdpUrl: `http://127.0.0.1:${httpPort}`,
url: "https://example.com",
url: "https://93.184.216.34",
ssrfPolicy: {
dangerouslyAllowPrivateNetwork: false,
allowedHostnames: ["127.0.0.1"],
},
}),
).rejects.toBeInstanceOf(SsrFBlockedError);
).rejects.toBeInstanceOf(BrowserCdpEndpointBlockedError);
});
it("blocks the initial /json/version fetch when the cdpUrl host is outside strict SSRF policy", async () => {
await expect(
createTargetViaCdp({
cdpUrl: "http://169.254.169.254:9222",
url: "https://example.com",
url: "https://93.184.216.34",
ssrfPolicy: {
dangerouslyAllowPrivateNetwork: false,
allowedHostnames: ["127.0.0.1"],
},
}),
).rejects.toBeInstanceOf(SsrFBlockedError);
).rejects.toBeInstanceOf(BrowserCdpEndpointBlockedError);
});
it("blocks direct websocket cdp urls outside strict SSRF policy", async () => {
await expect(
createTargetViaCdp({
cdpUrl: "ws://169.254.169.254:9222/devtools/browser/PIVOT",
url: "https://example.com",
url: "https://93.184.216.34",
ssrfPolicy: {
dangerouslyAllowPrivateNetwork: false,
allowedHostnames: ["127.0.0.1"],
},
}),
).rejects.toBeInstanceOf(SsrFBlockedError);
).rejects.toBeInstanceOf(BrowserCdpEndpointBlockedError);
});
it("evaluates javascript via CDP", async () => {
@@ -470,3 +503,17 @@ describe("parseHttpUrl with WebSocket protocols", () => {
expect(() => parseHttpUrl("file:///etc/passwd", "test")).toThrow("must be http(s) or ws(s)");
});
});
const proxyEnvKeys = [
"ALL_PROXY",
"all_proxy",
"HTTP_PROXY",
"http_proxy",
"HTTPS_PROXY",
"https_proxy",
] as const;
beforeEach(() => {
for (const key of proxyEnvKeys) {
vi.stubEnv(key, "");
}
});

View File

@@ -78,8 +78,8 @@ export async function captureScreenshot(opts: {
contentSize?: { width?: number; height?: number };
};
const size = metrics?.cssContentSize ?? metrics?.contentSize;
const contentWidth = Number(size?.width ?? 0);
const contentHeight = Number(size?.height ?? 0);
const contentWidth = size?.width ?? 0;
const contentHeight = size?.height ?? 0;
if (contentWidth > 0 && contentHeight > 0) {
const vpResult = (await send("Runtime.evaluate", {
expression:
@@ -91,14 +91,14 @@ export async function captureScreenshot(opts: {
};
};
const v = vpResult?.result?.value;
const currentW = Number(v?.w ?? 0);
const currentH = Number(v?.h ?? 0);
const currentW = v?.w ?? 0;
const currentH = v?.h ?? 0;
savedVp = {
w: currentW,
h: currentH,
dpr: Number(v?.dpr ?? 1),
sw: Number(v?.sw ?? currentW),
sh: Number(v?.sh ?? currentH),
dpr: v?.dpr ?? 1,
sw: v?.sw ?? currentW,
sh: v?.sh ?? currentH,
};
// mobile: false is the safe default — CDP provides no way to query
// the active mobile flag, and inferring from navigator.maxTouchPoints
@@ -148,11 +148,7 @@ export async function captureScreenshot(opts: {
returnByValue: true,
})) as { result?: { value?: { w?: number; h?: number; dpr?: number } } };
const p = postResult?.result?.value;
if (
Number(p?.w) !== savedVp.w ||
Number(p?.h) !== savedVp.h ||
Number(p?.dpr) !== savedVp.dpr
) {
if (p?.w !== savedVp.w || p?.h !== savedVp.h || p?.dpr !== savedVp.dpr) {
await send("Emulation.setDeviceMetricsOverride", {
width: savedVp.w,
height: savedVp.h,
@@ -187,12 +183,13 @@ export async function createTargetViaCdp(opts: {
wsUrl = opts.cdpUrl;
} else {
// Standard HTTP(S) CDP endpoint — discover WebSocket URL via /json/version.
await assertCdpEndpointAllowed(opts.cdpUrl, opts.ssrfPolicy);
const version = await fetchJson<{ webSocketDebuggerUrl?: string }>(
appendCdpPath(opts.cdpUrl, "/json/version"),
1500,
undefined,
opts.ssrfPolicy,
);
const wsUrlRaw = String(version?.webSocketDebuggerUrl ?? "").trim();
const wsUrlRaw = version?.webSocketDebuggerUrl?.trim() ?? "";
wsUrl = wsUrlRaw ? normalizeCdpWsUrl(wsUrlRaw, opts.cdpUrl) : "";
if (!wsUrl) {
throw new Error("CDP /json/version missing webSocketDebuggerUrl");
@@ -204,7 +201,7 @@ export async function createTargetViaCdp(opts: {
const created = (await send("Target.createTarget", { url: opts.url })) as {
targetId?: string;
};
const targetId = String(created?.targetId ?? "").trim();
const targetId = created?.targetId?.trim() ?? "";
if (!targetId) {
throw new Error("CDP Target.createTarget returned no targetId");
}

View File

@@ -1,6 +1,6 @@
import { normalizeLowercaseStringOrEmpty } from "openclaw/plugin-sdk/text-runtime";
import { normalizeString } from "../record-shared.js";
import type { SnapshotAriaNode } from "./client.js";
import type { SnapshotAriaNode } from "./client.types.js";
import {
getRoleSnapshotStats,
type RoleRefMap,

View File

@@ -7,7 +7,7 @@ import { normalizeOptionalString, readStringValue } from "openclaw/plugin-sdk/te
import { resolvePreferredOpenClawTmpDir } from "../infra/tmp-openclaw-dir.js";
import { asRecord } from "../record-shared.js";
import type { ChromeMcpSnapshotNode } from "./chrome-mcp.snapshot.js";
import type { BrowserTab } from "./client.js";
import type { BrowserTab } from "./client.types.js";
import { BrowserProfileUnavailableError, BrowserTabNotFoundError } from "./errors.js";
type ChromeMcpStructuredPage = {

View File

@@ -691,7 +691,7 @@ export function readBrowserVersion(executablePath: string): string | null {
}
export function parseBrowserMajorVersion(rawVersion: string | null | undefined): number | null {
const matches = [...String(rawVersion ?? "").matchAll(CHROME_VERSION_RE)];
const matches = [...(rawVersion ?? "").matchAll(CHROME_VERSION_RE)];
const match = matches.at(-1);
if (!match?.[1]) {
return null;

View File

@@ -6,7 +6,6 @@ import os from "node:os";
import path from "node:path";
import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
import { WebSocketServer } from "ws";
import { SsrFBlockedError } from "../infra/net/ssrf.js";
import {
decorateOpenClawProfile,
ensureProfileCleanExit,
@@ -22,6 +21,7 @@ import {
DEFAULT_OPENCLAW_BROWSER_COLOR,
DEFAULT_OPENCLAW_BROWSER_PROFILE_NAME,
} from "./constants.js";
import { BrowserCdpEndpointBlockedError } from "./errors.js";
type StopChromeTarget = Parameters<typeof stopOpenClawChrome>[0];
@@ -357,7 +357,7 @@ describe("browser chrome helpers", () => {
dangerouslyAllowPrivateNetwork: false,
allowedHostnames: ["127.0.0.1"],
}),
).rejects.toBeInstanceOf(SsrFBlockedError);
).rejects.toBeInstanceOf(BrowserCdpEndpointBlockedError);
} finally {
await new Promise<void>((resolve) => server.close(() => resolve()));
}

View File

@@ -171,14 +171,22 @@ async function fetchChromeVersion(
const ctrl = new AbortController();
const t = setTimeout(ctrl.abort.bind(ctrl), timeoutMs);
try {
await assertCdpEndpointAllowed(cdpUrl, ssrfPolicy);
const versionUrl = appendCdpPath(cdpUrl, "/json/version");
const res = await fetchCdpChecked(versionUrl, timeoutMs, { signal: ctrl.signal });
const data = (await res.json()) as ChromeVersion;
if (!data || typeof data !== "object") {
return null;
const { response, release } = await fetchCdpChecked(
versionUrl,
timeoutMs,
{ signal: ctrl.signal },
ssrfPolicy,
);
try {
const data = (await response.json()) as ChromeVersion;
if (!data || typeof data !== "object") {
return null;
}
return data;
} finally {
await release();
}
return data;
} catch {
return null;
} finally {

View File

@@ -4,95 +4,10 @@ import type {
BrowserActionTabResult,
} from "./client-actions-types.js";
import { buildProfileQuery, withBaseUrl } from "./client-actions-url.js";
import type { BrowserActRequest, BrowserFormField } from "./client-actions.types.js";
import { fetchBrowserJson } from "./client-fetch.js";
export type BrowserFormField = {
ref: string;
type: string;
value?: string | number | boolean;
};
export type BrowserActRequest =
| {
kind: "click";
ref?: string;
selector?: string;
targetId?: string;
doubleClick?: boolean;
button?: string;
modifiers?: string[];
delayMs?: number;
timeoutMs?: number;
}
| {
kind: "type";
ref?: string;
selector?: string;
text: string;
targetId?: string;
submit?: boolean;
slowly?: boolean;
timeoutMs?: number;
}
| { kind: "press"; key: string; targetId?: string; delayMs?: number }
| {
kind: "hover";
ref?: string;
selector?: string;
targetId?: string;
timeoutMs?: number;
}
| {
kind: "scrollIntoView";
ref?: string;
selector?: string;
targetId?: string;
timeoutMs?: number;
}
| {
kind: "drag";
startRef?: string;
startSelector?: string;
endRef?: string;
endSelector?: string;
targetId?: string;
timeoutMs?: number;
}
| {
kind: "select";
ref?: string;
selector?: string;
values: string[];
targetId?: string;
timeoutMs?: number;
}
| {
kind: "fill";
fields: BrowserFormField[];
targetId?: string;
timeoutMs?: number;
}
| { kind: "resize"; width: number; height: number; targetId?: string }
| {
kind: "wait";
timeMs?: number;
text?: string;
textGone?: string;
selector?: string;
url?: string;
loadState?: "load" | "domcontentloaded" | "networkidle";
fn?: string;
targetId?: string;
timeoutMs?: number;
}
| { kind: "evaluate"; fn: string; ref?: string; targetId?: string; timeoutMs?: number }
| { kind: "close"; targetId?: string }
| {
kind: "batch";
actions: BrowserActRequest[];
targetId?: string;
stopOnError?: boolean;
};
export type { BrowserActRequest, BrowserFormField } from "./client-actions.types.js";
export type BrowserActResponse = {
ok: true;

View File

@@ -0,0 +1,87 @@
export type BrowserFormField = {
ref: string;
type: string;
value?: string | number | boolean;
};
export type BrowserActRequest =
| {
kind: "click";
ref?: string;
selector?: string;
targetId?: string;
doubleClick?: boolean;
button?: string;
modifiers?: string[];
delayMs?: number;
timeoutMs?: number;
}
| {
kind: "type";
ref?: string;
selector?: string;
text: string;
targetId?: string;
submit?: boolean;
slowly?: boolean;
timeoutMs?: number;
}
| { kind: "press"; key: string; targetId?: string; delayMs?: number }
| {
kind: "hover";
ref?: string;
selector?: string;
targetId?: string;
timeoutMs?: number;
}
| {
kind: "scrollIntoView";
ref?: string;
selector?: string;
targetId?: string;
timeoutMs?: number;
}
| {
kind: "drag";
startRef?: string;
startSelector?: string;
endRef?: string;
endSelector?: string;
targetId?: string;
timeoutMs?: number;
}
| {
kind: "select";
ref?: string;
selector?: string;
values: string[];
targetId?: string;
timeoutMs?: number;
}
| {
kind: "fill";
fields: BrowserFormField[];
targetId?: string;
timeoutMs?: number;
}
| { kind: "resize"; width: number; height: number; targetId?: string }
| {
kind: "wait";
timeMs?: number;
text?: string;
textGone?: string;
selector?: string;
url?: string;
loadState?: "load" | "domcontentloaded" | "networkidle";
fn?: string;
targetId?: string;
timeoutMs?: number;
}
| { kind: "evaluate"; fn: string; ref?: string; targetId?: string; timeoutMs?: number }
| { kind: "close"; targetId?: string }
| {
kind: "batch";
actions: BrowserActRequest[];
targetId?: string;
stopOnError?: boolean;
};

View File

@@ -1,6 +1,42 @@
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import type { BrowserDispatchResponse } from "./routes/dispatcher.js";
vi.mock("openclaw/plugin-sdk/browser-security-runtime", async () => {
const actual = await vi.importActual<
typeof import("openclaw/plugin-sdk/browser-security-runtime")
>("openclaw/plugin-sdk/browser-security-runtime");
const lookupFn = async (_hostname: string, options?: { all?: boolean }) => {
const result = { address: "93.184.216.34", family: 4 };
return options?.all === true ? [result] : result;
};
return {
...actual,
resolvePinnedHostnameWithPolicy: (hostname: string, params: object = {}) =>
actual.resolvePinnedHostnameWithPolicy(hostname, { ...params, lookupFn: lookupFn as never }),
};
});
vi.mock("openclaw/plugin-sdk/ssrf-runtime", async () => {
const actual = await vi.importActual<typeof import("openclaw/plugin-sdk/ssrf-runtime")>(
"openclaw/plugin-sdk/ssrf-runtime",
);
return {
...actual,
fetchWithSsrFGuard: async (params: {
url: string;
init?: RequestInit;
signal?: AbortSignal;
}) => ({
response: await fetch(params.url, {
...params.init,
signal: params.signal,
}),
finalUrl: params.url,
release: async () => {},
}),
};
});
function okDispatchResponse(): BrowserDispatchResponse {
return { status: 200, body: { ok: true } };
}
@@ -87,6 +123,16 @@ async function expectThrownBrowserFetchError(
describe("fetchBrowserJson loopback auth", () => {
beforeEach(() => {
vi.restoreAllMocks();
for (const key of [
"ALL_PROXY",
"all_proxy",
"HTTP_PROXY",
"http_proxy",
"HTTPS_PROXY",
"https_proxy",
]) {
vi.stubEnv(key, "");
}
vi.stubEnv("OPENCLAW_GATEWAY_TOKEN", "loopback-token");
mocks.loadConfig.mockClear();
mocks.loadConfig.mockReturnValue({

View File

@@ -1,3 +1,4 @@
import { fetchWithSsrFGuard } from "openclaw/plugin-sdk/ssrf-runtime";
import { normalizeOptionalString } from "openclaw/plugin-sdk/text-runtime";
import { normalizeLowercaseStringOrEmpty } from "openclaw/plugin-sdk/text-runtime";
import { formatCliCommand } from "../cli/command-format.js";
@@ -5,12 +6,7 @@ import { loadConfig } from "../config/config.js";
import { isLoopbackHost } from "../gateway/net.js";
import { getBridgeAuthForPort } from "./bridge-auth-registry.js";
import { resolveBrowserControlAuth } from "./control-auth.js";
import {
createBrowserControlContext,
startBrowserControlServiceFromConfig,
} from "./control-service.js";
import { resolveBrowserRateLimitMessage } from "./rate-limit-message.js";
import { createBrowserRouteDispatcher } from "./routes/dispatcher.js";
// Application-level error from the browser control service (service is reachable
// but returned an error response). Must NOT be wrapped with "Can't reach ..." messaging.
@@ -188,8 +184,17 @@ async function fetchHttpJson<T>(
}
const t = setTimeout(() => ctrl.abort(new Error("timed out")), timeoutMs);
let release: (() => Promise<void>) | undefined;
try {
const res = await fetch(url, { ...init, signal: ctrl.signal });
const guarded = await fetchWithSsrFGuard({
url,
init,
signal: ctrl.signal,
policy: { allowPrivateNetwork: true },
auditContext: "browser-control-client",
});
release = guarded.release;
const res = guarded.response;
if (!res.ok) {
if (isRateLimitStatus(res.status)) {
// Do not reflect upstream response text into the error surface (log/agent injection risk)
@@ -204,6 +209,7 @@ async function fetchHttpJson<T>(
return (await res.json()) as T;
} finally {
clearTimeout(t);
await release?.();
if (upstreamSignal && upstreamAbortListener) {
upstreamSignal.removeEventListener("abort", upstreamAbortListener);
}
@@ -222,11 +228,7 @@ export async function fetchBrowserJson<T>(
return await fetchHttpJson<T>(url, { ...httpInit, timeoutMs });
}
isDispatcherPath = true;
const started = await startBrowserControlServiceFromConfig();
if (!started) {
throw new Error("browser control disabled");
}
const dispatcher = createBrowserRouteDispatcher(createBrowserControlContext());
const { dispatchBrowserControlRequest } = await import("./local-dispatch.runtime.js");
const parsed = new URL(url, "http://localhost");
const query: Record<string, unknown> = {};
for (const [key, value] of parsed.searchParams.entries()) {
@@ -266,7 +268,7 @@ export async function fetchBrowserJson<T>(
timer = setTimeout(() => abortCtrl.abort(new Error("timed out")), timeoutMs);
}
const dispatchPromise = dispatcher.dispatch({
const dispatchPromise = dispatchBrowserControlRequest({
method:
init?.method?.toUpperCase() === "DELETE"
? "DELETE"

View File

@@ -1,6 +1,7 @@
import { fetchBrowserJson } from "./client-fetch.js";
import type { BrowserTab, BrowserTransport, SnapshotAriaNode } from "./client.types.js";
export type BrowserTransport = "cdp" | "chrome-mcp";
export type { BrowserTab, BrowserTransport, SnapshotAriaNode } from "./client.types.js";
export type BrowserStatus = {
enabled: boolean;
@@ -47,24 +48,6 @@ export type BrowserResetProfileResult = {
to?: string;
};
export type BrowserTab = {
targetId: string;
title: string;
url: string;
wsUrl?: string;
type?: string;
};
export type SnapshotAriaNode = {
ref: string;
role: string;
name: string;
value?: string;
description?: string;
backendDOMNodeId?: number;
depth: number;
};
export type SnapshotResult =
| {
ok: true;

View File

@@ -0,0 +1,19 @@
export type BrowserTransport = "cdp" | "chrome-mcp";
export type BrowserTab = {
targetId: string;
title: string;
url: string;
wsUrl?: string;
type?: string;
};
export type SnapshotAriaNode = {
ref: string;
role: string;
name: string;
value?: string;
description?: string;
backendDOMNodeId?: number;
depth: number;
};

View File

@@ -307,11 +307,9 @@ describe("browser config", () => {
});
});
it("defaults browser SSRF policy to trusted-network mode", () => {
it("defaults browser SSRF policy to strict mode when unset", () => {
const resolved = resolveBrowserConfig({});
expect(resolved.ssrfPolicy).toEqual({
dangerouslyAllowPrivateNetwork: true,
});
expect(resolved.ssrfPolicy).toEqual({});
});
it("supports explicit strict mode by disabling private network access", () => {
@@ -323,6 +321,19 @@ describe("browser config", () => {
expect(resolved.ssrfPolicy).toEqual({});
});
it("keeps allowlist-only browser SSRF policy strict by default", () => {
const resolved = resolveBrowserConfig({
ssrfPolicy: {
allowedHostnames: ["example.com"],
hostnameAllowlist: ["*.example.com"],
},
} as unknown as BrowserConfig);
expect(resolved.ssrfPolicy).toEqual({
allowedHostnames: ["example.com"],
hostnameAllowlist: ["*.example.com"],
});
});
it("resolves existing-session profiles without cdpPort or cdpUrl", () => {
const resolved = resolveBrowserConfig({
profiles: {

View File

@@ -42,6 +42,14 @@ export {
export type { BrowserControlAuth };
export { parseBrowserHttpUrl as parseHttpUrl };
type BrowserSsrFPolicyCompat = NonNullable<BrowserConfig["ssrfPolicy"]> & {
/**
* Legacy raw-config alias. Keep it out of the public BrowserConfig type while
* still accepting old user files until doctor rewrites them.
*/
allowPrivateNetwork?: boolean;
};
export type ResolvedBrowserConfig = {
enabled: boolean;
evaluateEnabled: boolean;
@@ -119,9 +127,7 @@ function resolveCdpPortRangeStart(
const normalizeStringList = normalizeOptionalTrimmedStringList;
function resolveBrowserSsrFPolicy(cfg: BrowserConfig | undefined): SsrFPolicy | undefined {
const rawPolicy = cfg?.ssrfPolicy as
| (BrowserConfig["ssrfPolicy"] & { allowPrivateNetwork?: boolean })
| undefined;
const rawPolicy = cfg?.ssrfPolicy as BrowserSsrFPolicyCompat | undefined;
const allowPrivateNetwork = rawPolicy?.allowPrivateNetwork;
const dangerouslyAllowPrivateNetwork = rawPolicy?.dangerouslyAllowPrivateNetwork;
const allowedHostnames = normalizeStringList(rawPolicy?.allowedHostnames);
@@ -129,9 +135,7 @@ function resolveBrowserSsrFPolicy(cfg: BrowserConfig | undefined): SsrFPolicy |
const hasExplicitPrivateSetting =
allowPrivateNetwork !== undefined || dangerouslyAllowPrivateNetwork !== undefined;
const resolvedAllowPrivateNetwork =
dangerouslyAllowPrivateNetwork === true ||
allowPrivateNetwork === true ||
!hasExplicitPrivateSetting;
dangerouslyAllowPrivateNetwork === true || allowPrivateNetwork === true;
if (
!resolvedAllowPrivateNetwork &&
@@ -139,7 +143,9 @@ function resolveBrowserSsrFPolicy(cfg: BrowserConfig | undefined): SsrFPolicy |
!allowedHostnames &&
!hostnameAllowlist
) {
return undefined;
// Keep the default policy object present so CDP guards still enforce
// fail-closed private-network checks on unconfigured installs.
return {};
}
return {

View File

@@ -9,7 +9,7 @@ const mocks = vi.hoisted(() => ({
({
authConfig,
}: {
authConfig?: NonNullable<NonNullable<OpenClawConfig["gateway"]>["auth"]> | undefined;
authConfig?: NonNullable<NonNullable<OpenClawConfig["gateway"]>["auth"]>;
}) => {
const token =
typeof authConfig?.token === "string"
@@ -58,6 +58,14 @@ vi.mock("../gateway/auth.js", () => ({
resolveGatewayAuth: mocks.resolveGatewayAuth,
}));
function readPersistedConfig(): OpenClawConfig {
const persistedCfg = mocks.writeConfigFile.mock.calls[0]?.[0];
if (!persistedCfg) {
throw new Error("expected persisted config");
}
return persistedCfg;
}
let ensureBrowserControlAuth: typeof import("./control-auth.js").ensureBrowserControlAuth;
describe("ensureBrowserControlAuth", () => {
@@ -176,7 +184,7 @@ describe("ensureBrowserControlAuth", () => {
expect(result.auth.token).toBe(result.generatedToken);
expect(result.auth.password).toBeUndefined();
expect(mocks.writeConfigFile).toHaveBeenCalledTimes(1);
const persistedCfg = mocks.writeConfigFile.mock.calls[0]?.[0] as OpenClawConfig | undefined;
const persistedCfg = readPersistedConfig();
expect(persistedCfg?.gateway?.auth?.mode).toBe("none");
expect(persistedCfg?.gateway?.auth?.token).toBe(result.generatedToken);
expect(mocks.ensureGatewayStartupAuth).not.toHaveBeenCalled();
@@ -223,7 +231,7 @@ describe("ensureBrowserControlAuth", () => {
expect(result.auth.token).toBe(result.generatedToken);
expect(result.auth.password).toBeUndefined();
expect(mocks.writeConfigFile).toHaveBeenCalledTimes(1);
const persistedCfg = mocks.writeConfigFile.mock.calls[0]?.[0] as OpenClawConfig | undefined;
const persistedCfg = readPersistedConfig();
expect(persistedCfg?.gateway?.auth?.mode).toBe("none");
expect(persistedCfg?.gateway?.auth?.token).toBe(result.generatedToken);
expect(mocks.ensureGatewayStartupAuth).not.toHaveBeenCalled();
@@ -246,7 +254,7 @@ describe("ensureBrowserControlAuth", () => {
expect(result.auth.password).toBe(result.generatedToken);
expect(result.auth.token).toBeUndefined();
expect(mocks.writeConfigFile).toHaveBeenCalledTimes(1);
const persistedCfg = mocks.writeConfigFile.mock.calls[0]?.[0] as OpenClawConfig | undefined;
const persistedCfg = readPersistedConfig();
expect(persistedCfg?.gateway?.auth?.mode).toBe("trusted-proxy");
expect(persistedCfg?.gateway?.auth?.password).toBe(result.generatedToken);
expect(mocks.ensureGatewayStartupAuth).not.toHaveBeenCalled();
@@ -273,7 +281,7 @@ describe("ensureBrowserControlAuth", () => {
expect(result.auth.password).toBe(result.generatedToken);
expect(result.auth.token).toBeUndefined();
expect(mocks.writeConfigFile).toHaveBeenCalledTimes(1);
const persistedCfg = mocks.writeConfigFile.mock.calls[0]?.[0] as OpenClawConfig | undefined;
const persistedCfg = readPersistedConfig();
expect(persistedCfg?.gateway?.auth?.mode).toBe("trusted-proxy");
expect(persistedCfg?.gateway?.auth?.password).toBe(result.generatedToken);
expect(mocks.ensureGatewayStartupAuth).not.toHaveBeenCalled();

View File

@@ -1,5 +1,12 @@
import { describe, expect, it } from "vitest";
import { BrowserValidationError, toBrowserErrorResponse } from "./errors.js";
import { SsrFBlockedError } from "../infra/net/ssrf.js";
import {
BROWSER_ENDPOINT_BLOCKED_MESSAGE,
BROWSER_NAVIGATION_BLOCKED_MESSAGE,
BrowserCdpEndpointBlockedError,
BrowserValidationError,
toBrowserErrorResponse,
} from "./errors.js";
describe("browser error mapping", () => {
it("maps blocked browser targets to conflict responses", () => {
@@ -20,4 +27,22 @@ describe("browser error mapping", () => {
message: "bad input",
});
});
it("sanitizes navigation-target SSRF policy errors without leaking raw policy details", () => {
expect(
toBrowserErrorResponse(
new SsrFBlockedError("Blocked hostname or private/internal/special-use IP address"),
),
).toEqual({
status: 400,
message: BROWSER_NAVIGATION_BLOCKED_MESSAGE,
});
});
it("maps CDP endpoint policy blocks to a distinct endpoint-scoped message", () => {
expect(toBrowserErrorResponse(new BrowserCdpEndpointBlockedError())).toEqual({
status: 400,
message: BROWSER_ENDPOINT_BLOCKED_MESSAGE,
});
});
});

View File

@@ -1,6 +1,9 @@
import { SsrFBlockedError } from "../infra/net/ssrf.js";
import { InvalidBrowserNavigationUrlError } from "./navigation-guard.js";
export const BROWSER_ENDPOINT_BLOCKED_MESSAGE = "browser endpoint blocked by policy";
export const BROWSER_NAVIGATION_BLOCKED_MESSAGE = "browser navigation blocked by policy";
export class BrowserError extends Error {
status: number;
@@ -11,6 +14,18 @@ export class BrowserError extends Error {
}
}
/**
* Raised when a browser CDP endpoint (the cdpUrl itself) fails the
* configured SSRF policy. Distinct from a blocked navigation target so
* callers see "fix your browser endpoint config" rather than "fix your
* navigation URL".
*/
export class BrowserCdpEndpointBlockedError extends BrowserError {
constructor(options?: ErrorOptions) {
super(BROWSER_ENDPOINT_BLOCKED_MESSAGE, 400, options);
}
}
export class BrowserValidationError extends BrowserError {
constructor(message: string, options?: ErrorOptions) {
super(message, 400, options);
@@ -76,7 +91,12 @@ export function toBrowserErrorResponse(err: unknown): {
return { status: 409, message: err.message };
}
if (err instanceof SsrFBlockedError) {
return { status: 400, message: err.message };
// SsrFBlockedError from this point is from a navigation-target check
// (assertBrowserNavigationAllowed / resolvePinnedHostnameWithPolicy on a
// requested URL). CDP endpoint blocks are rethrown as
// BrowserCdpEndpointBlockedError by assertCdpEndpointAllowed and handled
// by the BrowserError branch above.
return { status: 400, message: BROWSER_NAVIGATION_BLOCKED_MESSAGE };
}
if (
err instanceof InvalidBrowserNavigationUrlError ||

View File

@@ -1,5 +1,5 @@
import { normalizeOptionalString } from "openclaw/plugin-sdk/text-runtime";
import type { BrowserFormField } from "./client-actions-core.js";
import type { BrowserFormField } from "./client-actions.types.js";
export const DEFAULT_FILL_FIELD_TYPE = "text";

View File

@@ -0,0 +1,20 @@
import {
createBrowserControlContext,
startBrowserControlServiceFromConfig,
} from "./control-service.js";
import {
createBrowserRouteDispatcher,
type BrowserDispatchRequest,
type BrowserDispatchResponse,
} from "./routes/dispatcher.js";
export async function dispatchBrowserControlRequest(
req: BrowserDispatchRequest,
): Promise<BrowserDispatchResponse> {
const started = await startBrowserControlServiceFromConfig();
if (!started) {
throw new Error("browser control disabled");
}
const dispatcher = createBrowserRouteDispatcher(createBrowserControlContext());
return await dispatcher.dispatch(req);
}

View File

@@ -116,6 +116,85 @@ describe("browser navigation guard", () => {
expect(lookupFn).toHaveBeenCalledWith("example.com", { all: true });
});
it("blocks hostname navigation when strict SSRF policy is explicitly configured", async () => {
const lookupFn = createLookupFn("93.184.216.34");
await expect(
assertBrowserNavigationAllowed({
url: "https://example.com",
lookupFn,
ssrfPolicy: { dangerouslyAllowPrivateNetwork: false },
}),
).rejects.toThrow(/dns rebinding protections are unavailable/i);
expect(lookupFn).not.toHaveBeenCalled();
});
it("allows explicitly allowed hostnames in strict mode", async () => {
const lookupFn = createLookupFn("93.184.216.34");
await expect(
assertBrowserNavigationAllowed({
url: "https://agent.internal",
lookupFn,
ssrfPolicy: {
dangerouslyAllowPrivateNetwork: false,
allowedHostnames: ["agent.internal"],
},
}),
).resolves.toBeUndefined();
});
it("allows wildcard-allowlisted hostnames in strict mode", async () => {
const lookupFn = createLookupFn("93.184.216.34");
await expect(
assertBrowserNavigationAllowed({
url: "https://sub.example.com",
lookupFn,
ssrfPolicy: {
dangerouslyAllowPrivateNetwork: false,
hostnameAllowlist: ["*.example.com"],
},
}),
).resolves.toBeUndefined();
});
it("does not treat the bare suffix as matching a wildcard allowlist entry", async () => {
const lookupFn = createLookupFn("93.184.216.34");
await expect(
assertBrowserNavigationAllowed({
url: "https://example.com",
lookupFn,
ssrfPolicy: {
dangerouslyAllowPrivateNetwork: false,
hostnameAllowlist: ["*.example.com"],
},
}),
).rejects.toThrow(/dns rebinding protections are unavailable/i);
expect(lookupFn).not.toHaveBeenCalled();
});
it("does not match sibling domains against wildcard allowlist entries", async () => {
const lookupFn = createLookupFn("93.184.216.34");
await expect(
assertBrowserNavigationAllowed({
url: "https://evil-example.com",
lookupFn,
ssrfPolicy: {
dangerouslyAllowPrivateNetwork: false,
hostnameAllowlist: ["*.example.com"],
},
}),
).rejects.toThrow(/dns rebinding protections are unavailable/i);
expect(lookupFn).not.toHaveBeenCalled();
});
it("treats bracketed IPv6 URL hostnames as IP literals in strict mode", async () => {
await expect(
assertBrowserNavigationAllowed({
url: "https://[2606:4700:4700::1111]/",
ssrfPolicy: { dangerouslyAllowPrivateNetwork: false },
}),
).resolves.toBeUndefined();
});
it("blocks strict policy navigation when env proxy is configured", async () => {
vi.stubEnv("HTTP_PROXY", "http://127.0.0.1:7890");
const lookupFn = createLookupFn("93.184.216.34");
@@ -165,6 +244,15 @@ describe("browser navigation guard", () => {
).resolves.toBeUndefined();
});
it("blocks final hostname URLs in strict mode after navigation", async () => {
await expect(
assertBrowserNavigationResultAllowed({
url: "https://example.com/final",
ssrfPolicy: { dangerouslyAllowPrivateNetwork: false },
}),
).rejects.toBeInstanceOf(InvalidBrowserNavigationUrlError);
});
it("blocks private intermediate redirect hops", async () => {
const publicLookup = createLookupFn("93.184.216.34");
const privateLookup = createLookupFn("127.0.0.1");

View File

@@ -1,3 +1,8 @@
import { isIP } from "node:net";
import {
matchesHostnameAllowlist,
normalizeHostname,
} from "openclaw/plugin-sdk/browser-security-runtime";
import { normalizeOptionalString } from "openclaw/plugin-sdk/text-runtime";
import { hasProxyEnvConfigured } from "../infra/net/proxy-env.js";
import {
@@ -41,6 +46,24 @@ export function requiresInspectableBrowserNavigationRedirects(ssrfPolicy?: SsrFP
return !isPrivateNetworkAllowedByPolicy(ssrfPolicy);
}
function isIpLiteralHostname(hostname: string): boolean {
return isIP(normalizeHostname(hostname)) !== 0;
}
function isExplicitlyAllowedBrowserHostname(hostname: string, ssrfPolicy?: SsrFPolicy): boolean {
const normalizedHostname = normalizeHostname(hostname);
const exactMatches = ssrfPolicy?.allowedHostnames ?? [];
if (exactMatches.some((value) => normalizeHostname(value) === normalizedHostname)) {
return true;
}
const hostnameAllowlist = (ssrfPolicy?.hostnameAllowlist ?? [])
.map((pattern) => normalizeHostname(pattern))
.filter(Boolean);
return hostnameAllowlist.length > 0
? matchesHostnameAllowlist(normalizedHostname, hostnameAllowlist)
: false;
}
export async function assertBrowserNavigationAllowed(
opts: {
url: string;
@@ -78,6 +101,21 @@ export async function assertBrowserNavigationAllowed(
);
}
// Browser navigations happen in Chromium's network stack, not Node's. In
// strict mode, a hostname-based URL would be resolved twice by different
// resolvers, so Node-side pinning cannot guarantee the browser connects to
// the same address that passed policy checks.
if (
opts.ssrfPolicy &&
!isPrivateNetworkAllowedByPolicy(opts.ssrfPolicy) &&
!isIpLiteralHostname(parsed.hostname) &&
!isExplicitlyAllowedBrowserHostname(parsed.hostname, opts.ssrfPolicy)
) {
throw new InvalidBrowserNavigationUrlError(
"Navigation blocked: strict browser SSRF policy requires an IP-literal URL because browser DNS rebinding protections are unavailable for hostname-based navigation",
);
}
await resolvePinnedHostnameWithPolicy(parsed.hostname, {
lookupFn: opts.lookupFn,
policy: opts.ssrfPolicy,
@@ -87,7 +125,8 @@ export async function assertBrowserNavigationAllowed(
/**
* Best-effort post-navigation guard for final page URLs.
* Only validates network URLs (http/https) and about:blank to avoid false
* positives on browser-internal error pages (e.g. chrome-error://).
* positives on browser-internal error pages (e.g. chrome-error://). In strict
* mode this intentionally re-applies the hostname gate after redirects.
*/
export async function assertBrowserNavigationResultAllowed(
opts: {

View File

@@ -111,7 +111,9 @@ describe("BrowserProfilesService", () => {
});
it("accepts per-profile cdpUrl for remote Chrome", async () => {
const resolved = resolveBrowserConfig({});
const resolved = resolveBrowserConfig({
ssrfPolicy: { dangerouslyAllowPrivateNetwork: true },
});
const { ctx } = createCtx(resolved);
vi.mocked(loadConfig).mockReturnValue({ browser: { profiles: {} } });

View File

@@ -124,6 +124,11 @@ export function createBrowserProfilesService(ctx: BrowserRouteContext) {
}
if (rawCdpUrl) {
if (driver === "existing-session") {
throw new BrowserValidationError(
"driver=existing-session does not accept cdpUrl; it attaches via the Chrome MCP auto-connect flow",
);
}
let parsed: ReturnType<typeof parseHttpUrl>;
try {
parsed = parseHttpUrl(rawCdpUrl, "browser.profiles.cdpUrl");
@@ -131,11 +136,6 @@ export function createBrowserProfilesService(ctx: BrowserRouteContext) {
} catch (err) {
throw new BrowserValidationError(formatErrorMessage(err));
}
if (driver === "existing-session") {
throw new BrowserValidationError(
"driver=existing-session does not accept cdpUrl; it attaches via the Chrome MCP auto-connect flow",
);
}
profileConfig = {
cdpUrl: parsed.normalized,
...(driver ? { driver } : {}),

View File

@@ -340,7 +340,7 @@ export function buildRoleSnapshotFromAiSnapshot(
aiSnapshot: string,
options: RoleSnapshotOptions = {},
): { snapshot: string; refs: RoleRefMap } {
const lines = String(aiSnapshot ?? "").split("\n");
const lines = aiSnapshot.split("\n");
const refs: RoleRefMap = {};
if (options.interactive) {

View File

@@ -1,5 +1,5 @@
import { chromium } from "playwright-core";
import { afterEach, describe, expect, it, vi } from "vitest";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { SsrFBlockedError } from "../infra/net/ssrf.js";
import * as chromeModule from "./chrome.js";
import { BrowserTabNotFoundError } from "./errors.js";
@@ -15,9 +15,33 @@ import {
listPagesViaPlaywright,
} from "./pw-session.js";
vi.mock("openclaw/plugin-sdk/browser-security-runtime", async () => {
const actual = await vi.importActual<
typeof import("openclaw/plugin-sdk/browser-security-runtime")
>("openclaw/plugin-sdk/browser-security-runtime");
const lookupFn = async (_hostname: string, options?: { all?: boolean }) => {
const result = { address: "93.184.216.34", family: 4 };
return options?.all === true ? [result] : result;
};
return {
...actual,
resolvePinnedHostnameWithPolicy: (hostname: string, params: object = {}) =>
actual.resolvePinnedHostnameWithPolicy(hostname, { ...params, lookupFn: lookupFn as never }),
};
});
const connectOverCdpSpy = vi.spyOn(chromium, "connectOverCDP");
const getChromeWebSocketUrlSpy = vi.spyOn(chromeModule, "getChromeWebSocketUrl");
const PROXY_ENV_KEYS = [
"ALL_PROXY",
"all_proxy",
"HTTP_PROXY",
"http_proxy",
"HTTPS_PROXY",
"https_proxy",
] as const;
type MockRoute = { continue: () => Promise<void>; abort: () => Promise<void> };
type MockRequest = {
isNavigationRequest: () => boolean;
@@ -126,6 +150,7 @@ async function dispatchMockNavigation(params: {
getRouteHandler: () => MockRouteHandler | null;
mainFrame: object;
url: string;
frame?: object;
isNavigationRequest?: boolean;
resourceType?: string;
route?: Partial<MockRoute>;
@@ -137,7 +162,7 @@ async function dispatchMockNavigation(params: {
const { resourceType } = params;
await handler(createMockRoute(params.route), {
isNavigationRequest: () => params.isNavigationRequest ?? true,
frame: () => params.mainFrame,
frame: () => params.frame ?? params.mainFrame,
...(resourceType ? { resourceType: () => resourceType } : {}),
url: () => params.url,
});
@@ -169,7 +194,14 @@ function mockBlockedRedirectNavigation(params: {
});
}
beforeEach(() => {
for (const key of PROXY_ENV_KEYS) {
vi.stubEnv(key, "");
}
});
afterEach(async () => {
vi.unstubAllEnvs();
connectOverCdpSpy.mockClear();
getChromeWebSocketUrlSpy.mockClear();
await closePlaywrightBrowserConnection().catch(() => {});
@@ -201,6 +233,20 @@ describe("pw-session createPageViaPlaywright navigation guard", () => {
expect(pageGoto).not.toHaveBeenCalled();
});
it("blocks hostname navigation when strict SSRF policy is configured", async () => {
const { pageGoto } = installBrowserMocks();
await expect(
createPageViaPlaywright({
cdpUrl: "http://127.0.0.1:18792",
url: "https://example.com",
ssrfPolicy: { dangerouslyAllowPrivateNetwork: false, allowedHostnames: ["127.0.0.1"] },
}),
).rejects.toBeInstanceOf(InvalidBrowserNavigationUrlError);
expect(pageGoto).not.toHaveBeenCalled();
});
it("blocks private intermediate redirect hops", async () => {
const { pageGoto, pageClose, getRouteHandler, mainFrame } = installBrowserMocks();
mockBlockedRedirectNavigation({ pageGoto, getRouteHandler, mainFrame });
@@ -237,6 +283,41 @@ describe("pw-session createPageViaPlaywright navigation guard", () => {
expect(pageClose).toHaveBeenCalledTimes(1);
});
it("aborts private subframe document hops without quarantining the page", async () => {
const { pageGoto, pageClose, getRouteHandler, mainFrame } = installBrowserMocks();
const subframe = {};
const subframeRoute = createMockRoute();
pageGoto.mockImplementationOnce(async () => {
await dispatchMockNavigation({
getRouteHandler,
mainFrame,
url: "https://93.184.216.34/start",
});
await dispatchMockNavigation({
getRouteHandler,
mainFrame,
frame: subframe,
url: "http://127.0.0.1:18080/internal-hop",
route: subframeRoute,
});
return {
request: () => ({
url: () => "https://93.184.216.34/start",
redirectedFrom: () => null,
}),
};
});
const created = await createPageViaPlaywright({
cdpUrl: "http://127.0.0.1:18792",
url: "https://93.184.216.34/start",
});
expect(created.targetId).toBe("TARGET_1");
expect(subframeRoute.abort).toHaveBeenCalledTimes(1);
expect(pageClose).not.toHaveBeenCalled();
});
it("preserves the created tab on ordinary navigation failure", async () => {
const { pageGoto, pageClose } = installBrowserMocks();
pageGoto.mockRejectedValueOnce(new Error("page.goto: net::ERR_NAME_NOT_RESOLVED"));

View File

@@ -14,6 +14,7 @@ import { SsrFBlockedError, type SsrFPolicy } from "../infra/net/ssrf.js";
import { withNoProxyForCdpUrl } from "./cdp-proxy-bypass.js";
import {
appendCdpPath,
assertCdpEndpointAllowed,
fetchJson,
getHeadersWithAuth,
normalizeCdpHttpBaseForJsonEndpoints,
@@ -337,9 +338,9 @@ export function ensurePageState(page: Page): PageState {
});
page.on("pageerror", (err: Error) => {
state.errors.push({
message: err?.message ? String(err.message) : String(err),
name: err?.name ? String(err.name) : undefined,
stack: err?.stack ? String(err.stack) : undefined,
message: err.message || String(err),
name: err.name || undefined,
stack: err.stack || undefined,
timestamp: new Date().toISOString(),
});
if (state.errors.length > MAX_PAGE_ERRORS) {
@@ -424,12 +425,15 @@ function observeBrowser(browser: Browser) {
}
}
async function connectBrowser(cdpUrl: string): Promise<ConnectedBrowser> {
async function connectBrowser(cdpUrl: string, ssrfPolicy?: SsrFPolicy): Promise<ConnectedBrowser> {
const normalized = normalizeCdpUrl(cdpUrl);
const cached = cachedByCdpUrl.get(normalized);
if (cached) {
return cached;
}
// Run SSRF policy check only on cache miss so transient DNS failures
// do not break active sessions that already hold a live CDP connection.
await assertCdpEndpointAllowed(normalized, ssrfPolicy);
const connecting = connectingByCdpUrl.get(normalized);
if (connecting) {
return await connecting;
@@ -440,7 +444,9 @@ async function connectBrowser(cdpUrl: string): Promise<ConnectedBrowser> {
for (let attempt = 0; attempt < 3; attempt += 1) {
try {
const timeout = 5000 + attempt * 2000;
const wsUrl = await getChromeWebSocketUrl(normalized, timeout).catch(() => null);
const wsUrl = await getChromeWebSocketUrl(normalized, timeout, ssrfPolicy).catch(
() => null,
);
const endpoint = wsUrl ?? normalized;
const headers = getHeadersWithAuth(endpoint);
// Bypass proxy for loopback CDP connections (#31219)
@@ -562,8 +568,10 @@ async function findPageByTargetIdViaTargetList(
pages: Page[],
targetId: string,
cdpUrl: string,
ssrfPolicy?: SsrFPolicy,
): Promise<Page | null> {
const cdpHttpBase = normalizeCdpHttpBaseForJsonEndpoints(cdpUrl);
await assertCdpEndpointAllowed(cdpUrl, ssrfPolicy);
const targets = await fetchJson<
Array<{
id: string;
@@ -578,6 +586,7 @@ async function findPageByTargetId(
browser: Browser,
targetId: string,
cdpUrl?: string,
ssrfPolicy?: SsrFPolicy,
): Promise<Page | null> {
const pages = await getAllPages(browser);
let resolvedViaCdp = false;
@@ -595,7 +604,7 @@ async function findPageByTargetId(
}
if (cdpUrl) {
try {
return await findPageByTargetIdViaTargetList(pages, targetId, cdpUrl);
return await findPageByTargetIdViaTargetList(pages, targetId, cdpUrl, ssrfPolicy);
} catch {
// Ignore fetch errors and fall through to return null.
}
@@ -609,12 +618,13 @@ async function findPageByTargetId(
async function resolvePageByTargetIdOrThrow(opts: {
cdpUrl: string;
targetId: string;
ssrfPolicy?: SsrFPolicy;
}): Promise<Page> {
if (isBlockedTarget(opts.cdpUrl, opts.targetId)) {
throw new BlockedBrowserTargetError();
}
const { browser } = await connectBrowser(opts.cdpUrl);
const page = await findPageByTargetId(browser, opts.targetId, opts.cdpUrl);
const { browser } = await connectBrowser(opts.cdpUrl, opts.ssrfPolicy);
const page = await findPageByTargetId(browser, opts.targetId, opts.cdpUrl, opts.ssrfPolicy);
if (!page) {
throw new BrowserTabNotFoundError();
}
@@ -624,11 +634,12 @@ async function resolvePageByTargetIdOrThrow(opts: {
export async function getPageForTargetId(opts: {
cdpUrl: string;
targetId?: string;
ssrfPolicy?: SsrFPolicy;
}): Promise<Page> {
if (opts.targetId && isBlockedTarget(opts.cdpUrl, opts.targetId)) {
throw new BlockedBrowserTargetError();
}
const { browser } = await connectBrowser(opts.cdpUrl);
const { browser } = await connectBrowser(opts.cdpUrl, opts.ssrfPolicy);
const pages = await getAllPages(browser);
if (!pages.length) {
throw new Error("No pages available in the connected browser.");
@@ -648,7 +659,7 @@ export async function getPageForTargetId(opts: {
if (!opts.targetId) {
return first;
}
const found = await findPageByTargetId(browser, opts.targetId, opts.cdpUrl);
const found = await findPageByTargetId(browser, opts.targetId, opts.cdpUrl, opts.ssrfPolicy);
if (found) {
if (isBlockedPageRef(opts.cdpUrl, found)) {
throw new BlockedBrowserTargetError();
@@ -693,6 +704,36 @@ function isTopLevelNavigationRequest(page: Page, request: Request): boolean {
}
}
function isSubframeDocumentNavigationRequest(page: Page, request: Request): boolean {
let sameMainFrame = false;
try {
sameMainFrame = request.frame() === page.mainFrame();
} catch {
// Fail closed: if frame resolution throws after the top-level check already
// determined this is NOT the main frame, treat it as a subframe document
// navigation so the SSRF guard still fires. Returning false here would let
// transient renderer churn skip the policy check entirely.
return true;
}
if (sameMainFrame) {
return false;
}
try {
if (request.isNavigationRequest()) {
return true;
}
} catch {
// Fall through to the resource-type check.
}
try {
return request.resourceType() === "document";
} catch {
return false;
}
}
function isPolicyDenyNavigationError(err: unknown): boolean {
return err instanceof SsrFBlockedError || err instanceof InvalidBrowserNavigationUrlError;
}
@@ -758,7 +799,10 @@ export async function gotoPageWithNavigationGuard(opts: {
await route.abort().catch(() => {});
return;
}
if (!isTopLevelNavigationRequest(opts.page, request)) {
const isTopLevel = isTopLevelNavigationRequest(opts.page, request);
const isSubframeDocument =
!isTopLevel && isSubframeDocumentNavigationRequest(opts.page, request);
if (!isTopLevel && !isSubframeDocument) {
await route.continue();
return;
}
@@ -769,7 +813,9 @@ export async function gotoPageWithNavigationGuard(opts: {
});
} catch (err) {
if (isPolicyDenyNavigationError(err)) {
blockedError = err;
if (isTopLevel) {
blockedError = err;
}
await route.abort().catch(() => {});
return;
}
@@ -887,7 +933,9 @@ function cdpSocketNeedsAttach(wsUrl: string): boolean {
async function tryTerminateExecutionViaCdp(opts: {
cdpUrl: string;
targetId: string;
ssrfPolicy?: SsrFPolicy;
}): Promise<void> {
await assertCdpEndpointAllowed(opts.cdpUrl, opts.ssrfPolicy);
const cdpHttpBase = normalizeCdpHttpBaseForJsonEndpoints(opts.cdpUrl);
const listUrl = appendCdpPath(cdpHttpBase, "/json/list");
@@ -976,6 +1024,7 @@ export async function forceDisconnectPlaywrightForTarget(opts: {
cdpUrl: string;
targetId?: string;
reason?: string;
ssrfPolicy?: SsrFPolicy;
}): Promise<void> {
const normalized = normalizeCdpUrl(opts.cdpUrl);
const cur = cachedByCdpUrl.get(normalized);
@@ -996,7 +1045,11 @@ export async function forceDisconnectPlaywrightForTarget(opts: {
// disconnect Playwright's CDP connection.
const targetId = normalizeOptionalString(opts.targetId) ?? "";
if (targetId) {
await tryTerminateExecutionViaCdp({ cdpUrl: normalized, targetId }).catch(() => {});
await tryTerminateExecutionViaCdp({
cdpUrl: normalized,
targetId,
ssrfPolicy: opts.ssrfPolicy,
}).catch(() => {});
}
// Fire-and-forget: don't await because browser.close() may hang on the stuck CDP pipe.
@@ -1007,7 +1060,10 @@ export async function forceDisconnectPlaywrightForTarget(opts: {
* List all pages/tabs from the persistent Playwright connection.
* Used for remote profiles where HTTP-based /json/list is ephemeral.
*/
export async function listPagesViaPlaywright(opts: { cdpUrl: string }): Promise<
export async function listPagesViaPlaywright(opts: {
cdpUrl: string;
ssrfPolicy?: SsrFPolicy;
}): Promise<
Array<{
targetId: string;
title: string;
@@ -1015,7 +1071,7 @@ export async function listPagesViaPlaywright(opts: { cdpUrl: string }): Promise<
type: string;
}>
> {
const { browser } = await connectBrowser(opts.cdpUrl);
const { browser } = await connectBrowser(opts.cdpUrl, opts.ssrfPolicy);
const pages = await getAllPages(browser);
const results: Array<{
targetId: string;
@@ -1056,7 +1112,7 @@ export async function createPageViaPlaywright(opts: {
url: string;
type: string;
}> {
const { browser } = await connectBrowser(opts.cdpUrl);
const { browser } = await connectBrowser(opts.cdpUrl, opts.ssrfPolicy);
const context = browser.contexts()[0] ?? (await browser.newContext());
ensureContextState(context);
@@ -1119,6 +1175,7 @@ export async function createPageViaPlaywright(opts: {
export async function closePageByTargetIdViaPlaywright(opts: {
cdpUrl: string;
targetId: string;
ssrfPolicy?: SsrFPolicy;
}): Promise<void> {
const page = await resolvePageByTargetIdOrThrow(opts);
await page.close();
@@ -1131,6 +1188,7 @@ export async function closePageByTargetIdViaPlaywright(opts: {
export async function focusPageByTargetIdViaPlaywright(opts: {
cdpUrl: string;
targetId: string;
ssrfPolicy?: SsrFPolicy;
}): Promise<void> {
const page = await resolvePageByTargetIdOrThrow(opts);
try {

View File

@@ -256,7 +256,7 @@ export async function downloadViaPlaywright(opts: {
const timeout = normalizeTimeoutMs(opts.timeoutMs, 120_000);
const ref = requireRef(opts.ref);
const outPath = String(opts.path ?? "").trim();
const outPath = opts.path?.trim() ?? "";
if (!outPath) {
throw new Error("path is required");
}

View File

@@ -1,5 +1,6 @@
import { describe, expect, it, vi } from "vitest";
import {
getPwToolsCoreNavigationGuardMocks,
getPwToolsCoreSessionMocks,
installPwToolsCoreTestHooks,
setPwToolsCoreCurrentPage,
@@ -9,6 +10,18 @@ import {
installPwToolsCoreTestHooks();
const mod = await import("./pw-tools-core.js");
function createMutableFrame(initialUrl: string) {
let currentUrl = initialUrl;
return {
frame: {
url: vi.fn(() => currentUrl),
},
setUrl: (nextUrl: string) => {
currentUrl = nextUrl;
},
};
}
describe("pw-tools-core interaction navigation guard", () => {
it("waits for the grace window before completing a successful non-navigating click", async () => {
vi.useFakeTimers();
@@ -120,12 +133,12 @@ describe("pw-tools-core interaction navigation guard", () => {
}
});
it("ignores subframe framenavigated events before the main frame navigates", async () => {
it("checks subframe navigations before a later main-frame navigation", async () => {
vi.useFakeTimers();
try {
const listeners = new Set<(frame: object) => void>();
const mainFrame = {};
const subframe = {};
const subframe = { url: () => "https://example.com/embed" };
let currentUrl = "http://127.0.0.1:9222/json/version";
const click = vi.fn(async () => {
setTimeout(() => {
@@ -169,10 +182,449 @@ describe("pw-tools-core interaction navigation guard", () => {
expect(
getPwToolsCoreSessionMocks().assertPageNavigationCompletedSafely,
).not.toHaveBeenCalled();
expect(
getPwToolsCoreNavigationGuardMocks().assertBrowserNavigationResultAllowed,
).not.toHaveBeenCalled();
await vi.advanceTimersByTimeAsync(10);
await task;
expect(
getPwToolsCoreNavigationGuardMocks().assertBrowserNavigationResultAllowed,
).toHaveBeenCalledWith({
ssrfPolicy: { allowPrivateNetwork: false },
url: "https://example.com/embed",
});
expect(getPwToolsCoreSessionMocks().assertPageNavigationCompletedSafely).toHaveBeenCalledWith(
{
cdpUrl: "http://127.0.0.1:18792",
page,
response: null,
ssrfPolicy: { allowPrivateNetwork: false },
targetId: "T1",
},
);
} finally {
vi.useRealTimers();
}
});
it("blocks subframe-only navigation to a private URL during the post-action grace window", async () => {
vi.useFakeTimers();
try {
const listeners = new Set<(frame: object) => void>();
const mainFrame = {};
const subframe = { url: () => "http://169.254.169.254/latest/meta-data/" };
const click = vi.fn(async () => {
setTimeout(() => {
for (const listener of listeners) {
listener(subframe);
}
}, 10);
});
const page = {
mainFrame: vi.fn(() => mainFrame),
on: vi.fn((event: string, listener: (frame: object) => void) => {
if (event === "framenavigated") {
listeners.add(listener);
}
}),
off: vi.fn((event: string, listener: (frame: object) => void) => {
if (event === "framenavigated") {
listeners.delete(listener);
}
}),
url: vi.fn(() => "https://attacker.example.com/page"),
};
setPwToolsCoreCurrentRefLocator({ click });
setPwToolsCoreCurrentPage(page);
const blocked = new Error("SSRF blocked: private network");
getPwToolsCoreNavigationGuardMocks().assertBrowserNavigationResultAllowed.mockRejectedValueOnce(
blocked,
);
const task = mod.clickViaPlaywright({
cdpUrl: "http://127.0.0.1:18792",
targetId: "T1",
ref: "1",
ssrfPolicy: { allowPrivateNetwork: false },
});
const rejection = expect(task).rejects.toThrow("SSRF blocked: private network");
await vi.advanceTimersByTimeAsync(10);
await vi.advanceTimersByTimeAsync(240);
await rejection;
expect(
getPwToolsCoreSessionMocks().assertPageNavigationCompletedSafely,
).not.toHaveBeenCalled();
} finally {
vi.useRealTimers();
}
});
it("snapshots delayed subframe URLs before later rewrites make them look safe", async () => {
vi.useFakeTimers();
try {
const listeners = new Set<(frame: object) => void>();
const mainFrame = {};
const subframe = createMutableFrame("http://169.254.169.254/latest/meta-data/");
const click = vi.fn(async () => {
setTimeout(() => {
for (const listener of listeners) {
listener(subframe.frame);
}
}, 10);
setTimeout(() => {
subframe.setUrl("https://example.com/embed");
}, 20);
});
const page = {
mainFrame: vi.fn(() => mainFrame),
on: vi.fn((event: string, listener: (frame: object) => void) => {
if (event === "framenavigated") {
listeners.add(listener);
}
}),
off: vi.fn((event: string, listener: (frame: object) => void) => {
if (event === "framenavigated") {
listeners.delete(listener);
}
}),
url: vi.fn(() => "https://attacker.example.com/page"),
};
setPwToolsCoreCurrentRefLocator({ click });
setPwToolsCoreCurrentPage(page);
const task = mod.clickViaPlaywright({
cdpUrl: "http://127.0.0.1:18792",
targetId: "T1",
ref: "1",
ssrfPolicy: { allowPrivateNetwork: false },
});
await vi.advanceTimersByTimeAsync(20);
await vi.advanceTimersByTimeAsync(230);
await task;
expect(
getPwToolsCoreNavigationGuardMocks().assertBrowserNavigationResultAllowed,
).toHaveBeenCalledWith({
ssrfPolicy: { allowPrivateNetwork: false },
url: "http://169.254.169.254/latest/meta-data/",
});
} finally {
vi.useRealTimers();
}
});
it("still quarantines the main frame when a delayed subframe block fires first", async () => {
vi.useFakeTimers();
try {
const listeners = new Set<(frame: object) => void>();
const mainFrame = {};
const subframe = { url: () => "http://169.254.169.254/latest/meta-data/" };
let currentUrl = "https://attacker.example.com/page";
const click = vi.fn(async () => {
setTimeout(() => {
for (const listener of listeners) {
listener(subframe);
}
}, 10);
setTimeout(() => {
currentUrl = "http://127.0.0.1:8080/internal";
for (const listener of listeners) {
listener(mainFrame);
}
}, 20);
});
const page = {
mainFrame: vi.fn(() => mainFrame),
on: vi.fn((event: string, listener: (frame: object) => void) => {
if (event === "framenavigated") {
listeners.add(listener);
}
}),
off: vi.fn((event: string, listener: (frame: object) => void) => {
if (event === "framenavigated") {
listeners.delete(listener);
}
}),
url: vi.fn(() => currentUrl),
};
setPwToolsCoreCurrentRefLocator({ click });
setPwToolsCoreCurrentPage(page);
const subframeBlocked = new Error("subframe blocked");
const mainFrameBlocked = new Error("main frame blocked");
getPwToolsCoreNavigationGuardMocks().assertBrowserNavigationResultAllowed.mockRejectedValueOnce(
subframeBlocked,
);
getPwToolsCoreSessionMocks().assertPageNavigationCompletedSafely.mockRejectedValueOnce(
mainFrameBlocked,
);
const task = mod.clickViaPlaywright({
cdpUrl: "http://127.0.0.1:18792",
targetId: "T1",
ref: "1",
ssrfPolicy: { allowPrivateNetwork: false },
});
const rejection = expect(task).rejects.toThrow("main frame blocked");
await vi.advanceTimersByTimeAsync(20);
await rejection;
expect(getPwToolsCoreSessionMocks().assertPageNavigationCompletedSafely).toHaveBeenCalledWith(
{
cdpUrl: "http://127.0.0.1:18792",
page,
response: null,
ssrfPolicy: { allowPrivateNetwork: false },
targetId: "T1",
},
);
} finally {
vi.useRealTimers();
}
});
it("does not stop watching for a later main-frame navigation after a harmless subframe hop", async () => {
vi.useFakeTimers();
try {
const listeners = new Set<(frame: object) => void>();
const mainFrame = {};
const subframe = { url: () => "about:blank" };
let currentUrl = "http://127.0.0.1:9222/json/version";
const click = vi.fn(async () => {
setTimeout(() => {
for (const listener of listeners) {
listener(subframe);
}
}, 10);
setTimeout(() => {
currentUrl = "http://127.0.0.1:9222/json/list";
for (const listener of listeners) {
listener(mainFrame);
}
}, 20);
});
const page = {
mainFrame: vi.fn(() => mainFrame),
on: vi.fn((event: string, listener: (frame: object) => void) => {
if (event === "framenavigated") {
listeners.add(listener);
}
}),
off: vi.fn((event: string, listener: (frame: object) => void) => {
if (event === "framenavigated") {
listeners.delete(listener);
}
}),
url: vi.fn(() => currentUrl),
};
setPwToolsCoreCurrentRefLocator({ click });
setPwToolsCoreCurrentPage(page);
const task = mod.clickViaPlaywright({
cdpUrl: "http://127.0.0.1:18792",
targetId: "T1",
ref: "1",
ssrfPolicy: { allowPrivateNetwork: false },
});
await vi.advanceTimersByTimeAsync(20);
await task;
expect(
getPwToolsCoreNavigationGuardMocks().assertBrowserNavigationResultAllowed,
).not.toHaveBeenCalled();
expect(getPwToolsCoreSessionMocks().assertPageNavigationCompletedSafely).toHaveBeenCalledWith(
{
cdpUrl: "http://127.0.0.1:18792",
page,
response: null,
ssrfPolicy: { allowPrivateNetwork: false },
targetId: "T1",
},
);
} finally {
vi.useRealTimers();
}
});
it("checks delayed subframe navigations in the action-error recovery path", async () => {
vi.useFakeTimers();
try {
const listeners = new Set<(frame: object) => void>();
const mainFrame = {};
const subframe = { url: () => "http://169.254.169.254/latest/meta-data/" };
const page = {
mainFrame: vi.fn(() => mainFrame),
evaluate: vi.fn(async () => {
setTimeout(() => {
for (const listener of listeners) {
listener(subframe);
}
}, 10);
throw new Error("evaluate failed");
}),
on: vi.fn((event: string, listener: (frame: object) => void) => {
if (event === "framenavigated") {
listeners.add(listener);
}
}),
off: vi.fn((event: string, listener: (frame: object) => void) => {
if (event === "framenavigated") {
listeners.delete(listener);
}
}),
url: vi.fn(() => "https://attacker.example.com/page"),
};
setPwToolsCoreCurrentPage(page);
const blocked = new Error("SSRF blocked: private network");
getPwToolsCoreNavigationGuardMocks().assertBrowserNavigationResultAllowed.mockRejectedValueOnce(
blocked,
);
const task = mod.evaluateViaPlaywright({
cdpUrl: "http://127.0.0.1:18792",
targetId: "T1",
fn: "() => 1",
ssrfPolicy: { allowPrivateNetwork: false },
});
const rejection = expect(task).rejects.toThrow("SSRF blocked: private network");
await vi.advanceTimersByTimeAsync(10);
await vi.advanceTimersByTimeAsync(240);
await rejection;
expect(
getPwToolsCoreSessionMocks().assertPageNavigationCompletedSafely,
).not.toHaveBeenCalled();
} finally {
vi.useRealTimers();
}
});
it("snapshots subframe URLs observed during the action before they change", async () => {
vi.useFakeTimers();
try {
const listeners = new Set<(frame: object) => void>();
const mainFrame = {};
const subframe = createMutableFrame("http://169.254.169.254/latest/meta-data/");
const click = vi.fn(
() =>
new Promise<void>((resolve) => {
setTimeout(() => {
for (const listener of listeners) {
listener(subframe.frame);
}
}, 10);
setTimeout(() => {
subframe.setUrl("https://example.com/embed");
}, 20);
setTimeout(resolve, 30);
}),
);
const page = {
mainFrame: vi.fn(() => mainFrame),
on: vi.fn((event: string, listener: (frame: object) => void) => {
if (event === "framenavigated") {
listeners.add(listener);
}
}),
off: vi.fn((event: string, listener: (frame: object) => void) => {
if (event === "framenavigated") {
listeners.delete(listener);
}
}),
url: vi.fn(() => "https://attacker.example.com/page"),
};
setPwToolsCoreCurrentRefLocator({ click });
setPwToolsCoreCurrentPage(page);
const task = mod.clickViaPlaywright({
cdpUrl: "http://127.0.0.1:18792",
targetId: "T1",
ref: "1",
ssrfPolicy: { allowPrivateNetwork: false },
});
await vi.advanceTimersByTimeAsync(30);
await vi.advanceTimersByTimeAsync(250);
await task;
expect(
getPwToolsCoreNavigationGuardMocks().assertBrowserNavigationResultAllowed,
).toHaveBeenCalledWith({
ssrfPolicy: { allowPrivateNetwork: false },
url: "http://169.254.169.254/latest/meta-data/",
});
} finally {
vi.useRealTimers();
}
});
it("still quarantines the main frame when an in-flight subframe block fires first", async () => {
vi.useFakeTimers();
try {
const listeners = new Set<(frame: object) => void>();
const mainFrame = {};
const subframe = { url: () => "http://169.254.169.254/latest/meta-data/" };
let currentUrl = "https://attacker.example.com/page";
const click = vi.fn(
() =>
new Promise<void>((resolve) => {
setTimeout(() => {
for (const listener of listeners) {
listener(subframe);
}
}, 10);
setTimeout(() => {
currentUrl = "http://127.0.0.1:8080/internal";
for (const listener of listeners) {
listener(mainFrame);
}
}, 20);
setTimeout(resolve, 30);
}),
);
const page = {
mainFrame: vi.fn(() => mainFrame),
on: vi.fn((event: string, listener: (frame: object) => void) => {
if (event === "framenavigated") {
listeners.add(listener);
}
}),
off: vi.fn((event: string, listener: (frame: object) => void) => {
if (event === "framenavigated") {
listeners.delete(listener);
}
}),
url: vi.fn(() => currentUrl),
};
setPwToolsCoreCurrentRefLocator({ click });
setPwToolsCoreCurrentPage(page);
const subframeBlocked = new Error("subframe blocked");
const mainFrameBlocked = new Error("main frame blocked");
getPwToolsCoreNavigationGuardMocks().assertBrowserNavigationResultAllowed.mockRejectedValueOnce(
subframeBlocked,
);
getPwToolsCoreSessionMocks().assertPageNavigationCompletedSafely.mockRejectedValueOnce(
mainFrameBlocked,
);
const task = mod.clickViaPlaywright({
cdpUrl: "http://127.0.0.1:18792",
targetId: "T1",
ref: "1",
ssrfPolicy: { allowPrivateNetwork: false },
});
const rejection = expect(task).rejects.toThrow("main frame blocked");
await vi.advanceTimersByTimeAsync(30);
await rejection;
expect(getPwToolsCoreSessionMocks().assertPageNavigationCompletedSafely).toHaveBeenCalledWith(
{
cdpUrl: "http://127.0.0.1:18792",
@@ -398,6 +850,115 @@ describe("pw-tools-core interaction navigation guard", () => {
});
});
it("runs the post-keypress navigation guard when navigation starts shortly after the keypress resolves", async () => {
vi.useFakeTimers();
try {
const listeners = new Set<() => void>();
let currentUrl = "http://127.0.0.1:9222/json/version";
const page = {
keyboard: {
press: vi.fn(async () => {
setTimeout(() => {
currentUrl = "http://127.0.0.1:9222/private-target";
for (const listener of listeners) {
listener();
}
}, 10);
}),
},
on: vi.fn((event: string, listener: () => void) => {
if (event === "framenavigated") {
listeners.add(listener);
}
}),
off: vi.fn((event: string, listener: () => void) => {
if (event === "framenavigated") {
listeners.delete(listener);
}
}),
url: vi.fn(() => currentUrl),
};
setPwToolsCoreCurrentPage(page);
const task = mod.pressKeyViaPlaywright({
cdpUrl: "http://127.0.0.1:18792",
targetId: "T1",
key: "Enter",
ssrfPolicy: { allowPrivateNetwork: false },
});
await vi.advanceTimersByTimeAsync(10);
await task;
expect(getPwToolsCoreSessionMocks().assertPageNavigationCompletedSafely).toHaveBeenCalledWith(
{
cdpUrl: "http://127.0.0.1:18792",
page,
response: null,
ssrfPolicy: { allowPrivateNetwork: false },
targetId: "T1",
},
);
} finally {
vi.useRealTimers();
}
});
it("propagates blocked delayed submit navigation instead of reporting type success", async () => {
vi.useFakeTimers();
try {
const listeners = new Set<() => void>();
let currentUrl = "https://example.com/form";
const locator = {
fill: vi.fn(async () => {}),
press: vi.fn(async () => {
setTimeout(() => {
currentUrl = "http://127.0.0.1:9222/private-target";
for (const listener of listeners) {
listener();
}
}, 10);
}),
};
const page = {
on: vi.fn((event: string, listener: () => void) => {
if (event === "framenavigated") {
listeners.add(listener);
}
}),
off: vi.fn((event: string, listener: () => void) => {
if (event === "framenavigated") {
listeners.delete(listener);
}
}),
url: vi.fn(() => currentUrl),
};
setPwToolsCoreCurrentRefLocator(locator);
setPwToolsCoreCurrentPage(page);
const blocked = new Error("blocked delayed interaction navigation");
getPwToolsCoreSessionMocks().assertPageNavigationCompletedSafely.mockRejectedValueOnce(
blocked,
);
const task = mod.typeViaPlaywright({
cdpUrl: "http://127.0.0.1:18792",
targetId: "T1",
ref: "1",
text: "hello",
submit: true,
ssrfPolicy: { allowPrivateNetwork: false },
});
const rejection = expect(task).rejects.toThrow("blocked delayed interaction navigation");
await vi.advanceTimersByTimeAsync(10);
await rejection;
expect(listeners.size).toBe(0);
} finally {
vi.useRealTimers();
}
});
it("does not run the post-click navigation guard when the url is unchanged", async () => {
const click = vi.fn(async () => {});
const page = { url: vi.fn(() => "http://127.0.0.1:9222/json/version") };

View File

@@ -10,8 +10,12 @@ import {
resolveActInteractionTimeoutMs,
resolveActWaitTimeoutMs,
} from "./act-policy.js";
import type { BrowserActRequest, BrowserFormField } from "./client-actions-core.js";
import type { BrowserActRequest, BrowserFormField } from "./client-actions.types.js";
import { DEFAULT_FILL_FIELD_TYPE } from "./form-fields.js";
import {
assertBrowserNavigationResultAllowed,
withBrowserNavigationPolicy,
} from "./navigation-guard.js";
import { DEFAULT_UPLOAD_DIR, resolveStrictExistingPathsWithinRoot } from "./paths.js";
import {
assertPageNavigationCompletedSafely,
@@ -119,20 +123,84 @@ function isMainFrameNavigation(page: NavigationObservablePage, frame: Frame): bo
return frame === page.mainFrame();
}
async function assertSubframeNavigationAllowed(
frameUrl: string,
ssrfPolicy?: SsrFPolicy,
): Promise<void> {
if (!ssrfPolicy || (!frameUrl.startsWith("http://") && !frameUrl.startsWith("https://"))) {
// Non-network frame URLs like about:blank and about:srcdoc do not cross the
// browser SSRF boundary, so they should not trigger the navigation policy.
return;
}
await assertBrowserNavigationResultAllowed({
url: frameUrl,
...withBrowserNavigationPolicy(ssrfPolicy),
});
}
type ObservedDelayedNavigations = {
mainFrameNavigated: boolean;
subframes: string[];
};
function snapshotNetworkFrameUrl(frame: Frame): string | null {
try {
const frameUrl = frame.url();
return frameUrl.startsWith("http://") || frameUrl.startsWith("https://") ? frameUrl : null;
} catch {
return null;
}
}
async function assertObservedDelayedNavigations(opts: {
cdpUrl: string;
page: Page;
ssrfPolicy?: SsrFPolicy;
targetId?: string;
observed: ObservedDelayedNavigations;
}): Promise<void> {
let subframeError: unknown;
try {
for (const frameUrl of opts.observed.subframes) {
await assertSubframeNavigationAllowed(frameUrl, opts.ssrfPolicy);
}
} catch (err) {
subframeError = err;
}
if (opts.observed.mainFrameNavigated) {
await assertPageNavigationCompletedSafely({
cdpUrl: opts.cdpUrl,
page: opts.page,
response: null,
ssrfPolicy: opts.ssrfPolicy,
targetId: opts.targetId,
});
}
if (subframeError) {
throw subframeError;
}
}
function observeDelayedInteractionNavigation(
page: NavigationObservablePage,
previousUrl: string,
): Promise<boolean> {
): Promise<ObservedDelayedNavigations> {
if (didCrossDocumentUrlChange(page, previousUrl)) {
return Promise.resolve(true);
return Promise.resolve({ mainFrameNavigated: true, subframes: [] });
}
if (typeof page.on !== "function" || typeof page.off !== "function") {
return Promise.resolve(false);
return Promise.resolve({ mainFrameNavigated: false, subframes: [] });
}
return new Promise<boolean>((resolve) => {
return new Promise<ObservedDelayedNavigations>((resolve) => {
const subframes: string[] = [];
const onFrameNavigated = (frame: Frame) => {
if (!isMainFrameNavigation(page, frame)) {
const frameUrl = snapshotNetworkFrameUrl(frame);
if (frameUrl) {
subframes.push(frameUrl);
}
return;
}
// Use isHashOnlyNavigation rather than !didCrossDocumentUrlChange: the
@@ -142,11 +210,14 @@ function observeDelayedInteractionNavigation(
return;
}
cleanup();
resolve(true);
resolve({ mainFrameNavigated: true, subframes });
};
const timeout = setTimeout(() => {
cleanup();
resolve(didCrossDocumentUrlChange(page, previousUrl));
resolve({
mainFrameNavigated: didCrossDocumentUrlChange(page, previousUrl),
subframes,
});
}, INTERACTION_NAVIGATION_GRACE_MS);
const cleanup = () => {
clearTimeout(timeout);
@@ -196,8 +267,13 @@ function scheduleDelayedInteractionNavigationGuard(opts: {
}
resolve();
};
const subframes: string[] = [];
const onFrameNavigated = (frame: Frame) => {
if (!isMainFrameNavigation(page, frame)) {
const frameUrl = snapshotNetworkFrameUrl(frame);
if (frameUrl) {
subframes.push(frameUrl);
}
return;
}
// Use isHashOnlyNavigation rather than !didCrossDocumentUrlChange: the
@@ -207,16 +283,26 @@ function scheduleDelayedInteractionNavigationGuard(opts: {
return;
}
cleanup();
void assertPageNavigationCompletedSafely({
void assertObservedDelayedNavigations({
cdpUrl: opts.cdpUrl,
page: opts.page,
response: null,
ssrfPolicy: opts.ssrfPolicy,
targetId: opts.targetId,
observed: { mainFrameNavigated: true, subframes },
}).then(() => settle(), settle);
};
const timeout = setTimeout(() => {
settle();
cleanup();
void assertObservedDelayedNavigations({
cdpUrl: opts.cdpUrl,
page: opts.page,
ssrfPolicy: opts.ssrfPolicy,
targetId: opts.targetId,
observed: {
mainFrameNavigated: didCrossDocumentUrlChange(page, opts.previousUrl),
subframes,
},
}).then(() => settle(), settle);
}, INTERACTION_NAVIGATION_GRACE_MS);
const cleanup = () => {
clearTimeout(timeout);
@@ -248,8 +334,13 @@ async function assertInteractionNavigationCompletedSafely<T>(opts: {
// slow interactions, silently bypassing the SSRF guard.
const navPage = opts.page as unknown as NavigationObservablePage;
let navigatedDuringAction = false;
const subframeNavigationsDuringAction: string[] = [];
const onFrameNavigated = (frame: Frame) => {
if (!isMainFrameNavigation(navPage, frame)) {
const frameUrl = snapshotNetworkFrameUrl(frame);
if (frameUrl) {
subframeNavigationsDuringAction.push(frameUrl);
}
return;
}
// Use isHashOnlyNavigation rather than didCrossDocumentUrlChange: the event
@@ -278,6 +369,15 @@ async function assertInteractionNavigationCompletedSafely<T>(opts: {
const navigationObserved =
navigatedDuringAction || didCrossDocumentUrlChange(opts.page, opts.previousUrl);
let subframeError: unknown;
try {
for (const frameUrl of subframeNavigationsDuringAction) {
await assertSubframeNavigationAllowed(frameUrl, opts.ssrfPolicy);
}
} catch (err) {
subframeError = err;
}
if (navigationObserved) {
await assertPageNavigationCompletedSafely({
cdpUrl: opts.cdpUrl,
@@ -290,17 +390,14 @@ async function assertInteractionNavigationCompletedSafely<T>(opts: {
// Preserve the action-error path semantics: if a rejected click/evaluate still
// triggers a delayed navigation, the SSRF block must win over the original
// action error instead of surfacing a stale interaction failure.
const delayedNavigationObserved = await observeDelayedInteractionNavigation(
opts.page,
opts.previousUrl,
);
if (delayedNavigationObserved) {
await assertPageNavigationCompletedSafely({
const observed = await observeDelayedInteractionNavigation(opts.page, opts.previousUrl);
if (observed.mainFrameNavigated || observed.subframes.length > 0) {
await assertObservedDelayedNavigations({
cdpUrl: opts.cdpUrl,
page: opts.page,
response: null,
ssrfPolicy: opts.ssrfPolicy,
targetId: opts.targetId,
observed,
});
}
} else {
@@ -316,6 +413,10 @@ async function assertInteractionNavigationCompletedSafely<T>(opts: {
});
}
if (subframeError) {
throw subframeError;
}
if (actionError) {
throw actionError;
}
@@ -379,25 +480,6 @@ function createAbortPromiseWithListener(
},
};
}
async function assertPostInteractionNavigationSafe(opts: {
cdpUrl: string;
page: Awaited<ReturnType<typeof getPageForTargetId>>;
ssrfPolicy?: SsrFPolicy;
targetId?: string;
}): Promise<void> {
if (!opts.ssrfPolicy) {
return;
}
await assertPageNavigationCompletedSafely({
cdpUrl: opts.cdpUrl,
page: opts.page,
response: null,
ssrfPolicy: opts.ssrfPolicy,
targetId: opts.targetId,
});
}
export async function highlightViaPlaywright(opts: {
cdpUrl: string;
targetId?: string;
@@ -559,12 +641,16 @@ export async function pressKeyViaPlaywright(opts: {
}
const page = await getPageForTargetId(opts);
ensurePageState(page);
await page.keyboard.press(key, {
delay: Math.max(0, Math.floor(opts.delayMs ?? 0)),
});
await assertPostInteractionNavigationSafe({
const previousUrl = page.url();
await assertInteractionNavigationCompletedSafely({
action: async () => {
await page.keyboard.press(key, {
delay: Math.max(0, Math.floor(opts.delayMs ?? 0)),
});
},
cdpUrl: opts.cdpUrl,
page,
previousUrl,
ssrfPolicy: opts.ssrfPolicy,
targetId: opts.targetId,
});
@@ -597,10 +683,14 @@ export async function typeViaPlaywright(opts: {
await locator.fill(text, { timeout });
}
if (opts.submit) {
await locator.press("Enter", { timeout });
await assertPostInteractionNavigationSafe({
const previousUrl = page.url();
await assertInteractionNavigationCompletedSafely({
action: async () => {
await locator.press("Enter", { timeout });
},
cdpUrl: opts.cdpUrl,
page,
previousUrl,
ssrfPolicy: opts.ssrfPolicy,
targetId: opts.targetId,
});

View File

@@ -7,6 +7,21 @@ import {
setPwToolsCoreCurrentPage,
} from "./pw-tools-core.test-harness.js";
vi.mock("openclaw/plugin-sdk/browser-security-runtime", async () => {
const actual = await vi.importActual<
typeof import("openclaw/plugin-sdk/browser-security-runtime")
>("openclaw/plugin-sdk/browser-security-runtime");
const lookupFn = async (_hostname: string, options?: { all?: boolean }) => {
const result = { address: "93.184.216.34", family: 4 };
return options?.all === true ? [result] : result;
};
return {
...actual,
resolvePinnedHostnameWithPolicy: (hostname: string, params: object = {}) =>
actual.resolvePinnedHostnameWithPolicy(hostname, { ...params, lookupFn: lookupFn as never }),
};
});
installPwToolsCoreTestHooks();
const mod = await import("./pw-tools-core.snapshot.js");

View File

@@ -89,7 +89,7 @@ export async function snapshotAiViaPlaywright(opts: {
timeout: Math.max(500, Math.min(60_000, Math.floor(opts.timeoutMs ?? 5000))),
track: "response",
});
let snapshot = String(result?.full ?? "");
let snapshot = result?.full ?? "";
const maxChars = opts.maxChars;
const limit =
typeof maxChars === "number" && Number.isFinite(maxChars) && maxChars > 0
@@ -152,7 +152,7 @@ export async function snapshotRoleViaPlaywright(opts: {
timeout: 5000,
track: "response",
});
const built = buildRoleSnapshotFromAiSnapshot(String(result?.full ?? ""), opts.options);
const built = buildRoleSnapshotFromAiSnapshot(result?.full ?? "", opts.options);
storeRoleRefsForTarget({
page,
cdpUrl: opts.cdpUrl,
@@ -178,7 +178,7 @@ export async function snapshotRoleViaPlaywright(opts: {
: page.locator(":root");
const ariaSnapshot = await locator.ariaSnapshot();
const built = buildRoleSnapshotFromAriaSnapshot(String(ariaSnapshot ?? ""), opts.options);
const built = buildRoleSnapshotFromAriaSnapshot(ariaSnapshot ?? "", opts.options);
storeRoleRefsForTarget({
page,
cdpUrl: opts.cdpUrl,

Some files were not shown because too many files have changed in this diff Show More