From 8f4050f51ad3c63bc7c9afc84d543065182222b4 Mon Sep 17 00:00:00 2001 From: heyitsaamir Date: Thu, 7 May 2026 18:25:06 +0000 Subject: [PATCH] chore(msteams): drop unused @microsoft/teams.api direct dep CI's deadcode:dependencies (knip) flagged @microsoft/teams.api as unused in extensions/msteams. The plugin source uses structural type aliases (MSTeamsActivityParams, MSTeamsActivityLike, etc.) to dodge tsgo resolution bugs with teams.api's hashed d.ts files, so it never imports teams.api directly. The package is brought in transitively via @microsoft/teams.apps; the only other reference is probe.test.ts's vi.mock("@microsoft/teams.api"), which works on the import-path string and doesn't require a direct dep declaration. Lockfile regenerates accordingly. tsgo:extensions, knip, and all 865 msteams tests pass. Co-Authored-By: Claude Sonnet 4.6 --- extensions/msteams/package.json | 1 - pnpm-lock.yaml | 3 --- 2 files changed, 4 deletions(-) diff --git a/extensions/msteams/package.json b/extensions/msteams/package.json index 9c7dc3677700..adb05a704b15 100644 --- a/extensions/msteams/package.json +++ b/extensions/msteams/package.json @@ -9,7 +9,6 @@ "type": "module", "dependencies": { "@azure/identity": "4.13.1", - "@microsoft/teams.api": "2.0.10", "@microsoft/teams.apps": "2.0.10", "express": "5.2.1", "typebox": "1.1.37" diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 16d3f6e8781a..9b0af6be5e7b 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -1041,9 +1041,6 @@ importers: '@azure/identity': specifier: 4.13.1 version: 4.13.1 - '@microsoft/teams.api': - specifier: 2.0.10 - version: 2.0.10 '@microsoft/teams.apps': specifier: 2.0.10 version: 2.0.10