From 211321ce5c498ce609903dd0366cd5eae21e5815 Mon Sep 17 00:00:00 2001
From: Colin <colin@solvely.net>
Date: Mon, 1 Jun 2026 11:47:17 -0400
Subject: [PATCH] address skill workshop review comments

---
 ui/src/ui/app-render.ts           | 14 ++++++--------
 ui/src/ui/views/skill-workshop.ts |  8 ++------
 2 files changed, 8 insertions(+), 14 deletions(-)

diff --git a/ui/src/ui/app-render.ts b/ui/src/ui/app-render.ts
index 7f7aa7bf7e75..15c93e8b5b3e 100644
--- a/ui/src/ui/app-render.ts
+++ b/ui/src/ui/app-render.ts
@@ -3087,18 +3087,17 @@ export function renderApp(state: AppViewState) {
                 state.skillWorkshopStatusFilter,
                 state.skillWorkshopQuery,
               );
-              const selectedIndex = Math.max(
-                0,
-                visibleProposals.findIndex(
-                  (proposal) => proposal.key === state.skillWorkshopSelectedKey,
-                ),
+              const selectedIndex = visibleProposals.findIndex(
+                (proposal) => proposal.key === state.skillWorkshopSelectedKey,
               );
               const selectRelativeProposal = (delta: -1 | 1) => {
                 if (visibleProposals.length === 0) {
                   return;
                 }
                 const nextIndex =
-                  (selectedIndex + delta + visibleProposals.length) % visibleProposals.length;
+                  selectedIndex < 0
+                    ? 0
+                    : (selectedIndex + delta + visibleProposals.length) % visibleProposals.length;
                 selectSkillWorkshopProposal(state, visibleProposals[nextIndex].key);
               };
               return m.renderSkillWorkshop({
@@ -3123,7 +3122,6 @@ export function renderApp(state: AppViewState) {
                 onQueryChange: (query) => (state.skillWorkshopQuery = query),
                 onFilePreviewQueryChange: (query) => (state.skillWorkshopFilePreviewQuery = query),
                 onQueueWidthChange: (width) => (state.skillWorkshopQueueWidth = width),
-                onQueueWidthCommit: (width) => (state.skillWorkshopQueueWidth = width),
                 onModeChange: (mode) => (state.skillWorkshopMode = mode),
                 onSelect: (key) => {
                   state.skillWorkshopFilePreviewKey = null;
@@ -3144,7 +3142,7 @@ export function renderApp(state: AppViewState) {
                 },
                 onRevisionSubmit: (key) =>
                   void requestSkillWorkshopRevision(state, key, async (message) => {
-                    state.setTab("chat" as import("./navigation.ts").Tab);
+                    state.setTab("chat" as Tab);
                     await state.handleSendChat(message, { restoreDraft: true });
                   }),
                 onPreviewFile: (key, path) => {
diff --git a/ui/src/ui/views/skill-workshop.ts b/ui/src/ui/views/skill-workshop.ts
index 2979164a74ff..ced2fcb73817 100644
--- a/ui/src/ui/views/skill-workshop.ts
+++ b/ui/src/ui/views/skill-workshop.ts
@@ -77,7 +77,6 @@ export type SkillWorkshopProps = {
   onQueryChange: (query: string) => void;
   onFilePreviewQueryChange: (query: string) => void;
   onQueueWidthChange: (width: number) => void;
-  onQueueWidthCommit: (width: number) => void;
   onModeChange: (mode: SkillWorkshopMode) => void;
   onSelect: (key: string) => void;
   onPrev: () => void;
@@ -273,7 +272,6 @@ function startQueueResize(event: PointerEvent, props: SkillWorkshopProps): void
 
   const startX = event.clientX;
   const startWidth = props.queueWidth;
-  let currentWidth = startWidth;
   const body = document.body;
   const previousCursor = body.style.cursor;
   const previousUserSelect = body.style.userSelect;
@@ -289,13 +287,11 @@ function startQueueResize(event: PointerEvent, props: SkillWorkshopProps): void
   };
 
   const onMove = (moveEvent: PointerEvent) => {
-    currentWidth = startWidth + moveEvent.clientX - startX;
-    props.onQueueWidthChange(currentWidth);
+    props.onQueueWidthChange(startWidth + moveEvent.clientX - startX);
   };
 
   const onUp = () => {
     cleanup();
-    props.onQueueWidthCommit(currentWidth);
   };
 
   window.addEventListener("pointermove", onMove);
@@ -309,7 +305,7 @@ function resizeQueueWithKeyboard(event: KeyboardEvent, props: SkillWorkshopProps
   }
   event.preventDefault();
   const delta = event.key === "ArrowLeft" ? -24 : 24;
-  props.onQueueWidthCommit(props.queueWidth + delta);
+  props.onQueueWidthChange(props.queueWidth + delta);
 }
 
 function renderLifecycleTabs(props: SkillWorkshopProps) {