mirror of
https://github.com/NoFxAiOS/nofx.git
synced 2026-07-07 04:50:57 +08:00
- Max drawdown was double-broken: the backend built the equity curve on a hardcoded $10k baseline (understating a small account's drawdown ~20x) and the frontend multiplied the already-percent value by 100 again (0.87% shown as -86.9%). The curve now starts from the trader's real initial balance (10k fallback when unknown) and the UI renders the percent once; the demo engine and type docs are aligned to percent semantics. - Header now separates equity-based 'Total P/L (incl. unrealized)' from 'Realized P/L (closed trades)' so it no longer contradicts profit factor / win rate, and the stats strip shows the fee-drag chain (gross - fees = net) plus a per-trade-labelled sharpe. - Risk radar read a non-existent account field (total_unrealized_profit) so unrealized PnL always showed $0; small PnLs also render with cents now. - Nav 'Connect Hyperliquid' turns into a green connected chip when the server already holds a fully-authorized exchange, instead of nagging forever from a browser without the localStorage flow state.
158 lines
4.0 KiB
Go
158 lines
4.0 KiB
Go
package store
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"gorm.io/driver/sqlite"
|
|
"gorm.io/gorm"
|
|
)
|
|
|
|
func TestGetOpenPositionBySymbolMatchesSideCaseInsensitively(t *testing.T) {
|
|
db, err := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{})
|
|
if err != nil {
|
|
t.Fatalf("open in-memory sqlite: %v", err)
|
|
}
|
|
|
|
positions := NewPositionStore(db)
|
|
if err := positions.InitTables(); err != nil {
|
|
t.Fatalf("init position table: %v", err)
|
|
}
|
|
|
|
entryTime := time.Now().Add(-5 * time.Minute).UnixMilli()
|
|
if err := positions.Create(&TraderPosition{
|
|
TraderID: "trader-1",
|
|
Symbol: "AAVEUSDT",
|
|
Side: "LONG",
|
|
Quantity: 0.27,
|
|
EntryPrice: 88.519,
|
|
EntryTime: entryTime,
|
|
}); err != nil {
|
|
t.Fatalf("create position: %v", err)
|
|
}
|
|
|
|
got, err := positions.GetOpenPositionBySymbol("trader-1", "AAVEUSDT", "long")
|
|
if err != nil {
|
|
t.Fatalf("get open position: %v", err)
|
|
}
|
|
if got == nil {
|
|
t.Fatal("expected open position")
|
|
}
|
|
if got.EntryTime != entryTime {
|
|
t.Fatalf("entry time mismatch: got %d want %d", got.EntryTime, entryTime)
|
|
}
|
|
}
|
|
|
|
func TestGetClosedPositionsByTraderFiltersIncludesLegacyAutopilotIDs(t *testing.T) {
|
|
db, err := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{})
|
|
if err != nil {
|
|
t.Fatalf("open in-memory sqlite: %v", err)
|
|
}
|
|
|
|
positions := NewPositionStore(db)
|
|
if err := positions.InitTables(); err != nil {
|
|
t.Fatalf("init position table: %v", err)
|
|
}
|
|
|
|
now := time.Now().UnixMilli()
|
|
rows := []*TraderPosition{
|
|
{
|
|
TraderID: "current-trader",
|
|
Symbol: "xyz:SP500",
|
|
Side: "LONG",
|
|
Quantity: 1,
|
|
EntryPrice: 100,
|
|
EntryTime: now - 3000,
|
|
ExitPrice: 101,
|
|
ExitTime: now - 2000,
|
|
RealizedPnL: 1,
|
|
Status: "CLOSED",
|
|
CreatedAt: now - 3000,
|
|
UpdatedAt: now - 2000,
|
|
CloseReason: "sync",
|
|
ExchangeType: "hyperliquid",
|
|
},
|
|
{
|
|
TraderID: "exchange_user-123_claw402_111",
|
|
Symbol: "AAVEUSDT",
|
|
Side: "LONG",
|
|
Quantity: 2,
|
|
EntryPrice: 50,
|
|
EntryTime: now - 5000,
|
|
ExitPrice: 49,
|
|
ExitTime: now - 4000,
|
|
RealizedPnL: -2,
|
|
Status: "CLOSED",
|
|
CreatedAt: now - 5000,
|
|
UpdatedAt: now - 4000,
|
|
CloseReason: "sync",
|
|
ExchangeType: "hyperliquid",
|
|
},
|
|
{
|
|
TraderID: "exchange_other-user_claw402_222",
|
|
Symbol: "LITUSDT",
|
|
Side: "LONG",
|
|
Quantity: 3,
|
|
EntryPrice: 10,
|
|
EntryTime: now - 7000,
|
|
ExitPrice: 12,
|
|
ExitTime: now - 6000,
|
|
RealizedPnL: 6,
|
|
Status: "CLOSED",
|
|
CreatedAt: now - 7000,
|
|
UpdatedAt: now - 6000,
|
|
CloseReason: "sync",
|
|
ExchangeType: "hyperliquid",
|
|
},
|
|
}
|
|
for _, row := range rows {
|
|
if err := db.Create(row).Error; err != nil {
|
|
t.Fatalf("create position: %v", err)
|
|
}
|
|
}
|
|
|
|
got, err := positions.GetClosedPositionsByTraderFilters(
|
|
[]string{"current-trader"},
|
|
[]string{"%_user-123_claw402_%"},
|
|
100,
|
|
)
|
|
if err != nil {
|
|
t.Fatalf("get closed positions: %v", err)
|
|
}
|
|
if len(got) != 2 {
|
|
t.Fatalf("expected current + same-user legacy positions, got %d", len(got))
|
|
}
|
|
|
|
stats, err := positions.GetFullStatsByTraderFilters(
|
|
[]string{"current-trader"},
|
|
[]string{"%_user-123_claw402_%"},
|
|
0,
|
|
)
|
|
if err != nil {
|
|
t.Fatalf("get stats: %v", err)
|
|
}
|
|
if stats.TotalTrades != 2 || stats.TotalPnL != -1 {
|
|
t.Fatalf("unexpected stats: trades=%d pnl=%.2f", stats.TotalTrades, stats.TotalPnL)
|
|
}
|
|
}
|
|
|
|
func TestCalculateMaxDrawdownUsesRealBaseline(t *testing.T) {
|
|
// +50 then -100: peak 550, trough 450 on a 500 account → 100/550 ≈ 18.18%.
|
|
pnls := []float64{50, -100}
|
|
|
|
got := calculateMaxDrawdownFromPnls(pnls, 500)
|
|
if got < 18.1 || got > 18.3 {
|
|
t.Fatalf("expected ~18.18%% drawdown on a 500 baseline, got %.2f", got)
|
|
}
|
|
|
|
// Unknown baseline falls back to the neutral 10k curve: 100/10050 ≈ 1%.
|
|
fallback := calculateMaxDrawdownFromPnls(pnls, 0)
|
|
if fallback < 0.9 || fallback > 1.1 {
|
|
t.Fatalf("expected ~1%% drawdown on the 10k fallback, got %.2f", fallback)
|
|
}
|
|
|
|
if calculateMaxDrawdownFromPnls(nil, 500) != 0 {
|
|
t.Fatalf("no trades must mean zero drawdown")
|
|
}
|
|
}
|