ZhouYongyou
b6ed2c3bcb
fix(trader): separate stop-loss and take-profit order cancellation to prevent accidental deletions
...
## Problem
When adjusting stop-loss or take-profit levels, `CancelStopOrders()` deleted BOTH stop-loss AND take-profit orders simultaneously, causing:
- **Adjusting stop-loss** → Take-profit order deleted → Position has no exit plan ❌
- **Adjusting take-profit** → Stop-loss order deleted → Position unprotected ❌
**Root cause:**
```go
CancelStopOrders(symbol) {
// Cancelled ALL orders with type STOP_MARKET or TAKE_PROFIT_MARKET
// No distinction between stop-loss and take-profit
}
```
## Solution
### 1. Added new interface methods (trader/interface.go)
```go
CancelStopLossOrders(symbol string) error // Only cancel stop-loss orders
CancelTakeProfitOrders(symbol string) error // Only cancel take-profit orders
CancelStopOrders(symbol string) error // Deprecated (cancels both)
```
### 2. Implemented for all 3 exchanges
**Binance (trader/binance_futures.go)**:
- `CancelStopLossOrders`: Filters `OrderTypeStopMarket | OrderTypeStop`
- `CancelTakeProfitOrders`: Filters `OrderTypeTakeProfitMarket | OrderTypeTakeProfit`
- Full order type differentiation ✅
**Hyperliquid (trader/hyperliquid_trader.go)**:
- ⚠️ Limitation: SDK's OpenOrder struct doesn't expose trigger field
- Both methods call `CancelStopOrders` (cancels all pending orders)
- Trade-off: Safe but less precise
**Aster (trader/aster_trader.go)**:
- `CancelStopLossOrders`: Filters `STOP_MARKET | STOP`
- `CancelTakeProfitOrders`: Filters `TAKE_PROFIT_MARKET | TAKE_PROFIT`
- Full order type differentiation ✅
### 3. Usage in auto_trader.go
When `update_stop_loss` or `update_take_profit` actions are implemented, they will use:
```go
// update_stop_loss:
at.trader.CancelStopLossOrders(symbol) // Only cancel SL, keep TP
at.trader.SetStopLoss(...)
// update_take_profit:
at.trader.CancelTakeProfitOrders(symbol) // Only cancel TP, keep SL
at.trader.SetTakeProfit(...)
```
## Impact
- ✅ Adjusting stop-loss no longer deletes take-profit
- ✅ Adjusting take-profit no longer deletes stop-loss
- ✅ Backward compatible: `CancelStopOrders` still exists (deprecated)
- ⚠️ Hyperliquid limitation: still cancels all orders (SDK constraint)
## Testing
- ✅ Compiles successfully across all 3 exchanges
- ⚠️ Requires live testing:
- [ ] Binance: Adjust SL → verify TP remains
- [ ] Binance: Adjust TP → verify SL remains
- [ ] Hyperliquid: Verify behavior with limitation
- [ ] Aster: Verify order filtering works correctly
## Code Changes
```
trader/interface.go: +9 lines (new interface methods)
trader/binance_futures.go: +133 lines (3 new functions)
trader/hyperliquid_trader.go: +56 lines (3 new functions)
trader/aster_trader.go: +157 lines (3 new functions)
Total: +355 lines
```
2025-11-04 19:05:54 +08:00
hzb1115
febf7f5f33
style(backend): go fmt code
2025-11-03 17:22:11 +00:00
icy
56a6d7e5a7
Add MarginMode configration
2025-10-31 13:14:24 +08:00
mxyhi
908236640a
🐛 fix(order): 开仓前先撤销所有挂单
...
- 先在开仓前取消所有挂单，防止残留挂单导致仓位叠加
- 取消挂单失败时记录警告，但仍继续开仓
2025-10-30 13:08:26 +08:00
mxyhi
234c4ab3c3
✨ feat(trader): aster平仓后自动取消挂单
...
- 调整 CloseLong/CloseShort 逻辑, 在平仓后调用 CancelAllOrders 清理挂单
2025-10-30 13:06:14 +08:00
nobody
78ba807cab
Update readmes.
2025-10-30 00:41:14 +08:00
nobody
6281166403
feat: Add Aster DEX exchange support + fix precision issues
...
## Features
- Add full Aster DEX integration with Binance-compatible API
- Support Web3 authentication with API wallet system
- Add comprehensive Aster integration guide (ASTER_INTEGRATION.md)
- Add example Aster configuration (config.aster.example.json)
## Bug Fixes
- Fix precision error (code -1111) for all order types
- Implement proper float-to-string conversion with exchange precision
- Add automatic precision fetching from /exchangeInfo endpoint
- Remove trailing zeros from formatted values
## Documentation
- Update README.md with Aster quick start guide
- Add detailed setup instructions for creating API wallet
- Include troubleshooting FAQ and security best practices
- Update core features to mention three supported exchanges
## Technical Details
- Added formatFloatWithPrecision() helper function
- Updated all order functions to use proper precision formatting
- Added precision logging for debugging
- Fully backward compatible with existing configurations
Closes #[issue number if applicable]
2025-10-30 00:27:33 +08:00
