Commit Graph

5 Commits

Author SHA1 Message Date
tinkle-community
c4363f3bc7 fix: use strategy config for position value ratio validation instead of hardcoded 1.5x 2025-12-13 20:47:15 +08:00
tinkle-community
a12c0ae8c9 refactor: standardize code comments 2025-12-08 01:43:22 +08:00
tinkle-community
f4ece051e7 Refactor/trading actions (#1169)
* refactor: 简化交易动作,移除 update_stop_loss/update_take_profit/partial_close
- 移除 Decision 结构体中的 NewStopLoss, NewTakeProfit, ClosePercentage 字段
- 删除 executeUpdateStopLossWithRecord, executeUpdateTakeProfitWithRecord, executePartialCloseWithRecord 函数
- 简化 logger 中的 partial_close 聚合逻辑
- 更新 AI prompt 和验证逻辑,只保留 6 个核心动作
- 清理相关测试代码
保留的交易动作: open_long, open_short, close_long, close_short, hold, wait
* refactor: 移除 AI学习与反思 模块
- 删除前端 AILearning.tsx 组件和相关引用
- 删除后端 /performance API 接口
- 删除 logger 中 AnalyzePerformance、calculateSharpeRatio 等函数
- 删除 PerformanceAnalysis、TradeOutcome、SymbolPerformance 等结构体
- 删除 Context 中的 Performance 字段
- 移除 AI prompt 中夏普比率自我进化相关内容
- 清理 i18n 翻译文件中的相关条目
该模块基于磁盘存储计算,经常出错,做减法移除
* refactor: 将数据库操作统一迁移到 store 包
- 新增 store/ 包,统一管理所有数据库操作
  - store.go: 主 Store 结构,懒加载各子模块
  - user.go, ai_model.go, exchange.go, trader.go 等子模块
  - 支持加密/解密函数注入 (SetCryptoFuncs)
- 更新 main.go 使用 store.New() 替代 config.NewDatabase()
- 更新 api/server.go 使用 *store.Store 替代 *config.Database
- 更新 manager/trader_manager.go:
  - 新增 LoadTradersFromStore, LoadUserTradersFromStore 方法
  - 删除旧版 LoadUserTraders, LoadTraderByID, loadSingleTrader 等方法
  - 移除 nofx/config 依赖
- 删除 config/database.go 和 config/database_test.go
- 更新 api/server_test.go 使用 store.Trader 类型
- 清理 logger/ 包中未使用的 telegram 相关代码
* refactor: unify encryption key management via .env
- Remove redundant EncryptionManager and SecureStorage
- Simplify CryptoService to load keys from environment variables only
  - RSA_PRIVATE_KEY: RSA private key for client-server encryption
  - DATA_ENCRYPTION_KEY: AES-256 key for database encryption
  - JWT_SECRET: JWT signing key for authentication
- Update start.sh to auto-generate missing keys on first run
- Remove secrets/ directory and file-based key storage
- Delete obsolete encryption setup scripts
- Update .env.example with all required keys
* refactor: unify logger usage across mcp package
- Add MCPLogger adapter in logger package to implement mcp.Logger interface
- Update mcp/config.go to use global logger by default
- Remove redundant defaultLogger from mcp/logger.go
- Keep noopLogger for testing purposes
* chore: remove leftover test RSA key file
* chore: remove unused bootstrap package
* refactor: unify logging to use logger package instead of fmt/log
- Replace all fmt.Print/log.Print calls with logger package
- Add auto-initialization in logger package init() for test compatibility
- Update main.go to initialize logger at startup
- Migrate all packages: api, backtest, config, decision, manager, market, store, trader
* refactor: rename database file from config.db to data.db
- Update main.go, start.sh, docker-compose.yml
- Update migration script and documentation
- Update .gitignore and translations
* fix: add RSA_PRIVATE_KEY to docker-compose environment
* fix: add registration_enabled to /api/config response
* fix: Fix navigation between login and register pages
Use window.location.href instead of react-router's navigate() to fix
the issue where URL changes but the page doesn't reload due to App.tsx
using custom route state management.
* fix: Switch SQLite from WAL to DELETE mode for Docker compatibility
WAL mode causes data sync issues with Docker bind mounts on macOS due
to incompatible file locking mechanisms between the container and host.
DELETE mode (traditional journaling) ensures data is written directly
to the main database file.
* refactor: Remove default user from database initialization
The default user was a legacy placeholder that is no longer needed now
that proper user registration is in place.
* feat: Add order tracking system with centralized status sync
- Add trader_orders table for tracking all order lifecycle
- Implement GetOrderStatus interface for all exchanges (Binance, Bybit, Hyperliquid, Aster, Lighter)
- Create OrderSyncManager for centralized order status polling
- Add trading statistics (Sharpe ratio, win rate, profit factor) to AI context
- Include recent completed orders in AI decision input
- Remove per-order goroutine polling in favor of global sync manager
* feat: Add TradingView K-line chart to dashboard
- Create TradingViewChart component with exchange/symbol selectors
- Support Binance, Bybit, OKX, Coinbase, Kraken, KuCoin exchanges
- Add popular symbols quick selection
- Support multiple timeframes (1m to 1W)
- Add fullscreen mode
- Integrate with Dashboard page below equity chart
- Add i18n translations for zh/en
* refactor: Replace separate charts with tabbed ChartTabs component
- Create ChartTabs component with tab switching between equity curve and K-line
- Add embedded mode support for EquityChart and TradingViewChart
- User can now switch between account equity and market chart in same area
* fix: Use ChartTabs in App.tsx and fix embedded mode in EquityChart
- Replace EquityChart with ChartTabs in App.tsx (the actual dashboard renderer)
- Fix EquityChart embedded mode for error and empty data states
- Rename interval state to timeInterval to avoid shadowing window.setInterval
- Add debug logging to ChartTabs component
* feat: Add position tracking system for accurate trade history
- Add trader_positions table to track complete open/close trades
- Add PositionSyncManager to detect manual closes via polling
- Record position on open, update on close with PnL calculation
- Use positions table for trading stats and recent trades (replacing orders table)
- Fix TradingView chart symbol format (add .P suffix for futures)
- Fix DecisionCard wait/hold action color (gray instead of red)
- Auto-append USDT suffix for custom symbol input
* update
---------
2025-12-06 01:04:26 +08:00
Lawrence Liu
a41f2f5a72 fix(decision): clarify field names for update_stop_loss and update_take_profit actions (#993)
* fix(decision): clarify field names for update_stop_loss and update_take_profit actions
修复 AI 决策中的字段名混淆问题:
**问题**:
AI 在使用 update_stop_loss 时错误地使用了 `stop_loss` 字段,
导致解析失败(backend 期望 `new_stop_loss` 字段)
**根因**:
系统 prompt 的字段说明不够明确,AI 无法知道 update_stop_loss
应该使用 new_stop_loss 字段而非 stop_loss
**修复**:
1. 在字段说明中明确标注:
   - update_stop_loss 时必填: new_stop_loss (不是 stop_loss)
   - update_take_profit 时必填: new_take_profit (不是 take_profit)
2. 在 JSON 示例中增加 update_stop_loss 的具体用法示例
**验证**:
decision_logs 中的错误 "新止损价格必须大于0: 0.00" 应该消失
* test(decision): add validation tests for update actions
添加针对 update_stop_loss、update_take_profit 和 partial_close
动作的字段验证单元测试:
**测试覆盖**:
1. TestUpdateStopLossValidation - 验证 new_stop_loss 字段
   - 正确使用 new_stop_loss 字段(应通过)
   - new_stop_loss 为 0(应报错)
   - new_stop_loss 为负数(应报错)
2. TestUpdateTakeProfitValidation - 验证 new_take_profit 字段
   - 正确使用 new_take_profit 字段(应通过)
   - new_take_profit 为 0(应报错)
   - new_take_profit 为负数(应报错)
3. TestPartialCloseValidation - 验证 close_percentage 字段
   - 正确使用 close_percentage 字段(应通过)
   - close_percentage 为 0(应报错)
   - close_percentage 超过 100(应报错)
**测试结果**:所有测试用例通过 ✓
---------
Co-authored-by: Shui <88711385+hzb1115@users.noreply.github.com>
2025-11-15 22:21:11 -05:00
0xYYBB | ZYY | Bobo
6a66913194 fix(decision): 添加槓桿超限 fallback 機制並澄清盈虧計算說明 (#716)
* fix(decision): 添加槓桿超限 fallback 機制並澄清盈虧計算說明
1. AI 決策輸出超限槓桿時(如 20x),驗證直接拒絕導致整個交易週期失敗
2. Prompt 未明確說明盈虧百分比已包含槓桿效應,導致 AI 思維鏈中誤用價格變動%
- **Before**: 超限直接報錯 → 決策失敗
- **After**: 自動降級為配置上限 → 決策繼續執行
- **效果**: SOLUSDT 20x → 自動修正為 5x(配置上限)
- 明確告知 AI:系統提供的「盈虧%」已包含槓桿效應
- 公式: 盈虧% = (未實現盈虧 / 保證金) × 100
- 示例: 5x 槓桿,價格漲 2% = 實際盈利 10%
- 測試山寨幣超限修正(20x → 5x)
- 測試 BTC/ETH 超限修正(20x → 10x)
- 測試正常範圍不修正
- 測試無效槓桿拒絕
```
PASS: TestLeverageFallback/山寨币杠杆超限_自动修正为上限
PASS: TestLeverageFallback/BTC杠杆超限_自动修正为上限
PASS: TestLeverageFallback/杠杆在上限内_不修正
PASS: TestLeverageFallback/杠杆为0_应该报错
```
-  向後兼容:正常槓桿範圍不受影響
-  容錯性增強:AI 輸出超限時系統自動修正
-  決策質量提升:AI 對槓桿收益有正確認知
Co-Authored-By: tinkle-community <tinklefund@gmail.com>
* style: apply go fmt after rebase
Co-Authored-By: tinkle-community <tinklefund@gmail.com>
---------
Co-authored-by: ZhouYongyou <128128010+zhouyongyou@users.noreply.github.com>
Co-authored-by: tinkle-community <tinklefund@gmail.com>
2025-11-10 20:47:46 -05:00